Commit Graph
2844 Commits
Author SHA1 Message Date
Clément Fournier 0ff87229ff Remove TokenBasedNode
I don't think we should expose tokens as an API
yet. They're an implementation detail, not used
much, and the AST should be able to reflect all
the information that can be found in the tokens.

The methods of AbstractNode can be pulled down
to AbstractJjtreeNode and made protected.
2020-01-05 23:13:04 +01:00
Andreas Dangel a0d0a22e7b Merge branch 'pr-2190'
[java] Deprecations for statements PR

Prerequisite for #2164 for PMD 7.0.0
2020-01-05 19:30:52 +01:00
Andreas Dangel f973ad6ef3 Merge branch 'pr-2185'
[core] Internalize API that exposes ResourceLoader
2020-01-05 19:18:18 +01:00
Andreas Dangel 4cf6291ecb Fix pmd 2020-01-05 18:20:26 +01:00
Juan Martín Sotuyo Dodero caaa5eba9a Fix issue with analysis of IPv6 mapper IPv4 2020-01-04 04:37:13 -03:00
Egor18 3b8d694be3 Fix odd logic in AvoidUsingHardCodedIPRule 2019-12-29 22:00:13 +03:00
Clément Fournier f33291e372 Deprecate ASTYieldStatement implementing TypeNode 2019-12-26 18:53:22 +01:00
Clément Fournier 0a0bb6e4bb Rename getGuardExpressionNode -> getCondition 2019-12-26 18:47:28 +01:00
Clément Fournier 41baa353b0 Deprecate API of TryStatement that will be renamed 2019-12-26 18:40:24 +01:00
Clément Fournier 05870c98cc Deprecate RulesetFactory constructors 2019-12-24 14:39:20 +01:00
Clément Fournier 9023d86945 Merge branch 'master' into deprecate-jjtree-methods 2019-12-23 12:41:08 +01:00
Clément Fournier a7c5a1f0be Cleanup PMD.EOL in tests
Instead, normalize line endings in parse method.
This makes sure test code snippets are portable
and readable. For now they're platform-specific,
and assume that the resource files are saved with
the platform-specific line separator. This may not
be the case, as eg a git file may be checked out
with CRLF on a unix system.
2019-12-22 20:16:19 +01:00
Clément Fournier 80534a7e69 Fix line endings 2019-12-22 19:53:10 +01:00
Clément Fournier 5906564e23 Fix resource path 2019-12-20 19:01:10 +01:00
Clément Fournier 8afe5ae7a8 Abstract away parser utils
Convert a few pieces of code

Share with modelica

Remove yet another dup

Fix tests

Doc

Share with plsql

Fix tests

Fix build

Cleanup

Minimize diff

Share with JSP module

Share with JS module

Share with XML module

Share with VisualForce module

Share with Scala module

Fix last tests
2019-12-20 18:30:17 +01:00
Andreas Dangel f67819e05a Merge branch 'pr-2069'
[java] CommentRequired: make property names consistent
2019-12-20 11:38:03 +01:00
Andreas Dangel 0ff3216b48 Merge branch 'pr-2150'
[java] Fix false negative in AvoidLiteralsInIfCondition
2019-12-18 09:50:19 +01:00
Clément Fournier 627e258458 Revert 2019-12-17 17:49:01 +01:00
Clément Fournier 86b274c681 Make generic visitor superclass
Use raw supertype to avoid conflicts
2019-12-17 17:39:13 +01:00
Clément Fournier 2f37e1c256 Deprecate jjt* methods 2019-12-17 17:39:13 +01:00
Clément Fournier 1aabc53fa2 Deprecate childrenAccept in all modules 2019-12-17 17:39:13 +01:00
Clément Fournier 98df6bda1c Add TokenBasedNode, AbstractJjtreeNode 2019-12-17 17:39:13 +01:00
Andreas Dangel d8ed0cf45e [java] CommentRequired: Deprecated property "headerCommentRequirement" 2019-12-17 15:44:02 +01:00
snuyanzinandAndreas Dangel 6cec74851a [java] CommentRequired: Make headerCommentRequirement ignored by default, make tests more targeted
Refs #1683
2019-12-17 12:31:17 +01:00
snuyanzinandAndreas Dangel 88ff3f0628 [java] CommentRequired: Separate header comment from class comment and header top-level comment
Refs #1683
2019-12-17 12:30:05 +01:00
Andreas Dangel 1480bfeaa4 Merge branch 'pr-2165'
[java] Deprecate JavaQualifiedName and a few other things
2019-12-17 10:45:34 +01:00
Clément Fournier 6aadcb29a3 Fix UnnecessaryLocalBeforeReturn FP with method reference 2019-12-16 17:31:56 +01:00
Clément Fournier 50560e0aac Fix deprecated attribute usage 2019-12-16 16:23:27 +01:00
Andreas Dangel 7b5e9703ec [java] AvoidLiteralsInIfCondition: add property ignoreExpressions
The property ignoreExpressions is set to true in order to keep
the rule backwards compatible.
2019-12-16 11:17:25 +01:00
Andreas Dangel 1cfd14ec7c [java] AvoidLiteralsInIfCondition: add additional check for expressions 2019-12-16 11:17:21 +01:00
Andreas Dangel c0d0fd3fbe [java] AvoidLiteralsInIfCondition: report Literal rather than IfCondition
If the IfCondition spans multiple lines, it easier to spot the
literal, if the violation is reported on the correct line where
the literal is located.
2019-12-16 11:17:21 +01:00
Andreas DangelandAndreas Dangel ed253183aa [java] AvoidLiteralsInIfCondition: false negative for expressions
Fixes #2140
2019-12-16 11:17:17 +01:00
Clément Fournier 76d33ea3dd Fix checkstyle 2019-12-16 11:06:33 +01:00
Clément Fournier eddff1449e Deprecate TypeKind and related 2019-12-16 00:26:05 +01:00
Andreas Dangel da194bf427 Merge branch 'pr-2148'
[java] Fix false negative for StringInstantion with array access
2019-12-13 20:14:52 +01:00
Andreas Dangel 2b1e21bf11 Merge branch 'pr-2151'
[java] Fix false-positive in JUnitAssertionsShouldIncludeMessage
2019-12-13 20:10:50 +01:00
Clément Fournier 1f0caf5034 Merge branch 'master' into deprecate-rvf-impls 2019-12-09 01:09:27 +01:00
Clément Fournier c5b332d7fd Also deprecate JavaDataFlowHandler 2019-12-08 14:17:56 +01:00
Clément Fournier 5545927bd9 Do the same for Java language handlers 2019-12-08 14:17:19 +01:00
Clément Fournier 088f077407 Deprecate AbstractJavaParser
Internalize JavaLanguageParser
2019-12-08 14:15:59 +01:00
Andreas Dangel 71bf676225 Remove unnecessary CDATA in JUnitAssertionsShouldIncludeMessage.xml 2019-12-08 12:15:03 +01:00
Andreas Dangel 9502cae042 [java] JUnitAssertionsShouldIncludeMessage - False positive with assertEquals and JUnit5
Fixes #2149
2019-12-08 12:10:32 +01:00
Andreas Dangel b7d61fca94 [java] StringInstantiation: fix false negative with multi-dim arr access 2019-12-06 12:21:11 +01:00
Andreas Dangel 9616312de2 [java] Support type resolution for array access expressions 2019-12-06 12:21:06 +01:00
Andreas Dangel 3b6fcf4b7a [java] StringInstatiation: False negative with String-array access
Fixes #2141
2019-12-06 11:18:27 +01:00
Andreas Dangel b1fc3110de [java] StringInstatiation tests - remove unnecessary CDATA 2019-12-06 10:52:43 +01:00
Clément Fournier b1ba962ddf Deprecate RuleViolation impls 2019-12-05 15:26:03 +01:00
Clément Fournier eb6ceef085 Add comments and update release notes 2019-12-05 15:23:07 +01:00
Clément Fournier bb7478cd0a Deprecate RuleViolationFactory impls
Internal APIs
2019-12-05 15:18:35 +01:00
Andreas Dangel 00392cefc2 [maven-release-plugin] prepare for next development iteration 2019-11-29 19:46:14 +01:00