5560 Commits

Author SHA1 Message Date
Romain Pelisse
a37296d7b9 add a function to create root directory tree to harmonize script action between src release and binary release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7250 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:17:03 +00:00
Romain Pelisse
260e0730b7 fix inconsistency in variable uses
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7249 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:16:46 +00:00
Romain Pelisse
384cfa8bcd using mktemp() to have a temporary folder for each build make pointless the preventing rm -rf on the previous potential files...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7248 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:16:30 +00:00
Romain Pelisse
3f39a04a58 move current_dir check in an earlier step of the script
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7247 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:16:14 +00:00
Romain Pelisse
a3393f4b13 remove dependency to asm in project.xml
As it seems that ASM is no longer available in Maven 1 repository, this dependency leads to
a build failure. As Maven 1 is ONLY used to generate the xdocs documenation, and has been removed
from the trunk, it does not seems relevant to try to fix this. Removing the depedency does allow
one to build the documentation, which what we need here...

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7246 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:15:58 +00:00
Romain Pelisse
17442f2028 fix typos in xdocs (& to &)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7245 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:15:42 +00:00
Romain Pelisse
c7933c9700 make docs.sh able to use svn or git to restore files
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7244 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:15:26 +00:00
Romain Pelisse
779e304d18 removes all copy of folder related to the pmd 1.4 compliant release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7243 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:15:12 +00:00
Romain Pelisse
61498acc39 extract version number from pom.xml - makes -v optional, check if release script is executed from the 'etc' folder
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7242 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:14:54 +00:00
Romain Pelisse
12faf9023b enhance release script to use getopt and support args - instead of interactive commands
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7241 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:14:35 +00:00
Romain Pelisse
46671ba8b8 set release script to stop on the first shell failure
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7240 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:14:17 +00:00
Romain Pelisse
d1c1863f07 remove retroweaver for build - it seems broken right now and having a Java 1.4 compliant version of PMD is somewhat less critical today...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7239 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:14:01 +00:00
Romain Pelisse
75201a5a60 ensure that release script fails when ant build fails
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7238 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:13:45 +00:00
Romain Pelisse
0b23f48cf4 fix trailing whitespaces in changelog
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7237 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:13:29 +00:00
Romain Pelisse
73a989fc97 enhance release script to check for required dependencies (ant, maven, mvn...)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7236 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:13:10 +00:00
Romain Pelisse
779526036a add usage function for release script, and missing required argument check
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7235 51baf565-9d33-0410-a72c-fc3788e3496d
2011-09-11 19:12:54 +00:00
Romain Pelisse
19da0dfc1a Applied patch from Juan Jesús García de Soria on CPD
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7106 51baf565-9d33-0410-a72c-fc3788e3496d
2010-07-24 14:12:52 +00:00
Ryan Gustafson
ffc48e9835 Performance optimization for ends-with type include/exclude patterns. Assuming one has N patterns, and M files to check, one starts to see noticeable improvements once N*M is greater than 100,000.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7071 51baf565-9d33-0410-a72c-fc3788e3496d
2010-02-13 05:34:10 +00:00
Ryan Gustafson
fdb5dcc628 Add reference to QAPlug for Intellaj IDEA.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7068 51baf565-9d33-0410-a72c-fc3788e3496d
2010-02-02 15:59:13 +00:00
Ryan Gustafson
043e5d02f3 Add reference to SolidSDD, similar to CPD.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7067 51baf565-9d33-0410-a72c-fc3788e3496d
2010-01-26 00:53:11 +00:00
Romain Pelisse
7a083a30e9 applied patch from Nicolas Dordet to fix False+ on CloseResource - ID: 2920057.
Thanks Nicolas !

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7049 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-28 15:00:35 +00:00
Dale Anson
c831d82bf0 Added vararg to constructor so it matches with super constructor.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7027 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-12 16:21:03 +00:00
Dale Anson
2130c12ba3 Updated changelog to note Ecmascript is now supported by CPD.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7025 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-09 17:11:39 +00:00
Dale Anson
79ef486724 Changed javascript to ecmascript.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7024 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-09 17:10:47 +00:00
Dale Anson
b937b65558 Changed javascript to ecmascript.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7023 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-09 17:09:14 +00:00
Dale Anson
38044fb7f5 Added javascript as a supported language for CPD.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7019 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-09 02:22:56 +00:00
Ryan Gustafson
cc3f172ef2 Fix url for new rule.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7016 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-05 22:36:32 +00:00
Ryan Gustafson
8fe5a0d780 Add support for Unicode for JSP/JSF.
Add support to not parse body of <script> for JSP/JSF.
Add new NoInlineScript rule for JSP/JSF.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7015 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-05 22:34:45 +00:00
Romain Pelisse
f67056e7d7 fixing performance issue on PreserveStackTrace by removing use of descendant:: axis. See bug 1808110
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7010 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-04 14:37:46 +00:00
Romain Pelisse
59eaa27c59 Adding a new rule : GenericsNaming
Thanks to Nicolas Dordet for his inputs on this one.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7009 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-04 13:37:26 +00:00
Ryan Gustafson
d836721675 Fix for 2904832. ClassTypeResolver was clobbering the importedClasses in populateImports set by populateClassName. Changed to clobber at ASTCompilationUnit, then everyone adds to the map.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7005 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-27 18:13:13 +00:00
Romain Pelisse
aaeaefad1a oups, forgot to add new rule to changelog.txt
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7001 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-14 15:57:33 +00:00
Romain Pelisse
6f857aa813 oups forgot to add UseConcurrentHashMap to test class
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6998 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-14 15:01:15 +00:00
Romain Pelisse
1d7d5e6474 Adding a new rule 'UseConcurrentHashMap' to promote use of ConcurrentHashMap implementation in Java 5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6997 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-14 15:00:48 +00:00
Romain Pelisse
a73b7f1fb1 Fix bug 2832322 - cpd.xml file tag path attribute should be entity-encoded.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6988 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-16 13:18:39 +00:00
Romain Pelisse
64d3bc28cb Oups, this stateless crap of mine from my previous commit was erronous.
Rule are NOT recreated for each new source file, we need to clean the state of this object... Therefore I add this piece of code back.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6986 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-16 01:25:30 +00:00
Romain Pelisse
8b4ade3016 While debugging I realise that PMD rules are 'stateless', so I remove my code to clean the ArrayList at each passage.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6985 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 18:05:52 +00:00
Romain Pelisse
60c0bcb858 finally fixing bug 'wz-pmd-report.xslt in release 4.2.5 misses file name - ID: 2609540'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6980 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 17:20:10 +00:00
Romain Pelisse
0b60a2d6ff making field private and adding missing @Override
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6979 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 17:19:47 +00:00
Romain Pelisse
73ebf2603a Fixing bug 2826119 - False +: DoubleCheckedLocking warning with volatile field
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6978 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 16:40:53 +00:00
Romain Pelisse
6f427f9fa5 Fixing bug : False -: DoubleCheckedLocking with reversed null check - ID: 2835074
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6976 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 15:58:49 +00:00
Ryan Gustafson
d6b326838f Added AvoidLosingExceptionInformation from George Thomas.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6972 51baf565-9d33-0410-a72c-fc3788e3496d
2009-07-21 01:43:49 +00:00
Romain Pelisse
0e3a92c291 Adding link to my own article, in French, on PMD
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6968 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-30 12:33:10 +00:00
Romain Pelisse
bbc1d2a02f Fixing bug 2810228 : updating cpd documentation.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6965 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-22 14:25:55 +00:00
Xavier Le Vourch
0e1bf46e07 new Android rule DoNotHardCodeSDCard taken from my blog article on how to use PMD in Android projects
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6960 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-13 20:34:03 +00:00
Xavier Le Vourch
6243e25400 asm jars updated to 3.2
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6954 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-13 00:13:38 +00:00
Ryan Gustafson
ae499b9132 Fixed bug 2724653 - AvoidThreadGroup reports false positives
Changed Rule to use Type Resolution.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6918 51baf565-9d33-0410-a72c-fc3788e3496d
2009-04-24 02:51:55 +00:00
Ryan Gustafson
c168ecc6e5 Correct -benchmark reporting of Rule visits via the RuleChain
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6912 51baf565-9d33-0410-a72c-fc3788e3496d
2009-04-18 08:21:27 +00:00
Xavier Le Vourch
ac439685fc Android ruleset: CallSuperLast rule now also checks for finish() redefinitions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6891 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-22 23:06:42 +00:00
Xavier Le Vourch
2321376151 new rule AvoidLiteralsInIfCondition added to controversial ruleset
Patch contributed by Nadhamuni Kothapalle

https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2591627&group_id=56262


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6888 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-22 22:50:57 +00:00