Commit Graph

831 Commits

Author SHA1 Message Date
a07b8c7fd0 Separated test cases 2017-03-23 13:02:08 -03:00
beac88cef6 Optimised conditionals 2017-03-23 13:01:58 -03:00
94e3e25c03 Cleaned up 2017-03-23 13:01:50 -03:00
c63d8f3191 Fixed bug with inverted ternary expression 2017-03-23 13:01:45 -03:00
606f7e3c87 Merge branch 'master' of https://github.com/Oowekyala/pmd 2017-03-22 15:57:06 -03:00
11fa26ebef Merge branch 'pr-303' 2017-03-22 15:56:13 -03:00
e261b71258 Merge branch 'pr-303' into pmd/5.5.x 2017-03-22 15:40:43 -03:00
c62ad45cf6 Specialized condition 2017-03-22 15:14:09 -03:00
3454c6eb4e Removed test class 2017-03-22 15:13:59 -03:00
6bf8138aaf Added violation case for InefficientEmptyStringCheckRule
String.trim().isEmpty() now triggers a violation.

Fixed checkstyle
2017-03-22 15:13:41 -03:00
ddf49c4f17 Specialized condition 2017-03-22 18:50:30 +01:00
22139c14b4 Removed test class 2017-03-22 17:29:37 +01:00
adef0e6e8c Added violation case for InefficientEmptyStringCheckRule
String.trim().isEmpty() now triggers a violation.

Fixed checkstyle
2017-03-22 11:07:48 +01:00
d0ef852a06 [java] Rename unusedcode/UnusedModifier to unnecessary/UnnecessaryModifier 2017-03-18 19:24:57 -03:00
42741e3b48 Merge branch 'issue-282' 2017-03-18 11:05:06 +01:00
8e9f9388d4 [java] Fix FP on UnnecessaryLocalBeforeReturn
- If the local is initialized using another variable that is later
used, don't consider it a violation. Assume the later use is destructive
and the order is important.
 - Fixes #282
2017-03-18 10:58:57 +01:00
b05d42de48 [java] Revamp AccessorClassGeneration
- Fixes #291
 - Complete rewrite. Simpler and faster, using the RuleChain and SymbolTable.
2017-03-18 10:38:19 +01:00
6ccd252070 [java] Revamp AccessorClassGeneration
- Fixes #291
 - Complete rewrite. Simpler and faster, using the RuleChain and SymbolTable.
2017-03-12 23:51:38 -03:00
2d4da66072 Merge branch 'issue-275' 2017-03-03 19:20:26 +01:00
16f2094401 Merge branch 'issue-275' into pmd/5.5.x 2017-03-03 19:12:51 +01:00
19114a7030 Simplify XPath expression 2017-03-03 19:03:26 +01:00
fb405fef08 [java] fields in annotations are public static
- Fixes #275
2017-03-03 19:03:26 +01:00
f4ddb98130 Merge branch 'issue-274' 2017-03-03 18:52:57 +01:00
7a1eb4f26e [java] Fix class scopes for anon inner classes
- A new ClassScope was being created for each annon inner class method / field,
    which is incorrect.
 - I reworked the AccessorMethodGeneration to compare scopes directly, since
    I was missing anonymous classes completely.
 - Fixes #274
2017-03-03 18:42:36 +01:00
12fb1c2d7f [maven-release-plugin] prepare for next development iteration 2017-02-25 20:44:32 +01:00
765a542604 [maven-release-plugin] prepare release pmd_releases/5.5.4 2017-02-25 20:44:24 +01:00
4c7774ebf0 [maven-release-plugin] prepare for next development iteration 2017-02-25 19:03:45 +01:00
0eec906467 [maven-release-plugin] prepare release pmd_releases/5.4.5 2017-02-25 19:03:37 +01:00
a35959341c Merge branch 'pr-266' 2017-02-21 23:27:17 -03:00
58b863e204 Merge branch 'pr-266' into pmd/5.5.x 2017-02-21 23:20:08 -03:00
227060e5f8 corrected invalid reporting of LoD violation 2017-02-21 23:07:51 -03:00
5cd0f2e928 Merge branch 'issue-257' 2017-02-20 16:13:37 +01:00
a1299c5b9b Merge branch 'issue-257' into pmd/5.5.x 2017-02-20 16:06:26 +01:00
8f22e69560 Ugly workaround that don't need to change AST 2017-02-20 16:00:39 +01:00
907972f0ca [java] Improve grammar for CastExpression
- Provide a definite fix for casts. This allowed to remove a bunch of hacks.
 - I had to change the grammar a bit... `(int)` is now a cast with a
    PrimitiveType as child, not a Type with a nested PrimitiveType. This is due
    to JavaCC completely ignoring whatever you place in the LOOKAHEAD in favor
    of just looking the follow-up expression completely.
 - Removing the hacks raised an issue with expression orders, caused also by JavaCC's
    disregard to LOOKAHEAD contents
2017-02-20 16:00:39 +01:00
6d50709fc1 Merge branch 'pr-258' 2017-02-20 15:50:21 +01:00
a5089b27da [java] syboltable resolves inner class methods
- This fixes the last known false negative for `AccessorMethodGeneration`
2017-02-20 15:42:10 +01:00
452b785223 Merge branch 'cpd-suppress-comments-java' of https://github.com/Monits/pmd into pr-250 2017-02-19 10:04:09 +01:00
e680e45357 Merge branch 'pr-262' 2017-02-17 16:08:24 -03:00
9264fda777 Merge branch 'pr-262' into pmd/5.5.x 2017-02-17 15:54:39 -03:00
282a803a83 Allow annotations for UnnecessaryLocalBeforeReturnRule
- Fixes #933
2017-02-17 15:54:08 -03:00
09025c2315 Merge branch 'pr-249' 2017-02-15 20:07:23 +01:00
a92adc4bdf Merge branch 'pr-249' into pmd/5.5.x 2017-02-15 19:58:14 +01:00
756e9a713a Update docs to reflect on changes 2017-02-15 19:47:08 +01:00
b4d05e5f14 Checkstyle fixes 2017-02-15 19:47:08 +01:00
1fb05d995f [java] Revamp UnusedModifier
- This covers a ton of missing cases
 - Fixes #246
 - Fixes #247
 - Fixes #248
 - Notice `isNested` has been improved on `ASTClassOrInterfaceDeclaration`
    to cover being nested in an annotation definition
2017-02-15 19:47:08 +01:00
05237bf323 Merge branch 'issue-240' 2017-02-14 22:06:18 +01:00
4137df4309 [java] UnnecessaryLocalBeforeReturn checks usages
- We now check symbol table usages to detect violations.
 - We drop the consecutive lines requirement.
 - Resolves #240
2017-02-14 21:57:47 +01:00
4e04e62374 Merge branch 'feature-1496' 2017-02-13 21:13:56 +01:00
983a0dc9b8 Remove the to be ignored test from the regressionTests 2017-02-13 21:04:12 +01:00