15429 Commits

Author SHA1 Message Date
Andreas Dangel
c7f143534a [doc] Update generated rule doc 2019-10-25 18:42:50 +02:00
Andreas Dangel
c1f36d9d70 [java] Rename InvalidSlf4jMessageFormat to InvalidLogMessageFormat
Follow-up on #2012
2019-10-25 18:42:50 +02:00
Andreas Dangel
5c2bff403d Merge branch 'pr-2068' 2019-10-25 18:20:06 +02:00
Andreas Dangel
c2b484bbc0 [doc] Update release notes, refs #2068 2019-10-25 18:18:16 +02:00
Andreas Dangel
2bc67ea719 [java] Add deprecation javadoc 2019-10-25 18:18:05 +02:00
Andreas Dangel
63395684c4 Merge branch 'pr-2076' 2019-10-25 15:01:58 +02:00
Andreas Dangel
e8a4b5f77e [doc] Update release notes, refs #2076 2019-10-25 15:01:04 +02:00
Andreas Dangel
ecc4e7558f [java] Use full name for CLASS_FAN_OUT metric for operations as well 2019-10-25 14:44:45 +02:00
Andreas Dangel
1209b162a9 [ci] Explicitly configure known_hosts for web.sourceforge.net 2019-10-24 20:29:16 +02:00
Juan Martín Sotuyo Dodero
9a2314ab5d Merge pull request #2079 from adangel/issue-1531-unusedprivatemethod
[java] UnusedPrivateMethod false-positive with method result
2019-10-23 19:46:48 -03:00
andi
e2877ab95c use full name instead of abbreviation for classfanout & fix spelling 2019-10-22 20:22:20 +02:00
Chen Yang
48fab8cd64 Missing a ; 2019-10-22 21:24:13 +09:00
Chen Yang
80c293e82b Reuse the constructor 2019-10-22 21:13:02 +09:00
Andreas Dangel
abc048ce41 [doc] Update generated rule documentation 2019-10-21 20:41:10 +02:00
Andreas Dangel
7bdb2a03d1 Merge branch 'pr-2078' 2019-10-21 20:32:26 +02:00
Andreas Dangel
c7786d9438 [doc] Update release notes, fixes #1627, refs #2078 2019-10-21 20:32:03 +02:00
Andreas Dangel
50f748e191 [java] UnusedPrivateMethod false-positive with method result
Fixes #1531

In case we determined, that the method argument is a method call,
then we skip now completly trying to determine the correct argument
type. It was half-way fixed before for the first if condition, but
we still evaluated e.g. the allocation expression in

    print(new Integer(1).toString());

and wrongly assumed, the argument type would be an integer,
without taking into account the `toString()` method call.

The same happened with

    privateBooleanMethod(s, "true".equals(s));

where we took the 2nd argument as a literal and assumed
it is a "String", while the method call result actually
is a boolean.

With this change now, the false positive is fixed.

However, since we don't determine the argument type at all, the
method is matched solely on argument count. This will obviously
lead to wrong matches if method overloading is used.
2019-10-20 15:54:10 +02:00
Chen Yang
3abcbaa5a0 Move the resource loader to constructor 2019-10-20 11:26:52 +09:00
andi
7e48b4dcd3 fix documentation 2019-10-19 22:05:29 +02:00
Michael Clay
b32c7ad6a8 [java] DoNotUseThreads should not warn on Runnable #1627 2019-10-19 20:55:49 +02:00
Michael Clay
5739041b16 [java] DoNotUseThreads should not warn on Runnable on java8+ #1627 2019-10-18 17:43:33 +02:00
Andreas Dangel
a1781422ca Merge branch 'pr-2073' 2019-10-17 21:05:43 +02:00
Andreas Dangel
dde5cb530a [doc] Update release notes, refs #2073, fixes #2072 2019-10-17 21:05:14 +02:00
Andreas Dangel
b76feef44e Merge branch 'pr-2070' 2019-10-17 20:34:00 +02:00
Andreas Dangel
a91803f157 [doc] Update release notes, refs #2070, fixes #2067 2019-10-17 20:32:59 +02:00
andi
1515209a48 add classfanoutcomplexity metric 2019-10-17 13:05:36 +02:00
snuyanzin
de632e6193 [PMD-2072] Add expected and actual line of numbers to message wording 2019-10-15 22:08:18 +02:00
Saladoc
66b52ee38f Fix typo in AbstractRendererTest class name 2019-10-15 20:21:19 +02:00
Saladoc
05b39e3419 Streamline renderer tests.
Remove platform-dependent contents from the file names to prevent tests
breaking on Windows systems.
2019-10-15 20:08:36 +02:00
Chen Yang
5c36ee1eba Rule loader should use the same resources loader to load the Rule sets 2019-10-15 11:44:05 +09:00
Andreas Dangel
507f543a73 Bump commons-compress from 1.18 to 1.19 in pmd-dist
This fixes CVE-2019-12402
2019-10-14 19:40:54 +02:00
Andreas Dangel
e4e4c7ceae Merge branch 'pr-2060' 2019-10-14 19:36:45 +02:00
Clément Fournier
ecf9be0c52 Finish release notes 2019-10-13 20:09:11 +02:00
Travis CI (pmd-bot)
bf2bece085 Update documentation
TRAVIS_JOB_NUMBER=4328.1
TRAVIS_COMMIT_RANGE=e39a77812103...dff6f4d7ab98
2019-10-13 14:09:08 +00:00
Andreas Dangel
dff6f4d7ab Merge branch 'pr-2065' 2019-10-13 15:44:59 +02:00
Andreas Dangel
d45682faab [doc] Update release notes, refs #2065, fixes #1636 2019-10-13 15:44:45 +02:00
Carlos Macasaet
a8dbc91b5e Make comment consistent with expected failures
Three of the problems were UR anomalies.

Addresses: #1636
2019-10-12 21:45:15 -07:00
Carlos Macasaet
e41b8d992c Stop checking UR anomalies (Java)
This commit stops checking for UR anomalies in the
DataflowAnomalyAnalysis rule in Java. Note, I retained the UR anomaly
test, but changed the expected number of errors to zero.

Addresses: #1636
2019-10-12 19:01:30 -07:00
Clément Fournier
ced97bb70b Fix compilation 2019-10-10 17:37:08 +02:00
Clément Fournier
2fd9d39825 Fix charset 2019-10-10 17:33:09 +02:00
Clément Fournier
9c77d027a3 Apply suggestions from code review
Co-Authored-By: Juan Martín Sotuyo Dodero <juansotuyo@gmail.com>
2019-10-10 17:27:03 +02:00
Clément Fournier
1c799a3507 Update release notes 2019-10-09 22:57:46 +02:00
Clément Fournier
6abbfb5920 Fix source incompatible change
(had added throws IOException)
2019-10-09 22:52:49 +02:00
Clément Fournier
a9d14ac441 Deprecate other helpers 2019-10-09 22:48:41 +02:00
Clément Fournier
c289ed49c5 Deprecate ant stuff 2019-10-09 22:40:41 +02:00
Clément Fournier
7911d733d4 Deprecate various utility classes 2019-10-09 22:38:52 +02:00
Clément Fournier
ee41f610da Deprecate Filters
Will be replace with Predicate
2019-10-09 22:30:18 +02:00
Clément Fournier
e39a778121 Fix #2058 2019-10-09 22:12:59 +02:00
Andreas Dangel
cfb4fbec0f Merge branch 'pr-2026' 2019-10-07 18:50:34 +02:00
Juan Martín Sotuyo Dodero
bb7db78108 Update changelog, refs #2025 2019-10-06 17:40:16 -03:00