5532 Commits

Author SHA1 Message Date
Romain Pelisse
f67056e7d7 fixing performance issue on PreserveStackTrace by removing use of descendant:: axis. See bug 1808110
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7010 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-04 14:37:46 +00:00
Romain Pelisse
59eaa27c59 Adding a new rule : GenericsNaming
Thanks to Nicolas Dordet for his inputs on this one.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7009 51baf565-9d33-0410-a72c-fc3788e3496d
2009-12-04 13:37:26 +00:00
Ryan Gustafson
d836721675 Fix for 2904832. ClassTypeResolver was clobbering the importedClasses in populateImports set by populateClassName. Changed to clobber at ASTCompilationUnit, then everyone adds to the map.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7005 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-27 18:13:13 +00:00
Romain Pelisse
aaeaefad1a oups, forgot to add new rule to changelog.txt
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@7001 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-14 15:57:33 +00:00
Romain Pelisse
6f857aa813 oups forgot to add UseConcurrentHashMap to test class
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6998 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-14 15:01:15 +00:00
Romain Pelisse
1d7d5e6474 Adding a new rule 'UseConcurrentHashMap' to promote use of ConcurrentHashMap implementation in Java 5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6997 51baf565-9d33-0410-a72c-fc3788e3496d
2009-11-14 15:00:48 +00:00
Romain Pelisse
a73b7f1fb1 Fix bug 2832322 - cpd.xml file tag path attribute should be entity-encoded.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6988 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-16 13:18:39 +00:00
Romain Pelisse
64d3bc28cb Oups, this stateless crap of mine from my previous commit was erronous.
Rule are NOT recreated for each new source file, we need to clean the state of this object... Therefore I add this piece of code back.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6986 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-16 01:25:30 +00:00
Romain Pelisse
8b4ade3016 While debugging I realise that PMD rules are 'stateless', so I remove my code to clean the ArrayList at each passage.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6985 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 18:05:52 +00:00
Romain Pelisse
60c0bcb858 finally fixing bug 'wz-pmd-report.xslt in release 4.2.5 misses file name - ID: 2609540'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6980 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 17:20:10 +00:00
Romain Pelisse
0b60a2d6ff making field private and adding missing @Override
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6979 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 17:19:47 +00:00
Romain Pelisse
73ebf2603a Fixing bug 2826119 - False +: DoubleCheckedLocking warning with volatile field
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6978 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 16:40:53 +00:00
Romain Pelisse
6f427f9fa5 Fixing bug : False -: DoubleCheckedLocking with reversed null check - ID: 2835074
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6976 51baf565-9d33-0410-a72c-fc3788e3496d
2009-08-15 15:58:49 +00:00
Ryan Gustafson
d6b326838f Added AvoidLosingExceptionInformation from George Thomas.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6972 51baf565-9d33-0410-a72c-fc3788e3496d
2009-07-21 01:43:49 +00:00
Romain Pelisse
0e3a92c291 Adding link to my own article, in French, on PMD
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6968 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-30 12:33:10 +00:00
Romain Pelisse
bbc1d2a02f Fixing bug 2810228 : updating cpd documentation.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6965 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-22 14:25:55 +00:00
Xavier Le Vourch
0e1bf46e07 new Android rule DoNotHardCodeSDCard taken from my blog article on how to use PMD in Android projects
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6960 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-13 20:34:03 +00:00
Xavier Le Vourch
6243e25400 asm jars updated to 3.2
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6954 51baf565-9d33-0410-a72c-fc3788e3496d
2009-06-13 00:13:38 +00:00
Ryan Gustafson
ae499b9132 Fixed bug 2724653 - AvoidThreadGroup reports false positives
Changed Rule to use Type Resolution.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6918 51baf565-9d33-0410-a72c-fc3788e3496d
2009-04-24 02:51:55 +00:00
Ryan Gustafson
c168ecc6e5 Correct -benchmark reporting of Rule visits via the RuleChain
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6912 51baf565-9d33-0410-a72c-fc3788e3496d
2009-04-18 08:21:27 +00:00
Xavier Le Vourch
ac439685fc Android ruleset: CallSuperLast rule now also checks for finish() redefinitions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6891 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-22 23:06:42 +00:00
Xavier Le Vourch
2321376151 new rule AvoidLiteralsInIfCondition added to controversial ruleset
Patch contributed by Nadhamuni Kothapalle

https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2591627&group_id=56262


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6888 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-22 22:50:57 +00:00
Ryan Gustafson
f7cefa4a7d Fixed bug 2645268 - ClassCastException in UselessOperationOnImmutable.getDeclaration
Problem was due to incorrect assumption about AST structure, when Annotations are present on a local declaration.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6879 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-01 09:57:16 +00:00
Xavier Le Vourch
eeb8b10892 Fixed bug 2606609 - False "UnusedImports" positive in package-info.java
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6874 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 17:45:51 +00:00
Romain Pelisse
2577acd87e Cleanup: Moving testcase for bug '1843273 : False - on SimplifyBooleanReturns' to the appropriate file.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6858 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-19 23:40:14 +00:00
Romain Pelisse
e3ad18317a Adding fix for bug [2317099] False + in SimplifyConditional to changelog
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6856 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-19 22:24:12 +00:00
Romain Pelisse
6bc10af45e Test case and fix for bug [2317099 ] false + in SimplifyConditional.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6855 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-19 22:23:19 +00:00
Romain Pelisse
5a1a457eae Reproducing bug False 2606609: 'UnusedImports' positive in package-info.java
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6849 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-16 23:54:51 +00:00
Romain Pelisse
59a60be0d2 Adding Bug fix 2590258 - NPE with nicerhtml output to changelog.txt
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6848 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-16 12:17:34 +00:00
Romain Pelisse
f7aa88db54 Bug Fix: NPE in XsltRenderer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6847 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-16 12:17:11 +00:00
Xavier Le Vourch
eb371c24a1 wrong since attribute
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6843 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-12 19:30:51 +00:00
Xavier Le Vourch
a846ccb014 New rule in strictexceptions : AvoidCatchingGenericException
patch submitted by Nadhamuni Kothapalle

https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2591604&group_id=56262


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6842 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-12 19:28:38 +00:00
Xavier Le Vourch
a31f7f3578 next dev cycle: 4.2.6-SNAPSHOT
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6838 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 02:37:38 +00:00
Xavier Le Vourch
ecb51fbac5 upload of maven files to sourceforge was not correctly done
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6837 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 02:29:08 +00:00
Xavier Le Vourch
3ab42655dc web site updates for 4.2.5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6836 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 01:54:53 +00:00
Xavier Le Vourch
c44b0c2c87 android ruleset was not in changelog
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6832 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 01:18:15 +00:00
Xavier Le Vourch
2817991f7d preparing 4.2.5 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6830 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 00:52:32 +00:00
Xavier Le Vourch
ce0fd33919 local.properties ignored
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6829 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 00:46:29 +00:00
Xavier Le Vourch
316ef30f5b note for Fixed bug 2027626 - False + : AvoidFinalLocalVariable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6828 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 00:43:32 +00:00
Romain Pelisse
7a7381829a Final fix
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6824 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 21:57:20 +00:00
Romain Pelisse
9e0de88bc2 Adding testcase to reproduce bug 2027626 : 'False + : AvoidFinalLocalVariable'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6823 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 21:56:58 +00:00
Xavier Le Vourch
13f6224635 2009 added to copyright
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6821 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 21:30:56 +00:00
Xavier Le Vourch
a4e7012c63 dogfood location must be on branch or the pmd plugin complain about internal/pmdspecific.xml from the trunk
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6820 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 21:29:41 +00:00
Xavier Le Vourch
de924b50cf Fixed bug 2142986 - UselessOverridingMethod doesn't consider annotations
new property 'ignoreAnnotations' to get the old behavior


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6818 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 19:19:33 +00:00
Romain Pelisse
605de6f7bf Bug fixing 1609038 - Xslt report generators break if path contains 'java'.
As suggested by bug reporter i switch call to 'translate' and call to 'substring-before'.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6816 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-05 10:57:28 +00:00
Xavier Le Vourch
751ed84e0d new rule in strictexception: AvoidThrowingNewInstanceOfSameException
contributed by George Thomas:

https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2566369&group_id=56262


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6814 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-05 03:29:15 +00:00
Xavier Le Vourch
b5a90924a7 CallSuperFirst android rule now accepts logging before call to super()
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6812 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-04 23:50:51 +00:00
Romain Pelisse
ca664ea719 Adding test case for bug '[2115761] False +: System.arraycopy is more efficient'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6811 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-31 21:39:39 +00:00
Romain Pelisse
d740f68a94 Test case to reproduce [1732744] False + : basic/UselessOperationOnImmutable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6810 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-29 13:48:18 +00:00
Romain Pelisse
d20f8f2291 Test case to reproduce [1622281 ] Loop scoping dodgy
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6809 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-29 13:21:34 +00:00