Upgrade all pacakges to autoscalingv2beta2 (#39)

Signed-off-by: Arjun Naik <arjun.rn@gmail.com>
2025-05-20 03:53:55 +00:00 · 2019-04-03 10:23:52 +02:00
parent 04b212175e
commit dfeae82cae
16 changed files with 429 additions and 341 deletions
--- a/pkg/annotations/parser_test.go
+++ b/pkg/annotations/parser_test.go
@ -0,0 +1,83 @@
+package annotations
+
+import (
+	"github.com/stretchr/testify/require"
+	"testing"
+
+	autoscalingv2 "k8s.io/api/autoscaling/v2beta2"
+)
+
+func TestParser(t *testing.T) {
+	for _, tc := range []struct {
+		Name           string
+		Annotations    map[string]string
+		MetricName     string
+		MetricType     autoscalingv2.MetricSourceType
+		ExpectedConfig map[string]string
+		PerReplica     bool
+	}{
+		{
+			Name:           "no annotations",
+			Annotations:    map[string]string{},
+			ExpectedConfig: map[string]string{},
+		},
+		{
+			Name: "pod metrics",
+			Annotations: map[string]string{
+				"metric-config.pods.requests-per-second.json-path/json-key": "$.http_server.rps",
+				"metric-config.pods.requests-per-second.json-path/path":     "/metrics",
+				"metric-config.pods.requests-per-second.json-path/port":     "9090",
+			},
+			MetricName: "requests-per-second",
+			MetricType: autoscalingv2.PodsMetricSourceType,
+			ExpectedConfig: map[string]string{
+				"json-key": "$.http_server.rps",
+				"path":     "/metrics",
+				"port":     "9090",
+			},
+		},
+		{
+			Name: "prometheus metrics",
+			Annotations: map[string]string{
+				"metric-config.object.processed-events-per-second.prometheus/query":       "scalar(sum(rate(event-service_events_count{application=\"event-service\",processed=\"true\"}[1m])))",
+				"metric-config.object.processed-events-per-second.prometheus/per-replica": "true",
+			},
+			MetricName: "processed-events-per-second",
+			MetricType: autoscalingv2.ObjectMetricSourceType,
+			ExpectedConfig: map[string]string{
+				"query": "scalar(sum(rate(event-service_events_count{application=\"event-service\",processed=\"true\"}[1m])))",
+			},
+			PerReplica: true,
+		},
+		{
+			Name: "zmon collector",
+			Annotations: map[string]string{
+				"metric-config.external.zmon-check.zmon/key":             "custom.*",
+				"metric-config.external.zmon-check.zmon/tag-application": "my-custom-app-*",
+			},
+			MetricName: "zmon-check",
+			MetricType: autoscalingv2.ExternalMetricSourceType,
+			ExpectedConfig: map[string]string{
+				"key":             "custom.*",
+				"tag-application": "my-custom-app-*",
+			},
+			PerReplica: false,
+		},
+	} {
+		t.Run(tc.Name, func(t *testing.T) {
+			hpaMap := make(AnnotationConfigMap)
+			err := hpaMap.Parse(tc.Annotations)
+			require.NoError(t, err)
+			config, present := hpaMap.GetAnnotationConfig(tc.MetricName, tc.MetricType)
+			if len(tc.ExpectedConfig) == 0 {
+				require.False(t, present)
+				return
+			}
+			require.True(t, present)
+			for k, v := range tc.ExpectedConfig {
+				require.Equal(t, v, config.Configs[k])
+			}
+			require.Equal(t, tc.PerReplica, config.PerReplica)
+		})
+	}
+}