yusheng-guo/kube-metrics-adapter
1
0
Fork 1
mirror of https://github.com/zalando-incubator/kube-metrics-adapter.git synced 2025-07-01 15:43:46 +00:00
Code Issues 2 Packages Projects Releases Wiki Activity

Use regexp.Compile to avoid performance problems

Browse Source 
Signed-off-by: Lucas Thiesen <lucas.thiesen@zalando.de>
This commit is contained in:
Lucas Thiesen
2023-05-04 16:59:00 +02:00
parent 2f5d3f5a42
commit f28653de74
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/collector/hostname_collector.go
View File

@ -30,7 +30,7 @@ func NewHostnameCollectorPlugin(
metricName string, metricName string,
) (*HostnameCollectorPlugin, error) { ) (*HostnameCollectorPlugin, error) {
if metricName == "" { if metricName == "" {
return nil, fmt.Errorf("failed to initialize hostname collector plugin, metric name was not defined") return nil, fmt.Errorf("Failed to initialize hostname collector plugin, metric name was not defined")
} }
return &HostnameCollectorPlugin{ return &HostnameCollectorPlugin{
@ -52,15 +52,17 @@ func (p *HostnameCollectorPlugin) NewCollector(
// RPS data from a specific hostname from prometheus. The idea // RPS data from a specific hostname from prometheus. The idea
// of the copy is to not modify the original config struct. // of the copy is to not modify the original config struct.
confCopy := *config confCopy := *config
//hostnames := config.Config["hostnames"]
//weights := config.Config["weights"]
if _, ok := config.Config["hostnames"]; !ok { if _, ok := config.Config["hostnames"]; !ok {
return nil, fmt.Errorf("hostname is not specified, unable to create collector") return nil, fmt.Errorf("Hostname is not specified, unable to create collector")
}
regex, err := regexp.Compile("^[a-zA-Z0-9.-]+$")
if err != nil {
return nil, fmt.Errorf("Failed to create regular expression to match hostname format")
} }
hostnames := strings.Split(config.Config["hostnames"], ",") hostnames := strings.Split(config.Config["hostnames"], ",")
for _, h := range hostnames { for _, h := range hostnames {
if ok, err := regexp.MatchString("^[a-zA-Z0-9.-]+$", h); !ok || err != nil { if ok := regex.MatchString(h); !ok {
return nil, fmt.Errorf( return nil, fmt.Errorf(
"Invalid hostname format, unable to create collector: %s", "Invalid hostname format, unable to create collector: %s",
h, h,
@ -105,7 +107,7 @@ func (c *HostnameCollector) GetMetrics() ([]CollectedMetric, error) {
} }
if len(v) != 1 { if len(v) != 1 {
return nil, fmt.Errorf("expected to only get one metric value, got %d", len(v)) return nil, fmt.Errorf("Expected to only get one metric value, got %d", len(v))
} }
return v, nil return v, nil
} }