TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
21,678 Commits 2 Branches 0 Tags 294 MiB
5e7e81ab1a
Commit Graph

2891 Commits

Author SHA1 Message Date
Aaron Patterson
5c66677987 make our yaml output consistent 2011-01-04 17:29:40 -08:00
Aaron Patterson
7bd32e4d1d add Psych::SyntaxError to the list of rescued YAML exceptions 2011-01-04 16:52:47 -08:00
Aaron Patterson
4fabad7cf1 test that the custom ordered hash can be round-tripped 2011-01-04 15:07:15 -08:00
Aaron Patterson
a84b84efac require Psych if possible, use Psych output when enabled 2011-01-04 15:07:15 -08:00
Aaron Patterson
b1dc9c004e use dots for method calls 2011-01-04 15:07:15 -08:00
Jon Leighton
0619dc2319 Implement deprecated version of AssociationReflection#primary_key_name, which has been renamed to #foreign_key. Also bumping the deprecation_horizon in Active Support to 3.1. 2011-01-03 16:24:32 -08:00
Xavier Noria
99424eb099 Revert "Update CHANGELOGs to include 3.0.3 changes" 
Reason: Sorry, CHANGELOGs can only be edited in master.
If you provide a patch I'll apply it myself. Thanks!

This reverts commit 1f8ecb85d7c1b3efdf45c3cf3461502b608c1a7c.
 2011-01-02 00:20:59 +01:00
Prem Sichanugrist
1f8ecb85d7 Update CHANGELOGs to include 3.0.3 changes 2011-01-02 03:35:38 +07:00
Pratik Naik
0ac66caac5 Fix Duration#to_json 2010-12-29 22:20:14 +00:00
Neeraj Singh
27d0d4fffd while defining callbacks option :rescuable => true 
can be passed. There were no tests for this case.

This patch adds a test for :rescuable => true
option.
 2010-12-29 05:32:23 +08:00
Xavier Noria
8a3132b8a9 Merge branch 'master' of git://github.com/lifo/docrails 2010-12-23 00:15:10 +01:00
Piotr Sarnacki
b613145284 Fix activesupport tests. These classes are not used anywhere 2010-12-22 09:44:46 +01:00
Piotr Sarnacki
1a2c427991 Ensure that uncountable are removed after test 2010-12-22 09:44:46 +01:00
John Paul Ashenfelter
9b4622a483 Added a word boundary to uncountable inflection regex for #singularize so short inflections like ors do not affect larger words like sponsors [#6093 state:resolved] 2010-12-22 09:44:46 +01:00
Neeraj Singh
3c1a0a8b62 expand on set_callback method to explain that in 
some cases an implicit :before is assumed
 2010-12-21 15:45:50 -05:00
Ryan Bigg
1cacb08b21 Improve documentation on ActiveSupport::Deprecation. 2010-12-21 10:40:15 +10:00
Xavier Noria
880f8419c4 Merge branch 'master' of git://github.com/lifo/docrails 2010-12-20 20:13:34 +01:00
Emilio Tagua
02fc6fbccd Merge remote branch 'rails/master' into identity_map 
Conflicts:
	activerecord/lib/active_record/associations/association_proxy.rb
	activerecord/lib/active_record/autosave_association.rb
	activerecord/lib/active_record/base.rb
	activerecord/lib/active_record/persistence.rb
 2010-12-20 11:23:07 -03:00
John Firebaugh
435bccda93 Replace AD::Callbacks.to_prepare with AD::Reloader.to_prepare 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-12-20 12:43:02 +01:00
zhengjia
ad14926b44 Fix the example in ActiveSupport::Concern 2010-12-17 18:54:57 -06:00
Pavel Gorbokon
1ce9b73e5c Replace nested ifs with case/when 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-12-07 20:56:10 -02:00
Pavel Gorbokon
4c4c7a272f Ommit nil in method call 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-12-07 20:55:39 -02:00
Xavier Noria
48386d245b Merge branch 'master' of git://github.com/lifo/docrails 2010-12-05 10:33:50 +01:00
Ryan Bigg
7f1c794a11 Remove extra f 2010-12-03 13:29:02 +11:00
Santiago Pastorino
ae35a36afc :method: is not needed when RDoc can detect it 2010-12-02 20:31:06 -02:00
Neeraj Singh
aa1ac1ca8c Add comment for config_accessor method 2010-11-30 09:44:12 -05:00
Aditya Sanghi
8601f163a8 Merge branch 'master' of https://github.com/cylence/docrails into cylence-master 2010-11-29 21:36:43 +05:30
Aditya Sanghi
f28916194c Resolves LH #6063, should be :expires_in not :expire_in 2010-11-27 15:20:46 +05:30
José Valim
ce9456eca0 Only convert direct hash instances in hash with indifferent access. 2010-11-26 11:56:52 +01:00
raggi
cb1570936d Rakefiles are executables, and rake loads rake, not rakefile code 2010-11-25 06:49:55 +08:00
raggi
d8692985fe Don't depend on rubygems loading thread (for Mutex) 2010-11-25 06:47:27 +08:00
Josh Kalderimis
d7db6a8873 class inheritable attributes is used no more! all internal use of class inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-20 19:40:29 +01:00
José Valim
8d8062190d I18n is always loaded on boot by Active Model or Action Pack, so no need for supporting lazy hooks. 2010-11-20 19:39:57 +01:00
Xavier Noria
206e48e8b9 applies API conventions to the RDoc of json_encode 
* Examples running with the text are preferred over separate Example
  sections.
* No need to call puts, in # => we show the return value, not STDOUT.
* Say explicitly that double quotes are removed.
* Specify that we are talking \uXXX, rather than, say, HTML entities.
 2010-11-20 16:20:42 +01:00
Emilio Tagua
a84add0c2c We don't need to dup key, since only value is weak. 2010-11-19 19:08:58 -03:00
Emilio Tagua
4da31d21bc Add initial tests for WeakHash. 2010-11-19 19:08:42 -03:00
Emilio Tagua
0873d1e944 Use conditional to avoid warnings. 2010-11-19 19:08:28 -03:00
Emilio Tagua
ada014929b Use ActiveSupport::WeakHash for MRI, JRuby prefers Weakling. 2010-11-19 19:08:28 -03:00
Xavier Noria
cb8f7a1156 removes orphan tests, custom String#% was removed from AS in 39d6f9e 2010-11-19 18:24:58 +01:00
Santiago Pastorino
52b71c01fd Revert "Quick fix for not escaping []s (not ideal)" 
According to http://www.ietf.org/rfc/rfc2616.txt and
http://tools.ietf.org/rfc/rfc3986.txt [ and ] are reserved characters
and should be escaped using "%" HEX HEX

This reverts commit 856d2fd874d72dd9f83204affff4edfef3308361 and
1ee9b40b18a0bed5bb10a0785f7e2730bac983f6..
 2010-11-18 23:31:00 -02:00
Josh Kalderimis
ae44bf7c7e bye bye extlib_inheritable_*, AS callbacks now using class_attribute 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-18 00:38:51 +01:00
Carl Lerche
ccd2f3ede5 Update the version.rb files to include a PRE part 2010-11-16 17:19:46 -08:00
Aaron Patterson
254b0a4bbb using a merge with a Hash[] rather than a loop to add SAX parsed attributes 2010-11-16 10:09:42 -08:00
raggi
e6d14279b8 Add support for try to just yield the object to a block if no method is to be called. Kind of like a tap_if_present. 2010-11-14 17:23:44 +08:00
Larry Sprock
f43e5d160b HashWithIndifferentAccess should not change the subclass of an array 2010-11-14 17:14:47 +08:00
José Valim
f912a359aa Merge remote branch 'drogus/plugin_new' 
Conflicts:
	railties/test/generators/app_generator_test.rb
 2010-11-11 19:39:21 +01:00
Santiago Pastorino
2651a87a33 Duck typing here 2010-11-11 01:33:27 -02:00
Alvaro Bautista
5dc7f34dca Fix ActiveSupport::TimeWithZone#localtime method with DateTime 
[#5344 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-11 01:30:28 -02:00
Santiago Pastorino
c20838596b Remove unused method 2010-11-10 16:57:12 -02:00
Denis Odorcic
b961c6c158 Remove useless cgi 
[#5943 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-10 16:43:26 -02:00
Xavier Noria
41366cdec6 syncs CHANGELOGs for 3.0.2 in 3-0-stable with the ones in master 2010-11-09 20:56:41 +01:00
Santiago Pastorino
4e0477c9b7 Test cache.key_file_path with separators ht. Jim Wilson [#5611] 2010-11-07 20:02:14 -02:00
Denis Odorcic
c452d734f2 Fix FileStore cache incorrectly regenerating its key from a pathname when a regexp is used in expire_fragment 
[#5850 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-07 20:01:51 -02:00
Michael Koziarski
9ecaa80300 Make safe_append= live on AV::OutputBuffer not AS::SafeBuffer 
Conflicts:

	actionpack/lib/action_view/template/handlers/erb.rb
 2010-11-08 10:10:30 +13:00
Jan Maurits Faber
f04ec6a227 Added support for Erubis <%== tag 
<%== x %> is syntactic sugar for <%= raw(x) %>

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#5918 status:committed]
 2010-11-08 09:55:55 +13:00
James A. Rosen
697f4851b8 OrderedHash#select now preserves order [#5843 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-07 17:27:07 -02:00
laserlemon
02039e9752 Ensure that HashWithIndifferentAccess duplication preserves class (for sublclasses) and default value [#5724 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-07 10:19:51 -02:00
Aaron Patterson
6362538815 add more tests surrounding camlize in xmlmini, refactor rename_key() 2010-11-03 11:02:42 -07:00
Jeremy Holland
ea0faa2055 Allowing to_xml :camelize option to be set to :lower to enable lower-camelcase tags [#5903 state:resolved] 2010-11-03 10:43:45 -07:00
Piotr Sarnacki
5071b727b4 Added Hash#deep_dup function which performs deep duplication on given hash 2010-11-02 17:14:52 +01:00
Ryan L. Cross
67c40160d3 Corrected typo and wording. 2010-10-24 19:17:49 -07:00
Aaron Patterson
a3f96f16f4 save a few method calls 2010-10-22 17:31:28 -07:00
Aaron Patterson
cc12047372 removing wtfalse 2010-10-22 13:37:51 -07:00
Xavier Noria
d619b9d1d1 Merge branch 'master' of git://github.com/lifo/docrails 2010-10-19 23:07:29 +02:00
Xavier Noria
df044ec4ac explains why ERB::Util#h is removed before being re-aliased 2010-10-18 17:24:30 +02:00
Santiago Pastorino
460c4efd71 Merge CHANGELOGs from 3-0-stable 2010-10-18 12:24:41 -02:00
Neeraj Singh
ea14396c45 replace if ! with unless 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-17 12:26:32 -02:00
Neeraj Singh
a38e653a6d json_escape makes json invalid doc change [#1485 state:resolved] 2010-10-16 21:57:19 +02:00
Rob Zolkos & Xavier Noria
bc1bcddede implements weeks_ago and prev_week for Date/DateTime/Time [#5122 state:committed] 2010-10-16 02:23:23 +02:00
Aaron Patterson
eaa7605e2f Revert "refactor delete a little" 
This reverts commit f3f34bce8fc2895e05c4a06bb4105d6155fa423d.
 2010-10-15 10:23:05 -07:00
Xavier Noria
21ff8849bb in regexps, the dot in a character class is not a metacharacter 2010-10-15 16:31:00 +02:00
Xavier Noria
13f7f89bda Merge branch 'master' of git://github.com/lifo/docrails 2010-10-14 23:15:23 +02:00
Aaron Patterson
ab1a661533 Revert "speeding up flattened version of OrderedHash.[]" 
This reverts commit 9c53e82d66d0c34b8f35609b7972f28521d5794d.
 2010-10-13 21:06:07 -07:00
Aaron Patterson
9c53e82d66 speeding up flattened version of OrderedHash.[] 2010-10-13 21:04:42 -07:00
Aaron Patterson
f3f34bce8f refactor delete a little 2010-10-13 20:51:51 -07:00
Aaron Patterson
86b02e7bb1 use unless instead of if ! 2010-10-13 20:44:26 -07:00
Aditya Sanghi
a0b53b25b6 fix time.to_formatted_time(:time) example 2010-10-13 01:39:22 +05:30
wycats
cc8e386d08 Always pull in version for frameworks (standardize autoload / require / none) 2010-10-10 16:12:04 -07:00
Barry Sears
de05e1c33c Make ActiveSupport load own version. 
[#5739 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-10 19:46:49 -02:00
Wincent Colaiuta
f659a1576f Fix misleading advice to add 'memcache' to Gemfile 
[#5539 state:committed]

Commit 57144388f removed the hard-coded dependency on the memcache-client
gem, and added this warning advising people to install it if needed. The
problem is, however, that if people follow the advice literally and install
the 'memcache' gem, they will wind up with a completely different thing,
which is not API compatible with the memcache-client gem and which Rails
can't work with.

So, be explicit and tell users to install the 'memcache-client' gem.

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-10 14:30:22 -02:00
Andrea Campi
d80afed620 Override #store to be consistent with #[]. 
[#5775 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-10 14:06:44 -02:00
José Valim
f1f2fb8ae7 Cleanup logger a bit. 2010-10-08 16:14:39 +02:00
Xavier Noria
db520042b3 Merge branch 'master' of git://github.com/lifo/docrails 2010-10-06 23:16:13 +02:00
Erik Michaels-Ober
19a5f99685 Fix copy/paste bug 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-06 09:21:01 +02:00
Aaron Patterson
b7c49cedba calling correct method on minitest for test name when teardown callback fails 2010-10-04 09:34:34 -07:00
Aaron Patterson
ccf228b027 [#5406 state:resolved] calling the correct method on minitest to obtain the test name 2010-10-04 09:33:35 -07:00
Marcelo Giorgi
860d7c566b Correct documentation that references how *_filter of action_pack are translated into set_callback/run_callback's (from active_support) invocations. 2010-10-03 20:54:08 -02:00
Santiago Pastorino
5836af8f8b PERF: more Hash + map changes 2010-10-03 16:33:46 -02:00
Aaron Patterson
6e1df2ca46 remove another lolinject 2010-10-01 17:55:39 -07:00
Aaron Patterson
61e8b23fe5 speed up index_by by removing a lolinject 2010-10-01 17:37:34 -07:00
Aaron Patterson
ff2fdcc52b removing AS::Testing::Default in favor of just undefing default_test 2010-10-01 17:22:42 -07:00
Emilio Tagua
71acc2737a Move uri parser to AS as URI.parser method to reuse it in AP and ARes. 2010-09-28 11:38:35 +08:00
Xavier Noria
dc5336e7f4 revises RDoc of Hash#to_param to be more precise about ordering 2010-09-28 00:36:53 +02:00
Xavier Noria
10dec0e65e let Hash#to_param and Hash#to_query sort again 
This was a regression introduced in 5c858220085dc4ddc1bec496747059dfbe32f1da. We bring
sorting back because people rely on it, eg for constructing consistent cache keys.
 2010-09-28 00:32:20 +02:00
Neeraj Singh
bfc986811c Test for after_create callback order in ActiveSupport [#5703 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-27 23:12:10 +02:00
Neeraj Singh
72c1e19c33 after_create in ActiveModel should in the order specified 
[#5650 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-27 23:11:31 +02:00
José Valim
fe0251e408 Merge remote branch 'miloops/warnings' 
Conflicts:
	actionpack/lib/action_controller/metal/url_for.rb
 2010-09-27 21:00:54 +02:00
José Valim
6067d16200 Call it compile_methods! and do the same on AM. 2010-09-27 20:43:56 +02:00
thedarkone
77efc20a54 Make assert_valid_keys slightly faster. 2010-09-27 17:45:59 +02:00
thedarkone
4c360c15e5 No need for an extra wrapper array. 2010-09-27 17:45:59 +02:00
thedarkone
f2e0b3575e Use native attr_* macros for performance reasons. 2010-09-27 17:45:58 +02:00
thedarkone
320382ccd3 Creating singleton class for every object whenever the instance-level accessor is used quite is expensive. 2010-09-27 17:45:58 +02:00
thedarkone
5a518487fe Try to use Hash's native #[] for speed. 2010-09-27 17:45:58 +02:00
thedarkone
8cda132136 Make InheritableOptions's constructor more flexible. 2010-09-27 17:45:58 +02:00
thedarkone
918dc27345 Compile ActionController::Base.config's methods to avoid method_missing overhead. 2010-09-27 17:45:58 +02:00
Emilio Tagua
6b135f7e46 Remove method if already exists to avoid warnings. 2010-09-27 11:19:22 -03:00
Krekoten' Marjan
1b7d30bfc9 Fix 'warning: method redefined' [#5551 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-25 11:06:55 +02:00
Andrew Kaspick
fb08e334d6 memoized protected methods should remain protected 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-24 20:31:12 -03:00
Aaron Patterson
a0db7be4af attr_accessor_with_default should raise an ArgumentError not a RuntimeError 2010-09-24 14:48:57 -07:00
Emilio Tagua
c88deaf5ee Use map, no need to use inject here. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:04 -03:00
Emilio Tagua
7047d83ec5 Perf: speed up json encoding. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:04 -03:00
Emilio Tagua
418190d55c Refactor inject use in hash conversions. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:03 -03:00
Thiago Pradi
3c9bf6e1dc Exception handling more readable 
[#5601 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-19 12:18:51 -07:00
Prem Sichanugrist
af6757a1ca Use Time.current to maintain consistency with AS::Duration 
In [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch
methods in AS::Duration to use `Time.current` to return the correct
duration based on the `Time.default_zone` instead of using `Time.now`.

[#5607 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-19 11:26:20 -07:00
Krekoten' Marjan
d4fa120671 Move capture to Kernel. [#5641 state:resolved] 2010-09-18 20:49:36 +02:00
Xavier Noria
dd6efe98b6 Merge remote branch 'docrails/master' 2010-09-14 20:07:29 +02:00
Carl Lerche
9362ef6e21 Require lazy_load_hooks.rb with the correct path. 2010-09-14 10:40:05 -07:00
Jack Dempsey
a427876606 require i18n in transliterate so it can run in isolated situations 2010-09-14 10:25:33 -07:00
Marcelo Giorgi
d5ef502d2a Reference watch_namespaces in comments instead of watch_modules 2010-09-13 17:53:39 -03:00
Aaron Patterson
8c6de675e4 Remove dummy method definition in favor of RDoc hints: 
http://rdoc.rubyforge.org/RDoc/Parser/Ruby.html
 2010-09-11 20:51:02 -07:00
Jakub Suder
2524cf404c fixed some issues with JSON encoding 
- as_json in ActiveModel should return a hash
  and handle :only/:except/:methods options
- Array and Hash should call as_json on their elements
- json methods should not modify options argument

[#5374 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-09-07 11:33:10 -07:00
Carlos Antonio da Silva
c91605b15b Refactor a bit dependencies logging 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-05 18:14:47 +02:00
Carlos Antonio da Silva
9a776c2978 Improve dependencies by not calling constantize(const) twice while removing unloadable constants 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-05 18:14:47 +02:00
José Valim
599e46bf24 Revert "Setup explicit requires for files with exceptions. Removed them from autoloading." 
Booting a new Rails application does not work after this commit [#5359 state:open]

This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6.
 2010-09-02 21:11:03 +02:00
Łukasz Strzałkowski
38a421b34d Setup explicit requires for files with exceptions. Removed them from autoloading. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-02 11:54:04 +02:00
Andrew White
f1966337fa Add before_remove_const callback to ActiveSupport::Dependencies.remove_unloadable_constants! 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-09-01 22:32:41 +02:00
Neeraj Singh
cacb44874f delegate method should treat :prefix => false same as :prefix => nil 
[#5375 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-01 09:57:13 +02:00
Krekoten' Marjan
57693d1362 Make ActiveSupport::Duration#method_missing delegate blocks to value [#5498 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-01 09:56:54 +02:00
Neeraj Singh
67a2b5ec1b If certain sections of skip_callback method are commented out then 
no test was failing. Tests have been added to ensure that commenting
out the code within if loop would cause test failure.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-31 17:45:06 +02:00
Xavier Noria
b422cda2eb let String#strip_heredoc handle blank lines even if they are not indented 2010-08-30 10:39:34 +02:00
Jeremy Kemper
b861942691 Update CHANGELOGs for 3.0 release and upcoming 3.1 2010-08-29 22:06:48 -07:00
Xavier Noria
475ea14fd0 implements String#strip_heredoc 2010-08-29 23:52:38 +02:00
Mike Perham
390d285ef6 Support pluggable cache stores. 
[#5486 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-08-28 15:43:10 -07:00
Joost Baaij
80ae74dea7 Prevent any warnings from being printed during RDoc generation 2010-08-26 21:31:32 +02:00
Jaime Iniesta
5430f5bd06 lifecycle should be two words, life cycle 2010-08-26 14:23:58 +02:00
Xavier Noria
cd0267cd33 adds missing require for #parameterize 2010-08-26 01:56:10 +02:00
Jakub Suder
4f945e97e5 better callstack reporting in deprecation messages 
now the reported line is the first line in the stack
that's outside Rails, which is the one that actually
caused the problem in the first place

[#5231 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-25 07:23:50 -03:00
David Heinemeier Hansson
21b1f29720 Master is now targeting 3.1.0.beta 2010-08-23 21:44:57 -05:00
Santiago Pastorino
bb75c33754 Config is deprecated on 1.8.8 and 1.9.3 use RbConfig 2010-08-23 23:10:36 -03:00
Aaron Patterson
ecbdec115b making variable names a little more clear 2010-08-23 18:48:28 -07:00
Aaron Patterson
cdef4450e5 removing unused code 2010-08-22 17:15:56 -07:00
Santiago Pastorino
8d1ee434da Silence warnings for Encoding.default_external= and Encoding.default_internal= 2010-08-22 18:43:31 -03:00
Santiago Pastorino
d79a010976 Set default_internal and default_external on AS for testing purposes 2010-08-22 02:23:41 -03:00
Raphomet
7a090b0216 Trifling typos 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-21 19:20:42 -03:00
Xavier Noria
43291469cb deletes the rdoc task of each component, they are no longer published separately 2010-08-20 13:30:31 +02:00
Xavier Noria
5914875e77 now for real, the suite loads everything and these went unpatched 2010-08-19 02:57:10 +02:00
Xavier Noria
eab4860e9b avoids a ton o warnings activesupport/lib/active_support/dependencies.rb:239: warning: loading in progress, circular require considered harmful ... activesupport/lib/active_support/core_ext/hash/indifferent_access.rb while running the suite in Ruby 1.9.2 2010-08-19 02:46:42 +02:00
Santiago Pastorino
cad8bef5ea Bump up rdoc to 2.5.10 2010-08-18 11:44:12 -03:00
Aaron Patterson
a197d1c874 run the AS tests in verbose mode 2010-08-17 17:21:52 -07:00
wycats
c6db3486c3 1.8 block variable shadowing strikes again 2010-08-17 16:51:35 -07:00
wycats
dbe08026e1 Sadly, this segv's in 1.8 :( 2010-08-17 16:51:35 -07:00
Matthew Mongeau
dd55830bb2 to_sentence should return a duplicate 2010-08-17 13:52:37 -07:00
Xavier Noria
137e4e759a Merge remote branch 'docrails/master' 2010-08-17 13:28:33 +02:00
Peter Wagenet
ad53b68457 Class Attribute setter returns set value 
Signed-off-by: wycats <wycats@gmail.com>
 2010-08-16 18:36:12 -07:00
Xavier Noria
fb6b805620 code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them 2010-08-17 03:32:11 +02:00
Santiago Pastorino
2f9f0829c6 Object#returning has gone, it's already deprecated on 3-0-stable 2010-08-15 12:08:17 -03:00
Santiago Pastorino
2ad3d96cb0 recommended is the right word here 2010-08-15 08:44:14 -03:00
Santiago Pastorino
f939fb5e31 Makes use of class << self instead of def self. 2010-08-15 08:41:39 -03:00
Xavier Noria
3ba61ecb7f Revert "Add example label to activesupport/configurable" 
This reverts commit f480b2cea69247239f6fc2ad171b231595cc08c6.

Reason: API guidelines discourage this, see http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#example-code
 2010-08-15 02:22:38 +02:00
Xavier Noria
dd18840b79 Revert "Add example label to active_support/configurable" 
This reverts commit 693f770afe0e14fc1b4658ef51910d993e67dd07.

Reason: to be able to revert f480b2cea69247239f6fc2ad171b231595cc08c6
 2010-08-15 02:22:38 +02:00
Josep M. Bach
9f9a02af86 Whitespace and example identation 2010-08-15 02:22:38 +02:00
Josep M. Bach
e8ef58a697 Add example label to active_support/configurable 2010-08-15 02:22:38 +02:00
Josep M. Bach
664afe37dd Add example label to activesupport/configurable 2010-08-15 02:22:38 +02:00
Xavier Noria
21bbcfe42c reviews commit dcc9d38 2010-08-15 02:22:37 +02:00
Josep M. Bach
c7adc96186 Documented active_support/configurable 2010-08-15 02:22:37 +02:00
Josep M. Bach
ca87d0a395 Documentation just before Concern module 2010-08-15 02:22:37 +02:00
Josep M. Bach
98818f92b8 Documented active_support/concern dependency handling 2010-08-15 02:22:37 +02:00
Xavier Noria
0d5a060710 Revert "Add example label to activesupport/configurable" 
This reverts commit f480b2cea69247239f6fc2ad171b231595cc08c6.

Reason: API guidelines discourage this, see http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#example-code
 2010-08-14 18:35:01 +02:00
Xavier Noria
f725ae3fef Revert "Add example label to active_support/configurable" 
This reverts commit 693f770afe0e14fc1b4658ef51910d993e67dd07.

Reason: to be able to revert f480b2cea69247239f6fc2ad171b231595cc08c6
 2010-08-14 18:34:32 +02:00
Josep M. Bach
68e1b72f7a Whitespace and example identation 2010-08-14 17:52:52 +02:00
Josep M. Bach
693f770afe Add example label to active_support/configurable 2010-08-14 17:19:04 +02:00
Josep M. Bach
a83fcc1134 Merge branch 'master' of github.com:lifo/docrails 2010-08-14 17:15:15 +02:00
Josep M. Bach
f480b2cea6 Add example label to activesupport/configurable 2010-08-14 17:15:03 +02:00
Xavier Noria
d6fd0f7fa7 reviews commit dcc9d38 2010-08-14 17:08:14 +02:00
Josep M. Bach
25145d6f5f Documented active_support/configurable 2010-08-14 17:02:39 +02:00
Josep M. Bach
b5175566af Documentation just before Concern module 2010-08-14 16:52:05 +02:00
Josep M. Bach
dcc9d38b8b Documented active_support/concern dependency handling 2010-08-14 16:28:30 +02:00
Santiago Pastorino
b95d6e84b0 Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 13:17:32 +02:00
Santiago Pastorino
535082fe3e deprected -> deprecated 2010-08-14 03:55:14 -03:00
Xavier Noria
4134d7db34 Merge remote branch 'docrails/master' 2010-08-12 17:36:09 +02:00
Paco Guzman
8a2b69b727 applied guidelines to "# =>" 2010-08-12 17:09:58 +02:00
José Valim
25f1e015c0 Ensure @config is not a reserved instance variable in controllers. [#5342 state:resolved] 2010-08-11 10:26:07 -03:00
Gonçalo Silva
58add1b63c added support for more printers 2010-08-10 10:23:40 -07:00
José Valim
e86cced311 Revert "require_dependency should require using the normal mechanism if possible to avoid double-requires" 
This was causing double requires since 991cd59a225b90ab1ba3 was reverted.
This reverts commit 8bf79739b4219eb1d6464e6eb4853e92e81d7621.
 2010-08-10 11:18:58 -03:00
Neeraj Singh
fc01adee79 correcting wrong example 2010-08-06 15:51:52 -04:00
Xavier Noria
e0a0638094 commit review: say clearly that AS::OrderedHash is about insertion order, be more neutral in wording, do not imply lack of ordering is a problem 2010-08-06 13:11:44 +02:00
Neeraj Singh
cdbc880055 adding documentation for OrderedHash and OrderedOptions 2010-08-06 01:51:11 -04:00
Neeraj Singh
d0ac56b5b4 adding an example of skipping a callback 2010-08-06 01:51:11 -04:00
Xavier Noria
d62700f7dc Merge remote branch 'docrails/master' 2010-08-05 22:56:15 +02:00
Xavier Noria
02e711bf1c documents that :terminator is a string to be eval'ed, and that it sees the result variable 2010-08-05 22:54:43 +02:00
Xavier Noria
232218f465 Revert "correcting the documentation that default to false. it does not default to false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned" 
This reverts commit cd87cf771acb90c43cd56e5f038fc345a69790f9.

Reason: it does default to "false".
 2010-08-05 22:46:04 +02:00
Neeraj Singh
86842fd1ce fixing typo 2010-08-05 16:35:40 -04:00
Neeraj Singh
5130b0cf45 more documentation for class_inheritable_* 2010-08-05 11:55:45 -04:00
Neeraj Singh
cd87cf771a correcting the documentation that default to false. it does not default to false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned 2010-08-05 11:55:45 -04:00
Xavier Noria
8a657c0dc7 adds test coverage to ensure DateTime#advance processes first the date deltas, and then the time deltas 2010-08-05 16:12:43 +02:00
Xavier Noria
9989d3337f Merge remote branch 'docrails/master' 2010-08-05 15:56:42 +02:00
Tom Stuart
f544c0a32d Fix ActiveSupport::Callbacks' define_callbacks and ActiveSupport::Concern documentation to look like native English 2010-08-05 09:06:47 +01:00
Xavier Noria
3cbe111439 Merge remote branch 'docrails/master' 2010-08-05 01:15:57 +02:00
Neeraj Singh
589e6977d7 adding documentation to ActiveSupport::Concern ht:strictly typed for an awesome example 
some minor documentation changes
 2010-08-04 17:03:03 -04:00
Piotr Sarnacki
84f0a0bc30 Reload action_methods in AbstractController after defining new method. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-04 14:44:34 -03:00