thedarkone
f2e0b3575e
Use native attr_* macros for performance reasons.
2010-09-27 17:45:58 +02:00
thedarkone
320382ccd3
Creating singleton class for every object whenever the instance-level accessor is used quite is expensive.
2010-09-27 17:45:58 +02:00
thedarkone
5a518487fe
Try to use Hash's native #[] for speed.
2010-09-27 17:45:58 +02:00
thedarkone
8cda132136
Make InheritableOptions's constructor more flexible.
2010-09-27 17:45:58 +02:00
thedarkone
918dc27345
Compile ActionController::Base.config's methods to avoid method_missing overhead.
2010-09-27 17:45:58 +02:00
Emilio Tagua
6b135f7e46
Remove method if already exists to avoid warnings.
2010-09-27 11:19:22 -03:00
Krekoten' Marjan
1b7d30bfc9
Fix 'warning: method redefined' [ #5551 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-25 11:06:55 +02:00
Andrew Kaspick
fb08e334d6
memoized protected methods should remain protected
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-24 20:31:12 -03:00
Aaron Patterson
a0db7be4af
attr_accessor_with_default should raise an ArgumentError not a RuntimeError
2010-09-24 14:48:57 -07:00
Emilio Tagua
c88deaf5ee
Use map, no need to use inject here.
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-22 18:08:04 -03:00
Emilio Tagua
7047d83ec5
Perf: speed up json encoding.
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-22 18:08:04 -03:00
Emilio Tagua
418190d55c
Refactor inject use in hash conversions.
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-22 18:08:03 -03:00
Thiago Pradi
3c9bf6e1dc
Exception handling more readable
...
[#5601 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-19 12:18:51 -07:00
Prem Sichanugrist
af6757a1ca
Use Time.current
to maintain consistency with AS::Duration
...
In [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch
methods in AS::Duration to use `Time.current` to return the correct
duration based on the `Time.default_zone` instead of using `Time.now`.
[#5607 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-19 11:26:20 -07:00
Krekoten' Marjan
d4fa120671
Move capture to Kernel. [ #5641 state:resolved]
2010-09-18 20:49:36 +02:00
Xavier Noria
dd6efe98b6
Merge remote branch 'docrails/master'
2010-09-14 20:07:29 +02:00
Carl Lerche
9362ef6e21
Require lazy_load_hooks.rb with the correct path.
2010-09-14 10:40:05 -07:00
Jack Dempsey
a427876606
require i18n in transliterate so it can run in isolated situations
2010-09-14 10:25:33 -07:00
Marcelo Giorgi
d5ef502d2a
Reference watch_namespaces in comments instead of watch_modules
2010-09-13 17:53:39 -03:00
Aaron Patterson
8c6de675e4
Remove dummy method definition in favor of RDoc hints:
...
http://rdoc.rubyforge.org/RDoc/Parser/Ruby.html
2010-09-11 20:51:02 -07:00
Jakub Suder
2524cf404c
fixed some issues with JSON encoding
...
- as_json in ActiveModel should return a hash
and handle :only/:except/:methods options
- Array and Hash should call as_json on their elements
- json methods should not modify options argument
[#5374 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-09-07 11:33:10 -07:00
Carlos Antonio da Silva
c91605b15b
Refactor a bit dependencies logging
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-05 18:14:47 +02:00
Carlos Antonio da Silva
9a776c2978
Improve dependencies by not calling constantize(const) twice while removing unloadable constants
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-05 18:14:47 +02:00
José Valim
599e46bf24
Revert "Setup explicit requires for files with exceptions. Removed them from autoloading."
...
Booting a new Rails application does not work after this commit [#5359 state:open]
This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6.
2010-09-02 21:11:03 +02:00
Łukasz Strzałkowski
38a421b34d
Setup explicit requires for files with exceptions. Removed them from autoloading.
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-02 11:54:04 +02:00
Andrew White
f1966337fa
Add before_remove_const callback to ActiveSupport::Dependencies.remove_unloadable_constants!
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-09-01 22:32:41 +02:00
Neeraj Singh
cacb44874f
delegate method should treat :prefix => false same as :prefix => nil
...
[#5375 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:57:13 +02:00
Krekoten' Marjan
57693d1362
Make ActiveSupport::Duration#method_missing delegate blocks to value [ #5498 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:56:54 +02:00
Neeraj Singh
67a2b5ec1b
If certain sections of skip_callback method are commented out then
...
no test was failing. Tests have been added to ensure that commenting
out the code within if loop would cause test failure.
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-31 17:45:06 +02:00
Xavier Noria
b422cda2eb
let String#strip_heredoc handle blank lines even if they are not indented
2010-08-30 10:39:34 +02:00
Jeremy Kemper
b861942691
Update CHANGELOGs for 3.0 release and upcoming 3.1
2010-08-29 22:06:48 -07:00
Xavier Noria
475ea14fd0
implements String#strip_heredoc
2010-08-29 23:52:38 +02:00
Mike Perham
390d285ef6
Support pluggable cache stores.
...
[#5486 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-08-28 15:43:10 -07:00
Joost Baaij
80ae74dea7
Prevent any warnings from being printed during RDoc generation
2010-08-26 21:31:32 +02:00
Jaime Iniesta
5430f5bd06
lifecycle should be two words, life cycle
2010-08-26 14:23:58 +02:00
Xavier Noria
cd0267cd33
adds missing require for #parameterize
2010-08-26 01:56:10 +02:00
Jakub Suder
4f945e97e5
better callstack reporting in deprecation messages
...
now the reported line is the first line in the stack
that's outside Rails, which is the one that actually
caused the problem in the first place
[#5231 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-25 07:23:50 -03:00
David Heinemeier Hansson
21b1f29720
Master is now targeting 3.1.0.beta
2010-08-23 21:44:57 -05:00
Santiago Pastorino
bb75c33754
Config is deprecated on 1.8.8 and 1.9.3 use RbConfig
2010-08-23 23:10:36 -03:00
Aaron Patterson
ecbdec115b
making variable names a little more clear
2010-08-23 18:48:28 -07:00
Aaron Patterson
cdef4450e5
removing unused code
2010-08-22 17:15:56 -07:00
Santiago Pastorino
8d1ee434da
Silence warnings for Encoding.default_external= and Encoding.default_internal=
2010-08-22 18:43:31 -03:00
Santiago Pastorino
d79a010976
Set default_internal and default_external on AS for testing purposes
2010-08-22 02:23:41 -03:00
Raphomet
7a090b0216
Trifling typos
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-21 19:20:42 -03:00
Xavier Noria
43291469cb
deletes the rdoc task of each component, they are no longer published separately
2010-08-20 13:30:31 +02:00
Xavier Noria
5914875e77
now for real, the suite loads everything and these went unpatched
2010-08-19 02:57:10 +02:00
Xavier Noria
eab4860e9b
avoids a ton o warnings activesupport/lib/active_support/dependencies.rb:239: warning: loading in progress, circular require considered harmful ... activesupport/lib/active_support/core_ext/hash/indifferent_access.rb while running the suite in Ruby 1.9.2
2010-08-19 02:46:42 +02:00
Santiago Pastorino
cad8bef5ea
Bump up rdoc to 2.5.10
2010-08-18 11:44:12 -03:00
Aaron Patterson
a197d1c874
run the AS tests in verbose mode
2010-08-17 17:21:52 -07:00
wycats
c6db3486c3
1.8 block variable shadowing strikes again
2010-08-17 16:51:35 -07:00
wycats
dbe08026e1
Sadly, this segv's in 1.8 :(
2010-08-17 16:51:35 -07:00
Matthew Mongeau
dd55830bb2
to_sentence should return a duplicate
2010-08-17 13:52:37 -07:00
Xavier Noria
137e4e759a
Merge remote branch 'docrails/master'
2010-08-17 13:28:33 +02:00
Peter Wagenet
ad53b68457
Class Attribute setter returns set value
...
Signed-off-by: wycats <wycats@gmail.com>
2010-08-16 18:36:12 -07:00
Xavier Noria
fb6b805620
code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them
2010-08-17 03:32:11 +02:00
Santiago Pastorino
2f9f0829c6
Object#returning has gone, it's already deprecated on 3-0-stable
2010-08-15 12:08:17 -03:00
Santiago Pastorino
2ad3d96cb0
recommended is the right word here
2010-08-15 08:44:14 -03:00
Santiago Pastorino
f939fb5e31
Makes use of class << self instead of def self.
2010-08-15 08:41:39 -03:00
Xavier Noria
3ba61ecb7f
Revert "Add example label to activesupport/configurable"
...
This reverts commit f480b2cea69247239f6fc2ad171b231595cc08c6.
Reason: API guidelines discourage this, see http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#example-code
2010-08-15 02:22:38 +02:00
Xavier Noria
dd18840b79
Revert "Add example label to active_support/configurable"
...
This reverts commit 693f770afe0e14fc1b4658ef51910d993e67dd07.
Reason: to be able to revert f480b2cea69247239f6fc2ad171b231595cc08c6
2010-08-15 02:22:38 +02:00
Josep M. Bach
9f9a02af86
Whitespace and example identation
2010-08-15 02:22:38 +02:00
Josep M. Bach
e8ef58a697
Add example label to active_support/configurable
2010-08-15 02:22:38 +02:00
Josep M. Bach
664afe37dd
Add example label to activesupport/configurable
2010-08-15 02:22:38 +02:00
Xavier Noria
21bbcfe42c
reviews commit dcc9d38
2010-08-15 02:22:37 +02:00
Josep M. Bach
c7adc96186
Documented active_support/configurable
2010-08-15 02:22:37 +02:00
Josep M. Bach
ca87d0a395
Documentation just before Concern module
2010-08-15 02:22:37 +02:00
Josep M. Bach
98818f92b8
Documented active_support/concern dependency handling
2010-08-15 02:22:37 +02:00
Xavier Noria
0d5a060710
Revert "Add example label to activesupport/configurable"
...
This reverts commit f480b2cea69247239f6fc2ad171b231595cc08c6.
Reason: API guidelines discourage this, see http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#example-code
2010-08-14 18:35:01 +02:00
Xavier Noria
f725ae3fef
Revert "Add example label to active_support/configurable"
...
This reverts commit 693f770afe0e14fc1b4658ef51910d993e67dd07.
Reason: to be able to revert f480b2cea69247239f6fc2ad171b231595cc08c6
2010-08-14 18:34:32 +02:00
Josep M. Bach
68e1b72f7a
Whitespace and example identation
2010-08-14 17:52:52 +02:00
Josep M. Bach
693f770afe
Add example label to active_support/configurable
2010-08-14 17:19:04 +02:00
Josep M. Bach
a83fcc1134
Merge branch 'master' of github.com:lifo/docrails
2010-08-14 17:15:15 +02:00
Josep M. Bach
f480b2cea6
Add example label to activesupport/configurable
2010-08-14 17:15:03 +02:00
Xavier Noria
d6fd0f7fa7
reviews commit dcc9d38
2010-08-14 17:08:14 +02:00
Josep M. Bach
25145d6f5f
Documented active_support/configurable
2010-08-14 17:02:39 +02:00
Josep M. Bach
b5175566af
Documentation just before Concern module
2010-08-14 16:52:05 +02:00
Josep M. Bach
dcc9d38b8b
Documented active_support/concern dependency handling
2010-08-14 16:28:30 +02:00
Santiago Pastorino
b95d6e84b0
Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;)
2010-08-14 13:17:32 +02:00
Santiago Pastorino
535082fe3e
deprected -> deprecated
2010-08-14 03:55:14 -03:00
Xavier Noria
4134d7db34
Merge remote branch 'docrails/master'
2010-08-12 17:36:09 +02:00
Paco Guzman
8a2b69b727
applied guidelines to "# =>"
2010-08-12 17:09:58 +02:00
José Valim
25f1e015c0
Ensure @config is not a reserved instance variable in controllers. [ #5342 state:resolved]
2010-08-11 10:26:07 -03:00
Gonçalo Silva
58add1b63c
added support for more printers
2010-08-10 10:23:40 -07:00
José Valim
e86cced311
Revert "require_dependency should require using the normal mechanism if possible to avoid double-requires"
...
This was causing double requires since 991cd59a225b90ab1ba3 was reverted.
This reverts commit 8bf79739b4219eb1d6464e6eb4853e92e81d7621.
2010-08-10 11:18:58 -03:00
Neeraj Singh
fc01adee79
correcting wrong example
2010-08-06 15:51:52 -04:00
Xavier Noria
e0a0638094
commit review: say clearly that AS::OrderedHash is about insertion order, be more neutral in wording, do not imply lack of ordering is a problem
2010-08-06 13:11:44 +02:00
Neeraj Singh
cdbc880055
adding documentation for OrderedHash and OrderedOptions
2010-08-06 01:51:11 -04:00
Neeraj Singh
d0ac56b5b4
adding an example of skipping a callback
2010-08-06 01:51:11 -04:00
Xavier Noria
d62700f7dc
Merge remote branch 'docrails/master'
2010-08-05 22:56:15 +02:00
Xavier Noria
02e711bf1c
documents that :terminator is a string to be eval'ed, and that it sees the result variable
2010-08-05 22:54:43 +02:00
Xavier Noria
232218f465
Revert "correcting the documentation that default to false. it does not default to false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned"
...
This reverts commit cd87cf771acb90c43cd56e5f038fc345a69790f9.
Reason: it does default to "false".
2010-08-05 22:46:04 +02:00
Neeraj Singh
86842fd1ce
fixing typo
2010-08-05 16:35:40 -04:00
Neeraj Singh
5130b0cf45
more documentation for class_inheritable_*
2010-08-05 11:55:45 -04:00
Neeraj Singh
cd87cf771a
correcting the documentation that default to false. it does not default to false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned
2010-08-05 11:55:45 -04:00
Xavier Noria
8a657c0dc7
adds test coverage to ensure DateTime#advance processes first the date deltas, and then the time deltas
2010-08-05 16:12:43 +02:00
Xavier Noria
9989d3337f
Merge remote branch 'docrails/master'
2010-08-05 15:56:42 +02:00
Tom Stuart
f544c0a32d
Fix ActiveSupport::Callbacks' define_callbacks and ActiveSupport::Concern documentation to look like native English
2010-08-05 09:06:47 +01:00
Xavier Noria
3cbe111439
Merge remote branch 'docrails/master'
2010-08-05 01:15:57 +02:00
Neeraj Singh
589e6977d7
adding documentation to ActiveSupport::Concern ht:strictly typed for an awesome example
...
some minor documentation changes
2010-08-04 17:03:03 -04:00
Piotr Sarnacki
84f0a0bc30
Reload action_methods in AbstractController after defining new method.
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-04 14:44:34 -03:00
José Valim
462666b737
Revert "If a file is in the load path, require it without its full path (in more places)"
...
Caused failures in ActionMailer test suite.
This reverts commit 991cd59a225b90ab1ba31867810b8fc0942713eb.
2010-08-04 14:17:46 -03:00
wycats
991cd59a22
If a file is in the load path, require it without its full path (in more places)
2010-08-04 03:25:57 -07:00
wycats
8bf79739b4
require_dependency should require using the normal mechanism if possible to avoid double-requires
2010-08-04 03:25:57 -07:00
José Valim
88b5f938cf
Bring returning back to ease migration.
2010-08-02 18:40:20 +02:00
Chris Hoffman
59cf514a5b
Add missing require in ActiveSupport::HashWithIndifferentAccess [ #5189 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-02 16:18:33 +02:00
Xavier Noria
f78de68649
explains Array.wrap directly, rather by comparison with Kernel#Array which is too obscure, leaves the comparison to document the differences, and adds a comparison with the related idiom that uses the splat operator
2010-08-01 03:19:58 +02:00
Santiago Pastorino
5132081975
AS gem doesn't depend on nokogiri so shows a nicer error if users haven't installed
2010-07-30 16:05:51 -03:00
Santiago Pastorino
95e9ced581
Make options an attr_reader
2010-07-30 12:09:47 -03:00
Carl Lerche
d277b823d0
Add another missing require in 'active_support/inflector/inflections'
2010-07-29 22:53:21 -07:00
Xavier Noria
ccd45618ed
Merge remote branch 'rails/master'
2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755
edit pass to apply API guideline wrt the use of "# =>" in example code
2010-07-30 02:30:04 +02:00
Neeraj Singh
3c3ff1377d
Adding documentation regarding lazy_load_hooks
2010-07-29 13:05:54 -04:00
Carl Lerche
d04c6f2ff6
Add a missing require in 'active_support/core_ext/string/inflections'
2010-07-29 08:51:23 -07:00
Neeraj Singh
627d870c92
itsy bitsy changes to documentation
2010-07-28 22:44:32 -04:00
José Valim
7c3d479c4b
More documentation to class_attribute.
2010-07-28 08:49:54 -07:00
Neeraj Singh
dea8bf5dc4
editing the documentation regarding :race_condition_ttl and :expires_in option in AS cache
2010-07-28 11:22:35 -04:00
Neeraj Singh
2d601e4ea3
editing a sentence
2010-07-28 10:56:10 -04:00
Neeraj Singh
5b10e47593
adding comment specifying that cattr_accessor also supports instance_write and instance_rader option
2010-07-28 10:13:11 -04:00
Neeraj Singh
eb902d6c00
clarifying the instance_write option with an example
2010-07-28 10:08:00 -04:00
Neeraj Singh
ff7e17d33e
adding some comments to cattr_accessor method
2010-07-28 10:05:10 -04:00
Neeraj Singh
f3b50b11c7
updating description of how class_attribute works
2010-07-28 09:53:38 -04:00
Neeraj Singh
4952a80200
adding test for respond_to cache_key and cleaning up the ENV settings
2010-07-28 21:02:45 +08:00
Neeraj Singh
7d29627be9
test cases for rails_app_version in AS cache.rb
2010-07-28 21:02:45 +08:00
Neeraj Singh
3265af5c8b
adding more test cases for expand_cache_key
2010-07-28 21:02:44 +08:00
Neeraj Singh
194ec3d165
removing unused variable
2010-07-28 21:02:44 +08:00
Xavier Noria
e17e08efef
adds test coverage for edge-cases of Array.wrap, and better documentation for how it differs from Kernel#Array
2010-07-28 03:49:04 +02:00
Neeraj Singh
e7920a3bde
clarifying description for class_attribute method
2010-07-27 16:30:56 -04:00
Neeraj Singh
f3409dc0a0
polishing comments
2010-07-26 23:35:15 -04:00
Neeraj Singh
d214925625
making comments meaningful by correcting, adding and pruning
2010-07-26 23:03:46 -04:00
Neeraj Singh
b357aedbf6
making comments have a consistent theme of narrative
2010-07-26 22:41:13 -04:00
Santiago Pastorino
a2ca9cb78d
This is a hash in 1.9.2
2010-07-26 20:09:34 -03:00
David Heinemeier Hansson
856fc4bbc3
Prep for RC
2010-07-26 12:53:25 -05:00
Aaron Patterson
32844cbc02
fixing space errors
2010-07-26 09:58:35 -07:00
Leigh Caplan
37d82f2ca0
Test to ensure that falsy objects aren't wrapped by deprecation proxies
2010-07-26 09:53:42 -07:00
Leigh Caplan
e56c9ef08d
Override new on proxy objects so that they never wrap nil or false.
2010-07-26 09:53:42 -07:00
Bernerd Schaefer
e87e3db200
XmlMini.rename_key emits valid xml with dasherize
...
This resolves issues for libraries which use '_' prefixed keys in their
attributes hash, such as Mongoid. A key like "_id" or "_type" will no
longer be converted to "<-id>" and "<-type>".
Signed-off-by: wycats <wycats@gmail.com>
2010-07-26 09:48:22 -07:00
Santiago Pastorino
4ea1753fc2
This is for making sure const_missing is triggered without warnings
2010-07-26 12:51:52 -03:00
Neeraj Singh
78c8242d2f
strengthening the test suite for rescue_from
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-26 16:48:50 +02:00
Neeraj Singh
a5bb1f511f
strengthening the rescue_from test suites
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-26 16:48:45 +02:00
wycats
1b97701e51
Fix a bug where requires inside of autoloads were being added to the autoloaded_constants list, causing mayhem. [ #5165 state:resolved]
2010-07-26 00:59:54 -07:00
Aaron Patterson
53fbbf4b83
fisting warning
2010-07-25 16:28:21 -07:00
Xavier Noria
6aa1253588
Merge remote branch 'docrails/master'
2010-07-26 00:23:57 +02:00
Xavier Noria
dcb7832ed5
APIs for individual components are no longer published
2010-07-26 00:05:14 +02:00
Santiago Pastorino
9a32af96d1
CHANGELOG updated Object#returning removed
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-25 23:30:36 +02:00
Santiago Pastorino
b0b9bf3204
Object#returning removed
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-25 23:30:27 +02:00
José Valim
ff0d842454
Revert the previous three commits.
...
* AS::Notifications#instrument should not measure anything, it is not its responsibility;
* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
2010-07-25 20:46:42 +02:00
Aaron Patterson
b7e0408ca9
use a hash to collect optional statistics about the instrumentation
2010-07-25 11:11:23 -07:00
Santiago Pastorino
b1cfcedc8f
Change returning with tap
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-25 16:33:04 +02:00
Santiago Pastorino
749948a264
Removing one AS/lib ruby and rake adds to $LOAD_PATH
2010-07-25 08:27:00 +08:00
José Valim
834bd23a07
Get rid of instrumenter.elapsed.
2010-07-24 10:22:22 +02:00
Santiago Pastorino
85980852a0
make a throwaway value equals to _ to avoid warnings
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:55 +02:00
Santiago Pastorino
8289661903
Make this test, test again
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:47 +02:00
Santiago Pastorino
e1d4e78b15
Removes unused vars
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:44 +02:00
Santiago Pastorino
80cf6559ed
Makes restore previosly saved warnings_on_first_load value and avoid warning
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:43 +02:00
Neeraj Singh
8429e7b45b
making comments sentence more concise
2010-07-23 16:22:17 -04:00
Neeraj Singh
46c7a991a2
fixing typo
2010-07-23 16:14:16 -04:00
Aaron Patterson
b50635a59f
update Rakefiles for RDoc 2.5
2010-07-23 21:11:29 +02:00
Neeraj Singh
4bf6c1c0c0
adding proper markup in comments
2010-07-23 14:27:14 -04:00
Neeraj Singh
34165176cf
shortening the sentences and removing fluff
2010-07-23 14:21:03 -04:00
Neeraj Singh
8f638d8cc1
reformatting sentence
2010-07-23 14:11:14 -04:00
Santiago Pastorino
b378b19430
Makes Rakefile activate rdoc >= 2.5.9
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-07-23 00:04:06 +02:00
Santiago Pastorino
21c4b0942f
Don't shadow outer local variables
2010-07-22 15:48:52 -03:00
Carlhuda
ba8d89c4c8
Performance optimizations to handle cases of instrumentors that are not listened to. Also, fix a possible concurrency issue.
2010-07-22 11:36:16 -07:00
Mislav Marohnić
89b5e79632
revise download/installation/support sections in READMEs
...
- don't reference ancient gem versions
- don't link to old API doc subdomains
- point to GitHub instead of RubyForge
- point to Lighthouse account for support
2010-07-22 09:17:19 +02:00
Santiago Pastorino
30df88ae06
These tests are trusting in the order of the elements so use OrderedHash instead of Hash
2010-07-21 17:34:43 -07:00
Xavier Noria
b456877cfb
camelize and underscore are sort of inverse of each other, but not in a mathematical sense [ #5174 state:resolved]
2010-07-22 01:28:31 +02:00
Santiago Pastorino
6cbd085f69
Test Hash#to_param escapes keys and values
...
[#5175 ]
2010-07-22 06:29:59 +08:00
Santiago Pastorino
5c85822008
Hash#to_param is doesn't use sort anymore, some tests added for Hash#to_param
2010-07-22 06:23:13 +08:00
Santiago Pastorino
d16c5cc99b
Change some missing README -> README.rdoc
2010-07-22 01:47:06 +08:00
José Valim
508fba9e07
Add .rdoc extension to README files.
2010-07-21 12:51:14 +02:00
José Valim
f1082bd51e
Remove old install.rb files.
2010-07-21 11:56:28 +02:00
José Valim
d4151d7f0a
Fix a failing test in Railtie and properly define all severity levels in MockLogger for LogSubscriber.
2010-07-20 21:21:14 +02:00
José Valim
9df9c4bac0
Add a test for elapsed and require missing benchmark file.
2010-07-20 17:07:18 +02:00
Kouhei Sutou
a6e95ba554
fix mixed encoding logs can't be logged.
...
[#4807 state:committed]
Signed-off-by: Kouhei Sutou <kou@cozmixng.org>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-07-19 14:55:58 -07:00
Aaron Patterson
202fb79e86
reusing the time instrumentation from the instrumenter rather than Benchmark. [ #5098 state:open]
2010-07-19 13:44:11 -07:00
Aaron Patterson
1b26c66ce4
mocking out debing? call in the MockLogger
2010-07-19 13:19:28 -07:00
Daniel Guettler
38f0161aab
Minor performance improvment in notifications/fanout and active_record/log_subscriber [ #5098 state:open]
2010-07-19 11:45:50 -07:00
Aaron Patterson
dd4e81df86
avoid call to Array#first
2010-07-19 10:21:45 -07:00
Łukasz Strzałkowski
fc71d59219
Introduced redefine_method
2010-07-19 23:44:46 +08:00
Aaron Patterson
ad8f4dfc50
avoid proc activation every time a log message is made
2010-07-18 17:37:39 -07:00
Aaron Patterson
8cbb89c0bf
subscriber does not need to be a block, but an object that responds to #call
2010-07-18 17:20:20 -07:00
Aaron Patterson
b2c8a5fd3e
Notifier API == Fanout API, so replace Notifier with Fanout as they quack the same
2010-07-18 16:49:29 -07:00
Aaron Patterson
234b969946
tap the subscriber for easier return value
2010-07-18 15:39:32 -07:00
Aaron Patterson
2cbef6996c
bind method is not needed, so goodbye! <3 <3 <3
2010-07-18 15:37:23 -07:00
Santiago Pastorino
3870366092
Float comparison adjustment
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-18 19:28:46 +02:00
Aaron Patterson
cfca55949f
convert duration to an attr_reader
2010-07-17 16:03:56 -07:00
Santiago Pastorino
cebe5c2fac
It's not needed to initialize the attr when calling mattr_writer
2010-07-18 06:06:58 +08:00
Aaron Patterson
606d8fdfc8
drained? is never called
2010-07-17 14:45:59 -07:00
Aaron Patterson
fa73e777a1
private method is not needed
2010-07-17 14:44:29 -07:00
Aaron Patterson
4226c93779
removing Binding class
2010-07-17 14:35:44 -07:00
Aaron Patterson
9c80f5b391
use === to avoid regular expression creation, and speed up string comparison
2010-07-17 13:14:38 -07:00
Nick Sieger
ea7f1fb026
Don't rely on implementation-specific order-dependence of array comparisons in unit tests
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-07-17 01:59:51 +08:00
wycats
16bae77c56
Revert "Improve performance of MessageVerifier while keeping it constant time"
...
This reverts commit 8b05c5207dd5757d55d0c384740db289e6bd5415.
2010-07-13 16:13:54 -07:00
Xavier Noria
6d2e4ee96c
Merge remote branch 'docrails/master'
2010-07-13 18:41:09 +02:00
Benjamin Quorning
7e075e6247
Fixed many references to the old config/environment.rb and Rails::Initializer
2010-07-13 13:00:21 +02:00
Santiago Pastorino
725090942f
We shouldn't rely on float comparison, delta added just in case float representation of this values aren't equal
2010-07-12 09:59:52 +08:00
Xavier Noria
2f04c87855
Merge remote branch 'docrails/master'
2010-07-09 22:08:24 +02:00
Jaime Iniesta
c6f4c5916e
Minor typos: 'built-in' instead of 'built in', 'built into' instead of 'built in to'
2010-07-09 17:53:47 +02:00
Norman Clarke
6f83a57ac7
Improve bang method defs, make slice! operate in-place. [ #5028 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-08 22:59:24 +02:00
José Valim
a5dda97602
Define a convention for descendants and subclasses.
...
The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children.
By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts.
2010-07-05 13:01:27 +02:00
Santiago Pastorino
5bf3294c8b
Move Date#xmlschema to conversions and add a missing require
2010-07-04 14:10:28 -07:00
Santiago Pastorino
f6d7a4d251
Removes the dependency that AMo has on tzinfo
...
[#4979 state:committed]
2010-07-03 02:26:18 -03:00
Santiago Pastorino
201f373e7a
Refactor move some date, time and date_time methods to */zones and fixed some requires
2010-07-03 02:13:44 -03:00
Santiago Pastorino
8cc746331c
Time#formatted_offset is defined in core_ext/time/conversions
...
[#4979 ]
2010-07-02 20:22:35 -07:00
Geoff Buesing
227e1caea5
Time#as_json: use Time#formatted_offset instead of strftime %z directive, which is non-standard and inaccurate on some platforms (e.g., Mac OS X).
...
[#4979 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-07-02 11:50:16 -07:00
Santiago Pastorino
cb321546b7
Time has it own implementation of xmlschema, now AMo doesn't depend on TZInfo
...
[#4979 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-02 01:51:03 +02:00
Santiago Pastorino
4a0c514eb4
AS json refactor, move to_json implementation to core_ext and a cleanup a bit the code
2010-07-01 12:04:11 -07:00
José Valim
53b34e8476
Avoid calls to Rails::Application since this is not the official API.
...
Your application should *always* reference your application const (as Blog::Application) and Rails.application should be used just internally.
2010-07-01 18:43:44 +02:00
Cyril Mougel
9024545a6b
fix failure if behavior is not define and try use the default
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-01 12:17:21 +02:00
José Valim
e596a8e14c
Add the possibility to have several behaviors in AS::Deprecation.
2010-07-01 10:26:45 +02:00
Xavier Noria
c63cf7bf0d
Merge remote branch 'rails/master'
2010-06-30 20:47:26 +02:00
bodhi
2eaae1f50b
add note of which configuration option to set in deprecation warning message [ #5012 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-30 16:58:05 +02:00
José Valim
9ab8cfc21a
Improve the idiom used in multibyte chars a bit.
2010-06-30 15:01:23 +02:00
Alex Muntean
265b7c5edf
Fix ActiveSupport::Multibyte::Chars#slice for empty strings when starting offset is negative [ #4717 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-30 15:00:55 +02:00
Norman Clarke
4dbb6e3ff0
Update Unicode database to 5.2.0. [ #5011 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-30 13:22:35 +02:00
James MacAulay
16cef77d37
Fix AS::MB::Chars#+ to not alter self [ #4646 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-30 13:22:28 +02:00
Gonçalo Silva
68bd46ffb9
performance tests now working accurately on 1.9, using Ruby with the GCdata patch
2010-06-29 17:12:37 -07:00
wycats
c1beeb4068
Add CHANGELOG for new deprecation style
2010-06-29 12:25:13 -07:00
wycats
d4c7d3fd94
Create a deprecation behavior that triggers a notification for deprecation notices, and make the behaviors independent of the environment names.
...
* In Rails 2.3 apps being upgraded, you will need to add the deprecation
configuration to each of your environments. Failing to do so will
result in the same behavior as Rails 2.3, but with an outputted warning
to provide information on how to set up the setting.
* New Rails 3 applications generate the setting
* The notification style will send deprecation notices using
ActiveSupport::Notifications. Third-party tools can listen in to
these notifications to provide a streamlined view of the
deprecation notices occurring in your app.
* The payload in the notification is the deprecation warning itself
as well as the callstack from the point that triggered the
notification.
2010-06-29 12:20:15 -07:00
Santiago Pastorino
b2633f9f93
Don't store incorrect values in zones_map
...
[#4942 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-28 19:35:33 +02:00
Leigh Caplan
97a92a4cfd
test that unknown zones don't store mapping keys
...
[#4942 ]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-28 19:35:27 +02:00
Thiago Pradi
0175c470c0
Documentation for Array#sample
2010-06-28 13:31:57 -03:00
Santiago Pastorino
6cc29ab65f
Implemented getbyte as an aliased method and RDoc added
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-28 01:45:57 +02:00
Santiago Pastorino
cfb38319bc
Makes more sense to ask about method_defined?
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-28 01:26:01 +02:00
Santiago Pastorino
a822ce78b3
String#[] doesn't return the byte representation on 1.9.2, we should use getbyte that was already added as a Ruby < 1.9 core_ext
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-27 20:30:29 +02:00
Santiago Pastorino
fa96638bf2
Added getbyte as a core_ext to Ruby < 1.9
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-27 20:30:24 +02:00
Santiago Pastorino
926ca9c102
Load JSON additions (as to_json) on active_support/all.
...
[#4730 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-26 21:15:18 +02:00
Santiago Pastorino
51be8dbded
Move constantize from conversions to inflections.
...
This removes ActiveModel dependency on TZInfo.
[#4979 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-26 20:49:30 +02:00
José Valim
3782010377
Oops. Make previous commit pass on 1.9.2.
2010-06-26 12:14:25 +02:00
José Valim
aa48ab05f4
Tidy up tests in previous commit since they did not assure an OrderedHash is returned (the test would pass for an array and would pass by chance for hashes).
...
[#4875 state:resolved]
2010-06-26 12:09:56 +02:00
chaitanyav
9958950f78
Add OrderedHash#invert to preserve order in ruby 1.8 [ #4875 ]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-26 12:05:25 +02:00
José Valim
7bd85a8fc2
Work around the fact the JSON gem was overwriting to_json implementation for all Ruby core classes.
...
This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized.
So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved]
2010-06-26 12:01:13 +02:00
Norman Clarke
cfaaed3f40
Move some methods into 1.8.x-only proxy. [ #4978 state:resolved]
...
These methods had been overridden because they had bugs on 1.9.1. Since
Rails now supports only 1.9.2, and these methods now work properly on
that version, there's no longer any need to override them.
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-26 10:16:37 +02:00
rohit
cae33c4158
Remove previously defined class method logger to supress warnings in Active Support test suites. [ #4618 state:open]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-26 00:27:31 +02:00
Paul Mucur
158e22dae0
Alias ActiveSupport::OrderedHash#update to ActiveSupport::OrderedHash.merge!
...
This ensures that an OrderedHash's keys are set up appropriately when using update.
[#4973 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-06-25 15:02:20 -07:00
Nick Sieger
b549d93d2f
AS::Isolation functional on Windows/JRuby.
...
Doesn't make up for the fact that it's slooooooooow, though.
Signed-off-by: wycats <wycats@gmail.com>
2010-06-24 09:10:58 -07:00
José Valim
6788db824a
Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [ #4816 state:resolved]
2010-06-24 13:23:43 +02:00
José Valim
69abbe8934
Avoid using Pathname on Resolver and AS::Dependencies.
2010-06-24 01:06:37 +02:00
Xavier Noria
6f83a5036d
renames load_(once_)paths to autoload_(once_)paths in dependencies and config
2010-06-24 00:17:28 +02:00
Prem Sichanugrist
6c4bab306a
Missing require for the class/attribute.rb [4812 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-22 17:18:28 +02:00
David Calavera
b8330a2261
preventing memcached initialization errors with default servers list [ #4921 state:resolved]
...
As of this writing the JRuby client does not support a default port.
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-22 16:28:29 +02:00
David Calavera
256a33d0fb
defines ORIG_ARGV in Active Support's abstract_unit.rb (used in isolation.rb) [ #4922 state:resolved]
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-22 16:27:09 +02:00
Josh Kalderimis
fd03f1738e
removed default Formatter in logger, not needed with 1.8.7 upwards
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-22 01:19:02 +02:00
Josh Kalderimis
dad71c6099
removed 'unless const_defined?' code smell
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-21 23:34:45 +02:00
rohit
45b263cbf1
Initialize @last_update_at in file_update_checker to hide warnings in AS test suite.
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-21 11:10:19 +02:00
Hongli Lai (Phusion)
756d77622b
Allow instrumentation of cache hits and misses. [ #4888 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-21 01:09:55 +02:00
Xavier Noria
69fec3ab3f
adds parens to silence a warning in the test suite of AS
2010-06-20 23:29:37 +02:00
Xavier Noria
207fa59675
Merge remote branch 'rails/master'
...
Conflicts:
actionpack/lib/abstract_controller/base.rb
2010-06-20 23:13:19 +02:00
Rodrigo Rosenfeld Rosas
03216ae252
Fix comment in en.yml datime_select -> datetime_select
2010-06-20 10:41:47 -03:00
José Valim
50d37a7606
Update ActiveSupport CHANGELOG with latest changes.
2010-06-20 14:47:56 +02:00
José Valim
dad80ad786
I18n.reload! is only called if any of the locale files actually changed.
2010-06-20 14:44:38 +02:00
José Valim
71703c98ba
Add ActiveSupport::FileUpdateChecker.
2010-06-20 13:26:42 +02:00
Norman Clarke
667522ca98
Adds titleize/titlecase to AS::Multibyte::Chars
...
[#2794 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-20 00:51:19 +02:00
rohit
95a8f252c0
remove executable permission from files that don't need it. [ #4802 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-20 00:50:48 +02:00
Sam Elliott and Santiago Pastorino
02ea1aa88c
<=> is defined twice on multibyte/chars.rb for Ruby < 1.9
...
[#4850 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-20 00:35:20 +02:00
José Valim
72725d7b7f
Merge branch 'master' of github.com:rails/rails
2010-06-20 00:12:54 +02:00
José Valim
d430db9fd4
Remove descendants warning while executing tests.
2010-06-19 17:16:11 +02:00
José Valim
a2b7fcb07c
Change callbacks to automatically include DescendantsTracker and rename descendents to descendants.
2010-06-19 16:58:15 +02:00
José Valim
8db8c6f4ce
Add ActiveSupport::DescendantsTracker.
2010-06-19 16:44:35 +02:00
Maxime RETY
2c2a5fe829
Fix Yajl backend discovery in ActiveSupport::JSON
...
[#4897 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-06-18 20:12:31 -07:00
Gonçalo Silva
113b0ec03c
enable_stats added back in since Benchmarker doesn't start RubyProf
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-06-17 22:15:16 -07:00
Gonçalo Silva
0cef199c8e
check if the profiler patch is applied, otherwise GC::Profiler doesn't have the 'data' method
2010-06-17 19:18:53 -07:00
Gonçalo Silva
c8019cd04a
added information about what is being used
2010-06-17 19:18:53 -07:00
Gonçalo Silva
b169d83787
heap_live_objects+heap_free_objects is broken, use heap_total_objects instead
2010-06-17 19:18:53 -07:00
Gonçalo Silva
5e5d1babb0
also use GC profiler extended patch to retrieve GC time on 1.9
2010-06-17 19:18:53 -07:00
Gonçalo Silva
f02d3f9eee
ruby's GC doesn't support the time method, removed support for it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
175164397b
use GC profiler extended patch to retrieve GC runs on 1.9
2010-06-17 19:18:52 -07:00
Gonçalo Silva
555c3b5abe
ruby's GC doesn't support collections and heap_info, RubyProf can handle it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
4813462eea
GC at 1.9.X doesn't have malloc_allocated_size, remove support for it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
36f5d09692
removed support for 1.8's GC alternative hacks (railsbench and lloyd patches). RubyProf can handle it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
cb74cfc9c1
check if the data method is defined (meaning it's correctly patched)
2010-06-17 19:18:52 -07:00
Gonçalo Silva
901452d06a
the official profiler (present in 1.9) should have the highest priority
2010-06-17 19:18:52 -07:00
Gonçalo Silva
381a30fbba
don't set cpu_frequency if RubyProf resolved it
2010-06-17 19:18:52 -07:00
Aaron Patterson
5ae7a9d31d
when the timezone is nil, a TimeWithZone object should not be constructed. [ #4881 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-06-17 14:14:30 -07:00
Hongli Lai (Phusion)
6f5fb13928
Remove documentation reference to AS::Notifications::Event#result because it has been removed.
2010-06-17 15:47:37 +02:00
Xavier Noria
2aa4e5f3fa
pdoc tasks publishe APIs in api.rubyonrails.org
2010-06-16 22:39:13 +02:00
Xavier Noria
01f3f0dbae
use RDoc 2.2 to generate the documentation of individual components
2010-06-16 22:30:06 +02:00
Evgeniy Dolzhenko
ef404c771d
Fix a bunch of minor spelling mistakes
2010-06-15 12:04:22 +04:00
Xavier Noria
f17159b029
edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord"
2010-06-14 23:22:04 +02:00
Xavier Noria
94de5b8cb5
edit pass in #define_callbacks rdoc
2010-06-14 22:52:47 +02:00
Neeraj Singh
e4c8bc1b34
adding to the :kind documentation for ActiveSupport callbacks
2010-06-14 16:18:29 -04:00
Neeraj Singh
ed9a183ea4
clearer documentation of how scope applies to ActiveSupport callbacks
2010-06-14 15:48:09 -04:00
Xavier Noria
50df162a2b
explains why AS::OrderedHash does not leverage inheritance
2010-06-13 22:02:29 +02:00
Santiago Pastorino
b514b4d696
removes spurious .rb in require
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-13 13:56:08 +02:00
Santiago Pastorino
6d19a4a664
Change implementation to do it without asking each time for block_given?
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-13 07:27:26 +02:00
Xavier Noria
36143d26cb
revises implementation of AS::OrderedHash#merge!
2010-06-13 06:37:54 +02:00
Xavier Noria
3359af63a5
Revert "hash merging with a block ignores non-existing keys altogether"
...
This reverts commit 72f9fec607c4a72b2e88995d0cb32b16b96e9068.
It is wrong, this feature is a little undocumented, doing some research.
2010-06-13 05:53:42 +02:00
Xavier Noria
72f9fec607
hash merging with a block ignores non-existing keys altogether
2010-06-13 05:09:31 +02:00
Paul Barry
9183eaebed
re-organized test for merge into separate tests
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-13 04:19:35 +02:00
Paul Mucur
58e21a4a0d
Support passing a block to ActiveSupport::OrderedHash's merge and merge! [ #4838 state:committed]
...
For better consistency with Ruby's own Hash implementation.
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-13 04:19:35 +02:00
Santiago Pastorino
f802eb2f00
require conversions to use String#ord
2010-06-12 18:47:37 -07:00
Xavier Noria
f28d5cfbe6
registers 4146a44 in CHANGELOG
2010-06-12 22:16:57 +02:00
José Valim
1eecd9483b
No need to call convert_key before except.
2010-06-12 09:54:18 +02:00
José Valim
50ec0d9b2e
Simplify and optimize callbacks superclass sync.
2010-06-12 09:54:18 +02:00
Geoff Buesing
4146a443b6
Date#since, #ago, #beginning_of_day, #end_of_day, #xmlschema return TimeWithZone when Time.zone_default is set
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-12 00:19:12 +02:00
Jeremy Kemper
ed61c3b640
Remove String#constantize deps
2010-06-11 10:33:43 -07:00
Jeremy Kemper
cfc9439454
Explicitly delegate Chars#<=> to work around Kernel#<=> possibly ignoring method_missing
2010-06-11 10:03:23 -07:00
Evgeniy Dolzhenko
ccf9577aee
Fix a bunch of minor spelling mistakes
2010-06-11 14:15:34 +04:00
David Heinemeier Hansson
32d4330b81
Get ready for beta 4
2010-06-08 14:47:02 -04:00
wycats
6b49a71ab7
Missing require restored
2010-06-08 14:24:35 -04:00