Commit Graph

22391 Commits

Author SHA1 Message Date
David Heinemeier Hansson
8567ab9098 Need it declared too 2011-05-10 14:30:02 -05:00
David Heinemeier Hansson
de286206c3 Include lib/assets for sprocket paths 2011-05-10 14:23:18 -05:00
José Valim
1a844650a4 Merge pull request #498 from vatrai/minor_cleaning
minor cleaning with new api method all
2011-05-10 12:12:19 -07:00
Vishnu Atrai
9a0e3d44d1 minor cleaning with new api method 2011-05-11 00:15:16 +05:30
Aaron Patterson
558334a899 deprecating CSV fixture support 2011-05-10 11:08:18 -07:00
Aaron Patterson
714fea81e4 deprecating read_csv_fixture_files method 2011-05-10 11:08:18 -07:00
Piotr Sarnacki
2ea33d6b47 Merge pull request #490 from vijaydev/patch-4
Replace LH with GitHub url for filing issues
2011-05-10 10:58:12 -07:00
Piotr Sarnacki
9f0af6d6dd Merge pull request #495 from vatrai/minor_fixes
minor cleaning
2011-05-10 10:57:15 -07:00
Vishnu Atrai
33f0b6b67d minor cleaning 2011-05-10 22:51:54 +05:30
José Valim
8660433537 Merge pull request #494 from vijaydev/patch-5
Use all in place of find(:all)
2011-05-10 10:13:23 -07:00
Vijay Dev
e2390c08ce Use all in place of find(:all) 2011-05-10 10:08:31 -07:00
Aaron Patterson
134a05adcb Merge pull request #493 from guilleiguaran/changelog-fixes
Merging 3.0.x CHANGELOGs
2011-05-10 10:04:54 -07:00
Guillermo Iguaran
259c749de1 Merging 3.0.x CHANGELOGs 2011-05-10 11:51:35 -05:00
José Valim
ceaf73a503 Merge pull request #492 from jaw6/master
Serialized methods that return nil should not be considered YAML
2011-05-10 09:41:28 -07:00
Vijay Dev
8265c45db3 Replace LH with GitHub url for filing issues 2011-05-10 09:25:52 -07:00
David Heinemeier Hansson
4de977117f Update sprocket comments 2011-05-10 11:23:35 -05:00
Joshua Wehner
2cef2d411a Methods that return nil should not be considered YAML 2011-05-10 12:06:09 -04:00
Xavier Noria
8e55afb453 Merge pull request #487 from vijaydev/patch-3
s/javascript/JavaScript
2011-05-10 09:00:54 -07:00
Vijay Dev
c3c852c2d8 s/javascript/JavaScript 2011-05-10 08:51:50 -07:00
José Valim
3aa8f348ef Fix previous commit by allowing a proc to be given as response_body. This is deprecated and is going to be removed in future releases. 2011-05-10 16:53:57 +02:00
José Valim
4d5ce4738b Merge pull request #446 from danielstutzman/response_body_is_proc
New test: setting response_body to a Proc should be supported.
2011-05-10 07:38:43 -07:00
José Valim
fa8b0f44bd Merge pull request #484 from slainer68/master
Puts ActiveRecord::SessionStore attributes in white list, fixes #483
2011-05-10 07:23:26 -07:00
slainer68
95b4989559 Puts ActiveRecord::SessionStore attributes in white list, fixes #483 2011-05-10 16:11:28 +02:00
José Valim
8c05293b69 Merge pull request #482 from vijaydev/patch-2
Fix typos in IM documentation
2011-05-10 04:06:10 -07:00
Vijay Dev
a4765f74cd Fix typos in IM documentation 2011-05-10 03:44:57 -07:00
José Valim
302c912bf6 Document identity map inconsistency with associations, closes #474. 2011-05-10 11:33:39 +02:00
José Valim
5fc3564a50 Fix #480. Passing nil to create association works. 2011-05-10 11:18:16 +02:00
José Valim
0ceb21e335 Revert "b9ea751d0e56bd00d341766977a607ed3f7ddd0f".
Wrapping each Record.associations.build in a transaction is going to
make several unneeded queries. Reverting this commit also fixes #479.
2011-05-10 11:14:39 +02:00
José Valim
7c353d576a Add failing tests according to #479. 2011-05-10 11:11:30 +02:00
José Valim
b6a2113b8d Add failing tests, according to #480. 2011-05-10 11:02:34 +02:00
José Valim
9e4b715d79 Ensure assign_attributes and update_attributes do not fail on nil, closes #478. 2011-05-10 10:30:27 +02:00
José Valim
86a0f7f735 Add tests for content_for() for read, closes #475. 2011-05-10 10:22:09 +02:00
Vijay Dev
3f36441e90 Update copyright year in Active Resource and Active Support
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-05-09 20:17:23 -03:00
José Valim
0e1dcae185 Disable identity map by default. Detailed documentation will be pushed later. 2011-05-10 00:49:36 +02:00
Aaron Patterson
73ff6797ef use a null byte as a bind parameter substitute as it is not allowed in normal SQL. fixes #411, #417 2011-05-09 13:53:57 -07:00
José Valim
c56f4b272d Merge pull request #471 from joshk/remove_as_concern
Removed an unneed AS::Concern from AR::IdentityMap
2011-05-09 13:15:59 -07:00
Josh Kalderimis
d9f95c76a4 removed an unneed AS::Concern from AR::IdentityMap 2011-05-09 22:13:25 +02:00
José Valim
5b4849598a Merge pull request #461 from chrislwade/sorted-migrations
Sorted migrations
2011-05-09 09:54:04 -07:00
José Valim
59705deeaf Warn if we cannot verify CSRF token authenticity 2011-05-09 17:23:41 +02:00
José Valim
2750f2ee00 Fix failing test. 2011-05-09 17:08:59 +02:00
Mike Howard
372d72445b xml_mini.rb:_dasherize() replacement 20 to 25% faster
Signed-off-by: José Valim <jose.valim@gmail.com>
2011-05-09 17:06:56 +02:00
José Valim
851a4eab3c Oops, missing autoload, closes #466 2011-05-09 15:12:58 +02:00
José Valim
731923d79e Merge pull request #460 from guilleiguaran/patch-1
Just a minor fix in A.S CHANGELOG
2011-05-09 02:26:35 -07:00
José Valim
a9b72fbc9e Optimize the most common resolver case. 2011-05-09 11:17:24 +02:00
José Valim
4f03e404b2 No need for replace. 2011-05-09 10:42:54 +02:00
Christopher Wade
e585121539 Interleave db_list and file_list. 2011-05-09 01:46:35 -05:00
Christopher Wade
2952040f70 Sort migrations by the migration ID. 2011-05-09 01:45:45 -05:00
Guillermo Iguaran
1021b51b4f Just a minor fix in A.S CHANGELOG 2011-05-08 22:59:25 -07:00
Jon Leighton
72a4893452 Merge pull request #451 from baroquebobcat/fixing_last_for_issue_371 2011-05-08 23:43:34 +01:00
Nick Howard
92c10760d7 Fix for #371
if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior.

If the records were loaded, it returned the last record in the cached list.
If they were not, it reversed the order of the query and changed the limit to one.
If the earlier limit was less than the total matching the query in the db,
it would return a different record than if the records had been cached.

This commit changes find_last so that it loads the records when getting the
last record on a query containing a limit or an offset, which makes the behavior consistent.
2011-05-08 23:42:53 +01:00