hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge pull request #516 from Monits/issue-468

Browse Source 
[java] Fix issue 468
This commit is contained in:
Andreas Dangel
2017-07-26 20:21:43 +02:00
committed by GitHub
parent b4e799aaef f5c345bd0a
commit bad96d16d7
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/sunsecure/ArrayIsStoredDirectlyRule.java
View File

@ -131,7 +131,7 @@ public class ArrayIsStoredDirectlyRule extends AbstractSunSecureRule {
if (val == null) {
continue;
}
ASTPrimarySuffix foo = se.getFirstDescendantOfType(ASTPrimarySuffix.class);
ASTPrimarySuffix foo = e.getFirstDescendantOfType(ASTPrimarySuffix.class);
if (foo != null && foo.isArrayDereference()) {
continue;
}

17
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/sunsecure/xml/ArrayIsStoredDirectly.xml
View File

@ -175,6 +175,23 @@ public class NotificationPacket {
this.message = new String(rawTypeData, StandardCharsets.UTF_8);
}
}
}
]]></code>
</test-code>
<test-code>
<description>#468 False positive when qualifying with this</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
private final int[] a;
public Foo(int[] b) {
this.a = new int[b.length];
for (int i = 0; i < b.length; i++) {
this.a[i] = b[i];
}
}
}
]]></code>
</test-code>

2
src/site/markdown/overview/changelog.md
View File

@ -71,6 +71,8 @@ Based on those metrics, rules like "GodClass" detection can be implemented more
* [#487](https://github.com/pmd/pmd/pull/487): \[java] Fix typeresolution for anonymous extending object
* java-controversial
* [#408](https://github.com/pmd/pmd/issues/408): \[java] DFA not analyzing asserts
* java-sunsecure
* [#468](https://github.com/pmd/pmd/issues/468): \[java] ArrayIsStoredDirectly false positive
* java-unnecessarycode
* [#412](https://github.com/pmd/pmd/issues/412): \[java] java-unnecessarycode/UnnecessaryFinalModifier missing cases