hiifong/pmd
1
0 Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Use LanguageVersion.compareToVersion

Browse Source 
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
This commit is contained in:
Andreas DangelandClément Fournier committed 2021-07-16 09:58:17 +02:00
1 parent 690e50f198
commit e2864fa85a
1 file changed
+2 -6
Download Patch File Download Diff File Expand all files Collapse all files
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/BigIntegerInstantiationRule.java
+2 -6
View File
@@ -10,9 +10,7 @@ import java.util.Set;
import org.checkerframework.checker.nullness.qual.NonNull;
import net.sourceforge.pmd.lang.LanguageRegistry;
import net.sourceforge.pmd.lang.LanguageVersion;
import net.sourceforge.pmd.lang.java.JavaLanguageModule;
import net.sourceforge.pmd.lang.java.ast.ASTArgumentList;
import net.sourceforge.pmd.lang.java.ast.ASTConstructorCall;
import net.sourceforge.pmd.lang.java.ast.ASTExpression;
@@ -39,10 +37,8 @@ public class BigIntegerInstantiationRule extends AbstractJavaRulechainRule {
@Override
public Object visit(ASTConstructorCall node, Object data) {
LanguageVersion languageVersion = node.getAstInfo().getLanguageVersion();
boolean jdk15 = languageVersion
.compareTo(LanguageRegistry.getLanguage(JavaLanguageModule.NAME).getVersion("1.5")) >= 0;
boolean jdk9 = languageVersion
.compareTo(LanguageRegistry.getLanguage(JavaLanguageModule.NAME).getVersion("9")) >= 0;
boolean jdk15 = languageVersion.compareToVersion("1.5") >= 0;
boolean jdk9 = languageVersion.compareToVersion("9") >= 0;
if (TypeTestUtil.isA(BigInteger.class, node) || jdk15 && TypeTestUtil.isA(BigDecimal.class, node)) {