5407 Commits

Author SHA1 Message Date
Romain Pelisse
79a84939c5 Applying patch [ 1966013 ] Missing cases in UselessOperationOnImmutable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6197 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-13 20:36:32 +00:00
Ryan Gustafson
b287a5a73c Fixed bug 1989814 - false +: ConsecutiveLiteralAppends
If the definitive type of an AdditiveExpression is known to be other than a String, don't complain.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6186 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-10 20:58:24 +00:00
Ryan Gustafson
d9c6cb8b31 Fixed bug 1988829 - Violation reported without source file name (actually a fix to ConsecutiveLiteralAppends)
Allowed rootNode to be defaulted whenever 'concurrentCount' is more than 0.  This will allow a VariableDeclaration to be identified as the rootNode, even if it is never referenced later.  JUnit tests pass, I hope this doesn't have unintended consequences.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6184 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-10 05:56:05 +00:00
Ryan Gustafson
791e3f10e4 Additional fixing to get exclude-pattern to work with multiple RuleSets.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6178 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-04 05:04:43 +00:00
Ryan Gustafson
8534a438a6 Update RuleChainVisitor to group rules by RuleSet, and use RuleSet.applies(File) before visiting.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6170 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-03 17:22:48 +00:00
Xavier Le Vourch
185958c419 Fixes for exclude-pattern
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6169 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-30 22:00:19 +00:00
Ryan Gustafson
123fc5f64f Update RuleSet writing documentation to mention <exclude-pattern>/<include-pattern>.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6161 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-28 19:28:21 +00:00
Xavier Le Vourch
eed1a59034 cenqua link fixed and logo added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6159 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-27 21:52:20 +00:00
Xavier Le Vourch
2ab3bd3ac6 cleanup of pmd-test-<version>.jar build
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6150 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-23 23:07:47 +00:00
Romain Pelisse
bf5c221439 Adding back the excludes lines. The classes were excludes
as they are part of the pmd.jar.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6145 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-23 09:09:28 +00:00
Romain Pelisse
f84db1bffc Adding the generation of pmd-test.jar to the target 'jar'.
It's a quick fix.

Also note that i removed the following line from the jar 
creation:
excludes="test/net/sourceforge/pmd/testframework/**/**" 
this lead to exclude the testframework itself, which lead
to a pretty useless jar.

I didn't remove the pmd-test jar creation from the 
retroweaver task neither remove this exclusion. Retro
Weaver part of the build is still not working on my 
laptop, so i didn't want to alter without the capability
to test my modifications.

I modify the 4.2.3 first because of this. This way, if we have to
release a 4.2.3 before 5.0, the pmd-test.jar should be
in it.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6139 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-22 15:46:43 +00:00
Xavier Le Vourch
0043392460 version updated to 4.2.3-SNAPSHOT
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6137 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 19:56:32 +00:00
Xavier Le Vourch
99a31e423a updates for uploading 4.2.2
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6136 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 19:47:11 +00:00
Xavier Le Vourch
823d3447c8 preparing for 4.2.2 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6134 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 18:27:25 +00:00
Ryan Gustafson
68ff19de08 Reverse chronological order for releases, and change 'pmd' to 'PMD'.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6133 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:13:06 +00:00
Xavier Le Vourch
55218c6196 front page updated to include recent releases and short roadmap
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6130 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:05:02 +00:00
Xavier Le Vourch
ab934c2a9b link to article by Alan Berg
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6129 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:04:01 +00:00
Xavier Le Vourch
cd2745d5fe maven 1 pmd plugin page links to maven 2 plugin
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6128 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:02:35 +00:00
Xavier Le Vourch
f9590d218a UnnecessaryParentheses now checks all expressions, not just return statements
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6126 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-19 03:15:40 +00:00
Xavier Le Vourch
cfde99a990 Documentation of AvoidDuplicateLiterals properties
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6117 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-16 00:39:26 +00:00
Xavier Le Vourch
d2429a95cc copy/paste error in MoreThanOneLogger
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6075 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-28 18:46:14 +00:00
Xavier Le Vourch
713dc2a9a5 Bug fix: NPE in MoreThanOneLogger
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6073 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-28 18:34:24 +00:00
Xavier Le Vourch
411cf2826f Fixed parsing bug: constant fields in annotation classes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6071 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-27 23:47:59 +00:00
Xavier Le Vourch
99348a8582 Fixed false positive in UnusedImports: javadoc comments are parsed to check @see and other tags
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6023 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-16 23:34:30 +00:00
Xavier Le Vourch
33bcfed90f version changed to 4.2.2-SNAPSHOT in Java and 4.2.2 in other files
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6020 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-16 21:52:03 +00:00
Xavier Le Vourch
cdb5525716 Fixed false positive in UnusedImports: javadoc comments are parsed to check @see and other tags
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6018 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-16 21:18:35 +00:00
Xavier Le Vourch
d157b08bee 4.2.1 links updated
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6011 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-11 22:05:10 +00:00
Xavier Le Vourch
dc353cb718 preparing 4.2.1 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6007 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-11 21:25:11 +00:00
Romain Pelisse
adfd316184 Fixed bug 1808110 - PreserveStackTrace
(backport from trunk)

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6006 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-11 17:47:30 +00:00
Xavier Le Vourch
2f4cdbd6c3 backport of: AvoidDuplicateLiteralRule now has 'skipAnnotations' boolean property
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6004 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-11 16:41:42 +00:00
Xavier Le Vourch
bbad2dfbc2 preparing 4.2.1 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6001 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-09 19:34:58 +00:00
Xavier Le Vourch
ce49bdd986 Added file encoding option to CPD GUI, which already existed for the command line and Ant
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6000 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-09 16:00:10 +00:00
Ryan Gustafson
d61aa6189f Remove unintentionally copied line.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5997 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-09 01:07:23 +00:00
Xavier Le Vourch
1593b8037d bin scripts: cygwin-run.sh removed, only cpd, designer and pmd scripts should be in binary release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5996 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-09 00:05:21 +00:00
Xavier Le Vourch
e659268f29 standard unix scripts can be used with cygwin
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5995 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-08 23:55:58 +00:00
Xavier Le Vourch
e4fa5f88fe support for extra languages in cpd.sh
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5994 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-08 23:44:19 +00:00
Xavier Le Vourch
84cad6c1c4 retroweaver version was not correct in java14/bin scripts
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5993 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-08 23:34:59 +00:00
Ryan Gustafson
7a3d8ceb9a Update RuleSetWriter to handle non-Apache TRAX implementations, add an option to not use XML Namespaces
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5992 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-08 23:21:45 +00:00
Xavier Le Vourch
159cbfa9e9 ruleset.dtd and ruleset_xml_schema.xsd added to jar file in rulesets directory
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5990 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-08 21:58:07 +00:00
Xavier Le Vourch
89b1d699bf Fixed classpath issue in pmdOnPmd target
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5983 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-07 01:31:58 +00:00
Xavier Le Vourch
76a293d720 Fixed classpath issue in pmd target
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5981 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-07 01:17:05 +00:00
Romain Pelisse
4378fd6bdf Fixed bug 1932242 - EmptyMethodInAbstractClassShouldBeAbstract false +
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5952 51baf565-9d33-0410-a72c-fc3788e3496d
2008-04-02 16:47:36 +00:00
Ryan Gustafson
4d127404d3 Fix bug 1928009 - Error using migration ruleset in PMD 4.2
AbstractRuleChainVisitor changed an 'if' to a 'while' to ensure all RuleReferences were followed to find the real underlying Rule.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5942 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-28 22:45:43 +00:00
Xavier Le Vourch
e84d41bebb '41' and '42' shortcuts for rulesets added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5933 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-26 21:31:19 +00:00
Xavier Le Vourch
8e193d6f2c preparing for the 4.2 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5926 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-26 00:43:37 +00:00
Romain Pelisse
1bd08483ad Adding missing license header here and there.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5925 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-24 03:40:43 +00:00
Romain Pelisse
36864eace5 Fix mvn2 build
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5924 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-24 01:37:15 +00:00
Tom Copeland
6b90caa59f Fixed licenses, these were files that I missed when PMD went to BSD several years ago.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5923 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-23 19:18:17 +00:00
Xavier Le Vourch
cceb12bbd7 invalid rule urls corrected
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5922 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-23 16:56:09 +00:00
Romain Pelisse
b23d90ce08 Removing this rule. It's not ready and not for 4.2.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5921 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-23 11:15:02 +00:00