Xavier Le Vourch
b3d2a856a8
changes for 4.2.3 release
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6428 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 20:30:45 +00:00
Xavier Le Vourch
59a61fb58c
4.2.3 description on web site
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6427 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 20:05:06 +00:00
Xavier Le Vourch
7e018ac3bd
extra quote removed
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6426 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 19:51:21 +00:00
Xavier Le Vourch
d4e6c1872d
preparing 4.2.3 release
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6424 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 19:26:42 +00:00
Xavier Le Vourch
767cea113d
merge from trunk:
...
Fixed handling of escape characters in UseIndexOfChar and AppendCharacterWithChar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6422 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 20:27:04 +00:00
Xavier Le Vourch
5f2d71cdde
Fixed bug 1556594 - Wonky detection of NullAssignment
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6418 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 01:56:07 +00:00
Xavier Le Vourch
263b91d556
Fixed bug 2050064 - False + SuspiciousOctalEscape with backslash literal
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6415 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 01:04:34 +00:00
Xavier Le Vourch
94cfdb93fd
Fixed bug 1977438 - False positive for UselessStringValueOf
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6414 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 00:16:23 +00:00
Xavier Le Vourch
91ad44ba0a
Fixed false negative in UselessOverridingMethod
...
using < 0 instead of > 0 in getting argument list size. Maybe we should have a rule to detect this...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6408 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-26 19:19:14 +00:00
Xavier Le Vourch
2141dba366
code cleanup: unused import
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6400 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-25 19:41:26 +00:00
Xavier Le Vourch
d700a3ea11
All comment types are now stored in ASTCompilationUnit, not just formal ones
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6398 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-25 19:36:11 +00:00
Xavier Le Vourch
7a6f82b222
javacc.jar added to lib directory to get reproduceable builds
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6391 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-25 00:54:30 +00:00
Ryan Gustafson
1da7b889b7
Added credit for Jared's patch.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6386 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-24 06:09:43 +00:00
Ryan Gustafson
8b9942436d
Java grammar enhanced to include AnnotationMethodDeclaration as parent node of method related children of AnnotationTypeMemberDeclaration.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6385 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-24 06:01:18 +00:00
Ryan Gustafson
3d0d4436de
JavaCC generated artifacts updated to JavaCC 4.1d1.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6384 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-24 05:16:45 +00:00
Xavier Le Vourch
5620b24c8f
Fixed bug 2056318 - False positive for AvoidInstantiatingObjectsInLoops
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6370 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-19 22:18:34 +00:00
Ryan Gustafson
8a0052dee9
Added YourKit Java Profiler logo to Credits.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6369 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-15 13:34:31 +00:00
Ryan Gustafson
80e5944dcd
Add requested credit for YourKit, for use of licenses.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6341 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-08 13:00:36 +00:00
Xavier Le Vourch
169ab5d225
Fixed bug 2002722 - false + in UseStringBufferForStringAppends
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6334 51baf565-9d33-0410-a72c-fc3788e3496d
2008-07-22 17:54:45 +00:00
Xavier Le Vourch
d1e9279f3a
merging updates from the trunk
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6332 51baf565-9d33-0410-a72c-fc3788e3496d
2008-07-18 16:47:44 +00:00
Xavier Le Vourch
244c79ecb0
merge from trunk:
...
testTSM() disabled in regress mode:
because of random failures during continuous integration,
tests are disabled in regress mode until somebody figures out
what the tests are supposed to measure and why they sometime fail
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6312 51baf565-9d33-0410-a72c-fc3788e3496d
2008-07-01 20:45:01 +00:00
Xavier Le Vourch
10bc1bab17
Adding top level build.xml to have a more standard setup and ease continuous
...
integration configuration
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6311 51baf565-9d33-0410-a72c-fc3788e3496d
2008-07-01 20:37:21 +00:00
Xavier Le Vourch
1b59db43f3
merge from trunk: Looks like the Ant task doesn't take 'debug' anymore
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6310 51baf565-9d33-0410-a72c-fc3788e3496d
2008-07-01 16:39:45 +00:00
Romain Pelisse
18e444b448
Oups, i forgot to remove attribute language and to change xpath class back
...
to net.sourceforge.pmd.rules.XPathRule.
Corrected (thanks again to Ryan for this report).
By the way, it seems that the continous integration process is not set to
yell at us if we broke the build on the pmd-4.2.x branch.
If this is not too much work, it surely be nice to have.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6267 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-24 16:27:26 +00:00
Romain Pelisse
be028ccaef
Adding a proper example to TooFewBranchesForASwitchStatement
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6266 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-24 12:03:34 +00:00
Xavier Le Vourch
4583fde181
fix false positives in UselessOperationOnImmutable
...
false positives included string were used in expressions and BigInteger
as method arguments. The immutable object is ignored only if expression's
parent is a statement expression.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6237 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-20 19:58:54 +00:00
Xavier Le Vourch
a0b8ff4c4a
SuppressWarning fixes:
...
Fixed bug 1998185 - BeanMembersShouldSerialize vs @SuppressWarnings("serial")
@SuppressWarnings("all") disables all warnings
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6236 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-19 21:47:07 +00:00
Xavier Le Vourch
9ce5a5be43
Optimizations and false positive fixes in PreserveStackTrace
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6232 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-19 03:50:50 +00:00
Xavier Le Vourch
d951795634
Fixed bug 1977230 - false positive: UselessOverridingMethod
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6205 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-14 00:37:10 +00:00
Romain Pelisse
f663b9773a
Applying patch [ 1958961 ] EmptyInitializer
...
Not really bug fix, but the patch was easy to apply so, why deprive soon to be 4.2.X user from this little addon...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6201 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-13 22:07:56 +00:00
Romain Pelisse
79a84939c5
Applying patch [ 1966013 ] Missing cases in UselessOperationOnImmutable
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6197 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-13 20:36:32 +00:00
Ryan Gustafson
b287a5a73c
Fixed bug 1989814 - false +: ConsecutiveLiteralAppends
...
If the definitive type of an AdditiveExpression is known to be other than a String, don't complain.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6186 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-10 20:58:24 +00:00
Ryan Gustafson
d9c6cb8b31
Fixed bug 1988829 - Violation reported without source file name (actually a fix to ConsecutiveLiteralAppends)
...
Allowed rootNode to be defaulted whenever 'concurrentCount' is more than 0. This will allow a VariableDeclaration to be identified as the rootNode, even if it is never referenced later. JUnit tests pass, I hope this doesn't have unintended consequences.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6184 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-10 05:56:05 +00:00
Ryan Gustafson
791e3f10e4
Additional fixing to get exclude-pattern to work with multiple RuleSets.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6178 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-04 05:04:43 +00:00
Ryan Gustafson
8534a438a6
Update RuleChainVisitor to group rules by RuleSet, and use RuleSet.applies(File) before visiting.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6170 51baf565-9d33-0410-a72c-fc3788e3496d
2008-06-03 17:22:48 +00:00
Xavier Le Vourch
185958c419
Fixes for exclude-pattern
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6169 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-30 22:00:19 +00:00
Ryan Gustafson
123fc5f64f
Update RuleSet writing documentation to mention <exclude-pattern>/<include-pattern>.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6161 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-28 19:28:21 +00:00
Xavier Le Vourch
eed1a59034
cenqua link fixed and logo added
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6159 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-27 21:52:20 +00:00
Xavier Le Vourch
2ab3bd3ac6
cleanup of pmd-test-<version>.jar build
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6150 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-23 23:07:47 +00:00
Romain Pelisse
bf5c221439
Adding back the excludes lines. The classes were excludes
...
as they are part of the pmd.jar.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6145 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-23 09:09:28 +00:00
Romain Pelisse
f84db1bffc
Adding the generation of pmd-test.jar to the target 'jar'.
...
It's a quick fix.
Also note that i removed the following line from the jar
creation:
excludes="test/net/sourceforge/pmd/testframework/**/**"
this lead to exclude the testframework itself, which lead
to a pretty useless jar.
I didn't remove the pmd-test jar creation from the
retroweaver task neither remove this exclusion. Retro
Weaver part of the build is still not working on my
laptop, so i didn't want to alter without the capability
to test my modifications.
I modify the 4.2.3 first because of this. This way, if we have to
release a 4.2.3 before 5.0, the pmd-test.jar should be
in it.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6139 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-22 15:46:43 +00:00
Xavier Le Vourch
0043392460
version updated to 4.2.3-SNAPSHOT
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6137 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 19:56:32 +00:00
Xavier Le Vourch
99a31e423a
updates for uploading 4.2.2
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6136 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 19:47:11 +00:00
Xavier Le Vourch
823d3447c8
preparing for 4.2.2 release
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6134 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 18:27:25 +00:00
Ryan Gustafson
68ff19de08
Reverse chronological order for releases, and change 'pmd' to 'PMD'.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6133 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:13:06 +00:00
Xavier Le Vourch
55218c6196
front page updated to include recent releases and short roadmap
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6130 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:05:02 +00:00
Xavier Le Vourch
ab934c2a9b
link to article by Alan Berg
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6129 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:04:01 +00:00
Xavier Le Vourch
cd2745d5fe
maven 1 pmd plugin page links to maven 2 plugin
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6128 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-20 17:02:35 +00:00
Xavier Le Vourch
f9590d218a
UnnecessaryParentheses now checks all expressions, not just return statements
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6126 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-19 03:15:40 +00:00
Xavier Le Vourch
cfde99a990
Documentation of AvoidDuplicateLiterals properties
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6117 51baf565-9d33-0410-a72c-fc3788e3496d
2008-05-16 00:39:26 +00:00