ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

VPP-874: fix coverity warnings in tw_timer_template.c

Browse Source 
Best guess, tested carefully, should do no harm. Clang doesn't
complain either way; it's not certain that this patch will make the
coverity warnings in tw_timer_template.c disappear.

Change-Id: I75aa0cfd8970751e823a1165df2a755e947c4cf9
Signed-off-by: Dave Barach <dave@barachs.net>
This commit is contained in:
Dave Barach
2017-06-13 17:04:28 -04:00
committed by Chris Luke
parent 6f7ebf900e
commit 28b70af8e5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/vppinfra/tw_timer_template.c
View File

@ -132,13 +132,13 @@ TW (tw_timer_start) (TWT (tw_timer_wheel) * tw, u32 pool_index, u32 timer_id,
#endif
glacier_ring_offset = interval >> (2 * TW_RING_SHIFT);
ASSERT (glacier_ring_offset < TW_SLOTS_PER_RING);
interval -= (glacier_ring_offset << (2 * TW_RING_SHIFT));
ASSERT ((u64) glacier_ring_offset < TW_SLOTS_PER_RING);
interval -= (((u64) glacier_ring_offset) << (2 * TW_RING_SHIFT));
#endif
#if TW_TIMER_WHEELS > 1
slow_ring_offset = interval >> TW_RING_SHIFT;
ASSERT (slow_ring_offset < TW_SLOTS_PER_RING);
interval -= (slow_ring_offset << TW_RING_SHIFT);
ASSERT ((u64) slow_ring_offset < TW_SLOTS_PER_RING);
interval -= (((u64) slow_ring_offset) << TW_RING_SHIFT);
#endif
fast_ring_offset = interval & TW_RING_MASK;