ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tls: fix memory leak when client/server init error

Browse Source 
Type: fix
Signed-off-by: Xiaoming Jiang <jiangxiaoming@outlook.com>
Change-Id: I484f3759b6c27052e08741398ec389729285f035
This commit is contained in:
Xiaoming Jiang
2023-05-26 00:32:25 +00:00
parent d921b89880
commit 4778164869
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/vnet/tls/tls.c
View File

@ -463,6 +463,7 @@ tls_session_accept_callback (session_t * tls_session)
session_t *tls_listener, *app_session;
tls_ctx_t *lctx, *ctx;
u32 ctx_handle;
int rv;
tls_listener =
listen_session_get_from_handle (tls_session->listener_handle);
@ -489,7 +490,14 @@ tls_session_accept_callback (session_t * tls_session)
TLS_DBG (1, "Accept on listener %u new connection [%u]%x",
tls_listener->opaque, vlib_get_thread_index (), ctx_handle);
return tls_ctx_init_server (ctx);
rv = tls_ctx_init_server (ctx);
if (rv)
{
session_free (app_session);
tls_ctx_free (ctx);
}
return rv;
}
int
@ -530,6 +538,7 @@ tls_session_connected_cb (u32 tls_app_index, u32 ho_ctx_index,
tls_ctx_t *ho_ctx, *ctx;
session_type_t st;
u32 ctx_handle;
int rv;
ho_ctx = tls_ctx_half_open_get (ho_ctx_index);
@ -559,7 +568,14 @@ tls_session_connected_cb (u32 tls_app_index, u32 ho_ctx_index,
app_session->session_type = st;
app_session->connection_index = ctx->tls_ctx_handle;
return tls_ctx_init_client (ctx);
rv = tls_ctx_init_client (ctx);
if (rv)
{
session_free (app_session);
tls_ctx_free (ctx);
}
return rv;
}
int