ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Coverity issue in trace_util.c (REVERSE_INULL), thanks to Damjan for highlighting this.

Browse Source 
Change-Id: I22b1dc800624042e043e7632179f6281a6ccaafc
Signed-off-by: Vengada Govindan <venggovi@cisco.com>
This commit is contained in:
Vengada Govindan
2016-09-07 22:19:36 -07:00
parent 3b480933c8
commit 7a35ee91a4
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/ioam-plugin/ioam/lib-trace/trace_util.c
View File

@ -173,8 +173,13 @@ show_trace_profile_command_fn (vlib_main_t * vm,
trace_profile *p = NULL;
u8 *s = 0;
p = trace_profile_find ();
if (p->valid == 0)
return 0;
if (!(p && p->valid))
{
s = format (s, "\nTrace configuration not valid\n");
vlib_cli_output (vm, "%v", s);
vec_free (s);
return 0;
}
s = format (s, " HOP BY HOP OPTIONS - TRACE CONFIG - \n");
s = format (s, " Trace Type : 0x%x (%d)\n",
p->trace_type, p->trace_type);
@ -196,10 +201,6 @@ show_trace_profile_command_fn (vlib_main_t * vm,
s =
format (s, " App Data : 0x%x (%d)\n",
p->app_data, p->app_data);
if (!(p && p->valid))
{
s = format (s, "\nTrace configuration not valid\n");
}
vlib_cli_output (vm, "%v", s);
vec_free (s);
return 0;