misc: replace index() with strchr()
Type: improvement Change-Id: I471e514ebef0b4c1f86067115b2ebe5a5517c6fb Signed-off-by: Matus Fabian <matfabia@cisco.com>
This commit is contained in:

committed by
Florin Coras

parent
7561c45bcc
commit
7f163b682a
@ -436,7 +436,7 @@ svmdb_local_serialize_strings (svmdb_client_t * client, char *filename)
|
||||
u8 *sanitized_name = 0;
|
||||
int fd = 0;
|
||||
|
||||
if (strstr (filename, "..") || index (filename, '/'))
|
||||
if (strstr (filename, "..") || strchr (filename, '/'))
|
||||
{
|
||||
error = clib_error_return (0, "Illegal characters in filename '%s'",
|
||||
filename);
|
||||
|
@ -2151,7 +2151,7 @@ elog_save (vat_main_t * vam)
|
||||
}
|
||||
|
||||
/* It's fairly hard to get "../oopsie" through unformat; just in case */
|
||||
if (strstr (file, "..") || index (file, '/'))
|
||||
if (strstr (file, "..") || strchr (file, '/'))
|
||||
{
|
||||
errmsg ("illegal characters in filename '%s'", file);
|
||||
return 0;
|
||||
|
@ -198,7 +198,7 @@ unformat_vlib_tmpfile (unformat_input_t * input, va_list * args)
|
||||
return 0;
|
||||
|
||||
/* Brain-police user path input */
|
||||
if (strstr ((char *) filename, "..") || index ((char *) filename, '/'))
|
||||
if (strstr ((char *) filename, "..") || strchr ((char *) filename, '/'))
|
||||
{
|
||||
vec_free (filename);
|
||||
return 0;
|
||||
|
@ -655,7 +655,7 @@ elog_save_buffer (vlib_main_t * vm,
|
||||
}
|
||||
|
||||
/* It's fairly hard to get "../oopsie" through unformat; just in case */
|
||||
if (strstr (file, "..") || index (file, '/'))
|
||||
if (strstr (file, "..") || strchr (file, '/'))
|
||||
{
|
||||
vlib_cli_output (vm, "illegal characters in filename '%s'", file);
|
||||
return 0;
|
||||
|
Reference in New Issue
Block a user