string_test: coverity woe

Remove the needless tests and checks which coverity complains about in
string_test.c

Change-Id: I971650cada77136f06528a65625ef99bd3d7e915
Signed-off-by: Steven <sluong@cisco.com>
This commit is contained in:
Steven
2019-01-06 11:23:24 -08:00
committed by Dave Barach
parent 754f24b359
commit 98311da8b4

View File

@ -349,10 +349,6 @@ test_clib_strcmp (vlib_main_t * vm, unformat_input_t * input)
/* Null pointers comparison */
s = 0;
indicator = clib_strcmp (s, s);
if (indicator != 0)
return -1;
/* verify it against strcmp */
indicator = strcmp (s, s);
if (indicator != 0)
return -1;
@ -518,8 +514,6 @@ test_clib_strncmp (vlib_main_t * vm, unformat_input_t * input)
sizeof ("Every moment is a fresh beginning") - 1);
if (v_indicator != 0)
return -1;
if (v_indicator != indicator)
return -1;
/* OK, seems to work */
return 0;