ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

acl-plugin: vat: acl_interface_list_dump confusing/incorrect output in case n_input == 0

Browse Source 
The logic to print the line " output " is wrong for the case of n_input == 0,
and the applied ACLs are printed as if they were applied on input.
One may still figure out the truth by looking at the n_input value above,
but it is confusing.

Change-Id: I7b4a4d548e569994678dd1e139eb829456548b88
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
This commit is contained in:
Andrew Yourtchenko
2017-06-20 14:40:44 +02:00
committed by Ole Trøan
parent 284293a3ff
commit b736dc1876
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/acl/acl_test.c
View File

@ -144,9 +144,9 @@ static void vl_api_acl_interface_list_details_t_handler
out = format(out, "sw_if_index: %d, count: %d, n_input: %d\n", mp->sw_if_index, mp->count, mp->n_input);
out = format(out, " input ");
for(i=0; i<mp->count; i++) {
out = format(out, "%d ", ntohl (mp->acls[i]));
if (i == mp->n_input-1)
if (i == mp->n_input)
out = format(out, "\n output ");
out = format(out, "%d ", ntohl (mp->acls[i]));
}
out = format(out, "\n");
clib_warning("%s", out);