ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vcl: fix coverity warnings

Browse Source 
Change-Id: I24445b08a46041c370094ebba4243422e2342a26
Signed-off-by: Florin Coras <fcoras@cisco.com>
This commit is contained in:
Florin Coras
2018-12-21 19:28:34 -08:00
committed by Damjan Marion
parent 54ddf43533
commit c227e4950d
3 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/vcl/sock_test_client.c
View File

@ -648,7 +648,14 @@ sock_test_connect_test_sockets (uint32_t num_test_sockets)
errno_val);
return tsock->fd;
}
fcntl (tsock->fd, F_SETFL, O_NONBLOCK);
if (fcntl (tsock->fd, F_SETFL, O_NONBLOCK) < 0)
{
errno_val = errno;
perror ("ERROR in sock_test_connect_test_sockets()");
fprintf (stderr, "CLIENT: ERROR: fcntl failed (errno = %d)!\n",
errno_val);
return -1;
}
#ifdef VCL_TEST
rv = vppcom_session_connect (tsock->fd, &scm->server_endpt);

9
src/vcl/sock_test_server.c
View File

@ -653,7 +653,14 @@ main (int argc, char **argv)
errno_val);
return rv;
}
fcntl (ssm->listen_fd, F_SETFL, O_NONBLOCK);
if (fcntl (ssm->listen_fd, F_SETFL, O_NONBLOCK) < 0)
{
errno_val = errno;
perror ("ERROR in main()");
fprintf (stderr, "SERVER: ERROR: fcntl failed (errno = %d)!\n",
errno_val);
return rv;
}
#ifdef VCL_TEST
rv = vppcom_session_listen (ssm->listen_fd, 10);

6
src/vcl/vppcom.c
View File

@ -795,7 +795,11 @@ vcl_intercept_sigchld_handler (int signum, siginfo_t * si, void *uc)
if (vcl_get_worker_index () == ~0)
return;
sigaction (SIGCHLD, &old_sa, 0);
if (sigaction (SIGCHLD, &old_sa, 0))
{
VERR ("couldn't restore sigchld");
exit (-1);
}
wrk = vcl_worker_get_current ();
if (wrk->forked_child == ~0)