ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pnat: coverity fixes

Browse Source 
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia1cfdbd39ed458cb3fffd29a8b6d6eff64644de8
This commit is contained in:
Ole Troan
2021-03-09 09:25:33 +01:00
committed by Neale Ranns
parent b0c2ec5e7c
commit d01caf7fa2
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
MAINTAINERS
View File

@ -389,6 +389,11 @@ M: Filip Varga <fivarga@cisco.com>
M: Klement Sekera <ksekera@cisco.com>
F: src/plugins/nat/
Plugin - PNAT Static match and rewrite engine
I: pnat
M: Ole Troan <ot@cisco.com>
F: src/plugins/nat/pnat/
Plugin - AVF Device driver
I: avf
M: Damjan Marion <damarion@cisco.com>

6
src/plugins/nat/pnat/pnat.c
View File

@ -148,13 +148,15 @@ static int pnat_disable_interface(u32 sw_if_index,
return 0;
if (interface->enabled[attachment] && attachment == PNAT_IP4_INPUT) {
ip4_sv_reass_enable_disable_with_refcnt(sw_if_index, 0);
if (ip4_sv_reass_enable_disable_with_refcnt(sw_if_index, 0) != 0)
return -1;
if (vnet_feature_enable_disable("ip4-unicast", "pnat-input",
sw_if_index, 0, 0, 0) != 0)
return -1;
}
if (interface->enabled[attachment] && attachment == PNAT_IP4_OUTPUT) {
ip4_sv_reass_output_enable_disable_with_refcnt(sw_if_index, 0);
if (ip4_sv_reass_output_enable_disable_with_refcnt(sw_if_index, 0) != 0)
return -1;
if (vnet_feature_enable_disable("ip4-output", "pnat-output",
sw_if_index, 0, 0, 0) != 0)
return -1;

2
src/plugins/nat/pnat/pnat_api.c
View File

@ -145,7 +145,7 @@ static void send_interfaces_details(u32 index, vl_api_registration_t *rp,
rmp->sw_if_index = i->sw_if_index;
clib_memcpy(rmp->enabled, i->enabled, PNAT_ATTACHMENT_POINT_MAX);
clib_memcpy(rmp->lookup_mask, i->lookup_mask,
sizeof(i->lookup_mask) * PNAT_ATTACHMENT_POINT_MAX);
sizeof(vl_api_pnat_mask_t) * PNAT_ATTACHMENT_POINT_MAX);
/* Endian hack until apigen registers _details
* endian functions */