tests: replace pycodestyle with black

Drop pycodestyle for code style checking in favor of black. Black is
much faster, stable PEP8 compliant code style checker offering also
automatic formatting. It aims to be very stable and produce smallest
diffs. It's used by many small and big projects.

Running checkstyle with black takes a few seconds with a terse output.
Thus, test-checkstyle-diff is no longer necessary.

Expand scope of checkstyle to all python files in the repo, replacing
test-checkstyle with checkstyle-python.

Also, fixstyle-python is now available for automatic style formatting.

Note: python virtualenv has been consolidated in test/Makefile,
test/requirements*.txt which will eventually be moved to a central
location.  This is required to simply the automated generation of
docker executor images in the CI.

Type: improvement
Change-Id: I022a326603485f58585e879ac0f697fceefbc9c8
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
This commit is contained in:
Klement Sekera
2022-04-26 19:02:15 +02:00
committed by Ole Tr�an
parent f90348bcb4
commit d9b0c6fbf7
268 changed files with 46750 additions and 35224 deletions

View File

@ -12,7 +12,7 @@ from util import Host, ppp
class TestL2LearnLimit(VppTestCase):
""" L2 Learn no limit Test Case """
"""L2 Learn no limit Test Case"""
@classmethod
def setUpClass(self):
@ -35,11 +35,15 @@ class TestL2LearnLimit(VppTestCase):
hosts = dict()
swif = pg_if.sw_if_index
def mac(j): return "00:00:%02x:ff:%02x:%02x" % (subnet, swif, j)
def mac(j):
return "00:00:%02x:ff:%02x:%02x" % (subnet, swif, j)
def ip(j): return "172.%02u.1%02x.%u" % (subnet, swif, j)
def ip(j):
return "172.%02u.1%02x.%u" % (subnet, swif, j)
def h(j):
return Host(mac(j), ip(j))
def h(j): return Host(mac(j), ip(j))
hosts[swif] = [h(j) for j in range(n_hosts_per_if)]
return hosts
@ -56,15 +60,13 @@ class TestL2LearnLimit(VppTestCase):
self.vapi.bridge_flags(bd_id=bd_id, is_set=1, flags=1)
swif = pg_if.sw_if_index
packets = [Ether(dst="ff:ff:ff:ff:ff:ff", src=host.mac)
for host in hosts[swif]]
packets = [Ether(dst="ff:ff:ff:ff:ff:ff", src=host.mac) for host in hosts[swif]]
pg_if.add_stream(packets)
self.logger.info("Sending broadcast eth frames for MAC learning")
self.pg_start()
def test_l2bd_learnlimit(self):
""" L2BD test without learn Limit
"""
"""L2BD test without learn Limit"""
hosts = self.create_hosts(self.pg_interfaces[0], 20, 1)
self.learn_hosts(self.pg_interfaces[0], 1, hosts)
lfs = self.vapi.l2_fib_table_dump(1)
@ -78,22 +80,20 @@ class TestL2LearnLimit(VppTestCase):
self.vapi.bridge_domain_add_del(bd_id=1)
self.vapi.bridge_domain_add_del(bd_id=2)
self.vapi.sw_interface_set_l2_bridge(
self.pg_interfaces[0].sw_if_index, bd_id=1)
self.vapi.sw_interface_set_l2_bridge(
self.pg_interfaces[1].sw_if_index, bd_id=2)
self.vapi.sw_interface_set_l2_bridge(self.pg_interfaces[0].sw_if_index, bd_id=1)
self.vapi.sw_interface_set_l2_bridge(self.pg_interfaces[1].sw_if_index, bd_id=2)
def tearDown(self):
super(TestL2LearnLimit, self).tearDown()
self.vapi.sw_interface_set_l2_bridge(
rx_sw_if_index=self.pg_interfaces[0].sw_if_index,
bd_id=1, enable=0)
rx_sw_if_index=self.pg_interfaces[0].sw_if_index, bd_id=1, enable=0
)
self.vapi.sw_interface_set_l2_bridge(
rx_sw_if_index=self.pg_interfaces[1].sw_if_index,
bd_id=2, enable=0)
rx_sw_if_index=self.pg_interfaces[1].sw_if_index, bd_id=2, enable=0
)
self.vapi.bridge_domain_add_del(bd_id=1, is_add=0)
self.vapi.bridge_domain_add_del(bd_id=2, is_add=0)
if __name__ == '__main__':
if __name__ == "__main__":
unittest.main(testRunner=VppTestRunner)