ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tls: memory leak due to missing call to vnet_crypto_key_del

Browse Source 
We add the crypto key to the vnet crypto library via vnet_crypto_key_add.
However, when the session is disconnected, we don't call
vnet_crypto_key_del and the memory is leaked in vnet_crypto library
as well as in pico tls key store.

It seems dispose crypto is the appropriate place to add
vnet_crypto_key_del.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: If6d1266baf686fefe5bb81330ce60b35c8ff574e
This commit is contained in:
Steven Luong
2022-11-18 14:17:42 -08:00
parent fe2d23f916
commit dfd169816e
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/tlspicotls/pico_vpp_crypto.c
View File

@ -197,7 +197,12 @@ ptls_vpp_crypto_aead_encrypt_final (ptls_aead_context_t * _ctx, void *_output)
static void
ptls_vpp_crypto_aead_dispose_crypto (ptls_aead_context_t * _ctx)
{
/* Do nothing */
vlib_main_t *vm = vlib_get_main ();
struct vpp_aead_context_t *ctx = (struct vpp_aead_context_t *) _ctx;
clib_rwlock_writer_lock (&picotls_main.crypto_keys_rw_lock);
vnet_crypto_key_del (vm, ctx->key_index);
clib_rwlock_writer_unlock (&picotls_main.crypto_keys_rw_lock);
}
static int