ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ip6-nd: initialize radv_info->send_radv to 1

Browse Source 
Otherwise, the newly configured interface will never send RADV's.

See below. In the typical case, suppress = 0 and is_no = 0, which
propagates the current value of radv->send_radv:

  radv_info->send_radv =
    (suppress != 0) ? ((is_no != 0) ? 1 : 0) : radv_info->send_radv;

No other bit of code will set send_radv, at least in straightforward
ways.

Type:fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If9368155f7676460ca1f87729c2b3c453405d08d
This commit is contained in:
Dave Barach
2022-10-30 16:45:24 -04:00
committed by Matthew Smith
parent 23c989642c
commit f094ce7653
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/vnet/ip6-nd/ip6_ra.c
View File

@ -1700,6 +1700,9 @@ ip6_ra_config (vlib_main_t * vm, u32 sw_if_index,
if (!radv_info)
return (VNET_API_ERROR_IP6_NOT_ENABLED);
/* Start off believing that we're going to send radv's */
radv_info->send_radv = 1;
if ((max_interval != 0) && (min_interval == 0))
min_interval = .75 * max_interval;