ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tcp: terminate options with nops

Browse Source 
On the one hand, make sure options are terminated with NOPs to avoid
issues with clients that can't parse options that don't end on an u32
boundary. On the other, make sure the padding is rfc compliant. If
options end with EOL the padding should be zeros. The current change
does not use EOL so the padding is NOPs.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I608056707ef9658ca90b9c095e84a0689d8000d7
This commit is contained in:
Florin Coras
2020-12-18 13:30:45 -08:00
committed by Florin Coras
parent 40a5da8e96
commit f9e500e816
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vnet/tcp/tcp_packet.h
View File

@@ -370,14 +370,10 @@ tcp_options_write (u8 * data, tcp_options_t * opts)
}
}
/* Terminate TCP options */
if (opts_len % 4)
{
*data++ = TCP_OPTION_EOL;
opts_len += TCP_OPTION_LEN_EOL;
}
/* Pad with zeroes to a u32 boundary */
/* Terminate TCP options by padding with NOPs to a u32 boundary. Avoid using
* EOL because, it seems, it can break peers with broken option parsers that
* rely on options ending on a u32 boundary.
*/
while (opts_len % 4)
{
*data++ = TCP_OPTION_NOOP;