6834 Commits

Author SHA1 Message Date
jdenisco
08b8ce1d6c docs: Update the vhost section
Change-Id: Ic7a144ffda0d0a3e0f6f9bc1a4790ab36fdf002e
Signed-off-by: jdenisco <jdenisco@cisco.com>
2019-06-27 15:03:04 +00:00
Neale Ranns
6a4c9af347 build: remove japi-install from Makefile
Type: fix

Change-Id: I63245280a0939d07f495b11005596ffdfe1d85c8
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-27 09:30:47 +00:00
Steven Luong
f78e87bf82 lacp: custom dump for sw_interface_lacp_dump
Add custom dump code for sw_interface_lacp_dump

Type: fix

Change-Id: Ifa76192ec65f596391c07b151d2a7fceed502665
Signed-off-by: Steven Luong <sluong@cisco.com>
2019-06-27 08:10:22 +00:00
Neale Ranns
22d009b4f7 vom: get the tests working again
Type: fix
Fixes: 097fa66b

Change-Id: Ib73714665e3325c7e1e8f939275933a4d219f96b
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-27 01:00:46 +00:00
Vratko Polak
a37810dcf4 papi: prevent message_table inconsistencies
Socket transport is maintaining message_table to map
message name to index. After disconnect and re-connect,
the VPP may have been restarted with different set of plugins,
so message_table has to be wiped.

+ Edited MAINTAINERS to recognize "papi" as a separate component.

Type: fix
Change-Id: I1f16ad7ee0886e03bbc6a17bcddbfcaa322354e5
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
2019-06-26 19:45:43 +00:00
Florin Coras
c930cda331 tcp session: improvement to tests
Type: fix

Attempt at fixing a random failing tcp test

Change-Id: I73aa31e26dd2df77d8b975e4fc88df16d8991863
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-26 19:12:55 +00:00
Zhiyong Yang
52c5f26fc5 bonding: fix comment typo
Type: style

Change-Id: I28908756019f8ca54c50334c470d8eded5621ade
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
2019-06-26 15:40:39 +00:00
Florin Coras
1c91c77307 svm: fix fifo segment free chunk bytes accounting
Type:fix

Change-Id: Icab89337eb3dbdc93d0fb453cfd34090026072b7
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-26 15:29:45 +00:00
Paul Vinciguerra
c118a220e5 tests: fix test-checkstyle failure in test_memif.py
Type: style

Change-Id: Ifea1fed5a6943605a6111afb33c54a8ff852d087
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-26 13:07:07 +00:00
Neale Ranns
023d23ad89 fib: default flow hash config for each DPO protocol type
Type: fix
Fixes: 59fa121f

Change-Id: I9eb4fe1612734e54932228527c37bf33b705dbdb
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-26 11:46:18 +00:00
Lijian.Zhang
0f9845120a vppinfra: add u64x2_scatter/u32x4_scatter
Add u64x2_scatter/u32x4_scatter in vector_neon.h. u64x2_scatter/u32x4_scatter
scatters data from SIMD register to scattered memory locations.

Type: feature

Change-Id: I298d5478c7ba6935ab7402a6d467c7ee00f17e9f
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Sirshak Das <Sirshak.Das@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
2019-06-26 11:38:59 +00:00
Benoît Ganne
c47b97ddac gbp: enforce same endpoint mac and ip src
During packet classification, make sure packets coming from an EP also
matches this specific EP IP address and vice-versa. This prevents and EP
to send a packet on behalf of another EP.

Type: fix

Change-Id: I30287644ec73b90d9b6913952a82b2baedf6a5ff
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-06-26 11:37:24 +00:00
Paul Vinciguerra
ab05508e1e api: refactor format_vl_api_prefix_t return keys
format_vl_api_prefix_t returns a dict with keys 'address' and 'address_length',
but other format_vl_api_prefix functions return a dict with 'prefix', and 'len'.

Refactor all format_vl_api_prefix_t to return consistent keys 'address' and 'len'.

Type: refactor

Change-Id: I5f9558fc2da8742a303266e011102f5b2db80aad
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-26 11:36:57 +00:00
Paul Vinciguerra
941da4a224 tests: set object_id for routes.
Object id's are used as keys in the object repository.
They need to be unique.

Also useful for debugging in log.txt.

Type: test

Change-Id: I69b5f3a7508918a5780ff8f20d27d4a3c34a5699
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-26 11:36:04 +00:00
Neale Ranns
a608afeec3 vom: fix test build failure
Type: fix
Fixes: 097fa66b

Change-Id: Id5ae4029f27af6cba76d6527c0d3d7212ab84f3e
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-26 11:29:32 +00:00
Neale Ranns
377860a739 api: Remove the inlines file and replace with library functions
using inlines exposes the users to the internal data types used by VPP, namely vec.h. This file does not compile with a C++ compiler.

Type: feature

Change-Id: I1544fdd9eae998309f865df61df78571bdb96903
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-26 11:29:09 +00:00
Jakub Grajciar
7db35de508 tests: fix memif tests
remote_test.py - Remove 'ret' arg from _remote_exec(), so that the function
                 always reads the reply from the pipe. (fix unmatched request/reply)

memif_test.py - Don't register VppIpRoute to VppObjectRegistry.

Type: fix

Change-Id: I8a51e7ffd68df5f379534f5ddd5ec9367a89be32
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
2019-06-26 10:10:05 +00:00
Chore
b1edf37bd5 misc: nat is added to MAINTAINERS file.
Type: fix

Change-Id: I3c6a0abad22c86c7125dc10e6d9be3d5af6d4ee3
Signed-off-by: Chore <s3m2e1.6star@gmail.com>
2019-06-26 08:55:25 +00:00
Mohsin Kazmi
17da0c0d82 vom: Add getter for interface admin state
Type: feature

Change-Id: I3409bedb45f033210202c151a2267b036b8b97d6
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2019-06-26 08:51:25 +00:00
Paul Vinciguerra
aaba610077 api: initialize sw_if_index earlier in vxlan_gbp_tunnel_add_del
In the case of an error, it is uninitialized.

Type: fix

Change-Id: Ib88fb997e5eef410c1cd970674d9385575f30366
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-26 08:50:08 +00:00
Steven Luong
4845c696d9 misc: add bond_dump, slave_dump, and rx_placement_dump
Fixed the missing bond_dump, slave_dump, and rx_placement_dump in
custom_dump.c

Type: fix

Change-Id: I9bf9ce071db175543edb383768c5915b939758ae
Signed-off-by: Steven Luong <sluong@cisco.com>
2019-06-26 07:55:59 +00:00
Steven Luong
4201e96cbc vmxnet3: custom dump and debug cli fix
Add missing custom dump for vmxnet3_create, vmxnet3_delete, and
vmxnet3_dump.

Fix vmxnet3_create debug cli which may not parse all parameters
correctly due to passing address of u16 to unformat(). The fix is
to use a u32 local variable to receive the correct value from
unformat().

Type: fix

Change-Id: I04251c9ed0ab397ed4b1b5843a73880aec98b9f6
Signed-off-by: Steven Luong <sluong@cisco.com>
2019-06-26 07:51:54 +00:00
Neale Ranns
f6a9ec5cfc fib: adj cover refinement check change
Usually the adj cover refinement check which ensures that for any
adj sourced prefix its cover is connected, is satified by the presence
of the interface source. The interface source has a high priority
hence during the adj refinement check get_flags() which uses the best
source, usually returns the flags for the interface source. However,
in the presence of higher priority sources that interpose get_flags does
not return connected and the check fails.
With this change add a specific check for the interface source if the
best is not connected.

Type: feature

Change-Id: Iabc3e29fe7c447fc3ef313e40b00d48fab09fba4
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-26 07:29:04 +00:00
Florin Coras
00dd74cee7 hsa: move vcl test apps to hsa
Type: refactor

Change-Id: I352975585c1091bfc5b85d7f8fe985f9059820a7
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-26 02:15:20 +00:00
Florin Coras
33cd4823d6 misc: fix sctp test with debug images
Type:fix

Change-Id: I6bf938d8c71b0fac6e093278132b00fc1ab951bb
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-26 02:13:13 +00:00
Vratko Polak
9f1b3ff308 tests: one more ipfix flush cli to api replacement
Type: fix
Fixes: 21b83e96d6076cda01ee80343840bc1166557150

Change-Id: I8216127ddbbf3301d2602bab54dbc433233387a2
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
2019-06-25 23:12:23 +00:00
Vladimir Kropylev
398afbd889 tcp: window update ack
Type: feature

Provide interface for sending Window Update ACK,
ensuring it will be sent only once, if RWND became non-zero,
after zero RWND has been advertised before.

Change-Id: I7f0d8af76d7763208625df68ab4ac3727fdaf449
Signed-off-by: Vladimir Kropylev <vladimir.kropylev@enea.com>
2019-06-25 21:51:42 +00:00
Andreas Schultz
217c62a53e vppinfra: fix tw_timer_first_expires_in_ticks for multiple wheels
When only the fast in wheel is in use, the next expiring has
to be within the fast_slot_bitmap.

With mutliple wheels, the next expiring timer could be in the
slow wheel. The timers on the slow wheel are only moved into the
fast wheel when the fast wheel index reaches TW_SLOTS_PER_RING.
When calculating the next expiring timer we therefor need to
consider the timers on the slow wheel as well.
When there are no more before reaching TW_SLOTS_PER_RING, instead
of scanning the slow wheel, return the number of ticks until
TW_SLOTS_PER_RING is reached.

Type: fix
Change-Id: I847031f8efc015c888d082f0b0c1bd500aa65704
Signed-off-by: Andreas Schultz <andreas.schultz@travelping.com>
Signed-off-by: Dave Barach <dave@barachs.net>
2019-06-25 18:30:31 +00:00
Florin Coras
52814737c3 tcp: delivery rate estimator
Type: feature

First cut implementation with limited testing. The feature is not
enabled by default and the expectation is that cc algorithms will enable
it on demand.

Change-Id: I92b70cb4dabcff0e9ccd1d725952c4880af394da
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-25 16:02:51 +00:00
Dave Barach
6e5baf29e2 build: fix error messages in check_commit_msg.sh
Type: fix

Change-Id: I432c22880a418be35ad9f99c3e4afc90449e83d1
Signed-off-by: Dave Barach <dave@barachs.net>
2019-06-25 15:59:05 +00:00
Florin Coras
0bcb931c39 lisp: move cp tests to unittest
Type: refactor

Also reformats and fixes some of the tests.

Change-Id: I074c677fd9b28e192f72a2db32f6f2dbda9a314f
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-25 15:39:10 +00:00
Florin Coras
f910e51608 hsa: move external echo apps to hsa
Type: refactor

Change-Id: I9a5c2abfd0c5444b31d9020cea918f9cd28f1ac2
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-25 15:38:30 +00:00
Florin Coras
8eb3e07dea svm: make sure chunk search does not return tnil
Type:fix

Change-Id: I8405bf8d93b4468c54f4f3c5dcd21ef91a6b1048
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-25 14:29:22 +00:00
Florin Coras
e3b8682d3f hsa: move session-apps to host-stack apps plugin
Type:refactor

Change-Id: I114fea3a54258797e961d8627a99ba2098674d20
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-25 14:25:54 +00:00
Paul Vinciguerra
1b534f5a4a tests: fix test_gbp.py.
A number of VppGbpContractRules were missing the hash_mode_t
and were being replaced by an optional kwarg.

Type: fix

Change-Id: I6ca03c93b69e4355c237a6c9402e1e178b701b21
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-25 12:37:13 +00:00
Chore
464e1dcd6b quic: test_quic.py style is fixed.
Type: test

Change-Id: I943f95ef740a0646b2da363c6a16dff1f4a2bb83
Signed-off-by: Chore <s3m2e1.6star@gmail.com>
2019-06-25 11:52:26 +00:00
Paul Vinciguerra
5dd6a7b29f tests: if vpp is dead, specify the test name in the output
'Exception: VPP is dead when setting up the test'
is more helpful with the test info.

Type: test

Change-Id: I6a262fdcf2ecb33aae17bef3d19745053a0bade8
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-25 11:26:08 +00:00
Paul Vinciguerra
08d82e98cd api: fix vac_read return codes
- vac_read was returning the same code for multiple errors.
- Refactor VppTransportShmemIOError to capture rv and description.

Type: refactor

Change-Id: Ifb8ca5ff679f658bcd92a43ecddaffd2fc18dbd5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-25 11:25:07 +00:00
Guillaume Solignac
8f818cc359 ipsec: print spi in hexadecimal
Print the SPI in hexadecimal and decimal.

Type: feature

Change-Id: I012e94f9147058064e06c6bb4622ab6b6507957d
Signed-off-by: Guillaume Solignac <gsoligna@cisco.com>
2019-06-25 09:46:21 +00:00
Filip Tehlar
c036c93bdf avf: fix clear hw stats
AVF plugin is missing a handler for clearing stats. This patch will
implement it.

Ticket: VPP-1701
Type: fix
Change-Id: If4b4354da442065896bb001deda23f64ddc18fb4
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2019-06-25 09:40:46 +00:00
Neale Ranns
ece2ae0fa2 ipsec: return error if the engine backend has no handler for the
requested alogrithm.

Type: feature

Change-Id: I19a9c14b2bb52ba2fc66246845b7ada73d5095d1
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-25 09:39:10 +00:00
Dave Wallace
47e77304ed quic: server create streams test case
Type: test

* Refactor quic_echo test app
* Add timinig capabilities
* Add multiple quic tests

Change-Id: I3302c66539b12c1375d1a0c6d46f9ff4c6f2b27c
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2019-06-24 23:37:39 +00:00
Nathan Skrzypczak
b4c677526b session: full lock on session_send_evt_to_thread
Type: fix

This was causing issues in QUIC when an app client & the protocol
app compete for the worker msg_queue. Might not be ideal performance-
wise.

Change-Id: I629892253d5b5d968f31ad1d56f18463e143d6b4
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
2019-06-24 23:35:28 +00:00
Andrew Yourtchenko
9d97d01411 tests: fix the MAINTAINERS file
Undo the change from I8488ab318a596c9b737308829cedfb7e96e57302 to the MAINTAINERS file

Change-Id: Ieea4a59dad127c2f2dcd86a6a0c699c23fb9158d
Type: fix
Fixes: d84661c
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2019-06-24 17:52:25 +00:00
Dave Barach
a638c18375 vlib: packet tracer support for pkt thread handoffs
Type: feature

Change-Id: Ia3d9a47679202c2a47cd3746b50e86c6b8627ef6
Signed-off-by: Dave Barach <dave@barachs.net>
2019-06-24 17:13:24 +00:00
Paul Vinciguerra
21b83e96d6 api: implement ipfix_flush
-Migrate tests to api and cleanup:
  '# FIXME this should be an API call' in tests.

Type: feature

Change-Id: I715f9f8acc0f2af9c974ea221b2aea46692a6218
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-24 16:22:35 +00:00
Paul Vinciguerra
496b0dee7f tests: refactor VppDiedError.
- Move Exception into same module as TestCase.
- Move the error reporting logic inside the error.
- Allows testing of the returncode and signal_name for tests to consume.
- Fix the signal reporting code:
	VppDiedError: VPP subprocess died unexpectedly with returncode -6 [unknown].
    displays as:
	VppDiedError: VPP subprocess died unexpectedly with return code: -6 [SIGABRT].

Type: test

Change-Id: I8488ab318a596c9b737308829cedfb7e96e57302
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-24 16:03:09 +00:00
Steven Luong
b98dbb1f2f lacp: convert clib_warning to event logger
Replace clib_warning with event logger. The messages for the latter are
stored in the event buffers which can be viewed with debug CLI anytime.

Type: fix

Change-Id: I5ede4d1f1f9f0ab8d66394f49383fc1838d397ae
Signed-off-by: Steven Luong <sluong@cisco.com>
2019-06-22 12:57:41 +00:00
Neale Ranns
dd7736b515 misc: update maintainers to include VOM
Type: feature

Change-Id: I324127934f1a129c23f232940b991fd1455891c8
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-21 08:03:30 -07:00
Lijian.Zhang
107aa83630 vppinfra: add u64x2_gather/u32x4_gather
Add u64x2_gather/u32x4_gather in vector_neon.h. u64x2_gather/u32x4_gather
gathers data from scattered memory locations to a SIMD register.

Type: feature

Change-Id: I1dd27e38af28b9bed85143014c86197ee549fede
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Sirshak Das <Sirshak.Das@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
2019-06-21 11:27:33 +08:00