7478 Commits

Author SHA1 Message Date
Jianlin Lv
1c3c9f0393 api: Add API support for PP2 plugin to stable/1908
Support create/delete interface with marvell PP2 API

Type: feature

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
Change-Id: I2a81024e0fcf2f389d39a5498167a752f8f807e5
2019-11-07 13:32:36 +00:00
Chenmin Sun
387123e675 dpdk: fix tso not properly check the 'enable-tcp-udp-checksum' option issue
Type: fix

Fix tso did not properly check the 'enable-tcp-udp-checksum' option issue
Add description of 'tso' and 'enable-tcp-udp-checksum' in startup.conf

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: Id659067a9fa9e1db6c3f8dc533a2e90351b86831
(cherry picked from commit 5bec5f7860dafcef6aefd50b74de15d08910c6f4)
2019-11-05 10:47:31 +00:00
Benoît Ganne
c9ddd2eec1 vlib: only dump 1st buffer in chain by default
Several nodes include buffers in their traces, but only the 1st. When
formatting the trace we must not try to iterate through all chained
buffers.
Default to display only the 1st buffer.

Type: fix

Change-Id: Ib3c668bbf4ab70ae68eba2ac402c7b7329825b70
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 4354317bf3592d81fcafd94e33b320c3e49f45d3)
2019-11-05 10:46:54 +00:00
Benoît Ganne
e7ac6d0250 ipsec: fix esp trace seq number overflow
Do not copy invalid seq number if packet is too small.

Type: fix

Change-Id: I1e78f5920e9645521f57efccaf35bbf9ce0676a8
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit c520fe7ab9db6fa60f9e69be990dd5c83eb40522)
2019-11-05 10:44:44 +00:00
Florin Coras
e04a58d27b session: fix dispatch event logging
Type: fix

Change-Id: Icf3c73cd7eb7565ed6e1b0371da172b5408a9d36
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit ba13c3b3695cb4758848d856174b725afcc7cdb8)
2019-11-05 10:42:46 +00:00
Florin Coras
6de46b40d2 tcp: track lost rxt segments in byte tracker
Type: feature

Change-Id: I18dfac9c3d2f539edf20dba64cd2b7b541154144
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 46ec6e018e95a10d46d018dbc15d90c309b5dccc)
2019-11-05 10:41:16 +00:00
Paul Vinciguerra
7def5ba815 vlib: fix subclass name being truncated in output
Type: fix

Change-Id: I50816cca4eb88f58209138a348fc5954ab835f5b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit c9832e3df839d164a801b57cd5f4ee014efe496b)
2019-11-05 10:40:29 +00:00
Paul Vinciguerra
ac68457e55 dns: fix typo in counter
Type: fix

Change-Id: Id8a0ce8278816d2839d229799daa3735a097bc7b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit e74718fa987df415f2e2c6509461b2b3a9936331)
2019-11-05 10:40:01 +00:00
Paul Vinciguerra
bfb7c2a459 l2: fix typo in doxygen
Type: style

Change-Id: I286280fffa6ab5d3e15986911a4ccc35efbf41c3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit ddbd90aae332e6c4b59e35bf44a735e592a3a053)
2019-11-05 10:39:41 +00:00
Paul Vinciguerra
0700f3c50e ip: cleanup typos in documentation
Type: style

Change-Id: I7d44b7fab1b8b196e4934cb4832ee51084c5bf98
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit 5b755e2f9fce239b5280ac1e5e21f835464fa017)
2019-11-05 10:39:15 +00:00
Dave Wallace
eaec04895e tcp: rx fifo size is u32
- Limit cli input for rx fifo size to u32

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: If5a8e0668acf5b0f369acf4f120e47a012bd1899
(cherry picked from commit db39656d7a85ac6e9e6fbed9ea59b3089acc8cae)
2019-11-05 10:37:25 +00:00
Zeyu Zhang
00413d3fed tls: fix on tcp connection reset
VPP would fail in tcp_connection_reset() if the tls
or app session was just created.

Type: fix

Change-Id: I45d107f57e4f3fc468c15ca3392d5e1c413bd690
Signed-off-by: Zeyu Zhang <zeyu.zhang@intel.com>
(cherry picked from commit cbbc4a2558eca8d78e0bd713ff58c54e294b1819)
2019-11-05 10:35:25 +00:00
Benoît Ganne
bf2aa86fe9 lisp: fix lisp-gpe db hash
lgt->key is already a pointer to the key, hash the pointed data instead
of the pointer value.

Type: fix

Change-Id: I4d29d8c6519afc3843cb2e5ef88795d60f715e23
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 0c4def0e84e3f563d9b2729f16b159f18d382602)
2019-11-05 10:35:00 +00:00
Florin Coras
2172c35eb4 vcl: handle rx notifications on reused sessions
Type: fix

Ignore events on sessions that have been reused but not fully
initialized.

Change-Id: Ided020eb5245d665d0a2e4a9e1f8a6dddebae009
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit bd52e46fe8193182cce150292e9df1c517795011)
2019-11-05 10:34:11 +00:00
Florin Coras
f0c4096e1b session: allow transport cleanup only if not deleted
Type: fix

Change-Id: I51282182952a66be698226bace39626df4d67b9f
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 5afea129ed0c85f5313791d1d55fed6cdcc079c7)
2019-11-05 10:33:39 +00:00
Andrew Yourtchenko
92a5fdd684 tests: make RA tests run on VPP time
the IPv6 RA tests take timing into the account,
but the time inside VPP may go slightly differently compared
to the time inside the driving python thread,
if the machine running the tests is heavily loaded.
Make a sleep function which sleeps "on VPP time" and use it.

Change-Id: I3b34b0164f6e0ec7a619b92ee308089a4a8935e3
Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit 63cb8827e586f02f53512d23a8e7596fe9c19aa8)
2019-11-05 10:31:18 +00:00
Paul Vinciguerra
5cd73e6d92 vlib: unix trivial- clean up typos in docs
seen while reading through the code.

Type: style

Change-Id: I7a2f021b9f06d0eebb2ea3d0cafb6955ccb14781
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit d29422cbeeefb58d0213b295b35d04a673b380e7)
2019-11-05 10:31:00 +00:00
Paul Vinciguerra
9e20470cb3 ip: trivial typos in docs
Type: style

Change-Id: I620f15b96ee5401e0145a139f06d343d7c4fadb4
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit f158944cc4f1bfcc21bed16f5c6f9177734adecd)
2019-11-05 10:25:43 +00:00
Florin Coras
3d30598b7b tcp: avoid sending acks when data available
Type: fix

Change-Id: I02e2cb2d349f9ddb2bfed040a08ca448f379d565
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit cb711a4ec908b89edc9da29d3c2e093dab85fbbf)
2019-11-05 10:23:52 +00:00
Ryujiro Shibuya
efb8db4c8a session: avoid old io dispatch if no slots left to send
Type: fix

Signed-off-by: Ryujiro Shibuya <Ryujiro.Shibuya@owmobility.com>
Change-Id: I8e1f6cbd905ad5c21aed1b2e358540d0fbd7fc47
(cherry picked from commit 2a1118411deed799e079bf34d3f6d8bccb37f8c5)
2019-11-05 10:22:25 +00:00
Andrew Yourtchenko
eeaf6e7614 gso: fix buffers trace
When segmenting, new buffers must inherit the original buffer trace
handle.

Type: fix

Change-Id: Ibd1859a501b2862906dfc563b98652cfee5681da
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2019-11-03 19:51:06 +00:00
Filip Tehlar
5b055af741 ipsec: fix tunnel protection removal
Type: fix

Change-Id: I4d5546d1f9b3a162291997f6f0c094c5c3d6cf31
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
(cherry picked from commit 89b24950005914317c142149fa1ba8a167a978ca)
2019-11-03 19:49:07 +00:00
Benoît Ganne
c07b9b6891 rdma: build: fix ibverb compilation test
Type: fix

Change-Id: Ib6389ecbcf4a1b7bae25b2bd9e7fbdec49545aaa
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 386ebb6e2baa7d3b2535d646c04ccf852f859869)
2019-10-31 22:52:40 +00:00
Ryujiro Shibuya
65ef66543a tcp: correct tcp connection lookup condition
Type: fix

Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: Ibdbac568d5f765e6b5c959cab5e32dc33335064d
(cherry picked from commit c8be851161739d9f0b1c4bfbda4e991461ff0bc9)
2019-10-31 12:17:59 +00:00
Filip Varga
80276a7101 nat: respect udp checksum
Type: fix

Change-Id: I73895fa0101bd50483160c8dc6faac2c67513077
Signed-off-by: Filip Varga <fivarga@cisco.com>
(cherry picked from commit 0d75f783644a24b219ed79d9f9c17387783f67ca)
2019-10-31 12:17:38 +00:00
Changqian Wang
709375e755 memif: memif buffer leaks during disconnecting zero copy interface.
code added to free the zero copy interface rx/tx queue buffers during disconnecting.
As ddc9eb4 find the last official solution introduced core in ut. This does not.

Type: fix

Signed-off-by: Changqian Wang <changqwa@cisco.com>
Change-Id: I971ee164e6d4331a85feb9e65d6702d771c86985
(cherry picked from commit 00b2d74d1f58b9357e8d955ad7410fb608490904)
2019-10-31 12:17:09 +00:00
Miklos Tirpak
f3ecd4c029 gtpu: msg id fix in send_gtpu_tunnel_details api
Type: fix

_vl_msg_id must start at msg_id_base.

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: Id3f05683c873fcac47667a9736e45e85849b740c
(cherry picked from commit bd0a00a45637c1dde533ef6c3798418c2ab15009)
2019-10-31 12:16:45 +00:00
Florin Coras
cd0c5d8373 tcp: improve rate samples for retansmitted segments
Type: fix

- Initialize max_seq on both transmitted and retransmitted segments
- Keep track of segments that have been sacked.
- Track new data segments sent during recovery

Change-Id: Ice55231a3da200ae6171702e54b2ce155f831143
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit d6ae4bf13a7819d64d128d196d491af4700fa948)
2019-10-31 12:16:19 +00:00
Florin Coras
dcc5de6fc3 tcp: fix sack retransmit beyond snd_nxt
Type: fix

Ensure that sack retransmit logic does not try to inadvertently send new
data.

Change-Id: Idfda19643577d9c1b58e2af8d8283cabfbaf98e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 81cb8e4092991d3fd1e24f0862c12548a2d4c714)
2019-10-31 12:16:05 +00:00
Benoît Ganne
abe07c8a25 vppinfra: make coverity happy with vec_set_len
Coverity gets confused by ASSERT((l) <= vec_max_len(v)) when l is 0.

Type: fix

Change-Id: I247d7015b148233d8f195bcf41e9a047b7a21309
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 70d5d4fa09520bd5825b49960ae896beca3535e8)
2019-10-31 12:15:48 +00:00
Benoît Ganne
952d4e7fb9 vppinfra: add clib_mem_free_s
IPsec zero-es all allocated key memory including memory sur-allocated by
the allocator.
Move it to its own function in clib mem infra to make it easier to
instrument.

Type: refactor

Change-Id: Icd1c44d18b741e723864abce75ac93e2eff74b61
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 78af0a8c5ff1a33ff8dccb1b2ea6ffadb8ef7b62)
2019-10-31 12:15:33 +00:00
Sergey Ivanushkin
54ff70cb3c tcp: Init cwnd from ssthresh.
Set high ssthresh out of the box and make configurable

Type: fix

Signed-off-by: Sergey Ivanushkin <sergey.ivanushkin@enea.com>
Change-Id: Iba1549b4ee55e51468ad0b28ef3d26a85fa9cae0
(cherry picked from commit c30318da220953610820a2e7cd957da7046eaf4b)
2019-10-31 12:14:15 +00:00
Florin Coras
b345e41ed0 session: increase max ctrl msg size
Type: fix

Connect ctrl message recently outgrew the maximum ctrl msg size, so
increase the limit. Also add static asserts for messages that could
potentially exceed the limit.

Change-Id: I0d3e32e0d4d67d7e222cff14ddba59a0c3fb8b00
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit e24a4bc023b880cb01aeaf8ffea98f44dd66ef4a)
2019-10-31 12:13:57 +00:00
Florin Coras
7364ac14b6 tcp: avoid head retransmit if scoreboard has no holes
Type: fix

Change-Id: I6164ad0d97cd91b60c85302eff691836d12a0a70
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 8a8b05c526883fe34b83239a3c4f56087d1df9e5)
2019-10-31 12:13:32 +00:00
Neale Ranns
ae36a85c86 gbp: missing contract hash-mode setting
Type: fix

Change-Id: Ia0f1e88b43e861d3f6965076c73cc48fb9574da3
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit bb098f176433d435471161f8be297d43b3558f4f)
2019-10-29 20:24:52 +00:00
Ole Troan
9a4e5878b0 l2: l2bd nd termination test instability
The test for ND event suppression reused the previous test run
ipv6 address, and would sometimes consider that a duplicate,
and therefore suppressing that one too.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1b115aa4eba9d57770fa03fcf38b7a1c251cfe88
(cherry picked from commit df0191ead2cf39611714b6603cdc5bdddc445b57)
2019-10-29 10:03:16 +00:00
Steven Luong
abad677803 devices: vhoost cpu->copy array overflow on tcp jumbo frame (65535 bytes)
We reserve 40 slots in cpu->copy array prior to copy out to avoid overflowing
the array. However, 40 is not enough for the jumbo frame because desceiptor
buffer len is likely at 1536. Change the reserve to 200 and add ASSERT to avoid
encountering the same problem in the future.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ibf0c03c4b4f33e781d5be8679ccd6c3a4b4a646d
(cherry picked from commit 7331005c16d0e1499080899b2a0676a0cd945595)
2019-10-29 10:01:02 +00:00
Benoît Ganne
b4c5f16889 build: add missing ldflags to exe and shared
Type: fix

Change-Id: I859bc6ebc574ab09fd70b45f8c911769d00e7acf
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 534de8b2a77cc2479a3f23cdb6df3d43cead06a6)
2019-10-29 09:53:39 +00:00
Benoît Ganne
16a17507f4 vppinfra: add vec_set_len()
l2-flood and bier nodes reset vector length without updating it to its
effective size. Introduce a helper to do it (this allows ASAN to keep
track of the new vector size).

Type: refactor

Change-Id: I2d652550c440f0553a2b49c3ee3d37b49ebc16c3
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 8a4bfdae87286ed281df855c58b669eb6b76aaf8)
2019-10-29 09:53:17 +00:00
Andrew Yourtchenko
f7b53e155a tests: add PID of VPP under test to API dump filename for the test
Some testclasses (e.g. IPSec) have methods with the same names,
this causes a race when running in parallel to save the API and
move it into the test's directory - the name of the file has
only the test method name as a discriminator.

Saving two traces from two VPP instances "succeeds", in that
it silently overwrites the file. But only one mv operation
works - the other gives an error "file not found" and fails the test.

Solution: add the PID of VPP under test to the API dump filename,
this way the filenames become guaranteed unique and the race is avoided.

Change-Id: I1bb47ed73369fea0f1bfbf907588a51e2cabfb7f
Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit 586d3edf49f5dd8cd3e4f836afd562e21766914d)
2019-10-29 09:52:42 +00:00
Dave Barach
aad7fa7d6f vlib: enable worker-thread dispatch pcap trace
Needed a bit of foreach_vlib_main(...) action to turn on/off all
instances of vm->dispatch_pcap_enable, and to pick up the pcap_main_t
pointer from vlib_global_main.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I49b69b87934c7dc7a9835cd07aa2c5c4d3c79f18
(cherry picked from commit 349cd1af77a27962e9475e9fa9c0ed15e2af23de)
2019-10-29 09:51:42 +00:00
Neale Ranns
270594b5d3 misc: Update gitignore for /test/ext/.d
.. otherwise i'm going to commit it accidentally

Type: feature

Change-Id: I0378b9a29a28ea7317bc7d234f8cbacdafd6b762
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 8161d73d7eb292ce8d6212b3a1575eed12dfeee2)
2019-10-29 09:50:55 +00:00
Florin Coras
f6e4a3c2a0 tcp: fix mss flag in option parsing
Type: fix

Change-Id: Ib03151a097caf15e4e8285afea83d1b930a874b0
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit a9e1f7b99bcb2164f3481cf48134d4efe7319c04)
2019-10-29 09:50:33 +00:00
Ryujiro Shibuya
87aadb1e75 svm: immediate fifo growth even when wrapped
Type: fix

- when the fifo is wrapped, and if applicable, insert a new chunk after
  the tail-chunk and rebuild the rb_tree.
- make sure that this new algorithm can be applied only when the fifo is
  used by a single thread (master-thread of the fifo).

Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: I3fc187bc496ea537ca24381e4abc08d2906c9e03
(cherry picked from commit 8e20fe7ab445e2de80caabb298aef8a658f6d4ab)
2019-10-29 09:49:06 +00:00
Florin Coras
e68fe9c516 tls: allow disconnects from main thread
Type: fix

Use api with explicit thread index to retrieve tls contex on close.

Change-Id: Ibdc4338747300b7fc8f91ef3e10bcd48ce7ae366
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 6faac1622e0d5352da987c73a6f3f1ec55896116)
2019-10-29 09:48:30 +00:00
Florin Coras
cdb11ea329 tcp: refactor flags into cfg and conn flags
Type: refactor

Change-Id: Ib5e2ecf55732599e1322736e3662178c9da49c7d
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit bbcfaac9571004d87998684c123354667b726532)
2019-10-29 09:48:03 +00:00
Florin Coras
abdc7dfb5f tcp: improve pacing after idle send periods
Rest pacer on ack reception if we haven't recently sent anything.

Type: feature

Change-Id: I820bacd81b65130052dfafbfcbe6ca4553069fbc
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit c31dc31f84961033ecb6354811e0c360b6cf5f79)
2019-10-29 09:47:37 +00:00
juraj.linkes
9a114bcb28 ebuild: Unite default build platform to vpp
Top level makefile is using vpp as the default platform. The other place
where platform is specified has native as the default. Unite them to the
only currently supported platform - vpp.

Type: make

Change-Id: Idb12ccc3056dd6be640a2d6763dc30e4f789d2ac
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
(cherry picked from commit 664ec91fdea75c90c3b9c8086a9a97df32a6f91b)
2019-10-29 09:45:11 +00:00
Dave Wallace
7b3695d34d misc: 19.04.3 Release Notes
Type: docs

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I43a236be5289c50dafbede08beabe4c09ff3c892
2019-10-29 02:53:32 +00:00
Benoît Ganne
1517d5e727 bonding: fix interface deletion
Copy sw_if_index value instead of using pointers to original
bif->slaves content which could be overriden by eg. vec_del1().

Type: feature

Change-Id: I37e458effd6b2367479574f7bd3facd4e93bada4
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit cc3aac05697976b512ce68017ca02b27d613eff2)
2019-10-27 10:14:26 +00:00