Commit Graph

6895 Commits

Author SHA1 Message Date
Vladimir Kropylev
1cfcb78940 tcp: timestamp adjustment
Type: feature

Change-Id: Icb3c574100cde95ab5be4923c8739889cf7e48c6
Signed-off-by: Vladimir Kropylev <vladimir.kropylev@enea.com>
2019-07-05 15:36:08 +00:00
Benoît Ganne
17237fbdbb gbp: use bd index at ext-itf creation instead of bd id
Type: fix
Fixes: cfc7a107e6

Change-Id: I341cbc94271ab89c3c643756a9c04b790cef8591
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-07-05 14:51:29 +00:00
Florin Coras
ca2831a80c tcp: add cc algo start tx event
Type: feature

Notify cc algos that new data is sent on a connection that was
apparently idle.

Change-Id: I892e5e9bb5b88d791265ffbbefce6f9694d01970
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-05 11:58:34 +00:00
Florin Coras
eff6b82e90 tcp: add cc algo undo recovery notification
Type:feature

Change-Id: Iedefe87555f0a0033abed8569bc2995c8f523d7e
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-05 11:58:34 +00:00
Florin Coras
a3c3265b20 tcp: add loss signal to cc algo
Type:feature

Change-Id: Ibe1a4c555b55fb929d55b02599aaf099ed522cdf
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-05 11:58:34 +00:00
Benoît Ganne
ba6abfa062 gbp: add unit-tests for anonymous l3out
Type: test

Change-Id: Ib32c87b7f07c0552a6801a895332a0156c3c37f0
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-07-05 08:49:39 +00:00
Benoît Ganne
3918bdbcbb gbp: update gbp-ext-itf API
Change gbp-ext-itf API to create anonymous ext-itf through the same API
as non-anonymous instead of a new API

Type: refactor

Change-Id: I381ff2a5bcd55276793df78ca891334c28946cd0
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-07-05 08:48:39 +00:00
Zhiyong Yang
73c8d1d644 vxlan-gpe: simplify counter code
Type: style

Change-Id: Ia50867a853388d9f69571815ddcdaadfc47206bc
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
2019-07-03 22:56:32 -04:00
Dave Wallace
7c1af9d159 hsa: clean up quic_echo
- Fix typo
- Use same prefix on all error messages
- Fix time arg parsing

Type: fix

Change-Id: I27334ada47d8512d2b43ce770a55f87081af2a1e
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2019-07-04 01:33:18 +00:00
Florin Coras
0f46e1657c vcl: disable ldp bidirectional multiple socket tests
Type: fix

Change-Id: I83778d897b6aa37a37ffdfa1d0932bb5e95225e2
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-03 22:02:10 +00:00
Dave Barach
138945f71f doxygen: improve .md file discovery
Add directories under .../src which contain .md files to
DOXY_SRC_DIRECTORIES.

Type: fix

Change-Id: If7ce833b6cb9cd5ec30a8df8e263087e276cfe97
Signed-off-by: Dave Barach <dave@barachs.net>
2019-07-03 21:01:48 +00:00
Dave Barach
4bda2d955d misc: fix coverity warnings
Type: fix
Ticket: VPP-1649

Change-Id: I93a393eca80065c379035478500e75e855f39b12
Signed-off-by: Dave Barach <dave@barachs.net>
2019-07-03 20:24:00 +00:00
Vratko Polak
fc4828cdbe api: remove garbage from sockclnt_create reply
The fix uses memset to zero after alloc,
as sizing of source string is not obvious.

Function vl_msg_api_alloc_zero is added (and used),
so similar bugs can be fixed easily.

Type: fix
Ticket: VPP-1716

Change-Id: I3b20040d0de4222686c58779f2c0af78c5543504
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
2019-07-03 17:44:38 +00:00
Aloys Augustin
0c7f54d489 quic: fifo notifications fix
Add SESSION_IO_EVT_RX handling in session_send_evt_to_thread to allow
internal apps to send rx events ("tx notifications") to quic.
Add a call to quic_send_packets in quic_custom_app_rx_callback to
ensure QUIC ACKs are sent if there is no other activity on the
connection.

Type: fix

Change-Id: I885e01e6475e5b0274f274e9dd34d4a771719e69
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
2019-07-03 16:30:11 +00:00
Neale Ranns
3eea9de899 gbp: Consider data-plane learnt source better than control-plane
Type: feature

Change-Id: Ice8fc0da6450d2aa8ba63ca1277393ac3605aa2c
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-07-03 11:31:16 +00:00
Neale Ranns
7bf7ea3ce3 gbp: improve contract formatting
Type: feature

Change-Id: I04be003bd86f828ec387dd0309bebcbf0a041e3a
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-07-03 11:30:43 +00:00
Paul Vinciguerra
063f374393 vppapigen: allow decimal number in NUM token
Needed to set f64 default values.

Type: feature

Change-Id: Ic58ebc0d9d890bf0e7821894285e61a5bee13199
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-07-03 11:29:39 +00:00
Neale Ranns
c2ac2357fb fib: allow route delete with no paths and multipath=0 to remove the
whole route

Type: fix
Fixes: 097fa66b

Change-Id: I017ab5797670eb278c27c6e306cd8cadaacddf9d
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-07-03 11:27:44 +00:00
Florin Coras
eaacce4753 svm: fix multi-chunk fifo alloc and add more tests
Type: fix

- make sure that chunks and the rbtree are initialized if fifo segment
allocates multiple chunks for the fifo.
- ensure head/tail chunks are updated on all enqueue/dequeue events,
including when dropping data.
- more unit tests

Also fixes dequeue drop updates of head chunk.

Change-Id: I77f3550bc4e8b4e077f80ea87fe82b83ed013aeb
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-03 11:26:36 +00:00
juraj.linkes
b5ef26d1ed tests: fix FORCE_FOREGROUND
Type: fix

Change-Id: I145f9984c1d944d5b7de0487e8b41ae4fdb95b6d
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
2019-07-03 11:40:58 +02:00
Neale Ranns
b34f99ced8 vat: Fix the incrementing IPv6 address
Type: fix

Change-Id: Ie085713f45672e112993638e01cdb325f451020a
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-07-03 08:00:53 +00:00
Paul Vinciguerra
063366eb23 tests: Have worker return immediately on bad executable
No reason to waste CI cycles if we know the test will not run.

See:
17:55:11  ==============================================================================
17:55:11  VPP Object Model Test
17:55:11  ==============================================================================
17:55:11  Exception in thread Thread-4:
17:55:11  Traceback (most recent call last):
17:55:11    File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
17:55:11      self.run()
17:55:11    File "/w/workspace/vpp-beta-verify-master-ubuntu1804/test/framework.py", line 1475, in run
17:55:11      stdout=subprocess.PIPE, stderr=subprocess.PIPE)
17:55:11    File "/w/workspace/vpp-beta-verify-master-ubuntu1804/test/run/venv/local/lib/python2.7/site-packages/subprocess32.py", line 617, in __init__
17:55:11      restore_signals, start_new_session)
17:55:11    File "/w/workspace/vpp-beta-verify-master-ubuntu1804/test/run/venv/local/lib/python2.7/site-packages/subprocess32.py", line 1415, in _execute_child
17:55:11      raise child_exception_type(errno_num, err_msg)
17:55:11  OSError: [Errno 2] No such file or directory: '/w/workspace/vpp-beta-verify-master-ubuntu1804/test/build/vom_test/vom_test'
17:55:11
17:55:11  17:55:11,328 Timeout! Worker did not finish in 120s
17:55:11  run C++ VOM tests                                                        ERROR [ temp dir used by test case: /tmp/vpp-unittest-VOMTestCase-vpMcWF ]
17:55:11

Type: fix

Change-Id: I3d8252807e98a09a8abd70de8a22517151f9d786
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-07-03 02:07:59 +00:00
Florin Coras
6898e5cb89 svm: fix shm segment delete
Type:fix

Change-Id: Ia8f3496bf24a7dbe0a295b038aa6dfa24f034989
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-02 19:45:07 +00:00
Dave Barach
9683c1eceb api: fix coverity warnings
New coverity toolset, new set of squawks to fix

Ticket: VPP-1649
Type: fix

Change-Id: I2a7e4c42b101c6c79c01b150b2523ce3d5d62354
Signed-off-by: Dave Barach <dave@barachs.net>
2019-07-02 15:29:36 +00:00
Benoît Ganne
3c0d84c989 gbp: add anonymous l3-out subnets
An anonymous l3-out subnet is a locally attached l3-out subnet, and
differs from regular l3-out subnets in the way adjacencies are managed.
It is required for the anonymous l3-out external interfaces to correctly
classify locally attached l3-out hosts.

Type: feature

Change-Id: Ie7bc88b1f22abc4d0b46db5f3cfbf208bc53ba5f
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-07-02 14:19:15 +00:00
Benoît Ganne
cfc7a107e6 gbp: add anonymous l3-out external interfaces
So far, GBP l3-out packets classification & policy relied on programmed
EP. All traffic to/from l3-out must go through a known EP.
This patch introduces a new feature where l3-out next-hops are only
known by their subnets (l3-out prefixes). As there are no longer known
EPs to program, an interface must be configured as external anonymous
l3-out. Packets classification & policy on this interface will rely on
the external subnets programmed in the BD VRF.
Note that contrary to all other interfaces in a GBP BD, external
anonymous l3-out interfaces have BD L2 learning turned on and rely on
ARP/ND.

Type: feature

Change-Id: Ieedb29dff4e967d08c4301e82d06bff450a63e5f
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-07-02 14:19:07 +00:00
Benoît Ganne
2ec825937b gbp: disable L2 BD learning per-interface
Disable L2 BD learning for each GBP interface instead of at the bridge
level. This does not change the current behavior (learning is disabled
for all GBP interfaces) but enables turning it on selectively for future
features such as anonymous l3-out.

Type: refactor

Change-Id: Id88644277941d703600acf97d49cbc3332ae3f68
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-07-02 14:18:59 +00:00
Jakub Grajciar
12df497bb6 libmemif: version 3.0
Add support for multi-thread connection establishment.

- control_fd_update() callback now passes private context
  associated with updated file descriptor. File descriptor
  can belong to memif socket, memif connection or timerfd.
  In case of timerfd the context is NULL.

- memif_create_socket() new API. Creates memif socket
  handle to be passed to memif_create() in memif_conn_args_t.
  This API allows to pass private context whenever the file
  descriptor is updated.

- memif_delete_socket() new API. Deletes memif socket.
  Socket must not be in use by any interface.

Type: feature

Change-Id: I7ca4e4349595d4477195f1c32403d3e3a6eb5361
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
2019-07-02 14:06:46 +00:00
Neale Ranns
312758f9af fib: Coverity fix to remove dead code
Type: fix

Change-Id: I678f523f058165030572d9cd395802b772db9ed7
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-07-02 12:29:45 +00:00
Florin Coras
9a2082fb51 lisp: init locator probed field in parser
Type: fix

Reported by coverity.

Change-Id: Ic84ac8c373c4c834bfddbf3ca08e2cfa2152e2ae
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-02 11:53:17 +00:00
Florin Coras
617574dd47 vcl: handle fd rcv msg error
Type:fix

Also cleanup worker fds on error. Reported by coverity

Change-Id: I52cf77ca90e9ba1cc8ee9ddb3edaeabdc073beda
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-02 11:52:49 +00:00
Florin Coras
f4f73340d6 vcl: fix sock client and server tests
Type:fix

Reported by coverity.

Change-Id: Ie623c5aa3ef54b649039c5ffa10476373c532825
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-02 11:52:29 +00:00
Florin Coras
7beaa3df42 lisp: fix unitialized ip prefix in cp unit test
Type: fix

Found by coverity.

Change-Id: Ibfc753d2c42219d275e3722d6ce1ef0cec189adf
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-02 11:52:14 +00:00
Neale Ranns
8d020854c8 vom: Fix [m]route dump
Type: fix
Fixes: 097fa66b

Change-Id: I4ada76982c680ee9b0af5828c7268b9b2098ce6b
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-07-02 11:03:22 +00:00
Benoît Ganne
8a8b83f5fe ip: check all fib src for a connected dst entry
When looking for a connected fib entry matching the ARP destination,
there can be other DPO interposed prior to the connected one.

Type: fix

Change-Id: I9b4ab387fb08acf9879d5fda3791e6572a099492
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-07-02 11:05:36 +02:00
Dave Barach
b252848326 build: vpp-ext-deps .rpm may not be installed
It's fine to remove the old .rpm, but don't stop the parade if there
wasn't an old .rpm to remove.

Type: fix

Change-Id: I500c740cc4ded16d3345c1e98462a1e8533f1028
Signed-off-by: Dave Barach <dave@barachs.net>
2019-07-01 19:08:58 -04:00
Florin Coras
7910feb5af ip: fix ip lookup for arm
Type:fix
Fixes: cb54e3c

Change-Id: I3120eaabdc00a6c1248cf7eb81f2075983836dfd
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-07-01 21:39:10 +00:00
Jakub Grajciar
389c82286d libmemif: icmp-responder example buffer management fix
Type: fix

Change-Id: Ieeb763f282ee929a121585747119f458c00056ae
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
2019-07-01 15:17:13 +00:00
Neale Ranns
160c923f99 gbp: VRF scoped contracts
Type: feature

Change-Id: I01772cfc3a0118a5c49bf346339788824e6931b2
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-07-01 08:37:53 +00:00
Paul Vinciguerra
5770c916c0 papi: refactor set_errors_str
Assuming 2500 50 char lines:
  string_concat elapsed: 5.919933e-04
  string_join   elapsed: 2.830029e-04
  string_concat size:     156,312,500
  string_join size:           125,000

Type: refactor

Change-Id: I0a400265426bde492e9a651d24996ddcfe954aa1
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-07-01 08:18:35 +00:00
Neale Ranns
01b0a05e4f igmp: accept packets that have more on the wire data than IGMP reports.
IGMPv3 sends a variable length of sources in a query. Today if the
amount of data on the wire does not exactly match that required for the
number of sources the packet is dropped.
Relax this check and instead accept the packet is the amount of wire
data is equal or greater than the number of sources.
Some devices on the wild internet pad small packets.

Type: feature

Change-Id: I102682814b38c0a0614d71816c9a286d90b834df
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-30 09:14:18 +00:00
Paul Vinciguerra
1671d3be38 pg: format_pg_input_trace - reorder fields
00:00:00:814640: pg-input
  stream pcap0-sw_if_index-1, 42 bytes, 1 sw_if_index

is changed to:

00:00:00:814640: pg-input
  stream pcap0-sw_if_index-1, 42 bytes, sw_if_index 1

Type: style

Change-Id: I9bb32494c9c1d08bc7588f088ed67a60ed3236dd
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-06-29 09:12:53 +00:00
Steven Luong
e5584965b7 devices: virtio pci leaking spinlock
Memory is dirt cheap. But there is no need to throw it away.

Type: fix

Change-Id: I155130ab3c435b1c04d7c0e9f54795b8de9383d9
Signed-off-by: Steven Luong <sluong@cisco.com>
2019-06-29 07:38:32 +00:00
Florin Coras
2d379d8cc7 svm: rename fifo tx notifications to reflect use
Type: refactor

Change-Id: I651db44acdcb666a9c63e1037352cf88c68795b5
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-29 00:30:41 +00:00
Vijayabhaskar Katamreddy
e3bbf5b565 interface: fixes for buliding for 32bit targets
* structure alignment and padding issues
Type: fix

Change-Id: Ic7c2a8cb5a5526902463f3b4d2d93284b454ab6f
Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
2019-06-28 23:07:40 +00:00
Neale Ranns
cb54e3cd7f ip: ip-lookup - remove the dead code
Type: refactor

Change-Id: I791cc63e989df049104420faf74fc28f965b6648
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-06-28 22:07:24 +00:00
Dave Barach
d0853d71f3 vppinfra: add dummy/noop f32/f64 endian swap fns
Makes life easier for binary API language bindings

Type: fix

Change-Id: Ib459274fda05153d01cbb7bc328a8407e3ee5027
Signed-off-by: Dave Barach <dave@barachs.net>
2019-06-28 20:17:22 +00:00
Nathan Skrzypczak
e82a7ade8a quic : Use TX event for app read notification
Type: feature

Change-Id: I1846cdeb35f079249f66a0351aa244c540923a43
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
2019-06-28 19:28:17 +00:00
Florin Coras
f73d4c2084 tcp: reject out-of-order fins
Type:fix

Change-Id: Iab2c308739f7733dbf70953e0ea87dcc404c60da
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-28 17:54:49 +00:00
Florin Coras
182bbc1c5a tcp: fix close-waiting check for outstanding tx data
Type: fix

Change-Id: I9e0e1bb933c38b17ac9fb8bf11b81e2fed021bf8
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-06-28 17:53:08 +00:00