Commit Graph

10584 Commits

Author SHA1 Message Date
Damjan Marion
2e5544f353 build: fix ./configure help
Type: make
Change-Id: I2479f1f84d32bf3e7266625a01174c1706bea7be
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-06 20:36:17 +00:00
Florin Coras
3ec0165665 vcl: move tests to src/tests
Type: refactor

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If622dfcc6f98d90cac0487e6bb9eb8c0bb01cf85
2021-05-06 19:19:46 +00:00
Ole Troan
3b51f28a6f stats: move vector_rate counters into provider
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iae1fb59a6dc9679c0fa0b87fa5232d551a7995a5
2021-05-06 18:10:13 +00:00
Ole Troan
8f12698f83 vlib: remove unused simple counters fields
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I46cfdcd02e5fda310367da17532cd2f355044811
Signed-off-by: Ole Troan <ot@cisco.com>
2021-05-06 18:09:50 +00:00
Florin Coras
1d87914a61 vcl: reduce iperf tests output
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia6197e99ebc42367624da27387216dc4cdb3141b
2021-05-06 17:12:25 +00:00
Florin Coras
6f281c26fc vppinfra: export unserialize_elog_main for g2
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifb322a7eb7ca14c3561ea34e40b80e3d1ce1b6a5
2021-05-06 16:45:32 +00:00
Damjan Marion
4a251d0a9c vppinfra: fix tests
Type: fix
Change-Id: If59a66aae658dd35dbcb4987ab00c306b3c6e2e2
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-06 16:29:00 +00:00
Ole Troan
2c4acdd8d4 vlib: rename vl_counter_t to vlib_error_desc_t
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I368b0410db2d633d3c52199c840e24d21952c1b4
2021-05-06 14:19:55 +00:00
Ole Troan
a606d92107 stats: memory heap counters
- Add counters for the main-heap
- Add additional counters per heap:
  STAT_MEM_TOTAL
  STAT_MEM_USED,
  STAT_MEM_FREE,
  STAT_MEM_USED_MMAP,
  STAT_MEM_TOTAL_ALLOC,
  STAT_MEM_FREE_CHUNKS,
  STAT_MEM_RELEASABLE,

The per-heap counters are organised as a two dimensional vector.
total, used and free are directly available via symlinks.

vpp_get_stats ls "^/mem/"
/mem/stat segment
/mem/stat segment/total
/mem/stat segment/used
/mem/stat segment/free
/mem/main heap
/mem/main heap/total
/mem/main heap/used
/mem/main heap/free

vpp_get_stats dump "^/mem/main\ heap$"
[0 @ 0]: 1073741776 packets /mem/main heap
[1 @ 0]: 91586688 packets /mem/main heap
[2 @ 0]: 982155088 packets /mem/main heap
[3 @ 0]: 0 packets /mem/main heap
[4 @ 0]: 1073741776 packets /mem/main heap
[5 @ 0]: 433 packets /mem/main heap
[6 @ 0]: 981708688 packets /mem/main heap

Type: feature
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I36725dde3b4b3befd27a8b4d3ba931f2d3b627cc
2021-05-06 14:19:28 +00:00
Ole Troan
ec34fb7723 pnat: coverity errors
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ic38cfbdcab86172bad6ec6cb4c66c83f8deed64f
Signed-off-by: Ole Troan <ot@cisco.com>
2021-05-06 13:47:20 +02:00
Ole Troan
f09d655101 memif: add severity to counters
Also rename counters in stat segment to make them more filesystem friendly.

Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8a3f3ec318931f5475fcb181f8b4a079a1fa4b9c
Signed-off-by: Ole Troan <ot@cisco.com>
2021-05-06 11:10:55 +00:00
Mohsin Kazmi
36f7a6aeb0 vlib: fix the offload flags size
Type: fix

Change-Id: I433fe3799975fe3ba00fa30226f6e8dae34e88fc
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2021-05-06 10:28:02 +00:00
Damjan Marion
11e0d752e6 vppinfra: enfoce function pointer cast in CLIB_MARCH_FN_POINTER
Type: improvement
Change-Id: I6ba9f9467a3990f1436a60b1dbc6cb795fd18ba9
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-05 19:44:46 +00:00
Damjan Marion
7d14aad637 vppinfra: fix x86 packs / packus wrappers
They both take signed value as input.

Type: fix
Change-Id: If3d8ec4e0b1c02d7d65262bdd9db49ff7fbfef39
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-05 19:57:04 +02:00
Damjan Marion
a7cea39b33 avf: remove dead store
Type: fix
Change-Id: Ic8d965aecea6b5b729e3f414235e676d62de779a
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-05 14:18:30 +00:00
Maxime Peim
dde163d96f vlib: fix adaptive mode flag unset on nodes reforking
The adaptive mode flag is being unset on
nodes reforking. The flag is copied in order
to avoid this issue.

Old flags are copied for all nodes.

Type: fix
Signed-off-by: Maxime Peim <mpeim@cisco.com>
Change-Id: Ic29b20fc0e4454ce4b3765c478f55bf650b4572a
2021-05-05 14:17:54 +00:00
Filip Varga
9d91e0271f nat: cli commands parsing fix
Newline get's ignored when parsing configuration file.

Type: fix

Signed-off-by: Filip Varga <fivarga@cisco.com>
Change-Id: Ib4f86177150dfe3bc085231a9268cf730490ea81
2021-05-05 13:23:50 +00:00
Filip Varga
ae80aba3b0 nat: fixing cfg file parsing cli issues
Type: fix

Change-Id: I35012bb2f7af1996c954641af40f3223bc7f37e4
Signed-off-by: Filip Varga <fivarga@cisco.com>
2021-05-05 13:21:24 +00:00
Damjan Marion
49a2925b1b build: set CMAKE_EXPORT_COMPILE_COMMANDS
Type: make
Change-Id: I8c59c91b4af49efcfcf7544df01b3d20511abe52
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-05 13:11:27 +02:00
Mohsin Kazmi
a7e830ed46 vlib: move offload flags to 1st cacheline in vlib_buffer_t
Type: improvement

Some tests i.e. ipsec see performance regression when offload flags
are moved to 2nd cacheline. This patch moves them back to 1st cacheline.

Change-Id: I6ead45ff6d2c467b0d248f409e27c2ba31758741
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2021-05-05 11:10:51 +00:00
Matthew Smith
baa18701b9 misc: ipfix process node wait time adjustment
Type: fix

The ipfix process node has a hardcoded 5s sleep between sending packets.
The interval between template packets is configurable, but the timing
of packets being sent does not match configuration because of the time
being hardcoded. E.g. -

With template interval set to 3s, a packet will be sent every 5s.
With template interval set to 8s, a packet will be sent every 10s.

Honor the configuration by reducing the wait time to less than 5s if a
template will need to be sent less than 5s from the current time.

Change-Id: I8c11f7bc502ce5b20b6e82a7e7a135a8805a2bad
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2021-05-05 10:36:13 +00:00
Paul Vinciguerra
ac0415fac8 api: fix crash in custom dump
Change-Id: Iffc52b4f52c235b0b5d13d2b42467cb2be0bf934
Type: fix
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2021-05-05 07:58:47 +00:00
Filip Tehlar
06111a837d crypto crypto-openssl: support hashing operations
Type: feature

Change-Id: I36041fe5c5f0ff129aee42516189807e96f62123
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2021-05-05 07:34:00 +00:00
Florin Coras
9592909ecc tcp: cleanup rcv-process and bulk buffer translation
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2ca8a5e30e55a84d4567422e4b7fcf90830921d3
2021-05-05 07:33:45 +00:00
Florin Coras
7f969c7004 tcp: cleanup listen node and bulk buffer translation
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2d11b1411a7653b94fddd889a5f28640c5f5566c
2021-05-05 07:33:33 +00:00
Florin Coras
b636abeba0 tcp: cleanup syn-sent and bulk buffer translation
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Idb286e77a877a6a60aa532263277f002fc002e48
2021-05-05 02:11:30 +00:00
Florin Coras
974b468b4e tcp: cleanup established and bulk buffer translation
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic37f640b7f0d0a041c003e76c8f29c21b5e664b3
2021-05-04 13:12:43 -07:00
Mohsin Kazmi
a02ad34f8b virtio: add simple drop counter for interface
Type: improvement

Change-Id: I4ac6b1a6553e26a5c26b6761fa3c4cc5d4925486
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2021-05-04 17:42:23 +00:00
Mohsin Kazmi
6799f9b453 virtio: fix the interrupt
Type: fix

virtio/tap interfaces set the empty buffers in the input node
for receiving data. Backend uses those buffers, fills them with
data and notifies the virtio/tap driver. But virtio/tap driver
gets into stall state if interface is created and configured
through exec script on VPP startup.conf and put the interface in
interrupt mode while VPP is only configured with main thread.

This patch fixes the problem by prefilling buffers during the
interface creation.

Change-Id: Ibc4d0e70e127ccc4b7cf8b2b18406ae4b02c73b4
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2021-05-04 16:48:11 +00:00
Arthur de Kerhor
db02380904 stats: adding symlinks for nodes and interfaces in the stat segment
A given interface counter (e.g rx) can be accessed via
/interfaces/<interface_name>/<counter_name>.
Same goes with nodes: /nodes/<node_name>/<counter_name>
As interfaces may contain '/' in their names,
these are replaced by '_' in symlinks
Also added 2 tests for the stat segment

Type: feature

Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>
Change-Id: I27da252e7b3dc177815616ca46b5c200a456bf0f
Signed-off-by: Ole Troan <ot@cisco.com>
2021-05-04 16:29:29 +00:00
Ray Kinsella
78b0a6e3f6 dpdk: allow configuration of max-simd-bitwidth
Enable configuration of DPDK's max-simd-bitwidth through the startup.conf

Type: improvement
Change-Id: I455148714ffc7caa257931526f310dbefd7ab01c
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
2021-05-04 13:57:48 +00:00
Mohammed Hawari
7d64631e51 misc: improve src detection in configure script
Change-Id: I2c45b160d76883044a3a7db0afcac0c56bcd2bcf
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: feature
2021-05-04 12:21:16 +00:00
Mohammed Hawari
5a504b04fc avf: fix simultaneous txq wrap and tx retry
Change-Id: Ic2b853cda98c3010d2abb5c7ada1b1f6c5bc9f74
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix
Fixes: ca1812dbe7
Ticket: VPP-1980
2021-05-04 10:15:32 +02:00
Benoît Ganne
f5a45680ee rdma: add support for RSS configuration
Type: feature

Change-Id: I911ee94b624ef5edf46b34666597eff93df1d1ed
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2021-05-04 07:23:03 +00:00
Benoît Ganne
ee60ac638c rdma: support non-power-of-2 number of rxq
Type: improvement

Change-Id: I7b78a8470aa3fd271120587d08e82afb23cb195b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2021-05-04 07:22:34 +00:00
Damjan Marion
3a533cd561 build: add set-build-type-* targets to CMake
Type: make
Change-Id: Icf37873b461cd034567dc1b99e23d1bbb3f4b9f0
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-04 07:18:17 +00:00
Florin Coras
ba9cb1ba37 quic: fix coverity warning
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I277f2e9ae2b763f5833778406d11218211163e43
2021-05-03 08:34:53 -07:00
liuyacan
694046cf8e session: lookup listener with iface address
We add interface address to the global lookup table, so we should
use it as the key when lookup listener. Otherwise, when multiple
threads listen on 0.0.0.0 (local scope disable), duplicate
listeners and sessions would be allocated but only one works.

Type: fix

Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Change-Id: I86f36475c16e217c6c5293a62c4fb5c9477a191e
2021-05-03 15:13:32 +00:00
Damjan Marion
94b80770ff rdma: avoid unnencessary inlining
Type: fix
Change-Id: Ifc4b30675365ebb5d69c018a34fd17a5090b30e1
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-03 13:38:09 +00:00
Damjan Marion
eee099e957 vlib: multiarch vlib_frame_queue_dequeue()
Fact that it needs to copy buffer indices justifies this move.

Type: improvement
Change-Id: I5eb815ccc4cca0ef70b092eb83a49b713efdcbeb
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-03 11:09:38 +00:00
Florin Coras
757f470aef quic: improve udp dgram write
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2992c66d11fe6adc96b525b0fde533e5ff58d7e4
2021-05-03 08:08:39 +00:00
Florin Coras
88dd3cf603 tls: cleanup dtls migrated context
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I433cc1b7a29f785a431618641317bbfbbe2cf2f4
2021-05-02 16:52:50 +00:00
Florin Coras
87f63898b4 vcl: attr api to set endpt ext config
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I06cd3721c1b534e9449bf96760c02ca30628c21e
2021-05-01 16:25:18 -07:00
Benoît Ganne
f89bbbe300 vlib: refactor trajectory trace debug feature
trajectory trace has been broken for a while because we used to save the
buffer trajectory in a vector pointed to in opaque2. This does not work
well when opaque2 is copied (eg. because of a clone) as 2 buffers end up
sharing the same vector.
This dedicates a full cacheline in the buffer metadata instead when
trajectory is compiled in. No dynamic allocation, no sharing, no tears.

Type: refactor

Change-Id: I6a028ca1b48d38f393a36979e5e452c2dd48ad3f
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2021-05-01 11:42:37 +00:00
Damjan Marion
c8983241b9 build: add option to turn off some march variants
Type: make
Change-Id: I53f7995c7e7a7ff829c662d71f37d88780bdd140
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-05-01 00:54:42 +00:00
Damjan Marion
3648d93b98 build: declare some CMake variables as advanced
Type: make
Change-Id: I780c1c81a50cb92bc89c05856efd8ef88479c0ab
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-04-30 20:30:16 +02:00
Damjan Marion
88b2e3682b misc: experimental configure script
Type: make
Change-Id: Iaeb9d22eec9a7a763b63899814a44e78c8050f1f
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-04-30 17:02:32 +00:00
Florin Coras
10796899cf quic: report number of packets sent on custom tx
A transport's custom_tx function must report the number of segments that
it enqueued.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie088c4215e6f17df639159820b8adf46b96fbb46
2021-04-30 14:39:55 +00:00
Florin Coras
01fcd757a1 hsa: vcl test client incremental stats
Add option to print per second tx stats

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7f226a6521da13ab29de65a441f73d4e56fb57cf
2021-04-30 14:39:39 +00:00
Damjan Marion
1bb67abf3c build: switch release build to -O3
Type: make
Change-Id: Ia39c2f847e7b4907fdd3fcac75897b8b4c545a65
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-04-30 11:15:47 +02:00