Commit Graph

8261 Commits

Author SHA1 Message Date
574be8fe22 misc: add new type for commit message
Type: style

Change-Id: Ibfa8bd1c0987fd2a5050be6c454f665666eb0210
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-02-05 09:12:12 +00:00
5414062412 vcl: switch to closed state after app close
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I851db474538de76d5f70dd6d6f83a6487a5a02bd
2020-02-04 19:12:36 +00:00
9fbacbc56b nat: pool allocation function fix
Type: fix

Change-Id: I75b20db66fb58e1724a212253c51315836079f4b
Signed-off-by: Filip Varga <fivarga@cisco.com>
2020-02-04 13:36:57 +00:00
59b6c0c86d vppapigen: fix options representation
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ief77110160120ea0e1291cc79949a73404cdbfda
2020-02-04 13:05:28 +00:00
13ff90fe53 virtio: update FEATURE.yaml to include description for vhost-user
Add features supported by vhost-user

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Iba4c5244c40324b603e2803ade8ecc0816326de8
2020-02-04 10:37:03 +00:00
03ce46219c teib: Rename NHRP to TEIB
Type: refactor

The Tunnel Endpoint Informatiob Base (TEIB) is a better
description of what it is (a mapping between tunnel endpoint
address, in the overlay, and next-hop address, in the underlay)
whereas NHRP is one instanc eof a control protocol that might add
such endpoints.

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Idcb2ad0b6543d3e5d9f6e96f9d14dafb5ce2aa85
2020-02-04 09:44:58 +00:00
0860b2e193 dpdk: patch ixgbe driver to solve race condition
Type: fix

Some fiber ports that are managed by the ixgbe PMD have the
possibility to get into a state where link can never be brought up.

This patch should fix it and will be submitted to upstream DPDK.

Change-Id: Ia4d0df2e70d098b2151e513b96e8bd742151e8ce
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2020-02-04 09:43:43 +00:00
8af24b145c ip: translate fragmented icmp to fragmented icmp6
The first translated ICMPv6 packet of a fragmented ICMP message does
not have a IPv6 fragment header. All subsequent have.

With this commit, add a IPv6 fragment header to the first translated
ICMPv6 packet.

Type: fix

Change-Id: Id89409ce7273cbeed801e2e18a09d3e7c3c4e4bc
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
2020-02-04 09:31:44 +00:00
0f96673683 vppinfra: fix typo in tw_timer_template.c
Fix minor memory leak

Type: fix
Ticket: VPP-1833
Fixes: 4af9ba1dab

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id10fba70471ca78f73f14146054f6b12c5d4431f
2020-02-03 11:58:05 -05:00
f4a92f6a1c tls: refactor for tls async event handling
Type: refactor

Make sure one tls ctx has one event availble
Thus ctx has the same life time with event, which can simplify the
management.

Change-Id: I1f4240e7316025d81bb97644946ffa399c00cd76
Signed-off-by: Yu Ping <ping.yu@intel.com>
2020-02-03 16:34:01 +00:00
564e167291 virtio: vhost gso is broken in some topology
Recent modification added a call to vnet_gso_header_offset_parser in the
beginning of vhost_user_handle_tx_offload. The former routine may set tcp or
udp->checksum to 0. While it is appropriate to set it to 0 for the GSO packet,
it is broken and causes checksum error if the aformentiooned routine is called
by a non-GSO packet. The fix is to not call vhost_user_handle_tx_offload
if the buffer does not indicate checksum offload is needed.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6e699d7a40b7887ff149cd8f77e8f0fa9374ef19
2020-02-03 12:33:28 +00:00
174959cd96 fib: invalid check for adj types.
Type: fix

coverity found invalid logic.

Change-Id: Ic9144ac805a4e5a18aa299794fedda044dcb65fe
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-02-03 12:30:46 +00:00
3d5f6229bc fib: refresh adj pointer after fib_walk_sync due to possible realloc
fib_walk_sync may call adj_alloc which may cause adj_pool to expand. When
that happens, any previous frame which still use the old adj pointer needs to
refresh. Failure to do so may access or update to the old adj memory
unintentionally and crash mysteriously.

Type: fix
Ticket: VPPSUPP-54

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I173dec4c5ce81c6e26c4fe011b894a7345901b24
2020-02-03 10:45:37 +00:00
48ac1c2b2e gre: improve .api descriptions
+ Remove fields not present in the typedef.
+ Sort field descriptions by the order in the typedef.
+ Add descriptions to other messages.
+ Add comment lines with de-abbreviated enum values.

Type: style

Change-Id: I2c41e0204ba5c59a53f1cf7b5837118484a16ad0
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
2020-02-03 10:43:33 +00:00
8ab4e507ce gre: add missing .api edits
The previous edit has added a new field to a typedef.
That change is backward-compatible for PAPI users,
but not backward compatible for direct binary API users.

This change adds two edits that should have been there already:

+ Copyright year bump.
+ API version bump.
  - PAPI users point of view, so bumping minor version only.

Type: fix
Fixes: e5b94dded0

Change-Id: Ib85f457254e38a8e5999a078855848e6a5cfda13
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
2020-02-03 10:43:24 +00:00
78a1877463 vppinfra: write up clib_time_t
Describe the clock rate adjustment algorithm in detail

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I5bcab18efafe05cd1db9a4b01ce6a6ba66e383fa
2020-01-31 21:56:12 +00:00
36a0c4d65c session: fix chunk batch alloc for large fifos
Type: fix

Change-Id: Ibfac65b516f20d25d91f6d0cf86491353811b8be
Signed-off-by: Florin Coras <fcoras@cisco.com>
2020-01-31 21:40:16 +00:00
92de6b65be quic: quicly crypto offloading
- Implement our own quic packet allocator to allocate more memory at the end of the
packet to store crypto offloading related data
- 1RTT packets offloading encryption/decryption using vnet crypto
- Add cli to change max packet per key

Type: feature

Change-Id: I7557fd457d7ba492329d5d8ed192509cbd727f9c
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
2020-01-31 20:22:28 +00:00
776644efe7 crypto-native: add ARMv8 AES-CBC implementation
Type: feature

Change-Id: I32256061b9509880eec843db2f918879cdafbe47
Signed-off-by: Damjan Marion <dmarion@me.com>
2020-01-31 18:06:09 +01:00
62b1cea6ed quic: update quicly to v0.0.10-vpp
Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I5452f8bbd0ff9e2a57f7bd7d134a8824efa5f30a
2020-01-31 10:48:40 +00:00
93975e699a crypto-native: refactor AES code
- use neutral types in preparation for ARMv8 support
- simplify x86 key extraction support

Type: refactor

Change-Id: I947eb37b8c9d9ee6909bb32ef14c4de192d40a46
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-30 21:39:20 +00:00
548d70de68 misc: deprecate dpdk hqos
Not in functional state for a long time ...

Type: refactor

Change-Id: I2cc1525a6d49518cbc94faf6afbf0d2d0d515f56
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-30 21:38:14 +00:00
7db6ab03db misc: deprecate netmap and ixge drivers
Both are out of sync for long time...

Type: refactor

Change-Id: I7de3170d35330fc172501d87655dfef91998b8fe
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-30 21:05:09 +00:00
47c995063e map: Add several more MAP-T BR tests
Add several more MAP-T BR tests for normal packet flow.

Type: test

Change-Id: Ica880dd23c923795279e9d08dca2796f2925069a
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2020-01-30 21:04:33 +00:00
c25048bd05 vppinfra: improve clocks_per_second convergence
Apply exponential smoothing to the clock rate update calculation in
clib_time_verify_frequency(), with a half-life of 1 minute and a
sampling frequency of 16 seconds. Within 5 minutes or so, the
calculation converges

With each rate recalculation: reset total_cpu_time based on the kernel
timebase delta since vpp started, and the new clock rate

Improve the "show clock [verbose]" debug CLI command.

BFD echo + echo fail tests marked off until the BFD code can be
reworked a bit.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I24e88a78819b12867736c875067b386ef6115c5c
2020-01-30 20:45:18 +00:00
91592c0c9c tap: fix host mtu configuration setting
host mtu can't be set if tap interface is in namespace.
This patch fixes this issue.

Type: fix

Change-Id: I63811c4b56c708fe708061a8afbaec41994f08ca
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-01-30 20:27:56 +00:00
3039753eda tap: fix the host mac address
Tap configuration code sets the host mac address
two time. This patch fixes it.

Type: fix

Change-Id: I7bebb9b7f25352a8a9a98bae6a0636757c0cea9c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-01-30 20:27:56 +00:00
ffad890961 misc: move configs to extras/configs
Type: refactor

Change-Id: I64665b290e2c42bbd9b0e877e9e4b028090b0ede
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-30 20:24:51 +00:00
d1e6b2937d fib: fix typos in doxygen
cleaned up some trivial typo's while reading through adj.h

Type: docs

Change-Id: I1b6cd815dc10ed3da8db2024b3e015e076235d50
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-01-30 20:13:55 +00:00
e5b94dded0 gre: Tunnel encap/decap flags
Type: feature

common funcitons across IP-in-IP and GRE tunnels for encap/decap
functions

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I325b66824878d843af167adfe5a7a96b0ab90566
2020-01-30 20:12:19 +00:00
9ace36d0f9 vcl session: propagate cleanup notifications to apps
Type: feature

Change-Id: I7f8e3763d7f8364563a25d0fcc782976b906b325
Signed-off-by: Florin Coras <fcoras@cisco.com>
2020-01-30 18:44:13 +00:00
960e58efde vppapigen: update markdown documentation
- Add newly added typedefs.
- Update string examples.

Change-Id: I1e7ee7cbf5901ba97302472521bf1f42a14765ea
Type: docs
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-01-30 11:06:18 +00:00
65866f03d9 map: Prevent IPv4 prefix spoofing during IPv6 -> IPv4
Prevent malicious packets with spoofed embedded IPv4 addresses
by limiting the IPv6 ingress packets to known MAP-T domains.
Drop spoofed packets.

Add several tests that ensure spoofing isn't allowed.

Type: fix
Fixes: fc7344f9be

Change-Id: I80a5dd10d5fe7492e3a1b04de389d649a78065e2
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2020-01-30 11:05:35 +00:00
56817e2c48 map: handle ip4 ttl=1 packets in map-t
With this commit, ICMP Time Exceeded is sent to sender when TTL
expires at MAP BR.

Type: fix

Change-Id: I8effe163beab32596883127b819308cc355512c3
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
2020-01-30 11:03:31 +00:00
78b58f65f1 crypto-native: don't expand aes-cbc keys twice
Type: refactor

Change-Id: If0d9ec70f9e8c228c39505864a4a73bf94b67479
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-30 10:10:06 +00:00
27d12d30cd bfd: add missing cast
Add missing cast to time conversion function to to deal with arbitrary
clocks-per-second values.

Type: fix

Change-Id: I5075a823e7a95c972c513ac765252337d5f59fbf
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2020-01-30 00:37:16 +00:00
31b1a6ce1d tests: add map-t fragmentation verifications
Type: test

Change-Id: I5522e88ee178d0563c246895393e835d125f1b81
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
2020-01-29 14:00:05 +00:00
f31acfafb2 dhcp: disable extraneous vlib_log spew
When there are no dhcp client interfaces configured, it's not
useful to make periodic / timeout log entries.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I16b68fe15ad9de789e49ad1b782b3b0e536bad60
2020-01-28 17:05:58 -05:00
30928f87a3 session tcp: fix packet tracing
Type: fix

Change-Id: Ib823d016c64998779fb1d00b8aad3acb5e8340be
Signed-off-by: Florin Coras <fcoras@cisco.com>
2020-01-28 15:06:47 +00:00
dda2dbedab hsa: proxy rcv wnd update acks after full fifos
Avoid rcv wnd probing after zero window advertisments by registering for
tx dequeue notifications and forcing acks that open the rcv wnd.

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8f33e3cf917f8c83d412f370ca66013aa4cd6e67
2020-01-28 15:06:27 +00:00
7d08e39a87 crypto-native: rename crypto_ia32 to crypto_native
Type: refactor

Change-Id: I9f21b3bf669ff913ff50afe5459cf52ff987e701
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-28 10:24:18 +00:00
0d4a61216c map: ip4-map-t more RFC compliant
When MTU is not set, ignore_df and mtu check
always returns true and packets are dropped.
This patch puts MTU checks after it was
compared with 0 and set to maximum if not set.
Added trace node.

If MTU is less than the total length value of
the IPv4 packet plus 20, the translator MUST
send an ICMPv4 "Fragmentation Needed" error message
to the IPv4 source address

Type: fix
Fixes: 87663cdf64

Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I35b99bc2648984cdbf5b6a57ddec91c586b15bef
2020-01-28 08:14:36 +00:00
e9595dba26 crypto-ia32: add VAES support for AES-CBC
Type: feature

Change-Id: Ic8aa6c48913677537301971469f9627b70c1cec8
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-27 21:36:19 +00:00
bd5c49a161 sr: fix possible null-pointer dereference
Steps to reproduce VPP crash:
1. configure localsid End behavior
2. ping the localsid address

Type: fix

Signed-off-by: Ignas Bacius <ignas@noia.network>
Change-Id: Id780e0875ec9cdb25252217990919fb3dddbf06a
2020-01-27 21:09:34 +00:00
12e3e312b1 vppinfra: use CPUID provided base frequency if available
Type: fix

Change-Id: Ifb007207be97119e07c3a0eba4714eb519de043c
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-27 21:06:14 +00:00
38e0413b2a vppinfra: add x86 CPU definitions
Type: feature

Change-Id: I9d1f9f00ac011a93709850186dcf4cf5ea3bf88a
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-01-27 21:05:18 +00:00
196fce2b62 classify: pcap / packet trace debug CLI bugs
"classify filter trace ... " and "classify filter pcap ..." are
mutually exclusive.

vnet_pcap_dispatch_trace_configure needs to check for
set->table_indices == NULL.

Type: fix
Ticket: VPP-1827

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I43733364087ffb0a43de92e450955033431d559d
2020-01-27 20:43:29 +00:00
03328ec8bb interface: Add missing ip4 udp->checksum = 0 prior to computing checksum
For ip4 tcp, ip6 tcp, and ip6 udp packet, we set checksum = 0 prior to
computing the checksum. We missed ip4 udp case. This oversight requires all
clients to set udp->checksum = 0 if ip4 udp checksum offload is needed.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ic608811e82099f3bec469e123671e9b281f38d76
2020-01-27 20:42:43 +00:00
14053c9dbd ipip: Multi-point interface
Type: feature

plus fixes for gre

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I0eca5f94b8b8ea0fcfb058162cafea4491708db6
2020-01-27 20:40:30 +00:00
59ff918ea5 tunnel: Common types for IP tunnels
Type: refactor

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I18dcdb7af3e327f6cacdbcb1e52b89f13d6ba6e2
2020-01-27 20:40:30 +00:00