9871 Commits

Author SHA1 Message Date
Neale Ranns
a705f7171b fib: Remove unused BIER variables
Type: refactor

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Idf17c3c02fb77fcadf69a9164abd4da35289aaed
2020-12-11 08:11:45 +00:00
Tetsuya Murakami
ddba67054a srv6-mobile: Fix the position of QFI
Type: fix

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: Ica02435c4bc198fb6c4b9e4b62a287e47689ae7a
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
2020-12-11 08:06:57 +00:00
wanghanlin
785b6ea80c vcl: fix listener session close problem
Type: fix

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: I34ac04f05b84b271679aafc253f1606f11e29835
2020-12-11 02:24:36 +00:00
wanghanlin
492350ee64 vcl: fix crash problem for invalidation of vls_table_lock
Type: fix

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: I0649f4d5adb5fa5b407431ea23982f2ad87fb657
2020-12-11 02:10:55 +00:00
Elias Rudberg
7184571810 tests: check ethernet type in arp test case
Add assertions to verify correct ethernet type field in ARP test case.

Type: test

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I1d2671b0ab2b4dcb53dab4b54bf93578d6bc86a3
2020-12-10 18:34:18 +00:00
Ole Troan
791c2061ae api: remove unused singular option
The singular option to the API language was added as a way to deal with messages
that do not have a reply message. Examples in memclnt.api.
Instead dealt with these messages using the service {} construct.

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If01b390b24b7539d1f93de4b8edfe1dad08e509d
2020-12-10 17:23:37 +00:00
Christian Hopps
b71653e9a8 misc: add a couple useful functions for gdb
- vgb() (vlib_get_buffer)
- ph() (pool_header)

Type: feature
Signed-off-by: Christian Hopps <chopps@labn.net>
Change-Id: Ica954480a7809c918cf65b06a0333ebe246a6f3a
2020-12-10 12:59:27 +00:00
nandfan
1f3112e716 hsa: http proxy connected callback fixes
svm_fifo_init_ooo_lookup has been called by transport

Type: fix

Signed-off-by: nandfan <fanyufei521@outlook.com>
Change-Id: I6626421c9a71212be0f7b8bff953133f760811f6
2020-12-10 03:15:39 +00:00
Dave Wallace
1722da7397 bash: Update jjb version in jjb-sandbox-env function
- The version of jjb deployed in jenkins.fd.io was
  upgraded to 3.5.0. Make the sandbox setup function
  use the same version.

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I486faffc6b5a0cce7425dd526adf9dbc034b2d85
2020-12-09 19:42:57 +00:00
Mohammed Hawari
33c45f56ab fib: supporting inner flow hash on tunnels
Change-Id: I53011e089bfecb08483792029b534b09b9e33a10
Type: improvement
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
2020-12-09 08:40:50 +00:00
Filip Tehlar
027d813a50 ikev2: test responder behind NAT
Type: test
Ticket: VPP-1903

Change-Id: I7fab6931833d6e253b7b921172825387302d8f70
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-12-09 08:12:09 +00:00
Dave Wallace
1affb31ef5 build: fix centos-8 'make install-deps' enable PowerTools repo
- The name of the powertools repo was changed [0]
  in centos-8 from 'PowerTools' to 'powertools'.
  Retrieve the correct name from 'dnf repolist all'
  instead of hard coding it.

[0] b759b17557

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ic1402e671eb1d70dec429bab82ad18d8251f4eef
2020-12-08 20:39:07 +00:00
Paul Vinciguerra
bb3befceee tests: restore vapi C++ test under Centos-8
The Centos-7 compiler had problems with vapi_cpp_test.cpp.
The Centos-8 compiler does not.  This change adds back the test.

==============================================================================
VAPI test
==============================================================================
run C VAPI tests                                                     1.55 OK
run C++ VAPI tests                                                   0.44 OK

==============================================================================
TEST RESULTS:
     Scheduled tests: 2
      Executed tests: 2
        Passed tests: 2
==============================================================================

Type: test

Change-Id: Ic6a655ae99eb3ba0e73b7feef4436a0ca5fd92be
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-08 20:04:17 +00:00
Neale Ranns
5c544c8c3e fib: Adjacency flag for midchain to perfom flow hash (on inner packet)
Type: feature

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: I964afd9266645de5c87d49c58ce6b48c2c18f97f
2020-12-08 16:38:19 +00:00
Mohammed Hawari
59b792ffb1 tunnel: add cli support for encap_decap flags
Change-Id: I2bf6ba325975309183dba1e14e9519c944710752
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: improvement
2020-12-08 16:38:01 +00:00
Florin Coras
d2fb601022 svm: fix ssvm_va for private segments
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8288a1ed97b375626d69ac7efa0256211834d89c
2020-12-08 15:29:38 +00:00
Mohammed Hawari
8b55261e95 ipip: correct ipip_cli.c indentation
Change-Id: I162061f83a190723c3b4b5585717851c4b9ba255
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix
2020-12-08 12:11:00 +00:00
Paul Vinciguerra
9c5dd2591c papi: remove old client reference
deprecated in 3/19

Type: refactor

Change-Id: Ia8eebaa0cd89d1e95166a62645400946d8db2f75
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-08 09:02:58 +00:00
Alexander Chernavin
f6cf57ceb9 misc: fix api in ipfix_classify_table_add/details
In ipfix_classify_table_add_del and ipfix_classify_table_details the
ip_version field has vl_api_address_family_t type. However, there is
no encode/decode for the field in the IPFIX API. Moreover, the IPFIX
code expects the field to contain raw 4 or 6 to indicate the IP
version.

With this change, encode/decode the ip_version field in the IPFIX
API. Also, stop converting transport_protocol between host and network
byte order because it's u8.

Type: fix
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: I4051756b8077b4367dd779cb555a34f74f6d7a9d
2020-12-08 09:01:59 +00:00
Neale Ranns
e2fe097424 fib: Source Address Selection
Type: feature

Use the FIB to provide SAS (in so far as it is today)
 - Use the glean adjacency as the record of the connected prefixes
 = there's a glean per-{interface, protocol, connected-prefix}
 - Keep the glean up to date with whatever the recieve host prefix is
(since it can change)

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: I0f3dd1edb1f3fc965af1c7c586709028eb9cdeac
2020-12-08 09:00:24 +00:00
Elias Rudberg
9b8cb50824 nat: avoid hairpinning infinite loop problem
Fix in nat44 hairpinning code to check if anything was actually
changed in the snat_hairpinning() routine, and return 0 if nothing
changed. This helps avoid an infinite loop repeating the three
nodes nat44-hairpinning-->ip4-lookup-->ip4-local in case there
was no change. Also add a corresponding test case.

Type: fix

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I95f48476bd002ac4c6789afe504681f1963e5d38
Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
2020-12-08 08:49:24 +00:00
Jon Loeliger
3227e49689 docs: Fix CentOS 8 build
Type: fix

Signed-off-by: Jon Loeliger <jdl@netgate.com>
Change-Id: I2d0d29af9186c50735d9a3b41148549f5cde614e
2020-12-07 19:02:31 +00:00
Mohammed Hawari
fe909a6288 dpdk: support mlx drivers linked with rdma-core
Change-Id: I8b8e4420f7643df95c27f4a4764809e8ddd2d12e
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: improvement
2020-12-07 14:08:22 +00:00
Paul Vinciguerra
e061dad55e tests: py2 cleanup - remove subclassing of object
Type: refactor

Change-Id: I9096e3b473110350e1e8e5936e3c4c164f8969a7
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-07 08:17:10 +00:00
Paul Vinciguerra
d6f221789d tests: remove the dependency on subprocess32
Type: test

Change-Id: I39afe56a085648d881a18c7eafcf7caf2f375f31
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-06 20:45:34 +00:00
Nathan Skrzypczak
d9ed3f2d8a wireguard: run feature after gso
This allows using GSO with wireguard

Type: fix

Change-Id: Id00a1425f9d9412aca9f259beda55a46bf5595d7
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
2020-12-06 20:04:15 +00:00
Dave Barach
ecf98c095c vlib: vlib_log for "linux device up" warnings
Make it easy to figure out why vpp didn't bind a particular hardware
interface in the most common case: the Linux interface is up.

Type: improvement

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I99534dd91e0030601c09171a9fbc9ad45af6bf08
2020-12-06 20:02:41 +00:00
Paul Vinciguerra
1135f65586 tests: refactor ForeignAddressFactory
Move ForeignAddressFactory back to test_lisp.
It is the only test that uses the code and has
embedded addresses specific to the test.

Type: test

Change-Id: If1a39f9b167e36dd7aff7481350ddb8fe17155d2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-06 18:54:07 +00:00
Mohsin Kazmi
24841867d1 virtio: fix the interrupt handling for packed queues
Type: fix

Change-Id: I2cc1cfd519e5b3502c59cf72e95e454f9122b8e5
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-12-04 22:54:34 +00:00
PiotrX Kleski
8ed06c0dd3 crypto: fixed vnet_crypto_async_reset_frame assert
Type: fix

Changed vnet_crypto_async_reset_frame assert to expect also
ERROR state frames.

Signed-off-by: PiotrX Kleski <piotrx.kleski@intel.com>
Change-Id: I3abc29f3f9642027aee38a59a932e54c90da859d
2020-12-04 22:52:54 +00:00
PiotrX Kleski
ef69b51034 crypto: fixed async frame enqueue race condition
Type: fix

To avoid race condition happening in async crypto engines,
async frame state and thread index set should happen before enqueue.
In addition as the enqueue handler already returns the enqueue status,
when an enqueue is failed, the async crypto engine shall not worry
about setting the async frame state but let the submit_open_frame function
to do just that.

Signed-off-by: PiotrX Kleski <piotrx.kleski@intel.com>
Reviewed-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Ic1b0c94478b3cfd5fab98657218bbd70c46a220a
2020-12-04 22:52:16 +00:00
Andrew Yourtchenko
270f5235c0 acl: fix acl-plugin testcases packet counting
Counter checks in ACL tests were incorrect if VPP is running with multiple workers

Change-Id: Id095d55c6cd3bfee8aaac6d177984e569e87d29b
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2020-12-04 22:50:41 +00:00
Paul Vinciguerra
6223766f96 libmemif: clean up typos
Type: style

Change-Id: I0d25d922312dfd60a665916cf47c3d2faa29ea49
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-04 22:48:07 +00:00
Mohammed Hawari
2b29c9494e avf: fix coverity issue
Change-Id: I1b589c924326a98c4cabe5496ce72b20673b5153
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix
2020-12-04 22:47:08 +00:00
Florin Coras
7a105fdad6 udp session: fix deq notification for dgrams
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1440c11fb9d962a05d877aebb4de364c86f9953e
2020-12-04 18:30:56 +00:00
Mohsin Kazmi
a17381a41d virtio: fix the len offset
Type: fix

Change-Id: I8ce1df5c97941fb645b33476db9cfc74f1395b15
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-12-04 16:57:08 +00:00
barryxie
01e94db84f ip: fixup memory leak in function ip4_full_reass_drop_all
Type: fix

The vector 'to_free' allocated on heap should be freed to avoid memory leak.

Signed-off-by: barryxie <barryxie@tencent.com>
Change-Id: I539498b50a7f3e346c83b869fb400868961c233f
2020-12-04 14:36:34 +00:00
Paul Vinciguerra
3825d93afe papi: add support for enumflag part 1 of 2
Allow for papi to accept the new enumflag type.

Change-Id: I8d8dc8fdb122e9a1b1881f5b2558635c75e4a299
Type: feature
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit 299abebe2942b4c78b85f9f3b8843f8213bf1efe)
2020-12-04 12:14:34 +00:00
Paul Vinciguerra
a51f9b3747 vppapigen: add parser support for enumflags
Type: improvement

Change-Id: I0f15862cc8399a4f7c8a81fe44ba8b27d8772278
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Signed-off-by: Ole Troan <ot@cisco.com>
(cherry picked from commit e15523297bb3905f2e0eef4272fc69a8a92463cc)
2020-12-04 09:40:27 +00:00
Andrew Yourtchenko
86ffb6b232 stats: fix coverity issues
Usage of the possibly negative value with subsequent check on it
makes coverity very unhappy, so put the check before use.

Change-Id: I731fbe6246f9e4212d546fd9277bc1ddcd3c2ec1
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2020-12-04 08:41:38 +00:00
Paul Vinciguerra
068ad25c1a lisp: .api dont set defaults in reply messages
Type: fix

Change-Id: I39afa6ee048dd293c5e17120fa661052eb3477d1
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-03 22:49:03 -05:00
Vladimir Medvedkin
e6293ad19b tls: allow picotls to use secp elliptic curves
Fix typos in macros for elliptic curves over prime field.

Type: fix
Fixes: f83194c2f4

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Change-Id: I657a7feaf1d1fdf3f2ca74fb3787977c65891a20
2020-12-04 01:46:29 +00:00
Mohsin Kazmi
b18b190cb2 virtio: fix the offloads in tx path
Type: fix

Change-Id: I1f1f0b6e8c5ef8bc9f2aca4bdc78e89fa951b841
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-12-03 22:57:41 +00:00
Filip Varga
c05e2852f6 nat: fix forwarding handoff workaround
A special case when out2in packet needs to
be handoffed to other worker thread. We are
not able to determine which thread they belong
to in the first processing of nat handoff node.
These packets needs to go through out2in slowpath
before we are able to tell where to handoff them.

Type: fix
Ticket: VPP-1941

Change-Id: I7173bda970ce6a91d81f48fc72aa2457586a076f
Signed-off-by: Filip Varga <fivarga@cisco.com>
2020-12-03 22:55:02 +00:00
Paul Vinciguerra
090096bff3 tests: remove py2/py3 six compatability library
Type: test

Change-Id: Idb6b8169845e0239e639429ccfd02a683212b7e6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-03 19:43:23 +00:00
Vladimir Medvedkin
4a856f9593 tls: fix passed argument in openssl plugin
Thread index used in qat_init_thread() is passed via a pointer
to a variable located on a stack that does not exist
when qat_init_thread is actually executed.

Type: fix
Fixes: f4a92f6a1c

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Change-Id: I65dd4e604b78fcb1cf0452d707f47f9785e6371d
2020-12-03 18:07:46 +00:00
Florin Coras
1d56ac423c svm: fix mutex consistency on trylock
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1370943935b460a1a1a22847fed2c97b1272a5e1
2020-12-03 16:05:27 +00:00
Paul Vinciguerra
d7adc293d3 papi: remove python2 patterns
Type: refactor

Change-Id: I541759b4b788acf08599661eb9e7abc58e9283d2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-03 14:12:09 +00:00
Paul Vinciguerra
5395c6a079 papi: allow client control over loggers
This change enables a client to set debug levels
globally as well as individually.

exposes loggers as
  vpp_papi
  vpp_papi.serializer
  vpp_papi.transport

Type: improvement

Change-Id: Ib6bd1a1f552b51a22c9fe3de819a5fb970963ae5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-12-03 14:00:05 +00:00
Vratko Polak
18a71d8af5 stats: char-pointer arithmetic style-up
Char* typed shared_header value appears multiple times,
so store it is a variable.
Pointer "p" value is used more frequently casted to char*,
so use that type for it, and convert to void* only at return.

Type: style
Fixes: 41f15ae1dfd4ac1777b684fdc763d12496209418

Change-Id: I7b3f1e6a43c020acd7ae561f87d12237b07fcd66
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
2020-12-03 13:41:28 +00:00