5649 Commits

Author SHA1 Message Date
Paul Vinciguerra
8aeb2207f9 test framework. Remove unused code.
Change-Id: I1bd14d5aff4918b58aef18fa0a9264e033989f6e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-01-09 06:10:59 +00:00
Mohsin Kazmi
5f4eb24287 gbp: Fix coverity warnings
Change-Id: Iea64d246008b298edeeae338d781b79362f42046
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2019-01-09 06:10:08 +00:00
Jon Loeliger
e3034cdc74 VXLAN: Prevent duplicate bypass graph nodes.
Change-Id: I68cc509b594b09751ff5e0e09bbca187a4a88edd
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2019-01-09 04:13:15 +00:00
Hongjun Ni
95eec06e9d Fix name of ipv6-n-tuple
Change-Id: Ia95a75295e4865b4720573f164ccba8bcc7679ae
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
2019-01-08 21:21:14 +00:00
Damjan Marion
e40231b1ec virtio: fix kick race issue
Change-Id: I25b2a28513821bc5eab9ac6890a3964d412b0399
Signed-off-by: Damjan Marion <damarion@cisco.com>
2019-01-08 17:03:56 +00:00
Florin Coras
294afe297c vcl/ldp: select cleanup/improvements
Change-Id: I640e69388f2ab0f66ad60c5165c749f5a5a9f525
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-08 00:45:21 -08:00
Steven
98311da8b4 string_test: coverity woe
Remove the needless tests and checks which coverity complains about in
string_test.c

Change-Id: I971650cada77136f06528a65625ef99bd3d7e915
Signed-off-by: Steven <sluong@cisco.com>
2019-01-07 22:38:39 +00:00
Andrew Yourtchenko
754f24b359 tapv2: add "tap_flags" field to the TAPv2 interface API
Change-Id: I26f99d95f52c9fe107d17dcbbf5c6185523beade
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2019-01-07 21:59:10 +00:00
Damjan Marion
d2bfb78f4f avf: allocate descriptor memory from local numa
Change-Id: Ic56ee4ce83b282a5f0f5aed500721fe639b941b3
Signed-off-by: Damjan Marion <damarion@cisco.com>
2019-01-07 21:57:17 +00:00
Neale Ranns
7c03ed47d5 VOM: mroutes
- fixes in ip.api for dumping mroute path flags

Change-Id: I13b0cfb15d374250ed71bd4e13dda9b798c18204
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-01-07 21:56:08 +00:00
John Lo
e26c81fc80 L2 BD API to flush all IP-MAC entries in the specified BD
Implement API/CLI to clear IP-MAC tables used for ARP-termination
in the specified bridge domain.
The CLI to flush MAC IP tables for a BD is:
 set bridge-domain arp entry <bd-id> del-all
The API added is bd_ip_mac_flush.

Change-Id: I34ceb87c0f480c7102f6559312c24081ed485af8
Signed-off-by: John Lo <loj@cisco.com>
2019-01-07 21:55:28 +00:00
Jon Loeliger
2500c79423 MAP: Prevent duplicate MAP-E/T graph nodes.
Change-Id: I6031f3f9cfa048a901a8424d33d47679115c2eb3
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2019-01-07 21:30:11 +00:00
Ping Yu
ceebc1e715 Change vpp code to align with openssl interface change
PR in openssl community is almost done, and need to change some code in VPP
to align with the openssl interface.

Change-Id: Ic7da53e507b67b53958760d07738dd774b1c526d
Signed-off-by: Ping Yu <ping.yu@intel.com>
2019-01-07 21:21:25 +00:00
Dave Barach
3a63fc5470 Handle buffer alloc failure in vlib_buffer_add_data
It's not OK to crash due to a transient buffer allocation failure.

Return 1 if the requested operation failed, otherwise 0.

Buffer index parameter change to a value-result, so the caller can
differentiate between partial and complete allocation failure: callers
which request an initial allocation (inbound bi = ~0) need to check
the (out) value to decide whether or not to call vlib_buffer_free(...).

Change-Id: I03029d7f2714c17dca4630dfd95a1eb578b68384
Signed-off-by: Dave Barach <dave@barachs.net>
2019-01-07 16:47:09 +00:00
Andrej Kozemcak
9d7570ccde Fix TCP checksum.
Set TCP checksum to zero, before calculate the TCP checksum.

Change-Id: Id96743334481804b8ebb74afef2f1dbfed29e0cb
Signed-off-by: Andrej Kozemcak <andrej.kozemcak@pantheon.tech>
2019-01-07 16:43:37 +00:00
Florin Coras
7baeb71f92 vcl/ldp: add locked sessions shim layer
Moves LDP logic that allows sharing of sessions between multi-process
app workers into a separate VCL shim layer. Also refactors LDP to use
the new layer.

Change-Id: I8198b51eae7d099a8c486e36b29e3a0cb8cee8e9
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-07 16:37:55 +00:00
Dave Barach
8dc146e000 Update tcpdump / wireshark packet format writeup
Change-Id: I8195bae1421f68a823b86e12373840f5292ac0df
Signed-off-by: Dave Barach <dave@barachs.net>
2019-01-07 15:55:53 +00:00
Mohsin Kazmi
78d62422e1 gbp: Fix typo in condition
Change-Id: Ib474e2af98d98d54c9fc4070fab56799555c0f31
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2019-01-07 15:33:13 +01:00
Paul Vinciguerra
356824fa3c vpp-api: Add context to VPPStatsIOError.
* Provide context information and return meaningful information.
VPPStatsIOError: Stat segment client connection returned: -2 Stat client socket open but couldn't connect.

Change-Id: I14ea35c58452a2cb7598a7efd136f0c7e1f5743a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-01-06 23:59:50 +00:00
Dave Barach
3c8e14684d pktgen: support mixed multi/single chunk pcap replay
Change-Id: I3d387b5e2b17f89ed688ea6cfee3fb6d782fe326
Signed-off-by: Dave Barach <dave@barachs.net>
2019-01-06 13:03:55 +00:00
Florin Coras
30e79c2e38 vcl/session: add api for changing session app worker
In case of multi process apps, after forking, the parent may decide to
close part or all of the sessions it shares with the child. Because the
sessions have fifos allocated in the parent's segment manager, they must
be moved to the child's segment manager.

Change-Id: I85b4c8c8545005724023ee14043647719cef61dd
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-05 21:53:16 +00:00
Ole Troan
3c1cf2c171 socket API: Use pool index instead of handle in sock_delete handler
The socket API used the socket index handle directly in the sock_delete handler,
resulting in "unknown client id" warnings, and a failure in return for socket clients.

Change-Id: Ia69f740ce0f834cd9b62b7157243a1f42bcad765
Signed-off-by: Ole Troan <ot@cisco.com>
2019-01-05 17:13:23 +00:00
Paul Vinciguerra
3c6f1045e2 VPP-1508: Python3: Support simultaneous p2/p3 venvs.
Change-Id: I24cf3e390f6f0b98be939ef717048742d3f183d6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-01-05 10:33:33 +00:00
Florin Coras
03afb6d973 tcp: fix reset in syn-sent
Change-Id: I6732adc06fbb3d4b427e671ddcfe6eabc08d4a1b
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-04 22:07:03 +00:00
Ping Yu
34a3a08d99 Add TLS support for VCL
Ater this patch, vcl_test_client and vcl_test_server can work happily with
TLS connection.
"-S" is to indicate TLS connection.

Change-Id: I761894b0b5929912691625f0fe63604725b55978
Signed-off-by: Ping Yu <ping.yu@intel.com>
2019-01-04 19:55:47 +00:00
Koichiro Den
33331edd3a libmemif: fix incorrect write leading to memory corruption
in the worst case scenario this leads to segfault in a hard-to-debug way.

Change-Id: I165adae0bd2dee26af777a2665c8c124d3a49808
Signed-off-by: Koichiro Den <den@klaipeden.com>
2019-01-04 19:55:33 +00:00
Michal Cmarada
6ebc6eb3d2 VPP-1525: additional fixes for strings in Japi
Change-Id: Ic5aa09fdc360cdded16d3c4693f0d4b2067f66d6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2019-01-04 13:29:25 +01:00
Florin Coras
b56fcf14d8 tcp: add more closing state arcs
Change-Id: If6f4d6404753b2d6b96e17f5414079bcdb9edde8
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-03 21:25:29 +00:00
Florin Coras
18e0d4f078 tcp: better randomize iss
Change-Id: I3638221e59024d6b7d82499d57e25b8e609f73cb
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-03 21:25:15 +00:00
Dave Barach
98d6b61183 Fix used-before-set in vl_api_bridge_flags_t_handler
The aarch64 cross-compiler complains about this when building an
optimized image. So we fix it...

Change-Id: Ib2b2089c0534753d7d470311012fa0073ab27d1d
Signed-off-by: Dave Barach <dave@barachs.net>
2019-01-03 09:51:42 -05:00
Ping Yu
d8e94ba823 Fix an issue in tls.c
Curernt code will overwrite parent_app_api_context, and defer the
setting after this value is used in callback.

Change-Id: Ie16e432fd0f4214e6deff3aa3b58b3be824b0331
Signed-off-by: Ping Yu <ping.yu@intel.com>
2019-01-03 00:16:46 +00:00
Florin Coras
4a7cbcd06b Revert "add ipsecmb plugin"
This reverts commit be16020c5034bc69df25a8ecd7081aec9898d93c.

The arm verify job actually failed but the result was overwritten by an x86 ubuntu retry. 

Change-Id: Idcae7691fc575053563b8ff8bcad661c15891668
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-02 18:50:37 +00:00
David Johnson
d9818dd68c Fixes for buliding for 32bit targets:
* u32/u64/uword mismatches
  * pointer-to-int fixes
  * printf formatting issues
  * issues with incorrect "ULL" and related suffixes
  * structure alignment and padding issues

Change-Id: I70b989007758755fe8211c074f651150680f60b4
Signed-off-by: David Johnson <davijoh3@cisco.com>
2019-01-02 10:55:55 -05:00
Paul Vinciguerra
d6897c1597 Add microarch details to 'show cpu'.
Change-Id: I31a3ff9e8f70468196c091027592a3aed2d09ac3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-01-02 12:23:59 +00:00
Matthew Smith
461caa5f98 ipsec: fix support check when using AES-GCM
When adding an IPsec SA, ipsec_check_support_cb() is called. This
invokes a callback for AH and a callback for ESP to check if the
algorithms are supported.

When using AES-GCM on an ESP SA with the DPDK IPsec backend selected,
the AH callback fails. The DPDK IPsec backend has no AH support,
so the callback for the default OpenSSL backend is invoked. This
checks whether the crypto algorithm is AES-GCM and returns failure.

Only invoke the callback to check support for the IPsec protocol
of the SA - either AH or ESP rather than doing both.

Change-Id: Ic10be6a17b580d06ffb7e82ef5866e53a4f8b525
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2019-01-02 12:21:40 +00:00
Klement Sekera
be16020c50 add ipsecmb plugin
Change-Id: I99c0737dfeeec2db267773625ddc9b55324fd237
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2019-01-02 12:21:02 +00:00
Florin Coras
a7a1a22673 ldp/vcl: epoll and shutdown cleanup
Change-Id: I882b4c495426551fad63372dc106496c5e8c141e
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-02 12:13:55 +00:00
Dave Barach
036343b8b1 Default huge page size to the regular page size
With this simple tweak, vpp is OK for "make test" or non-dpdk driver
operation over a kernel which doesn't support hugepages at all.

Tested on a Raspberry-pi 3B+ running the Ubuntu 18.04 64-bit server
beta image. It's amazing that such a minimal system will not only
self-compile vpp, but also run the unit tests. It's slow, but what do
you expect for that amount of money?

Change-Id: I7f080f871c828cc4b44be13809495278fadbd717
Signed-off-by: Dave Barach <dave@barachs.net>
2019-01-01 19:43:55 +00:00
Damjan Marion
671e60e656 buffers: remove unused code
Change-Id: If2bbfbc52994f5de0879763e0b7a7864498debb6
Signed-off-by: Damjan Marion <damarion@cisco.com>
2019-01-01 14:57:54 +00:00
Florin Coras
b0f662fe93 vcl/ldp: add write msg function and fine tuning
Allows app to push data. Additionally, ensure reset/close replies are
not sent unless vcl closes the session.

Change-Id: Icbbf933cf57b55cfbcc7b802af0f83919a066f65
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-01-01 14:55:53 +00:00
Dave Barach
22af447454 binary api clients: wait for vpp to start
Change-Id: I740a7423327b724e88fdfa35d90cb1285e9f9746
Signed-off-by: Dave Barach <dbarach@cisco.com>
2018-12-31 17:39:33 +00:00
Damjan Marion
c879c149d6 avf: tx dequeue optimizations
Change-Id: I9d8fcf930132e832941e5678a9278a029e104dc3
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-29 08:01:36 +00:00
Damjan Marion
1e75c6cffe avf: chained buffers rx support
Change-Id: I76ba11441f0ab3d150cdd080919cda91eac60b01
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-29 00:11:29 +00:00
Damjan Marion
9703ce4628 avf: chained buffers tx support
Change-Id: Ib573d45def80b4123d5623fda920e6cda1247638
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-28 23:32:14 +00:00
Damjan Marion
aed75f3d1d vppinfra: add simple ring implementation
Change-Id: I188e2dfd187d7b2ab7e0fbb11461f3db052f3224
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-28 23:31:51 +00:00
Florin Coras
5a2ec8fc41 session: free session after transport and app confirm
In addition to that, a bit of refactoring.

Change-Id: Iea1eabc2167bcdef185ec53bc09bae087c5398e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-28 20:41:44 +00:00
Florin Coras
fa915f8180 vcl: handle invalid sessions in epoll
Change-Id: I62d37f3c05451e5667863a2c6c551872d5dac1ea
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-28 20:41:31 +00:00
Paul Vinciguerra
fe4827c97d vpp_papi: MACAddress equals fails in unittest.
Before:
    EqualsAssertionError:  :: MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)
    ----------------------------------------------------------------------
    Ran 1 test in 0.002s
    FAILED (failures=1)
    MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)

After:

    ----------------------------------------------------------------------
    Ran 1 test in 0.001s
    OK

Change-Id: I89896a823b8f8a861813dabf23e7c9207e4fabb6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-28 20:40:14 +00:00
Jon Loeliger
28eedf4e89 MAP: Install lpm.h as map.h references it.
Change-Id: I97c6475920b7f7028c2bb1117ff9e5f629a54b44
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2018-12-27 20:05:22 +00:00
Florin Coras
223548d479 install-dep: force osleap boost dep install
Change-Id: I4a053f41eef138fc0e6db7e2650860c0ac999552
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-27 10:15:16 -08:00