4375 Commits

Author SHA1 Message Date
Ed Warnicke
e400a6d1a5 Update .gitreview for stable/1807
Change-Id: I6e405e9d729990bb57aaaa4aab01a1d4f54f4ee4
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
v18.07-rc1
2018-07-16 12:11:28 -05:00
Dave Barach
635ec3bdd0 VPP-1341: fix loopback interface graph arcs
Remove broken special case from l2_input.c:set_int_l2_mode(), which
turns out to confuse the graph dispatch engine.

The loopback TX function needs to push packets to either
ethernet-input or to l2-input, based on bridge / BVI
configuration. Rather than overloading a single graph arc - and making
vain attempts to reconfigure it - create both arcs and use the correct
one.

Rewrote the loopback tx function as an idosyncratic multi-arch
quad/single loop fn.

Change-Id: I15b56ce641d90a11e7b3c7d23859f40e168dd7b2
Signed-off-by: Dave Barach <dave@barachs.net>
2018-07-15 08:51:15 +00:00
John Lo
0e6f4d6af4 Improve IP4 ARP and IP6 ND Events Notification
For L2 ARP termination, use both brodcast ARP request and reply
packets to provide MAC/IP binding events.

For IP4/IP6 neighbor adress resolution, send resolution events
if there is an address resolution attemp with a static neighbor
entry where both IP and MAC matches. This allow probe of an IP
neighbor with a static entry to confirm it is responding with
a reply matching that of the static entry.

Change-Id: Iffb923bb5aea3f9021436735d5ca06e7b24f966f
Signed-off-by: John Lo <loj@cisco.com>
v18.10-rc0
2018-07-14 15:47:08 +00:00
Igor Mikhailov (imichail)
29b32c2ae3 Add QEDE poll mode driver (librte_pmd_qede)
The driver implements Cavium QLogic FastLinQ QL4xxxx 10G/25G/40G/50G/100G
Intelligent Ethernet Adapters (IEA) and Converged Network Adapters (CNA)
(doc/guides/nics/qede.rst)

Change-Id: If17e8cb572eb8c0585085be1c7cfdfa159eb6e68
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
2018-07-13 16:59:09 -07:00
Francois Clad
b02f3b7b8a srv6-as: Adding support for L2 traffic
Change-Id: I72978c5957cb1acf154c9de7ad153092bac37785
Signed-off-by: Francois Clad <fclad@cisco.com>
2018-07-13 19:19:27 +00:00
Francois Clad
0928da903f srv6-as: Adding test cases
Change-Id: I597a88d255c2f7cff552b1fa12ed4a7c4579b91c
Signed-off-by: Francois Clad <fclad@cisco.com>
2018-07-13 19:19:27 +00:00
Damjan Marion
18c458ebcf vppinfra: add missing header file to install list
Change-Id: I1f82c40f9f927296d5d439b0db70a70ef803cf3c
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-07-13 18:54:27 +00:00
Dave Barach
9779197f02 Improve the "show version" command
Add "show version cmdline" to display the command line
Add doxygen tags to the source code

Change-Id: I0205b373062fd88f176d9c8086d89d7784a5172f
Signed-off-by: Dave Barach <dave@barachs.net>
2018-07-13 17:58:59 +00:00
Dave Barach
a8d476468d VPP-1338: fix ipsec api coverity warnings
Remove useless unsigned comparisions: "(unsigned) value < 0", correct
a couple of incorrect limit checks.

Change-Id: I9606c4057df157f770d59535457cb9df1cfd1f35
Signed-off-by: Dave Barach <dave@barachs.net>
2018-07-13 11:26:36 -04:00
shenJibiao
b9124828bf The gateway IP should be 172.16.2.1
Change-Id: I28d05a04abd11f630035d34ce573016c77ffab53
Signed-off-by: shenJibiao <shenjibiao@corp.netease.com>
2018-07-13 08:48:09 +00:00
Dave Cornejo
d5091ffaf5 STATS fix memory leak in stat_client.c
continue statement in case bypasses cleaning up of unserialized
node

Change-Id: I0103d31df2eed3ed04d7cdcdfb790f4d9a376336
Signed-off-by: Dave Cornejo <dcornejo@netgate.com>
2018-07-13 00:10:21 +00:00
Dave Barach
0610039fd0 Fix debug CLI node recycling bugs
When creating a new - as opposed to recycled - debug CLI process node,
perform a proper barrier sync and node runtime update. Otherwise, the
graph replicas diverge for some period of time. That's not immediately
fatal, but it's not a good idea, either.

When renaming a debug cli process node, fix all of the name-vector
replicas before freeing the [one-and-only] name vector.

This fixes the so-called stats segment node runtime scraper crash,
which tripped over a replicated dangling reference to the
recently-freed debug CLI node name.

Change-Id: Ieffabd9f003139e534b9d79b88370439907930e5
Signed-off-by: Dave Barach <dbarach@cisco.com>
2018-07-12 22:30:11 +00:00
Dave Barach
93c90a5c97 Revert "vppinfra: AVX2 blend"
Causes clang validation failures. The patch did not actually pass validation; unfortunately it received a +1 from fd.io JJB - presumably due to a race condition

This reverts commit 779c865cc6c7af5bb435d8b3465d80685370edb2.

Change-Id: Ica3697f8f90e67d3eae4debc597f27d7d512004a
Signed-off-by: Dave Barach <dbarach@cisco.com>
2018-07-12 22:29:45 +00:00
Francois Clad
c82b358048 srv6: fix pointers in quad loops
Change-Id: I51c4bcbd456d2e7ffbdeef9cc8c7703d1c88b52e
Signed-off-by: Francois Clad <fclad@cisco.com>
2018-07-12 11:36:03 +00:00
Neale Ranns
582856273c IGMP: validate the packets length in the DP
thanks to coverity... validate that the length of the packet on
wire matches the size of the header based on the number of groups
and sources. drop those that don't match.

Change-Id: Iab3f3a835f6a43d9c73c5d502ea5ceccdd6985b0
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-07-12 10:26:10 +00:00
Florin Coras
daa1276fbf stats-segment: add startup node serialization option
Node serialization is turned off by default. To enable it do:

statseg {serialize-nodes on}

Change-Id: I53bba3cab517bd3ba90eba52d94b3ebb16870141
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-07-12 08:06:57 +00:00
Damjan Marion
779c865cc6 vppinfra: AVX2 blend
Change-Id: Ie7a64318f10ebb535c98aff4e25cdfc48f60ff33
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-07-12 08:06:25 +00:00
Florin Coras
46f001d2ac session: push tx notifications only if needed
VPP-1340

Change-Id: Ia3f2fc054dbfb2ba912a768c70466e7042024e32
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-07-11 23:10:09 +00:00
Ed Kern
bf2f3261b2 Documentation: Placeholder directory and files
This adds the directory sphinx and sphinx/docs
as well as two matching placeholder files.  These
are being added now to facilitate some gerrit triggers

Change-Id: I0e6e7607c5ae5cdbf05718b95b1d299178544485
Signed-off-by: Ed Kern <ejk@cisco.com>
2018-07-11 18:10:04 +00:00
Damjan Marion
067cd6229a avoid using thread local storage for thread index
It is cheaper to get thread index from vlib_main_t if available...

Change-Id: I4582e160d06d9d7fccdc54271912f0635da79b50
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-07-11 15:13:41 +00:00
Eyal Bari
b6b04f0c2a bridge-domain:fix no_flood count
no_flood count was not updated on removal
might couase a negative insertion index when adding new members

Change-Id: I2caf2c453dfef1a9f16fb8fa2e5af42b4e653a69
Signed-off-by: Eyal Bari <ebari@cisco.com>
2018-07-11 13:43:40 +00:00
Damjan Marion
20728d40d9 memif: fix max number of rings
Change-Id: Ie7621a38a44e7c692e23e58c43d27d8d2aab43e6
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-07-11 13:23:03 +00:00
Damjan Marion
9a02c54e4f avf: descriptor should be volatile
Change-Id: I2cb4cf2167b6e958d2e57b461848a4a189e3fda0
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-07-11 13:22:36 +00:00
Francois Clad
151b322492 srv6-as: Adding rewrite counters
Change-Id: I57f1db6fabfdb8ddfba514ad754707b24d47c962
Signed-off-by: Francois Clad <fclad@cisco.com>
2018-07-11 13:17:46 +00:00
Francois Clad
d47da680eb srv6: Fixing SRH parsing bug in Scapy 2.4
Change-Id: Ib2cb345d07665735697bf54ad48d353ba4112eda
Signed-off-by: Francois Clad <fclad@cisco.com>
2018-07-11 13:17:46 +00:00
Dave Barach
f46d8f8d3f VPP-1338: fix coverity warning in mactime plugin
Add missing VALIDATE_SW_IF_INDEX macro / check.

Net of this fix, a spurious warning will probably recur. Coverity will
complain that sw_if_index is tainted. Please dismiss the warning.

Change-Id: Iec31ce1d86f742e197e63b0c5d474cd5e496ee5f
Signed-off-by: Dave Barach <dave@barachs.net>
2018-07-11 13:16:45 +00:00
Mohsin Kazmi
9aca7b5ee9 vom: Add TAPv2 support
Change-Id: I1fff014dd7d8a66ed3cb063e8c996de4f7e745c2
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2018-07-11 13:12:12 +00:00
Damjan Marion
858151ff84 threads: fix issue with setting main-core to 0
Change-Id: Id3ccfcfa2a88cf7aa106f1202af7cd677de32575
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-07-11 11:02:18 +00:00
Jan Gelety
059d1d0e01 make_test: Add missing classifier tests
Jira: CSIT-1172

Change-Id: I04e726aab97efb96ed835d2a6db293a2acab0add
Signed-off-by: Jan Gelety <jgelety@cisco.com>
2018-07-11 09:34:42 +02:00
Dave Barach
c1dccc5c11 VPP-1337: Dangling reference be gone!
Freeing the prefix and address vectors after signalling them from
dhcpv6_client_node_fn to either the pd or iana report processes is
absolutely wrong. The code has appeared to work by luck.

This took three full days' worth of expert effort to root cause - in
the context of an unrelated patch - and about one minute to fix.

Change-Id: Ie589ab1a70ae83441ab4e8b6618a6d405741f53f
Signed-off-by: Dave Barach <dave@barachs.net>
2018-07-10 20:24:42 -04:00
Neale Ranns
4555bb4ffa IGMP: coverity found defects
Change-Id: Id6aba75c30712e9a0ac7b3075bd6cfc49d6bec36
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-07-10 21:23:09 +00:00
Neale Ranns
de450cb3cc FIB path dump: fix next-hop-table ID for recursive routes
Change-Id: I57b4ebca29c0b185770373e8878f89a9bd13b742
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-07-10 21:22:53 +00:00
Matus Fabian
8008d7cdfc NAT44: multiple outside FIB tables (VPP-1314)
Change-Id: I56eb15f8fd2d3049845287dc3df7870582764f8b
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2018-07-10 10:12:57 +00:00
Marco Varlese
abec942075 openSUSE: spec file update to reflect latest deps
Change-Id: I3c04956400a2e88d331f43d1b4865ee2c75e7bc9
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
2018-07-10 10:12:38 +00:00
Igor Mikhailov (imichail)
ebf4aa3786 Remove unused variables
Change-Id: If4da80c7eefe55905594eaaba0946d75f0892da5
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
2018-07-10 10:11:09 +00:00
Juraj Sloboda
c746a15272 Do not translate packets destined for NAT64 inside interface (VPP-1331)
Change-Id: Ieb8020f57ed5ad20daf552cd62ae3fdd8c573926
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2018-07-10 10:10:05 +00:00
Brian Brooks
3ecef99484 pp2: increase recycle batch size
Increase batch size when recycling buffers. This increases Mpps by 7%.

Change-Id: I2a460611d9c36e9bf087b076fc4e187acf61108f
Signed-off-by: Brian Brooks <brian.brooks@arm.com>
2018-07-10 10:09:24 +00:00
Brian Brooks
e356cbfaa8 pp2: use configured RX queue size
Change-Id: I5e5b2dd4f4bc3e257824015c723228ac5128d6a0
Signed-off-by: Brian Brooks <brian.brooks@arm.com>
2018-07-10 10:08:35 +00:00
Neale Ranns
947ea6222d IGMP improvements
- Enable/Disable an interface for IGMP
- improve logging
- refactor common code
- no orphaned timers
- IGMP state changes in main thread only
- Large groups split over multiple state-change reports
- SSM range configuration API.
- more tests

Change-Id: If5674f1044e7e97274a711f47807c9ba689d7b9a
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-07-09 21:10:53 +00:00
Eyal Bari
dd47ecadcf vxlan:use bihash_16_8 for ipv4 lookup
Change-Id: I0d4630c88d6caacffcd073ebaa12766dfc893f70
Signed-off-by: Eyal Bari <ebari@cisco.com>
2018-07-09 21:08:54 +00:00
Neale Ranns
a1ff01e5c9 new pipe code does not use stdints
Change-Id: Idee565af852c7bb434b886fbf31c6e76315686c4
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-07-09 18:41:16 +00:00
Matthew Smith
999a0a4199 Fix missing pipe.api.h
Errors occur when building a library outside the VPP
source tree that uses the shared memory API because
vnet/devices/pipe/pipe.api.h is not installed but is
included by vnet/vnet_all_api_h.h.

In src/vnet.am, Add vnet/devices/pipe/pipe.api.h to
nobase_include_HEADERS.

Change-Id: Id3dc28d90f41bb0ff576736f9d77bee19a2b8fdd
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2018-07-09 11:16:44 -05:00
Matthew Smith
0e36bbfd1b Fix IPsec intf tx node setup at intf creation
When using a DPDK cryptodev with IPsec, sending outbound
packets results in a crash on division by zero if using an
algorithm not supported by the OpenSSL ESP nodes. This
includes AES-GCM and MD5.

At IPsec intf creation time, the next node at slot
IPSEC_OUTPUT_NEXT_ESP_ENCRYPT for ipsec_if_tx_node_fn is
set to the node named esp-encrypt. This is the OpenSSL
ESP encrypt function. If DPDK cryptodevs are configured,
dpdk-esp-encrypt is the correct next node.

Change to setting the next node according to the value in
ipsec_main.esp_encrypt_node_index. That value is set to
esp-encrypt by default. If DPDK cryptodevs are configured
it gets set to dpdk-esp-encrypt.

Change-Id: I83896c76b975d74aead247a162c85eccca9575a8
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2018-07-08 11:22:17 +00:00
Matthew Smith
7b13e0df70 ixgbe link update patch for DPDK 18.05
Add patch for DPDK 18.05 that was previously applied
to DPDK 18.02.1. Issue with ixgbe on x550 SFP+ still
exists.

Bug report submitted to DPDK:

https://bugs.dpdk.org/show_bug.cgi?id=69

Change-Id: I9b005709ddf2a72192b1288ba8b4bac85bf12685
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2018-07-08 11:21:45 +00:00
Florin Coras
95e0ce0547 session/svm: fix coverity warnings
Change-Id: Ic5daed1f6c23d9561a04e235dcbf257f190d066a
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-07-08 11:21:23 +00:00
Mohsin Kazmi
e7cde313e1 vhost: Add multi-versioning support
It also refactors the vhost code which was in one big file vhost-user.c.
Receive side code is in vhost_user_input.c and
Transmit side code is in vhost_user_output.c

Change-Id: I1b539b5008685889723e228265786a2a3e9f3a78
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2018-07-08 11:21:07 +00:00
Neale Ranns
17ff3c1fa5 Pipes
A pipe resembles a unix pipe. Each end of the pipe is a full
VPP interface.
pipes can be used for e.g. packet recirculation, inter-BD, etc.

Change-Id: I185bb9fb43dd233ff45da63ac1b85ae2e1ceca16
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2018-07-07 16:06:34 +00:00
Florin Coras
65784c1602 svm: add unidirectional message queue
Meant for single reader/writer message exchanges. Supports multiple
message rings.

Change-Id: I925de9a6ae19226c5c39a63caff76424ed123a13
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-07-06 08:40:18 +00:00
Dave Barach
01a771b121 add stat segment size configuration
Change-Id: I395ff9c91d670a9f9e50dc1b030e0412b7234de5
Signed-off-by: Dave Barach <dave@barachs.net>
2018-07-05 11:49:00 -04:00
Eyal Bari
0fa56788f7 vxlan:use bihash_24_8 for ipv6 lookup
* added the fib index into the key
* conform coding style for vxlan.h
* added "show vxlan tunnel raw" command to dump bihash

Change-Id: Icc96e41abb648e96de5b4605b035f68f9e20f8a9
Signed-off-by: Eyal Bari <ebari@cisco.com>
2018-07-05 14:55:33 +00:00