4553 Commits

Author SHA1 Message Date
Lijian Zhang
f315410543 fix compiling warnings with GCC
GCC 7 plus Ubuntu-16.04 default ccache 3.2.4 reports warnings on switch case fall-through code,
which is commonly seen in DPDK code, which will cause image building failure finally.
It requires newer ccache version to support -Wimplicit-fallthrough.
To suppress the warning, if GCC is version 7 or higher, and it's old ccache version,
will disable the fall-through check.

dpdk-18.05/drivers/net/ark/ark_ethdev_rx.h:39:0,
                  from dpdk-18.05/drivers/net/ark/ark_ethdev_rx.c:36:
dpdk-18.05/arm64-armv8a-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_alloc_bulk’:
dpdk-18.05/arm64-armv8a-linuxapp-gcc/include/rte_mbuf.h:1292:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
     idx++;
     ~~~^~

Change-Id: I4d12492471fadef9d349ba9e853a6799512f76f5
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
2018-08-17 11:39:30 +00:00
Ping Yu
a0c29a9a8a Fix a segment fault issue in TLS
The root cause is it uses a dangling reference after memory move
Need to call session_alloc first, then use index to get the app
listener point

Change-Id: If5b7e0d6ddc761e5327660c47ce620e375319b4d
Signed-off-by: Ping Yu <ping.yu@intel.com>
2018-08-16 19:11:05 -04:00
Ondrej Fabry
e29cb67b7c Edit some warning messages in vpp-api client
- fix one typo: cnacel -> cancel
- edit log about returned value to be consistent with others

Change-Id: I09560eee8a9da361fa51e35f316d44361292bdb2
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
2018-08-16 13:56:11 +00:00
Damjan Marion
9daf8fb6b3 dpdk: fix rss hash function handling
DPDK 18.08 verifies if all set bits are supported and fails if not....

Change-Id: Ia87242fcda11147dff3bebe2e2bef32f0a8891fb
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-08-16 13:55:17 +00:00
shubing guo
4657c27b88 VPP-1386: fix wrong ip address of hash key for creating user in unknown protocol
Change-Id: I6239e930a8805207f8e42d15e8b17d444047e3f3
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
2018-08-16 13:40:46 +00:00
Florin Coras
452378a544 tcp: add tcp_error.def to installed headers list
Change-Id: I38351900bad9d727e7df6117597da488dbf5e12c
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-08-15 15:32:39 +00:00
Ondrej Fabry
6bd197ebb9 Remove client_index field from replies in API
- replies should not need to contain client_index since
  it is used to identify sender of requests to VPP

Change-Id: Iece3853b3f020054ee1652b149d0cf8d9580db4e
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
2018-08-15 13:09:16 +00:00
Matus Fabian
182e37e33f NAT44: fix next_src_nat (VPP-1384)
Use rx_fib_index instead of sm->inside_fib_index for session lookup key.

Change-Id: I2d6cce5b9376fa8ac4d75a9bbfa8498be0fd1493
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2018-08-15 13:08:56 +00:00
shubing guo
762a493890 VPP-1387:foreach outside address vector to find correct index when free outside address and port
Change-Id: Ie5452350a8ebe2c1b62085fcab50dbc0138d3ae2
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
2018-08-15 07:10:30 +00:00
Matus Fabian
38bc30802f NAT44: fix bug in snat_interface_add_del (VPP-1380)
Should not enable nat44-hairpinning node in deterministic mode

Change-Id: I5790323a6842ee71a62c6c91c49166a2839eac12
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2018-08-15 07:10:19 +00:00
Matus Fabian
8fed4240be NAT64: fix TCP session expire (VPP-1390)
Add missing call of nat64_tcp_session_set_state to set TCP session state.

Change-Id: Ifd297ea3ffe20870e1e34a95449b5c9404ec13eb
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2018-08-15 07:10:05 +00:00
Ondrej Fabry
b11f903ae8 Fix context field position in API definition
- context should be first field for reply messages,
  just like it is for all other 545 replies

Change-Id: Ib291036d3389dbc26c8e9194966d01cab81534aa
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
2018-08-14 21:16:10 +00:00
Dave Barach
e324898958 Run interior graph nodes before process nodes
Reduces the chance of tripping over vectors in flight, especially in
single-core cases.

Change-Id: I132cdd3689f8e634f9a983af57219503817b8560
Signed-off-by: Dave Barach <dave@barachs.net>
2018-08-14 20:19:09 +00:00
Kyle Mestery
acc1fbcb5e Make vagrant work behind a proxy
Without this change, I cannot get the in-tree VPP Vagrant to work behind
a proxy. This commit fixes that by ensuring when we run sudo we're passing
environment variables, amongst some other cleanups.

Change-Id: Ica98a1238d40e6e6ccf80c472f52559c95af52f0
Signed-off-by: Kyle Mestery <mestery@mestery.com>
2018-08-14 20:16:51 +00:00
John DeNisco
ce96dda447 DOCS: Moved multiarch and build system, Incorprated Scott's changes
Change-Id: I5a57846db2d4faac1aa24db4629b612657f59afb
Signed-off-by: John DeNisco <jdenisco@cisco.com>
2018-08-14 20:13:21 +00:00
andrew
9f0c02053f DOCS: Updated startup.conf parameters
Change-Id: Id1f4ff7409e8a833b8f7e6030d7287d8c1274c2d
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
2018-08-14 20:12:46 +00:00
Ping Yu
998dfd3c0f reduce polling and resume overhead by checking if inflight request exists
Change-Id: I0777a00f0cc082bab3348be8ec0be39faa50ffed
Signed-off-by: Ping Yu <ping.yu@intel.com>
2018-08-14 16:49:49 +00:00
ahdj007
22130e163e neighbor advertisement must with target_link option
Change-Id: Ic20eea8f2fd19dd3c1728a1f7c622ef0c9728f81
Signed-off-by: ahdj007 <dong.juan1@zte.com.cn>
2018-08-14 11:11:18 +00:00
John DeNisco
758dc46072 DOCS: Cleanup Getting Started
Change-Id: I4766773779f8d5c30a24bfed48090d7305c80ec5
Signed-off-by: John DeNisco <jdenisco@cisco.com>
2018-08-13 17:00:22 -04:00
Juraj Sloboda
34eb5d423d classify_add_del_session API: Use more descriptive docstring (VPP-1385)
Change-Id: I30788c0dd1ee012e786bb3127bf2743ab0bfdc70
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2018-08-13 17:13:19 +00:00
Damjan Marion
c9dad5d945 Multiarch for ip4 forwarding nodes
Change-Id: I68b55fc641da9dacc3343628b3e0cf77d3533313
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-08-13 14:34:22 +00:00
Damjan Marion
6e36351faf Multiarch handling in different constructor macros
This significantly reduces need for

...

in multiarch code. Simply constructor macros will jost create static unused
entry if CLIB_MARCH_VARIANT is defined and that will be optimized out by
compiler.

Change-Id: I17d1c4ac0c903adcfadaa4a07de1b854c7ab14ac
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-08-13 14:33:54 +00:00
Damjan Marion
3bf6c2bfe5 dpdk: support for DPDK 18.08
Change-Id: If1b93341c222160b9a08f127620c024620e55c37
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-08-13 14:32:03 +00:00
shubing guo
060c3a7e5a VPP-1381: Fix the incorrect if condition when delete session for static mapping
-- The session should not be deleted when either ip address or port doesn't same with static mapping.

Change-Id: I09ab7379947654d2780a8c40c5340ce430541b12
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
2018-08-11 22:32:19 +00:00
Mohsin Kazmi
dd8e7d0e51 Multiversioning: Device (tx) function constructor
Change-Id: I39f87ca161c891fb22462a23188982fef7c3243f
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2018-08-11 15:01:42 +00:00
Damjan Marion
7f1f7e7865 avf: fix prefetch bug
Change-Id: I4e774dc53b08746cd4ab42393f33676dcc78e791
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-08-11 09:17:51 +00:00
Dave Barach
d7a37a7562 emacs skeletons: add quad/single, avx2/avx512 support
Change-Id: Ib8095ad69620308d6199ab030a754ee45f92e59b
Signed-off-by: Dave Barach <dave@barachs.net>
2018-08-11 00:07:10 +00:00
Ole Troan
7eb9d9608b IP fragmentation buffer chains, part 2.
Change-Id: I8d1072cf9ff9f502302fd906c5590e0f3698dc60
Signed-off-by: Ole Troan <ot@cisco.com>
2018-08-10 20:31:13 +00:00
Florin Coras
9936831502 vcl: support for eventfd mq signaling
- support eventfd based mq signaling. Based on configuration, vcl
epoll/select can use either condvars or epoll on mq eventfds.
- add vcl support for memfd segments
- vpp explicitly registers cut-through segments with apps/vcl
- if using eventfd, make ldp allow one call to libc_epoll_create. Needed
for the message queue epfd
- update svm_queue_t to allow blocking calls with eventfd signaling.

Change-Id: I064151ac370bbe29bb16c968bf4e3659c8286bea
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-08-10 20:26:24 +00:00
Dave Barach
f46663c65b DOC-ONLY: document latest multi-arch support scheme
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I613415c109f648248ee04dd76d5e652dbf21bc7f
2018-08-10 11:15:55 -04:00
Dave Barach
8e83bcb9ae DOC-ONLY: build system details
The tables need some TLC from someone familiar with making pretty
tables.

Fixed text-wrapping onto newlines for all tables in our docs.
Changed Environment Variables to ENV Variables so that the specific
column header fits properly.

Change-Id: Ie758612e561eefe44e771dac63b63bf026a52c2d
Signed-off-by: Dave Barach <dave@barachs.net>
2018-08-10 15:05:09 +00:00
andrew
a38d001cfe docs: A little cleanup and added some gdb examples.
docs: Added section on running VPP for developers.

Change-Id: I98b5c6f1c9fee60b297e3947e78ec33f950f598a
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
2018-08-10 15:04:46 +00:00
Ole Troan
4146c65f0d IP fragmentation to handle buffer chains.
Change-Id: Iff557f566ebc9ab170d75da1233997d83b8c8a66
Signed-off-by: Ole Troan <ot@cisco.com>
2018-08-10 12:02:51 +00:00
shubing guo
3074629b25 VPP-1382: Fix ip6 address cann't display completely when show ip6 neighbors
Change-Id: Iadfbe3c0d0c6dcec2b4ccf1695bd234358f6969a
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
2018-08-10 09:27:01 +00:00
Neale Ranns
d0df49f26e Use IP address types on UDP encap API
Change-Id: I3c714c519b6d0009329b50947ce250c18ee2a85a
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-08-10 08:26:00 +00:00
Neale Ranns
404d88edce Add test of the IP unnumbered dump
Change-Id: Ic3e978faf58b43adb8a9fd0dea36eb4513fe0c64
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2018-08-10 07:47:46 +00:00
Neale Ranns
99a3c6c483 Use the bihash walk function
... rather than re-implementing the loop

Change-Id: I20bede8403c804cbec654db9b7020a4d01e5bc18
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2018-08-10 00:33:14 +00:00
andrew
df50b45e23 DOCS: General cleanup (did not move any sections)
Change-Id: I67cc42769661c10d2793f8c6cdb3b232b803d145
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
2018-08-09 18:03:05 +00:00
javierfernandezvalles
7d84c16eb6 DOCS: modified writing docs section
Change-Id: Ic3ec16dba1a6374785f25f622b2cdc9b6415a13b
Signed-off-by: javierfernandezvalles <JaviervallesF@gmail.com>
2018-08-09 18:02:42 +00:00
John DeNisco
faa9300867 DOCS: Restructure Events
Change-Id: I135ced20b58cdb72fbd0784015af037bb6e7ad28
Signed-off-by: John DeNisco <jdenisco@cisco.com>
2018-08-09 18:02:20 +00:00
John Lo
fe80c49740 Fix L2 flooding to BVI with error return not working
Change-Id: Id0b0e9bf1a7ba02144ec75783378352423f7a4b9
Signed-off-by: John Lo <loj@cisco.com>
2018-08-09 17:03:01 +00:00
Dave Barach
49433adb91 Thread-safe ARP / ND throttling
Change-Id: I810d834c407bd404d5f0544cdec0674f0bb92d31
Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: Dave Barach <dbarach@cisco.com>
2018-08-09 16:10:09 +00:00
Andrew Yourtchenko
7fad624b09 acl-plugin: fix failures in some of IPv4 test-debug testcases
Commit 1c7bf5d41737984907e8bad1dc832eb6cb1d6288 added the poisoning
of the newly freed memory in debug builds, exposing a logic
error in mask assignment code - it passed a pointer to
within a pool to a function which might potentially expand the pool.

This resulted in a failure of the test in the debug version.

Fix that by making a local copy of the value before passing
a pointer to it.

Change-Id: I73f3670672c3d86778aad0f944d052d0480cc593
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2018-08-09 15:45:03 +00:00
Yalei Wang
f7f4e399e0 Fix the fifo-size limitation in tcp_echo
Correct the size verification when send_test_chuck, tcp send process
will not be broken when avalable fifo queue size less then the
min_chuck.

Change-Id: Ide13169283c0311cf2fb18d2606bc869065a2a1b
Signed-off-by: Yalei Wang <william.wangyalei@huawei.com>
2018-08-09 15:17:54 +00:00
Ole Troan
eabd607d3a PAPI: Python 3.7 uses async keyword.
Change-Id: I01e99c85598a7cb5bc1a506c7fd1fc3f6789d72e
Signed-off-by: Ole Troan <ot@cisco.com>
2018-08-09 12:37:04 +00:00
Matus Fabian
68ba880792 NAT44: delete user with zero sessions (VPP-1282)
Change-Id: I756e3ad3de9ffe1494221ef95c1943c8591f8f50
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2018-08-09 11:59:19 +00:00
Eyal Bari
85a2555f0c bfd:fix NULL session free/put
Change-Id: If9f1f8c16c098c453bb53591e50a4cbd7cb192e4
Signed-off-by: Eyal Bari <ebari@cisco.com>
2018-08-09 11:58:14 +00:00
Juraj Sloboda
7528245795 Fix "Old Style VLA" build warnings
Change-Id: I8d42f6ed58ec34298d41edcb3d783e7e9ded3eec
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2018-08-09 07:34:25 +00:00
Korian Edeline
40e6bdfff7 fix typo in bitmap.h
Change-Id: I11587fc382a529cfd9c0971cc2ad59cd97dd6a13
Signed-off-by: Korian Edeline <korian.edeline@ulg.ac.be>
2018-08-08 16:51:47 +00:00
Neale Ranns
9da2e542c6 Remove unnecessary routes during vrf-multi-instances tests
Change-Id: I0a7fd0df90eff522366cb55ad224fe24a3121e56
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2018-08-08 14:08:17 +00:00