Drop kebab-case configuration notation #196

2021-06-30T09:27:15Z

justusbunsi commented

2021-06-30 09:27:15 +00:00

(Migrated from gitea.com)

Currently there are two different styles for defining both ldap and oauth configuration in values.yaml file: camelCase and kebab-case.
Supporting both styles created multiple regressions in the past.

⚠️ BREAKING ⚠️

These changes completely remove any support for kebab-case notation in values.yaml in favor of camelCase. Configuration keys must use camelCase.
Only exception are Kubernetes resource keys for annotations or labels.

Fixes: #188

Currently there are two different styles for defining both ldap and oauth configuration in _values.yaml_ file: `camelCase` and `kebab-case`. Supporting both styles created multiple regressions in the past. ⚠️ BREAKING ⚠️ --------------- These changes completely remove any support for `kebab-case` notation in _values.yaml_ in favor of `camelCase`. Configuration keys must use `camelCase`. Only exception are Kubernetes resource keys for annotations or labels. Fixes: #188

justusbunsi (Migrated from gitea.com) reviewed 2021-06-30 09:30:50 +00:00

luhahn (Migrated from gitea.com) approved these changes 2021-07-05 08:19:54 +00:00

luhahn (Migrated from gitea.com) left a comment

tested in my clusters, looks good

lunny (Migrated from gitea.com) approved these changes 2021-07-06 05:28:09 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#196