Non clustered redis options #559

2023-11-11T00:17:23Z

julienym commented

2023-11-11 00:17:23 +00:00

(Migrated from gitea.com)

Description of the change

Enable the options to use a standalone or replication non clustered Redis

Benefits

Cluster Redis requires 6 instances/pod, harder to start and explore the product.

Possible drawbacks

Might be missing updated documentation

Applicable issues

Additional information

⚠ BREAKING

Checklist

Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
Breaking changes are documented in the README.md
Templating unittests are added

### Description of the change Enable the options to use a standalone or replication non clustered Redis ### Benefits Cluster Redis requires 6 instances/pod, harder to start and explore the product. ### Possible drawbacks Might be missing updated documentation ### Applicable issues ### Additional information ### ⚠ BREAKING ### Checklist  - [ ] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [ ] Breaking changes are documented in the `README.md` - [ ] Templating unittests are added

pat-s commented

2023-11-16 21:02:24 +00:00

(Migrated from gitea.com)

@julienym Thanks for the request/pointer. We're currently discussing this internally and will come up with some changes/feedback in due time. Thanks for your patience.

❤️ 2

pat-s commented

2024-03-03 20:50:09 +00:00

(Migrated from gitea.com)

@julienym Sorry for the long delay!

I'd say adding a non-clustered redis is in fact a good idea, as an option for non-HA deployments. Therefore I'd suggest to use the "standalone" mode with just one replica by default - so that non-HA users can enable the option and get a minimal one-pod setup.

I'd also leave all other options to the defaults of the sub-chart. Users can always change them as needed. What is important for users is mainly the general availability of the sub-chart.

Do you want to update the version and the suggested changes from above?

@julienym Sorry for the long delay! I'd say adding a non-clustered redis is in fact a good idea, as an option for non-HA deployments. Therefore I'd suggest to use the "standalone" mode with just one replica by default - so that non-HA users can enable the option and get a minimal one-pod setup. I'd also leave all other options to the defaults of the sub-chart. Users can always change them as needed. What is important for users is mainly the general availability of the sub-chart. Do you want to update the version and the suggested changes from above?

julienym commented

2024-03-27 00:27:27 +00:00

(Migrated from gitea.com)

@pat-s Done, ran unittests and make readme too

justusbunsi commented

2024-03-27 05:33:06 +00:00

(Migrated from gitea.com)

@julienym Highly appreciate your continuing. I just skimmed over the changes. Please add unit tests to ensure correct rendering with the new options. Some useful testing scenarios:

Fail when both redis options are enabled
Render expected resources when standalone redis is enabled
Configure Gitea to Redis standalone when enabled

@julienym Highly appreciate your continuing. I just skimmed over the changes. Please add unit tests to ensure correct rendering with the new options. Some useful testing scenarios: - Fail when both redis options are enabled - Render expected resources when standalone redis is enabled - Configure Gitea to Redis standalone when enabled

👍 1

julienym commented

2024-04-03 21:53:12 +00:00

(Migrated from gitea.com)

@justusbunsi Did my best, hopefully everything is fine!