lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Storage Class don´t use global.storageClass (#601) #602

Merged
florianspk merged 5 commits from main into main 2024-01-22 09:33:08 +00:00
Conversation 1 Commits 5 Files Changed 3 +41 -4
florianspk commented 2024-01-15 17:45:36 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

The code change ensures proper usage of gitea.persistence.storageClass, improving configuration accuracy and code readability.

Applicable issues

### Description of the change The code change ensures proper usage of gitea.persistence.storageClass, improving configuration accuracy and code readability. ### Applicable issues - fixes #601
justusbunsi commented 2024-01-15 18:16:37 +00:00 (Migrated from gitea.com)
Copy Link

Good catch. Please add a unit test that covers this fix. It will ensure this does not happens again for that part of the chart. 🙂

Good catch. Please add a unit test that covers this fix. It will ensure this does not happens again for that part of the chart. 🙂
👍 1
pat-s (Migrated from gitea.com) approved these changes 2024-01-22 09:32:55 +00:00
pat-s (Migrated from gitea.com) left a comment
Copy Link

Thank you, good catch!

Thank you, good catch!
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#602
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?