phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug fix: create new log appender in applyLogPreferences() if configureLogs() didn't manage to set it earlier

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5665 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Xavier Le Vourch
2007-11-20 02:03:14 +00:00
parent 859908da80
commit 1fbc00927e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pmd-eclipse-plugin/pmd-eclipse-runtime/src/net/sourceforge/pmd/runtime/PMDRuntimePlugin.java
View File

@ -94,7 +94,7 @@ public class PMDRuntimePlugin extends AbstractUIPlugin {
*/
public void start(BundleContext context) throws Exception {
super.start(context);
configureLogs();
configureLogs(loadPreferences());
}
/**
@ -180,7 +180,9 @@ public class PMDRuntimePlugin extends AbstractUIPlugin {
Logger log = Logger.getLogger(ROOT_LOG_ID);
log.setLevel(preferences.getLogLevel());
RollingFileAppender appender = (RollingFileAppender) log.getAppender(PMD_ECLIPSE_APPENDER_NAME);
if (!appender.getFile().equals(preferences.getLogFileName())) {
if (appender == null) {
configureLogs(preferences);
} else if (!appender.getFile().equals(preferences.getLogFileName())) {
appender.setFile(preferences.getLogFileName());
appender.activateOptions();
}
@ -190,10 +192,8 @@ public class PMDRuntimePlugin extends AbstractUIPlugin {
* Configure the logging
*
*/
private void configureLogs() {
private void configureLogs(IPreferences preferences) {
try {
IPreferences preferences = loadPreferences();
Layout layout = new PatternLayout("%d{yyyy/MM/dd HH:mm:ss,SSS} %-5p %-32c{1} %m%n");
RollingFileAppender appender = new RollingFileAppender(layout, preferences.getLogFileName());