phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

minor tweaks

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7515 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Brian Remedios
2011-12-05 10:18:10 +00:00
parent 54554a5104
commit e2fe6d1621
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java
View File

@ -1,5 +1,7 @@
package net.sourceforge.pmd.eclipse.ui.actions;
import java.util.List;
import name.herlin.command.CommandException;
import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
import net.sourceforge.pmd.eclipse.runtime.cmd.RenderReportsCmd;
@ -39,10 +41,17 @@ public class GenerateReportAction extends AbstractUIAction {
}
private boolean checkRenderers() {
List<Renderer> renderers = ReportManager.instance.activeRenderers();
if (renderers.isEmpty()) {
PMDPlugin.getDefault().showUserError("No report renderers selected");
return false;
}
StringBuilder errors = new StringBuilder();
for (Renderer renderer : ReportManager.instance.activeRenderers()) {
for (Renderer renderer : renderers) {
String issue = renderer.dysfunctionReason();
if (StringUtil.isNotEmpty(issue)) {
errors.append(renderer.getName()).append(": ");

5
pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/reports/ReportPreferencesPage.java
View File

@ -1,11 +1,7 @@
package net.sourceforge.pmd.eclipse.ui.reports;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.Set;
import net.sourceforge.pmd.PropertyDescriptor;
@ -20,7 +16,6 @@ import net.sourceforge.pmd.eclipse.ui.preferences.br.ValueChangeListener;
import net.sourceforge.pmd.eclipse.ui.preferences.panelmanagers.FormArranger;
import net.sourceforge.pmd.eclipse.ui.preferences.panelmanagers.PerRulePropertyPanelManager;
import net.sourceforge.pmd.renderers.Renderer;
import net.sourceforge.pmd.util.IOUtil;
import net.sourceforge.pmd.util.StringUtil;
import org.eclipse.jface.preference.PreferencePage;