Compare commits

...
Author SHA1 Message Date
Andreas Dangel ef34553486 [maven-release-plugin] prepare release pmd_releases/6.55.0 2023-02-25 11:50:49 +01:00
Andreas Dangel b491afc628 Prepare pmd release 6.55.0 2023-02-25 11:38:40 +01:00
Andreas Dangel 1abf8e063a Merge pull request #4407 from adangel:pmd6-release-notes-6.55.0
[doc] Update release notes - last pmd6 release, pmd7 development #4407
2023-02-25 11:33:31 +01:00
Andreas Dangel 8bdfc9538b Merge pull request #4377 from adangel:pmd6-java-20
[java] Add support for java 20 #4377
2023-02-23 11:34:37 +01:00
Andreas Dangel 2db7255035 Merge pull request #4395 from adangel:pmd6-support-env-CLASSPATH
[core] Support environment variable CLASSPATH with pmd.bat under Windows #4395
2023-02-23 11:26:51 +01:00
Andreas Dangel 794263c463 [doc] Update release notes - last pmd6 release, pmd7 development 2023-02-23 11:23:38 +01:00
Juan Martín Sotuyo Dodero 67c8daaf25 Merge pull request #4398 from adangel/pmd6-cpd-usage-text
[doc] CPD - use non deprecated `--dir` cli option
2023-02-21 19:22:06 -03:00
Andreas Dangel 17364a997b [doc] CPD - use non deprecated --dir cli option 2023-02-17 11:39:03 +01:00
Andreas Dangel a74bf9665f [doc] Update gitter urls, update codacy badge 2023-02-17 09:12:32 +01:00
Andreas Dangel af6d502afb Merge pull request #4390 from pguyot:w06/add_support_for_tsql
Add support for T-SQL using Antlr4 lexer #4390
2023-02-16 19:43:52 +01:00
Andreas Dangel 961c96d447 [doc] Update release notes (#4390) 2023-02-16 19:24:32 +01:00
Andreas Dangel f2cae1d383 Merge branch 'master' into pr-4390 2023-02-16 18:58:54 +01:00
Andreas Dangel d4d7f4b75b Add CaseChangingCharStream for t-sql, downgrade antlr 2023-02-16 18:55:47 +01:00
Andreas Dangel b5ea31d53f [core] Support environment variable CLASSPATH with pmd.bat under Windows 2023-02-16 16:40:24 +01:00
Andreas Dangel 62f2970946 Merge pull request #4392 from dawiddc:issue4224
[java] Fix #4393 MissingStaticMethodInNonInstantiatableClass: Fix false-positive for field-only class #4392
2023-02-16 10:53:52 +01:00
Andreas Dangel d129e29fc8 [doc] Update release notes (#4393, #4392) 2023-02-16 10:52:09 +01:00
Andreas Dangel 1eeb045e17 Add @dawiddc as a contributor 2023-02-16 10:49:29 +01:00
Dawid Ciok af7640f136 [java] Fix #4393 MissingStaticMethodInNonInstantiatableClass: Fix false-positive for field-only class 2023-02-16 10:48:32 +01:00
Paul Guyot c9b19b680a [TSql] Move files & classes according to new layout 2023-02-16 08:24:03 +01:00
Paul Guyot d20592ba63 Add support for T-SQL using Antlr4 lexer 2023-02-10 11:33:58 +01:00
Andreas Dangel c4ee830721 Merge pull request #4386 from adangel:pmd6-update-version
Update versions #4386
2023-02-10 09:36:33 +01:00
Juan Martín Sotuyo Dodero bc3d9b24ad Merge pull request #4374 from adangel/pmd6-deprecate-go-language-module
[go] Deprecate GoLanguageModule
2023-02-09 13:40:02 -03:00
Andreas Dangel e10cf6a4ff Merge pull request #4384 from openium:master
[swift] Add more swift 5.x support (#unavailable mainly) #4384
2023-02-09 10:54:04 +01:00
Andreas Dangel 300c32a1a4 [doc] Update release notes (#4384) 2023-02-09 10:53:31 +01:00
Andreas Dangel ea0b8ff904 Fixups from #4384 2023-02-09 10:51:24 +01:00
Andreas Dangel c1170e76e2 Bump maven-gpg-plugin from 1.6 to 3.0.1 2023-02-09 09:48:09 +01:00
Andreas Dangel 8e7e4a46bb Bump maven-deploy-plugin from 3.0.0 to 3.1.0 2023-02-09 09:48:09 +01:00
Andreas Dangel 36ad68eb58 Remove reporting section
The site lifecycle is not used for a long time now
in PMD, so we don't need to configure a reporting
section.
2023-02-09 09:48:03 +01:00
Andreas Dangel 427f0cab43 Bump maven-enforcer-plugin from 3.1.0 to 3.2.1 2023-02-09 09:22:09 +01:00
Andreas Dangel b859115627 Bump ant from 1.10.12 to 1.10.13 2023-02-09 09:21:47 +01:00
Andreas Dangel bc33a222ea Bump checkstyle from 10.6.0 to 10.7.0 2023-02-09 09:21:29 +01:00
Andreas Dangel 34add58c41 Bump kotest from 5.5.4 to 5.5.5 2023-02-09 09:21:13 +01:00
Andreas Dangel e779e8676f Bump maven from 3.8.6 to 3.9.0 2023-02-09 09:10:23 +01:00
kenji a10662731b Add more swift 5.x support (#unavalaible mainly) 2023-02-07 20:50:08 +01:00
Andreas Dangel ae55297984 Update javadoc 2023-02-04 20:09:21 +01:00
Andreas Dangel 2e0b6292b6 [doc] Update release notes (#4333) 2023-02-03 20:05:25 +01:00
Andreas Dangel e80e4cf204 [java] Fix javadoc warnings 2023-02-03 20:03:32 +01:00
Andreas Dangel 3ac021da02 [java] Remove support for named record patterns 2023-02-03 19:54:19 +01:00
Andreas Dangel 4ec06b71fe [java] Add more examples for record patterns 2023-02-03 19:48:12 +01:00
Andreas Dangel 600ad870db [java] Support record patterns in for-each loops 2023-02-03 19:37:28 +01:00
Andreas Dangel 50cdb99a7f [java] Update sample files for Pattern Matching for switch 2023-02-03 18:49:50 +01:00
Andreas Dangel 36fb459bd9 [java] Correct grammar regarding default case label
Update ExhaustiveSwitch so that it compiles with java 20. "case default" is not allowed anymore.
2023-02-03 17:09:58 +01:00
Andreas Dangel 1843ff51c7 [java] Simplify null case label grammar
Update DealingWithNull to that it compiles with java 20. Some cases are not allowed anymore.
2023-02-03 16:41:19 +01:00
Andreas Dangel b07c5ae152 Remove old exclusions in all-java.xml 2023-02-03 15:52:44 +01:00
Andreas Dangel 35a11574ed [java] Remove language version 18-preview 2023-02-03 15:49:19 +01:00
Andreas Dangel 6f89a7f4a4 Bump org.ow2.asm:asm from 9.3 to 9.4 2023-02-03 15:01:28 +01:00
Andreas Dangel c46a2d31bf [java] Add new language versions 20 and 20-preview 2023-02-03 14:55:43 +01:00
Andreas Dangel 016afb96e3 [go] Deprecate GoLanguageModule 2023-02-03 14:29:11 +01:00
Andreas Dangel c3b1317a77 Update gems 2023-02-02 09:37:17 +01:00
Andreas Dangel 49d35d0973 Bump pmd from 6.53.0 to 6.54.0 2023-01-28 10:55:19 +01:00
Andreas Dangel 625a1cc7f0 Prepare next development version [skip ci] 2023-01-28 10:51:02 +01:00
Andreas Dangel 5772440a79 [maven-release-plugin] prepare for next development iteration 2023-01-28 10:31:53 +01:00
Andreas Dangel de1b12b060 [maven-release-plugin] prepare release pmd_releases/6.54.0 2023-01-28 10:31:46 +01:00
Andreas Dangel cb031625e8 Prepare pmd release 6.54.0 2023-01-28 10:18:27 +01:00
Andreas Dangel aa64a5e3f0 Add @hassanalamibmx as a contributor 2023-01-27 09:12:36 +01:00
Andreas Dangel c473634e26 Add @liamsharp as a contributor 2023-01-27 09:11:49 +01:00
Andreas Dangel 8d6068b123 Merge pull request #4366 from Monits:fix-4346
[java] Fix broken TextBlock grammar #4366
2023-01-27 09:10:29 +01:00
Juan Martín Sotuyo Dodero 3e29407ebe Update changelog 2023-01-26 19:40:24 -03:00
Juan Martín Sotuyo Dodero 0883b186ee Update token id
- The grammar now produces IDENTIFIER as token 74, and TEXT_BLOCK as 72
2023-01-26 19:36:37 -03:00
Juan Martín Sotuyo Dodero 312ebc173d Allow the escapes new line sequence 2023-01-26 19:36:20 -03:00
Juan Martín Sotuyo Dodero 619e014d0d Properly define TEXT_BLOCK tokens 2023-01-26 18:59:55 -03:00
Juan Martín Sotuyo Dodero 390b040432 Fix TextBlock grammar 2023-01-26 16:43:30 -03:00
Juan Martín Sotuyo Dodero 146f9077d2 Add failing test case for #4364 2023-01-26 16:42:49 -03:00
Juan Martín Sotuyo Dodero 30a01c4f33 Merge branch 'pr-4214' 2023-01-26 13:16:54 -03:00
Andreas Dangel 614a574292 Bump build-tools from 19/20-SNAPSHOT to 20 2023-01-26 15:32:15 +01:00
Andreas Dangel 7d56432d53 Fix release notes 2023-01-26 14:38:23 +01:00
Andreas Dangel 4208182058 Bump maven-release-plugin from 3.0.0-M1 to 3.0.0-M7 2023-01-26 14:22:37 +01:00
Andreas Dangel 5e023b097a Bump maven-dependency-plugin from 3.1.2 to 3.5.0 2023-01-26 14:22:05 +01:00
Andreas Dangel 10150667b7 Bump maven-assembly-plugin from 3.2.0 to 3.4.2 2023-01-26 14:21:38 +01:00
Andreas Dangel cdb64ff1c5 Bump maven-antrun-plugin from 1.8 to 3.1.0 2023-01-26 14:21:18 +01:00
Andreas Dangel e1077ae1e3 Bump maven-clean-plugin from 3.1.0 to 3.2.0 2023-01-26 13:50:13 +01:00
Andreas Dangel 4d072aabc9 Bump maven-project-info-reports-plugin from 2.9 to 3.4.2 2023-01-26 13:35:12 +01:00
Andreas Dangel aae7e544ab Bump maven-jxr-plugin from 2.5 to 3.3.0 2023-01-26 13:34:23 +01:00
Andreas Dangel 91a3aea133 Bump jacoco-maven-plugin from 0.8.5 to 0.8.8 2023-01-26 13:33:45 +01:00
Andreas Dangel 96b7f47daf Bump nexus-staging-maven-plugin from 1.6.8 to 1.6.13 2023-01-26 13:33:17 +01:00
Andreas Dangel 60ff1746a5 Bump versions-maven-plugin from 2.5 to 2.14.2 2023-01-26 13:32:41 +01:00
Andreas Dangel 6c83e2a0c3 Bump maven-site-plugin from 4.0.0-M1 to 4.0.0-M4 2023-01-26 13:32:01 +01:00
Andreas Dangel 09d10ae51d Bump maven-failsafe-plugin from 2.19.1 to 3.0.0-M8 (surefire.version) 2023-01-26 13:31:30 +01:00
Andreas Dangel 9b2e9b2696 Bump maven-enforcer-plugin from 3.0.0 to 3.1.0 2023-01-26 13:30:09 +01:00
Andreas Dangel d6f6d73f1c Bump build-helper-maven-plugin from 3.0.0 to 3.3.0 2023-01-26 13:29:14 +01:00
Andreas Dangel 3ef506f9be Bump maven-shade-plugin from 3.2.3 to 3.4.1 2023-01-26 13:28:00 +01:00
Andreas Dangel f60ce583f2 Bump maven-resources-plugin from 3.1.0 to 3.3.0 2023-01-26 13:27:35 +01:00
Andreas Dangel ecb7b17bae Bump maven-jar-plugin from 3.2.0 to 3.3.0 2023-01-26 13:27:12 +01:00
Andreas Dangel 647cfe9d91 Bump maven-install-plugin from 2.5.2 to 3.1.0 2023-01-26 13:26:43 +01:00
Andreas Dangel d239b8b0a9 Bump maven-deploy-plugin from 2.8.2 to 3.0.0 2023-01-26 13:26:15 +01:00
Andreas Dangel 7f89335f6d Bump maven-compiler-plugin from 3.8.1 to 3.10.1 2023-01-26 13:25:54 +01:00
Andreas Dangel 84d2a1f9ac Bump checkstyle from 10.3.3 to 10.6.0 2023-01-26 13:25:05 +01:00
Andreas Dangel 54e300dc01 Bump maven-javadoc-plugin from 3.2.0 to 3.4.1 2023-01-26 13:24:28 +01:00
Andreas Dangel 2d7049eae3 Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 2023-01-26 13:24:19 +01:00
Andreas Dangel d1fe9e1429 Bump maven-pmd-plugin from 3.19.0 to 3.20.0 2023-01-26 13:22:44 +01:00
Andreas Dangel 436dce2641 [scala] Fix javadoc configuration for dokka/pmd-lang-test 2023-01-26 11:33:35 +01:00
Andreas Dangel 473241b241 Merge pull request #4329 from adangel:refactor-snakeyml
[core] Refactor usage of snakeyaml #4329
2023-01-26 11:16:17 +01:00
Andreas Dangel f5cb8d97d7 Merge pull request #4125 from mohan-chinnappan-n:master
[core] New report format html-report-v2.xslt to provide html with datatable and chart features #4125
2023-01-26 11:13:49 +01:00
Andreas Dangel 1b6cba7f16 [doc] Update release notes (#4125) 2023-01-26 11:12:51 +01:00
Andreas Dangel 540a7374fb Merge pull request #4110 from tprouvot:feature/unusedVariableBindFalsePositive
[apex] Feature/unused variable bind false positive with dynamic SOQL #4110
2023-01-26 11:03:06 +01:00
Andreas Dangel aa24ae7d25 [doc] Update release notes (#2669, #4110) 2023-01-26 11:02:33 +01:00
Andreas Dangel cc4d83d279 Deprecate PMDConfiguration#reportShortNames 2023-01-25 16:40:04 +01:00
Juan Martín Sotuyo Dodero 87220c05e6 Merge pull request #4336 from adangel/deprecations-for-4235
[core] Deprecations in CPDConfiguration, Base(CPD)CLITest, AbstractAntTestHelper
2023-01-25 12:18:26 -03:00
Andreas Dangel 8eabce2f6f Follow symlinks when collecting source files
Verify behavior with symlinks and relativize paths with.
2023-01-25 13:33:43 +01:00
Andreas Dangel a93b45c040 [doc] Update doc for --relativize-paths-with regarding absolute paths 2023-01-25 13:02:06 +01:00
Andreas Dangel 8a85295e49 Verify behavior with no relativize paths and absolute/relative src dirs 2023-01-25 12:07:07 +01:00
Andreas Dangel 7619693102 Revert "Update gems, update activesupport"
This reverts commit 460d6a0809.
2023-01-25 10:30:35 +01:00
Andreas Dangel b6062ca1fd Fixups from review (#4336) 2023-01-25 09:53:43 +01:00
Andreas Dangel 460d6a0809 Update gems, update activesupport
Fixes https://github.com/pmd/pmd/security/dependabot/35
Fixes https://github.com/advisories/GHSA-j6gc-792m-qgm2
2023-01-25 09:46:26 +01:00
Andreas Dangel 9d92528587 Update bundler 2023-01-25 08:56:17 +01:00
Andreas Dangel 6b2f1be14e Update gems
Fixes https://github.com/pmd/pmd/security/dependabot/35
Fixes CVE-2023-22796
Fixes https://github.com/advisories/GHSA-j6gc-792m-qgm2

Fixes https://github.com/pmd/pmd/security/dependabot/36
Fixes https://github.com/advisories/GHSA-636f-xm5j-pj9m
2023-01-25 08:48:34 +01:00
Andreas Dangel 599e0b6a75 [doc] Update release notes (#4236) 2023-01-25 08:44:02 +01:00
Juan Martín Sotuyo Dodero 39c62fca7f Merge pull request #4343 from adangel/cpd-renderer
[core] CPD - implement CPDReportRenderer for all renderers
2023-01-24 16:53:37 -03:00
Juan Martín Sotuyo Dodero e6696a3f7e Merge branch 'pr-4341' 2023-01-24 12:51:18 -03:00
Juan Martín Sotuyo Dodero 453d2282fc Merge branch 'pr-4300' 2023-01-24 12:39:24 -03:00
Juan Martín Sotuyo Dodero d3c576fd0d Update release notes 2023-01-24 12:39:10 -03:00
Andreas Dangel e65fddff82 [core] FileCollector - add back addZipFile() as deprecated method 2023-01-24 16:37:06 +01:00
Juan Martín Sotuyo Dodero 61ecf4c500 Merge pull request #4346 from adangel/issue-4236-kotest
[testing] Use custom surefire console reporter
2023-01-24 12:32:55 -03:00
Andreas Dangel cf1dd6e902 Small fixes in PMDParameters 2023-01-24 16:13:22 +01:00
Andreas Dangel 0b4cc1e5bb [ant] Make relativizePathsWith a path-like structure
Update documentation
2023-01-24 15:52:36 +01:00
Andreas Dangel 74e6f85a50 Fix tests under Windows 2023-01-24 12:10:05 +01:00
Andreas Dangel fed44709c7 Test deprecation warning for --short-names 2023-01-24 11:41:51 +01:00
Andreas Dangel e9baa5b931 [doc] Update CLI reference for new --relativize-paths-with 2023-01-24 11:35:55 +01:00
Andreas Dangel 81bfed2ef7 Fix unit tests 2023-01-24 10:55:11 +01:00
Andreas Dangel faf3b6ebf9 Merge branch 'master' into pr-4214 2023-01-24 10:46:14 +01:00
Andreas Dangel e2d6325841 Update dependencies 2023-01-24 10:17:49 +01:00
Andreas Dangel e05bc041f7 Added category other 2023-01-24 09:42:41 +01:00
Andreas Dangel cc4c672f43 Add example of html-report-v2 for documentation 2023-01-23 16:38:38 +01:00
Andreas Dangel c99e9cff81 Use jQuery to count violations 2023-01-23 16:29:14 +01:00
Andreas Dangel 6c76387112 Rename rule/ruleset -> category, display rule name 2023-01-23 15:36:31 +01:00
Andreas Dangel d4ee2a6f33 [cli] Use non-deprecated long options for PMD cli examples 2023-01-23 15:27:36 +01:00
Andreas Dangel 85375d0850 Remove previous pmd-report-v2.xslt 2023-01-23 15:12:06 +01:00
Andreas Dangel cfddd700e9 Fix indentation 2023-01-23 15:10:38 +01:00
Andreas Dangel 25e0a7bd30 Fix mapping of rulesets 2023-01-23 15:10:14 +01:00
Andreas Dangel a03a55ba44 [apex] Enhance UnusedLocalVariable to consider SOQL binding vars
Fixes #2669
2023-01-23 14:47:35 +01:00
Thomas Prouvot cd88b367ab Add test to check if false positive is fixed 2023-01-23 14:46:38 +01:00
Andreas Dangel b59808f04f Use custom surefire console reporter from build tools 2023-01-20 20:17:58 +01:00
Andreas Dangel de1c886c2a Bump build-tools from 19 to 20-SNAPSHOT 2023-01-20 20:17:57 +01:00
Andreas Dangel eff73bdb0b Fix wrong junit-platform-commons version 2023-01-20 20:17:57 +01:00
Andreas Dangel ac2e4d881b Bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8
Remove forkMode option as it doesn't exist anymore
2023-01-20 20:17:42 +01:00
Andreas Dangel 67c04ef42b Refactor ParserTestSpec to not depend on internal kotest API
This adds custom test scopes and makes the ParserTestCtx a container.
2023-01-20 20:10:38 +01:00
Andreas Dangel bc7b0f8e2f Fix missing package for Java11Test 2023-01-20 20:09:05 +01:00
Andreas Dangel d6ef489dd1 Fix ASTPatternTest to have leaf test nodes 2023-01-19 20:18:13 +01:00
Andreas Dangel 125edb4fed [core] CPD - implement CPDReportRenderer for all renderers 2023-01-19 16:24:55 +01:00
Andreas Dangel 774a8fbadf [ci] Add additional repository for spring-framework-build
Add https://maven.repository.redhat.com/ga/ as repository in order to resolve
dependency com.ibm.websphere/uow/6.0.2.17
See https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020
2023-01-19 14:02:16 +01:00
Andreas Dangel 26a57156a1 [core] Add CPDReport#filterMatches
Fixes #4340
2023-01-18 09:38:59 +01:00
Andreas Dangel bab2e6f9ab [core] Deprecate some fields in AbstractAntTestHelper
Refs #4155
2023-01-17 11:53:10 +01:00
Andreas Dangel aa06344d87 [core] Deprecate BaseCPDCLITest 2023-01-17 10:58:53 +01:00
Andreas Dangel 3dcecb6b55 [test] Deprecate BaseCLITest 2023-01-17 09:00:48 +01:00
Andreas Dangel 7c428db062 [core] Deprecate get/setEncoding on CPDConfiguration 2023-01-17 09:00:28 +01:00
mohan-chinnappan-n cd59f45023 Create html-report-v2.xslt
XLST for creating HTML reports
2023-01-16 20:42:28 -05:00
mohan-chinnappan-n 6d142a445a Merge branch 'pmd:master' into master 2023-01-16 20:40:39 -05:00
Andreas Dangel 77b4970de8 Add webrick as gem dependency (jekyll/jekyll#8523) 2023-01-16 11:34:41 +01:00
Andreas Dangel 8b7b0c7d5c [core] Internalize CSVWriter 2023-01-16 10:47:34 +01:00
Andreas Dangel 10c281824e [java] Verify rule violation message for JUnitTestContainsTooManyAsserts and RedundantFieldInitializer
These contain placeholder like ${variableName} which should
be replaced by the actual value.
2023-01-16 10:01:56 +01:00
mohan-chinnappan-n dc0f816098 Merge branch 'pmd:master' into master 2023-01-14 12:08:20 -05:00
Andreas Dangel d73095a69f [ci] Build and create baseline for experimental-apex-parser branch 2023-01-14 11:45:48 +01:00
Andreas Dangel 5a8f8f06e7 Merge pull request #4280 from aaronhurst-google:deprecate-apex-version
[apex] Deprecate ApexRootNode.getApexVersion #4280
2023-01-14 11:00:53 +01:00
Andreas Dangel 8985c9dbf3 [doc] Update release notes (#4280) 2023-01-14 11:00:27 +01:00
Andreas Dangel 33315c498e [core] Refactor usage of snakeyaml
It was a dependency via apex-jorje, but there snakeyaml is actually not needed.

During generating doc, we use snakeyaml to load the sidebar and modify it. The code has been adjusted to use SafeConstructor to mitigate the risk.

Fixes https://github.com/pmd/pmd/security/dependabot/33
Fixes CVE-2022-1471
Fixes https://github.com/advisories/GHSA-mjmj-j48q-9wg2
2023-01-12 19:18:27 +01:00
Andreas Dangel 611cb94b7a [core] Allow empty values for rule properties
Fixes #4279
2023-01-11 09:11:43 +01:00
Andreas Dangel 89b947bec5 Update gems
Fixes https://github.com/pmd/pmd/security/dependabot/34
Fixes CVE-2022-46648
Fixes https://github.com/advisories/GHSA-pfpr-3463-c6jh
2023-01-10 12:21:27 +01:00
Andreas Dangel 6c336b37e4 Merge pull request #4285 from mluckam:elasticsearch_visiblefortesting
[java] CommentDefaultAccessModifier - add co.elastic.clients.util.VisibleForTesting as default suppressed annotation #4285
2023-01-10 10:26:00 +01:00
Andreas Dangel 11a33a536d [java] CommentDefaultAccessModifier - extend test case for junit5
Refs #3859
2023-01-10 10:24:47 +01:00
Andreas Dangel 60d46d4234 [doc] Update release notes (#4285) 2023-01-10 09:51:59 +01:00
Andreas Dangel a388d8466f Add @mluckam as a contributor 2023-01-10 09:50:01 +01:00
Matthew LuckamandAndreas Dangel f6504a6875 add more accurate test description
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2023-01-09 10:17:47 -05:00
Matthew Luckam de4fb8239f add co.elastic.clients.util.VisibleForTesting to collection of default
suppressed annotations for rule CommentDefaultAccessModifierRule
2023-01-09 10:17:37 -05:00
Aaron Hurst 0715bd91d5 Remove unused imports. 2023-01-05 13:39:17 +00:00
Aaron Hurst f0137f2907 Deprecate ApexRootNode.getApexVersion.
Assume Apex version is >= V176.
2023-01-03 22:42:49 +00:00
Andreas Dangel 14b39cee83 Bump pmd from 6.52.0 to 6.53.0 2022-12-31 18:25:42 +01:00
Andreas Dangel 3cdf1f2c74 Prepare next development version [skip ci] 2022-12-31 18:23:24 +01:00
Andreas Dangel 6a6acb9b43 [maven-release-plugin] prepare for next development iteration 2022-12-31 18:22:10 +01:00
Andreas Dangel 37103451bf [maven-release-plugin] prepare release pmd_releases/6.53.0 2022-12-31 18:22:04 +01:00
Andreas Dangel 349c89240a Prepare pmd release 6.53.0 2022-12-31 18:07:28 +01:00
Andreas Dangel f0e113c376 Merge pull request #4274 from kdebski85:issue-4266-compact-constructor-with-lambda
[java] Fix finding lambda scope in record compact constructor #4274
2022-12-31 15:35:47 +01:00
Andreas Dangel ebefb36c73 [doc] Update release notes (#4266, #4274) 2022-12-31 15:34:36 +01:00
Andreas Dangel d0367d0248 Add @kdebski85 as a contributor 2022-12-31 15:33:00 +01:00
Andreas Dangel 62d789526a [java] DoNotUseThreads: more tests 2022-12-31 15:30:57 +01:00
Andreas Dangel 11867b0d3d Merge pull request #4265 from adangel:issue-4164-AvoidAssertAsIdentifier
[java][doc] AvoidAssertAsIdentifier and AvoidEnumAsIdentifier - clarify use case #4265
2022-12-31 15:13:19 +01:00
Andreas Dangel 3dd0f84ef6 Merge pull request #4264 from adangel:issue-4250-WhileLoopWithLiteralBoolean
[java] WhileLoopWithLiteralBoolean - don't limit to two bool literals #4264
2022-12-31 15:11:09 +01:00
Andreas Dangel b81df9681e Merge pull request #4262 from adangel:issue-2127-deprecate-excessive-length-rules
[java] Deprecate rules ExcessiveClassLength and ExcessiveMethodLength #4262
2022-12-31 15:09:40 +01:00
Andreas Dangel 67230ed7b0 Merge pull request #4260 from adangel:issue-4166-UnusedPrivateField-annotations
[java] UnusedPrivateField - add new property reportForAnnotations #4260
2022-12-31 15:07:12 +01:00
Andreas Dangel 0dcefd174c Merge pull request #4249 from adangel:issue-4248-zip-files
[core] Use jar filesystem provider for zip files #4249
2022-12-31 15:05:09 +01:00
Andreas Dangel 15cba772ac Merge pull request #4247 from adangel:issue-4210-DoNotUseThreads-duplicated-violations
[java] DoNotUseThreads: Fix duplicated violations reporting #4247
2022-12-31 15:03:13 +01:00
Krzysztof Debski c714806447 [java] Fix finding lambda scope in record compact constructor 2022-12-28 10:37:58 +01:00
Andreas Dangel a76603b026 Merge pull request #4244 from Tarush-Singh35:#4146
[apex] ApexCRUDViolation: user mode and system mode with test cases added #4244
2022-12-19 16:17:45 +01:00
Andreas Dangel 2cdef852c5 [java][doc] AvoidAssertAsIdentifier and AvoidEnumAsIdentifier - clarify use case
Fixes #4164
2022-12-19 16:13:11 +01:00
Andreas Dangel 87c991f31d [java] DoNotUseThreads: Fix false negatives with field declarations
in anonymous classes
2022-12-19 15:55:22 +01:00
Andreas Dangel c2de15e4c5 [java] WhileLoopWithLiteralBoolean - fix false positives 2022-12-19 15:26:43 +01:00
Andreas Dangel d7bab260b3 [java] WhileLoopWithLiteralBoolean - don't limit to two bool literals
Fixes #4250
2022-12-17 19:58:47 +01:00
Andreas Dangel 8e72aaf9ab PR review fixups 2022-12-17 18:38:20 +01:00
Andreas Dangel bef608058b [java] UnusedPrivateField - rename property "reportForAnnotations"
And other PR review fixups
2022-12-17 18:20:14 +01:00
Andreas Dangel 03db70602f [doc] Update release notes (#4146, #4244) 2022-12-16 19:19:59 +01:00
Andreas Dangel 4efbbdd41a Add @Tarush-Singh35 as a contributor 2022-12-16 19:19:36 +01:00
Andreas Dangel 930b77876b [apex] ApexCRUDViolation - support AccessLevel
Also support more DML methods: *async and *immediate
2022-12-16 18:58:31 +01:00
Andreas Dangel 93e768319c [apex] ApexCRUDViolation - no violation for explicit system mode 2022-12-16 17:45:58 +01:00
Andreas Dangel 637663212e [apex] ApexCRUDViolation - fix rule tests 2022-12-16 16:06:11 +01:00
Andreas Dangel 47128c8b99 Bump build-tools from 18 to 19 2022-12-15 18:45:04 +01:00
Tarush Singh 1ce1a2fcef Simple change in voilation check 2022-12-15 00:58:59 +05:30
Andreas Dangel 0f9a0f4876 [java] Update quickstart.xml - remove deprecated Excessive*Length rules 2022-12-09 20:37:44 +01:00
Andreas Dangel 7237d0c076 [doc] Consistently document deprecated and renamed rules 2022-12-09 20:37:23 +01:00
Andreas Dangel e8510fa7da [java] Deprecate base class ExcessiveLengthRule 2022-12-09 20:32:58 +01:00
Andreas Dangel 330594d51d [java] Deprecate rules ExcessiveClassLength and ExcessiveMethodLength
Fixes #2127
2022-12-09 15:23:56 +01:00
Andreas Dangel 5a3ff840aa [java] UnusedPrivateField - add new property "annotations"
Fixes #4166
2022-12-08 19:03:29 +01:00
Andreas Dangel 9f5bd42d43 Update gems
Fixes https://github.com/pmd/pmd/security/dependabot/31
Fixes CVE-2022-23476
Fixes https://github.com/advisories/GHSA-qv4q-mr5r-qprj
2022-12-08 11:41:02 +01:00
Andreas Dangel 124c4fd281 [doc] Update release notes (#4248) 2022-12-08 11:38:11 +01:00
Andreas Dangel 827221d874 [doc] Clarify documentation about analyzing zip files 2022-12-08 11:37:56 +01:00
Andreas Dangel ce12835d36 Add integration tests for zip/jar files 2022-12-08 11:37:35 +01:00
Andreas Dangel a9fb6f604e Add additional test for jar files 2022-12-08 11:37:16 +01:00
Andreas Dangel 94e6fb55e3 Fix test under Windows (again) 2022-12-08 10:20:08 +01:00
Juan Martín Sotuyo Dodero 3f525dfdbb Merge pull request #4256 from pmd/doc-fix-use-version
[doc] Fix doc showing deprecated CLI switches
2022-12-07 10:37:27 -03:00
Clément Fournier a377f07b9c Fix doc showing deprecated CLI switches 2022-12-07 11:14:40 +01:00
Andreas Dangel 5c935b8cae Fix test under Windows 2022-12-02 17:41:25 +01:00
Andreas Dangel 9942be4107 [core] Better handle display name for zip files
Hopefully restored backwards compatible behavior
for File based data sources (see getNiceFileName).
2022-12-02 17:04:24 +01:00
Andreas Dangel dc4f8d4cac [core] Better handle display name for zip files
Now the reporting format is "file.zip!/path/inside".
Previously it was "file.zip:path/inside"
(see ZipDateSource::getNiceFilename)
2022-12-01 22:41:33 +01:00
Andreas Dangel eb7c2e5468 [java] DoNotUseThreads: Fix false negatives with field declarations 2022-12-01 21:48:30 +01:00
Andreas Dangel 9d0bf66ee1 [core] Use jar filesystem provider for zip files
Fixes #4248
2022-12-01 18:40:36 +01:00
Andreas Dangel a3b95bec47 [java] DoNotUseThreads: Fix duplicated violations reporting
Fixes #4210
2022-12-01 17:31:00 +01:00
Tarush Singh efd83665dc Simple change in voilation check 2022-12-01 17:52:48 +05:30
Tarush Singh bce0331fe7 check added for User and system mode in validateCRUDCheckPresent 2022-12-01 16:51:43 +05:30
Tarush Singh 73b95b2e92 check added for User and system mode in validateCRUDCheckPresent 2022-12-01 16:49:42 +05:30
Tarush Singh 1ce646a535 check added for User and system mode in validateCRUDCheckPresent 2022-12-01 16:17:11 +05:30
Tarush Singh 0253929cc5 user mode and System mode with test cases added 2022-11-29 17:05:33 +05:30
Andreas Dangel 30b78ddec3 Bump pmd from 6.51.0 to 6.52.0 2022-11-26 10:31:25 +01:00
Andreas Dangel c1390d219f Prepare next development version [skip ci] 2022-11-26 10:27:01 +01:00
Andreas Dangel 1634bd0043 [maven-release-plugin] prepare for next development iteration 2022-11-26 10:24:58 +01:00
Andreas Dangel e90bf0f11b [maven-release-plugin] prepare release pmd_releases/6.52.0 2022-11-26 10:24:53 +01:00
Andreas Dangel 6f64edf714 Prepare pmd release 6.52.0 2022-11-26 10:10:14 +01:00
Andreas Dangel 9c42eba8b5 Add @nvervelle as a contributor 2022-11-25 19:26:15 +01:00
Andreas Dangel 335a12fe1b Add @mihalyr as a contributor 2022-11-25 19:25:41 +01:00
Andreas Dangel 8f2ce2408e Add @ctoomey as a contributor 2022-11-25 19:25:16 +01:00
Andreas Dangel 8b71fe6fd6 Merge pull request #4231 from adangel:issue-4175-ImmutableField-deprecate-ignoredAnnotations
[java] ImmutableField - deprecate property ignoredAnnotations #4231
2022-11-25 18:44:59 +01:00
Andreas Dangel 93587f0b1f Merge pull request #4203 from adangel:issue-4177-InvalidJavaBean
[java] New Rule InvalidJavaBean #4203
2022-11-25 18:38:41 +01:00
Andreas Dangel 9be37acaeb Merge pull request #4196 from adangel:issue-4176-NonSerializableClass
[java] Implement rule NonSerializableClass #4196
2022-11-25 18:32:38 +01:00
Andreas Dangel 8a5d964176 [java] Restore BeanMembersShouldSerializeRule as deprecated class 2022-11-25 18:30:39 +01:00
Andreas Dangel 44cc43ce2b Merge pull request #4232 from deining:fix/typos
[doc] Fixing typos #4232
2022-11-25 18:26:02 +01:00
Andreas Dangel db6a30c88a [doc] Update release notes (#4232) 2022-11-25 18:25:07 +01:00
Andreas Dangel afa4e70c8a Add @deining as a contributor 2022-11-25 18:24:54 +01:00
Andreas Dangel a5cce75038 Merge pull request #4227 from LynnBroe:issue4225
[java] Fix #4225 MissingStaticMethodInNonInstantiatableClass: Exclude lombok's @NoArgsConstructor annotation #4227
2022-11-25 18:14:25 +01:00
Andreas Dangel ddb60c51ac [doc] Update release notes (#4225, #4227) 2022-11-25 17:59:19 +01:00
Andreas Dangel 1cecabcec4 [java] MissingStaticMethodInNonInstantiatableClass - update test cases 2022-11-25 17:57:31 +01:00
Andreas Dangel cb7c07f365 Merge pull request #4228 from LynnBroe:issue4224
[java] Fix #4224 MissingStaticMethodInNonInstantiatableClass: Exclude lombok's UtilityClass #4228
2022-11-25 17:51:17 +01:00
Andreas Dangel bc210b41b2 [doc] Update release notes (#4224, #4228) 2022-11-25 17:50:14 +01:00
Andreas Dangel 7b55f9360c [java] Refactor/reformat xpath query for MissingStaticMethodInNonInstantiatableClass 2022-11-25 17:47:45 +01:00
Andreas Deininger 5b2243aff1 Fixing typos 2022-11-25 17:32:49 +01:00
Andreas Dangel edcfe21131 Update pmdtester and other gems 2022-11-25 15:15:10 +01:00
Andreas Dangel 05a6daad2d Merge pull request #4226 from aaronhurst-google:feature/replace-jorje-for-visualforce
[visualforce] Replace uses of Jorje types in pmd-visualforce #4226
2022-11-25 15:12:22 +01:00
Andreas Dangel 3bd1283ab1 [doc] Update release notes (#4226) 2022-11-25 15:11:51 +01:00
Andreas Dangel faa5bf6e00 [doc] Document deprecated API 2022-11-25 15:10:30 +01:00
Lynn cdaf0d2500 Merge branch 'master' into issue4225 2022-11-25 21:34:48 +08:00
Lynn 4c38c5df8b Merge branch 'master' into issue4224 2022-11-25 21:32:04 +08:00
Andreas Dangel 7f7498dfba Merge pull request #4213 from adangel:issue-4172-InvalidLogMessageFormat
[java] InvalidLogMessageFormat - check for formatted calls #4213
2022-11-25 10:56:21 +01:00
Andreas Dangel 08784bd9c4 Merge pull request #4209 from adangel:issue-4174-MissingStaticMethodInNonInstantiatableClass
[java] MissingStaticMethodInNonInstantiatableClass - check for alloca… #4209
2022-11-25 10:52:55 +01:00
Andreas Dangel 21f24207ff Merge pull request #4193 from adangel:issue-4189-AbstractClassWithoutAnyMethod
[java] AbstractClassWithoutAnyMethod - exclude lombok constructor annotations #4193
2022-11-25 10:50:27 +01:00
Andreas Dangel 7d954dc8b3 Merge pull request #4192 from adangel:issue-4188-ClassWithOnlyPrivateConstructorsShouldBeFinal
[java] ClassWithOnlyPrivateConstructorsShouldBeFinal: Exclude lombok annotations #4192
2022-11-25 10:34:25 +01:00
Andreas Dangel 366bb3c651 Merge pull request #4190 from adangel:issue-4183-AvoidArrayLoops
[java] Fix #4183 AvoidArrayLoops false positive #4190
2022-11-25 10:30:56 +01:00
LynnBroe db8636c2ad revise 2022-11-25 16:33:22 +08:00
LynnBroe 7a30d7e2b4 support RequiredArgsConstructor and AllArgsConstructor 2022-11-25 14:48:11 +08:00
Aaron Hurst 1029d6b24d Fix checkstyle violations.
Change-Id: I0aa6ecfeb343f2e0b48d2ebfd176a877a72f40f6
2022-11-24 20:35:42 +00:00
Aaron Hurst e62b71f89a Add back DataType.fromBasicType(BasicType) and test.
Isolate references to BasicType inside method implementation.

Change-Id: I4be2ad5b8b42fb7a84da0755106d8f0b08034690
2022-11-24 15:55:43 +00:00
Andreas Dangel a28705a379 [java] ImmutableField - deprecate property ignoredAnnotations
Fixes #4175
2022-11-24 15:19:46 +01:00
Andreas Dangel 8a0a196886 Merge branch 'master' into issue-4177-InvalidJavaBean 2022-11-24 11:19:36 +01:00
LynnBroe 45a3d451af fix #4224 2022-11-23 16:30:55 +08:00
LynnBroe 376d4fbfb8 fix #4225 2022-11-23 16:11:05 +08:00
Aaron Hurst c9e21cd4eb Tweak terminology: the map is case-normalized not case-insensitive.
Change-Id: I3499dc615262612b6c220b7840d3ab8cca87c226
2022-11-22 21:38:03 +00:00
Aaron Hurst 5ad37f6757 Replace uses of Jorje types in pmd-visualforce.
Summary: store and compare primitive type names instead of using BasicType enum.

Udpate unit tests and add a few more cases.

Change-Id: If4e5bb33d11793813839b82cf8beb043aad2ce34
2022-11-22 20:15:39 +00:00
Andreas Dangel 184f2031e2 Merge pull request #4207 from adangel:doc-add-scala-sidebar
[doc] List all languages in rule doc #4207
2022-11-18 15:59:29 +01:00
Andreas Dangel 1f9691b7f3 [doc] Update release notes (#4207) 2022-11-18 15:59:10 +01:00
Andreas Dangel 78ac4bc387 [java] NonSerializableClass - Fix NPE 2022-11-18 11:19:23 +01:00
Andreas Dangel 7d0f60891c [java] NonSerializableClass - support serialPersistentFields 2022-11-18 10:12:27 +01:00
Andreas Dangel f6e51b1457 [java] NonSerializableClass - new property "checkAbstractTypes"
By default, ignore abstract types like abstract classes, interfaces, generic types and java.lang.Object.
2022-11-17 17:09:43 +01:00
Andreas Dangel aed682453b Merge branch 'master' into issue-4176-NonSerializableClass 2022-11-17 16:29:25 +01:00
Andreas Dangel c70f89417f [doc] Update release notes (#4215) [skip ci] 2022-11-17 11:07:21 +01:00
Clément Fournier 384dec422d Merge branch 'pr/4173' 2022-11-16 13:01:04 +01:00
Clément Fournier 81ac22dd78 Merge branch 'master' into pr/4173 2022-11-16 13:00:52 +01:00
Clément Fournier 9d8ff6c4a6 Merge branch 'pr/4191' 2022-11-16 12:50:58 +01:00
Clément Fournier 382dea54ea Merge branch 'master' into pr/4191 2022-11-16 12:50:42 +01:00
Clément Fournier b45ab08021 Add tests for zip file paths 2022-11-13 18:42:00 +01:00
Clément Fournier e0c0bd9241 Test -z / 2022-11-13 15:20:31 +01:00
Clément Fournier 99b24b702f Add tests, dedup collected files 2022-11-13 14:36:36 +01:00
Clément Fournier d3e68d795b Add --relativize-paths-with 2022-11-13 00:08:35 +01:00
Andreas Dangel 69ccb693c0 [java] InvalidLogMessageFormat - check for formatted calls
Fixes #4172
2022-11-12 19:26:23 +01:00
Clément Fournier bdbeef6235 Merge branch 'pr/4195'
Refs #4195
2022-11-12 18:55:20 +01:00
Clément Fournier 2f06def8ae Apply suggestions from code review 2022-11-12 18:54:31 +01:00
Andreas Dangel 22cbae07fd [java] MissingStaticMethodInNonInstantiatableClass - check for allocations of the outer class
Fixes #4174
2022-11-11 17:37:17 +01:00
Andreas Dangel 8a51c56094 Merge branch 'master' into issue-2867-ClassNamingConventions-testClassPattern 2022-11-11 15:49:00 +01:00
Andreas Dangel 86eab418a9 [java] TestClassWithoutTestCases - don't consider nested TestNG classes 2022-11-11 15:43:31 +01:00
Andreas Dangel bbfb5eca6c Merge branch 'master' into issue-4177-InvalidJavaBean 2022-11-11 15:22:51 +01:00
Andreas Dangel a505bbf2ac [doc] Update release notes (#4177) 2022-11-11 15:21:21 +01:00
Andreas Dangel 9ced8ad63c [java] InvalidJavaBean - update rule doc 2022-11-11 15:18:09 +01:00
Andreas Dangel 7e8a886b93 [java] InvalidJavaBean - add property packages 2022-11-11 14:57:29 +01:00
Andreas Dangel 0d44e59f82 [java] InvalidJavaBean - support indexed getters and setters 2022-11-11 14:43:28 +01:00
Andreas Dangel 770b1f541e [java] InvalidJavaBean - consider properties not backed by fields
These are computed values.
2022-11-11 13:56:31 +01:00
Andreas Dangel 4ef342cd28 [doc] Fix jdoc links in release notes 2022-11-11 12:22:06 +01:00
Andreas Dangel 2092ea2b88 Merge pull request #4205 from Eldrick19:eldrick19-scala-clarification
[doc] Clarify Scala support (no built-in rules) #4205
2022-11-11 12:21:14 +01:00
Andreas Dangel 2bfc8da9d2 Add @Eldrick19 as a contributor 2022-11-11 12:20:09 +01:00
Andreas Dangel 43aa917687 [doc] Update release notes (#4205) 2022-11-11 12:19:54 +01:00
Andreas Dangel d842ea2a90 Revert package-lock.json 2022-11-11 12:19:00 +01:00
Andreas Dangel 02ad552445 [doc] List all languages in rule doc
Even without rules.

- Relates #4205
- Relates #4105
2022-11-11 12:14:28 +01:00
Andreas Dangel 36d18aefc6 Merge pull request #4197 from oowekyala:pmd6-java-type-annotations
[java] Support type annotations properly #4197
2022-11-11 10:48:25 +01:00
Andreas Dangel c010561045 [doc] Update release notes (#3643, #4152, #4197) 2022-11-11 10:44:55 +01:00
Andreas Dangel e2a845e77d Merge pull request #4202 from LynnBroe:master
[java] Fix #4200 and #4201: ClassWithOnlyPrivateConstructorsShouldBeFinal, CommentDefaultAccessModifier: Exclude lombok @Value annotation #4202
2022-11-11 10:29:10 +01:00
Andreas Dangel f28bb76d35 [doc] Update release notes (#4200, #4201, #4202) 2022-11-11 10:28:28 +01:00
Andreas Dangel b1ce2da3b9 [doc] Fix rule doc generation when rule description is empty 2022-11-11 10:23:25 +01:00
Andreas Dangel feb1166ec7 [java] InvalidJavaBean - consider Lombok annotations 2022-11-11 10:08:57 +01:00
Andreas Dangel dea8d03ab2 [java] InvalidJavaBean - add property ensureSerialization 2022-11-11 09:35:35 +01:00
Andreas Dangel 038ef44e16 [java] InvalidJavaBean - use symbol table 2022-11-11 09:31:36 +01:00
LynnBroe 6234b15ce7 revise 2022-11-11 14:22:22 +08:00
Eldrick Wega ed1e84ec58 Provide Scala Update 2022-11-10 23:33:08 +00:00
Andreas Dangel 7d06d2ac2b [java] InvalidJavaBean - add more tests 2022-11-10 17:51:35 +01:00
Juan Martín Sotuyo Dodero 79e294b36e Merge pull request #4161 from Monits/prep-4059
[core] Backport to PMD6 changes to accomodate PicoCli in PMD7
2022-11-10 12:34:05 -03:00
Juan Martín Sotuyo Dodero c513d72d59 Fix typo 2022-11-10 12:33:52 -03:00
Juan Martín Sotuyo DoderoandClément Fournier 6c5c34bb03 Update docs/pages/pmd/userdocs/cli_reference.md
Co-authored-by: Clément Fournier <clement.fournier@tu-dresden.de>
2022-11-10 12:26:46 -03:00
Lynn d94e67d828 Merge branch 'pmd:master' into master 2022-11-10 20:40:15 +08:00
Andreas Dangel 1a344d8cb3 [java] New Rule InvalidJavaBean
Refs #4177
2022-11-10 12:01:21 +01:00
Andreas Dangel a6a4199287 Merge pull request #4198 from jvwilge:patch-1
[doc] Add supported CPD languages #4198
2022-11-10 11:14:01 +01:00
Andreas Dangel 81dd7e5688 [doc] Update release notes (#4198) 2022-11-10 11:13:26 +01:00
Andreas Dangel b2e580863b Add @jvwilge as a contributor 2022-11-10 11:13:12 +01:00
LynnBroe a6256f90a5 fix #4201 2022-11-10 18:00:07 +08:00
Andreas Dangel f21f63b905 [java] Improve ClassNamingConventions for testClassPatterns
Don't consider nested classes.
Add TestCase as valid pattern by default.
2022-11-10 10:57:19 +01:00
LynnBroe 3eb291c811 fix #4200 2022-11-10 17:52:34 +08:00
Jeroen van Wilgenburg 1b42676c1b Add supported languages
Languages were missing in the documentation
2022-11-09 10:18:18 +01:00
Andreas Dangel ffa852f426 [java] Improve NonSerializableClass
Use rulechain, consider inner classes/enums
Use fully qualified name for reporting
2022-11-08 19:19:13 +01:00
Clément Fournier eaa6d43eab fix invalid test code 2022-11-07 23:53:24 +01:00
Clément Fournier 735197cff4 Support other cases found in checkstyle 2022-11-07 00:44:22 +01:00
Clément Fournier 36f19eda92 Push actual annotation nodes
This is to avoid having rules like UnusedImports
fail to see an annotation usage. This makes the
tree rather messy when there are type annotations
though.
2022-11-06 22:39:38 +01:00
Clément Fournier 00c06343a5 Fix tests 2022-11-06 21:50:33 +01:00
Clément Fournier 2027d2f57f Support generic ctors 2022-11-05 17:05:46 +01:00
Clément Fournier 92ccf1b0ea Support array init with just a comma
Refs #3643
2022-11-05 16:31:17 +01:00
Clément Fournier b39ba3c560 Add new tests
Refs #3643
2022-11-05 16:30:01 +01:00
Clément Fournier cd075d2459 Fix #4152 - support type annotations in more places 2022-11-05 15:48:04 +01:00
Andreas Dangel 1824f523dc [java] ClassNamingConventions - change default testClassPattern 2022-11-04 20:10:37 +01:00
Andreas Dangel 51067c2c5e [java] Implement rule NonSerializableClass
Fixes #4176
Fixes #1668
2022-11-04 20:05:45 +01:00
Andreas Dangel 9b53bf444e [java] Rename rule BeanMembersShouldSerialize to NonSerializableClass 2022-11-04 18:43:01 +01:00
Andreas Dangel 11a4940d6d [java] ClassNamingConventions - add new property testClassPattern
Fixes #2867
2022-11-04 18:15:32 +01:00
Andreas Dangel a5b6264ad7 Bump kotest from 5.5.3 to 5.5.4 2022-11-04 11:05:01 +01:00
Andreas Dangel 06bace1364 Merge branch 'master' into upgrade-kotlin-1.7.20 2022-11-04 11:04:31 +01:00
Andreas Dangel 87297f39f8 [java] AbstractClassWithoutAnyMethod - exclude lombok constructor annotations
Fixes #4189
2022-11-04 10:58:59 +01:00
Andreas Dangel 66b689375f [java] ClassWithOnlyPrivateConstructorsShouldBeFinal: Exclude lombok annotations
Fixes #4188
2022-11-04 10:45:56 +01:00
Andreas Dangel dcbc48b740 [java] Fix NPE in InvalidLogMessageFormat
Fixes #4185
2022-11-03 16:23:34 +01:00
Andreas Dangel 1a07963ea7 Merge pull request #4184 from valfirst:patch-1
[java][doc] TestClassWithoutTestCases - fix small typo in description #4184
2022-11-03 15:45:30 +01:00
Andreas Dangel 5d46939592 [doc] Update release notes (#4184) 2022-11-03 15:44:57 +01:00
Andreas Dangel 88c473498e Add @valfirst as a contributor 2022-11-03 15:43:29 +01:00
Andreas Dangel f061ab58d5 [java] Fix #4183 AvoidArrayLoops false positive 2022-11-03 15:40:12 +01:00
Valery Yatsynovich 6109aea217 [java] TestClassWithoutTestCases - fix small typo in description 2022-10-31 10:29:37 +03:00
Andreas Dangel d4eba4f456 Bump pmd from 6.50.0 to 6.51.0 2022-10-29 09:40:13 +02:00
Andreas Dangel ac76fa6f24 Prepare next development version [skip ci] 2022-10-29 09:36:33 +02:00
Andreas Dangel 5a4bf05493 [maven-release-plugin] prepare for next development iteration 2022-10-29 09:34:25 +02:00
Andreas Dangel 66e834049f [maven-release-plugin] prepare release pmd_releases/6.51.0 2022-10-29 09:34:19 +02:00
Andreas Dangel 22425a6d71 Prepare pmd release 6.51.0 2022-10-29 09:20:31 +02:00
Andreas Dangel 2792577da0 Bump kotest from 5.5.2 to 5.5.3 2022-10-28 10:46:16 +02:00
Andreas Dangel 0a10dad628 Add @tysonstewart as a contributor 2022-10-28 10:11:53 +02:00
Andreas Dangel e7013bb061 Add @rnveach as a contributor 2022-10-28 10:08:26 +02:00
Andreas Dangel 2f515e554a Merge pull request #4170 from adangel:issue-4140-doc-max-lang-version
[doc] Rule doc: add maximum language version #4170
2022-10-28 10:04:29 +02:00
Andreas Dangel 66d67c7fe4 Merge pull request #4169 from adangel:issue-4165-InaccurateNumericLiteral
[javascript] InaccurateNumericLiteral - consider underscores #4169
2022-10-28 10:02:45 +02:00
Andreas Dangel e59d25b697 Merge pull request #4162 from adangel:improve-TestClassWithoutTestCases
[java] Improve TestClassWithoutTestCases #4162
2022-10-28 10:01:22 +02:00
Andreas Dangel fc8c01aaaf Merge pull request #4160 from adangel:issue-4139-UnnecessaryFullyQualifiedName
[java] Fix UnnecessaryFullyQualifiedName for current package java.lang #4160
2022-10-28 09:59:31 +02:00
Andreas Dangel 59cfe99325 Merge pull request #4159 from adangel:AvoidArrayLoops-improvements
[java] AvoidArrayLoops improvements #4159
2022-10-28 09:39:41 +02:00
Andreas Dangel af013d61e1 Merge pull rquest #4156 from adangel:issue-4148-ArrayListVector
[java] Use type resolution for UseArrayListInsteadOfVector #4156
2022-10-28 09:36:45 +02:00
Andreas Dangel fddc47ed31 Merge pull request #4154 from adangel:StringToString-improvements
[java] StringToString improvements #4154
2022-10-28 09:34:52 +02:00
Andreas Dangel 71446164de [doc] Link 3rd party rulesets from making rulesets 2022-10-27 20:08:41 +02:00
Andreas Dangel 36c197f705 Merge pull request #4147 from yasarshaikh:master
[java] Added support for Do-While for AvoidArrayLoops #4147
2022-10-27 15:53:09 +02:00
Andreas Dangel 56b61f6a64 [doc] Update release notes (#4091, #4147) 2022-10-27 15:51:25 +02:00
Andreas Dangel d011996df9 Add @yasarshaikh as a contributor 2022-10-27 15:48:36 +02:00
Andreas Dangel a059986945 Bump kotest from 5.5.1 to 5.5.2 2022-10-27 15:47:07 +02:00
Andreas Dangel ea3b860d61 [java] Upgrade testing dsl for kotest 5.5.1 2022-10-21 15:23:15 +02:00
Andreas Dangel 0240c51ff0 Bump kotest from 4.4.3 to 5.5.1
Also update JUnit5 to 5.8.2
2022-10-21 12:14:32 +02:00
Andreas Dangel 3dc9d92833 Bump dokka from 1.6.21 to 1.7.20 2022-10-21 10:39:49 +02:00
Andreas Dangel e3fcd690a5 Bump kotlin from 1.7.0 to 1.7.20 2022-10-21 10:39:13 +02:00
Andreas Dangel 11764884c7 [java] TestClassWithoutTestCases - fix default pattern
To not match inner classes or a potential test class if the
inner class is not named test.
2022-10-21 09:29:06 +02:00
Andreas Dangel 21cca4b94d [java] AccessorClass/MethodGeneration: Document maximum language version
Fixes #4140
2022-10-20 17:34:03 +02:00
Andreas Dangel ebf3837199 [doc] Rule doc: add maximum language version
Fixes #4140
2022-10-20 17:25:09 +02:00
Andreas Dangel c7acac7f29 [javascript] InaccurateNumericLiteral - consider underscores
Fixes #4165
2022-10-20 17:15:18 +02:00
Andreas Dangel f54ca8b364 Update gems 2022-10-20 15:53:51 +02:00
Andreas Dangel 241e1e140a Bump pmdtester from 1.5.1 to 1.5.2 2022-10-20 15:53:32 +02:00
Andreas Dangel dd26af7f93 [java] TestClassWithoutTestCases - improve message 2022-10-20 15:47:07 +02:00
Andreas Dangel 5860f64648 [java] TestClassWithoutTestCases - improve nested class support 2022-10-20 15:33:28 +02:00
Andreas Dangel 0363c61b77 [java] TestClassWithoutTestCases - support JUnit5 nested tests 2022-10-20 14:59:24 +02:00
Juan Martín Sotuyo Dodero ecd7ab14ce Update CLI docs 2022-10-17 17:59:47 -03:00
Juan Martín Sotuyo Dodero 637b701778 Fix link to JavaFX 2022-10-17 01:10:41 -03:00
Juan Martín Sotuyo Dodero 21306f36db Add deprecations 2022-10-17 01:07:26 -03:00
Juan Martín Sotuyo Dodero 9e92ca3d76 Include CLI deprecations 2022-10-17 00:45:59 -03:00
Andreas Dangel c8eecb53a4 [doc] Fix broken links for "Architecture Decisions"
Fixes #4163
2022-10-16 11:37:57 +02:00
Andreas Dangel 33ede7fbc2 [java] Improve TestClassWithoutTestCases
- Added new property "testClassPatterns" to property detect empty test classes
- Added support for different JUnit5 annotations (like ParameterizedTest)
- Added support for TestNG

- Fixes #929
- Fixes #2636
2022-10-15 18:50:36 +02:00
Juan Martín Sotuyo Dodero 7d0208f6ac Avoid NPEs 2022-10-14 23:56:11 -03:00
Juan Martín Sotuyo Dodero b9737e23b5 Backport to PMD6 changes to accomodate PicoCli in PMD7
- Companion PR for #4059
 - Add deprecations and path the way for the upcoming changes to the CLI in PMD7
2022-10-14 23:36:45 -03:00
Andreas Dangel 96a1ca0a13 [java] Fix UnnecessaryFullyQualifiedName for current package java.lang
Fixes #4139
2022-10-14 19:34:33 +02:00
Andreas Dangel d575586d1e Merge pull request #4150 from tprouvot:feature/addApexUnitShouldHaveRunAs
[apex] New rule ApexUnitTestClassShouldHaveRunAs #4149 #4150
2022-10-14 16:59:09 +02:00
Andreas Dangel 8834af16f6 [doc] Update release notes (#4149, #4150) 2022-10-14 16:58:40 +02:00
Andreas Dangel df2d1b806e [apex] ApexUnitTestClassShouldHaveRunAsRule - remove unnecessary constructor 2022-10-14 16:57:47 +02:00
Andreas Dangel a9f00ecadb [java] AvoidArrayLoops - enhance documentation
Fixes #2692
2022-10-14 14:04:12 +02:00
Andreas Dangel c8649b73e4 [java] AvoidArrayLoops - consider final variables
Fixes #3847
2022-10-14 12:06:29 +02:00
Andreas Dangel 30885b6212 [java] AvoidArrayLoops - ignore multi-dim array assignment 2022-10-14 11:51:57 +02:00
Andreas Dangel d1328b2ba7 [java] AvoidArrayLoops - rework XPath expression
Fixes #1167
2022-10-14 11:41:51 +02:00
Thomas ProuvotandAndreas Dangel a88ad1cd5d Update pmd-core/src/main/resources/rulesets/releases/6510.xml
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-10-14 11:01:01 +02:00
Andreas Dangel 173a41b712 [java] UseArrayListInsteadOfVector - use typeIsExactly 2022-10-14 10:26:18 +02:00
Thomas Prouvot a72f1332d4 Merge branch 'feature/addApexUnitShouldHaveRunAs' of https://github.com/tprouvot/pmd into feature/addApexUnitShouldHaveRunAs 2022-10-14 10:25:13 +02:00
Thomas Prouvot d0d2d2a6f7 Remove unused imports 2022-10-14 10:24:00 +02:00
Thomas ProuvotandAndreas Dangel 150f109db4 Update pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveRunAsRule.java
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-10-14 10:03:45 +02:00
Thomas ProuvotandAndreas Dangel bac0e6e999 Update pmd-apex/src/main/resources/category/apex/bestpractices.xml
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-10-14 09:52:52 +02:00
Thomas Prouvot 3cd67eabf3 Set default message and priority to the rule 2022-10-14 09:52:04 +02:00
Andreas Dangel 78a49175a5 [java] Use type resolution for UseArrayListInsteadOfVector
Fixes #4148
2022-10-14 09:48:36 +02:00
Thomas Prouvot ef48c7628c Add a test for a normal class 2022-10-14 09:36:53 +02:00
Thomas Prouvot d6f3b3c68e revert changes on deprecvated rule 2022-10-14 09:26:47 +02:00
Thomas ProuvotandAndreas Dangel 0da5cc9937 Update pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveRunAsRule.java
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-10-14 09:21:34 +02:00
Yasar ShaikhandAndreas Dangel 82e7da5d0e Added issue number in the Description for the AvoidArrayLoops
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-10-14 12:50:36 +05:30
Andreas Dangel 46e2007ce4 [java] StringToString - fix false positive 2022-10-13 15:08:57 +02:00
Andreas Dangel 896c7c6b78 [java] StringToString - update javadoc 2022-10-13 14:43:42 +02:00
Andreas Dangel 39c26d97f9 [doc] Update release notes (#2080, #3437, #3681, #3977) 2022-10-13 13:20:49 +02:00
Andreas Dangel 1f26319325 [java] Support class literal in type resolution
Fixes #3437
2022-10-13 13:17:53 +02:00
Andreas Dangel 5d08ecd5be [java] StringToString - use type resolution for field access
Fixes #2080
2022-10-13 12:25:34 +02:00
Andreas Dangel b26e0bda8c [java] StringToString - consider literals
Fixes #3681
2022-10-13 11:53:28 +02:00
Andreas Dangel 58b3f02a16 [java] StringToString - use type resolution 2022-10-13 11:46:30 +02:00
Andreas Dangel 3ee4926f64 [java] StringToString false-positive with local method name confusion
Fixes #3977
2022-10-13 11:08:42 +02:00
Thomas Prouvot a48b56b5c3 Add new apex rule ApexUnitTestClassShouldHaveRunAs 2022-10-11 16:47:16 +02:00
Andreas Dangel fd594f682c [doc] Update "Articles about PMD" 2022-10-10 18:13:19 +02:00
Andreas Dangel 4a7ba3e6c0 [doc] Update contributors, mention founders 2022-10-10 18:12:47 +02:00
Andreas Dangel 2954b486cf Add @tcopeland as a contributor 2022-10-10 18:00:58 +02:00
Thomas Prouvot c0f88d004d Merge branch 'pmd:master' into master 2022-10-10 16:32:38 +02:00
Yasar Shaikh 204bbacbdc [java] added unit test of do-while for AvoidArrayLoops 2022-10-09 22:23:37 +05:30
Yasar Shaikh 14b4a805d0 Added support for Do-While for "AvoidArrayLoops" 2022-10-07 20:11:39 +05:30
Juan Martín Sotuyo Dodero 5f2961f78f Merge pull request #4144 from adangel/doc-supported-languages
[doc] Update docs to reflect supported languages
2022-10-06 13:04:34 -03:00
Juan Martín Sotuyo Dodero e22a77699e Merge branch 'master' into doc-supported-languages 2022-10-06 13:03:52 -03:00
Juan Martín Sotuyo DoderoandAndreas Dangel 1063d6c224 Update docs/pages/release_notes.md
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-10-06 13:02:43 -03:00
Andreas Dangel d09aa48064 Merge pull request #4142 from LynnBroe:master
[java] fix #4141 Update UncommentedEmptyConstructor - ignore @Autowired annotations #4142
2022-10-06 17:46:49 +02:00
Andreas Dangel 38a0950fb9 [doc] Update release notes (#4141, #4142) 2022-10-06 17:46:13 +02:00
Andreas Dangel 78b69fdb96 Update @LynnBroe as a contributor 2022-10-06 17:45:38 +02:00
Andreas Dangel 17b8661dab [doc] Use java highlighting in issue templates by default 2022-10-06 17:41:39 +02:00
Andreas Dangel 9c182974e7 [doc] Fix ruledoc for POM: ProjectVersionAsDependencyVersion 2022-10-06 17:40:35 +02:00
Andreas Dangel 6faf6ed223 [doc] Update docs to reflect supported languages (#4143)
Refs #4059
2022-10-06 16:25:20 +02:00
Andreas Dangel d1fa989b3c Bump snakeyaml from 1.32 to 1.33 2022-10-06 10:11:33 +02:00
Andreas Dangel f9ccab3d7b Bump protobuf-java from 3.16.1 to 3.16.3
Fixes https://github.com/pmd/pmd/security/dependabot/29
Fixes https://github.com/advisories/GHSA-h4h5-3hr4-j3g2
Fixes CVE-2022-3171
2022-10-06 10:03:25 +02:00
LynnBroe a1bcad2db2 fix #4141 2022-10-05 13:54:41 +08:00
Andreas Dangel 905f1432f4 Bump pmd from 6.49.0 to 6.50.0 2022-09-30 16:08:44 +02:00
Andreas Dangel d69a292d16 [ci] Escape ampersand to avoid pattern substitution replacement [skip ci]
This is a new feature of bash 5.2...
See also shopt patsub_replacement
2022-09-30 16:04:15 +02:00
Andreas Dangel a9647edb63 [doc] Fix old release notes [skip ci] 2022-09-30 15:44:10 +02:00
Andreas Dangel 090af8c3a5 Prepare next development version [skip ci] 2022-09-30 15:40:54 +02:00
Andreas Dangel 13d9a9457f [maven-release-plugin] prepare for next development iteration 2022-09-30 15:39:14 +02:00
Andreas Dangel 37f6d8254c [maven-release-plugin] prepare release pmd_releases/6.50.0 2022-09-30 15:39:08 +02:00
Andreas Dangel 3f08ad70fe Prepare pmd release 6.50.0 2022-09-30 15:28:09 +02:00
Andreas Dangel 62e2c910d9 [doc] Update contributors
* Add @koalalam as a contributor
* Update @OlegAndreych as a contributor
* Add @garydgregory as a contributor
* Add @vanguard-1024 as a contributor
* Update @abyss638 as a contributor
* Update @dykov as a contributor
* Add @ewantempero as a contributor
* Update @JerritEic as a contributor
* Add @cbfiddle as a contributor
* Add @MartGit as a contributor
* Update @gredler as a contributor
* Add @Alexx-G as a contributor
* Update @jborgers as a contributor
2022-09-30 15:06:21 +02:00
Andreas Dangel f8e298dc22 [java] UnnecessaryFullyQualifiedName - add test for #4133
Fixes #4133
2022-09-30 12:49:01 +02:00
Andreas Dangel be871350c0 Merge pull request #4072 from adangel:doc-adr
[doc] Add architecture decision records #4072
2022-09-30 11:34:29 +02:00
Andreas Dangel 398d05c3d3 [doc] Update release notes (#4072) 2022-09-30 11:33:09 +02:00
Andreas Dangel 146f86f552 Merge pull request #4138 from adangel:scala-upgrades
[scala] Upgrade scala-library to 2.12.7 / 2.13.9 and scalameta to 4.6.0 #4138
2022-09-30 11:31:29 +02:00
Andreas Dangel 9e5efcb09d [doc] Update release notes (#4138) 2022-09-30 11:30:40 +02:00
Andreas Dangel 545c4cd284 Merge pull request #4135 from adangel:issue-3431
[java] Add java-regression-tests for regression testing #4135
2022-09-30 11:29:26 +02:00
Andreas Dangel a46bea27f0 Merge pull request #4130 from sashashura:patch-1
[ci] GitHub Workflows security hardening #4130
2022-09-30 11:27:31 +02:00
Andreas Dangel 8fa94cf2f5 [doc] Update release notes (#4130) 2022-09-30 11:25:21 +02:00
Andreas Dangel c75a4795d3 Add @sashashura as a contributor 2022-09-30 11:25:01 +02:00
Andreas Dangel 7d58fc8551 Merge pull request #4101 from adangel:issue-4099-constructorcallsoverridable
[java] ConstructorCallsOverridableMethod should consider method calls… #4101
2022-09-30 11:22:57 +02:00
Andreas Dangel 94410916c2 Merge pull request #4100 from LynnBroe:master
[java] Update UnusedPrivateFieldRule - ignore any annotations #4100
2022-09-30 11:21:18 +02:00
Andreas Dangel 2105bde614 [doc] Update release notes (#4100, #4033, #4037) 2022-09-30 11:20:51 +02:00
Andreas Dangel 1d6aeb0a95 Add @LynnBroe as a contributor 2022-09-30 11:20:23 +02:00
Andreas Dangel 9056204317 [ci] Execute danger and dogfood only for pull requests in our own repository 2022-09-30 11:15:26 +02:00
Andreas Dangel d7de6f59d2 [doc] Accept ADR-1 and ADR-2 2022-09-30 11:00:06 +02:00
Andreas Dangel 81a8ba0c87 [ci] Add permission contents:write for build job 2022-09-30 10:48:42 +02:00
Andreas Dangel 16bb510cca Fix release notes 2022-09-30 10:32:22 +02:00
Andreas Dangel 4fc12f031c [java] Fix rule tests with dysfunctional rule configurations 2022-09-30 10:21:25 +02:00
Andreas Dangel 1cc0fbb047 [java] UnusedPrivateFieldRule - remove ignoredAnnotations from rule tests 2022-09-30 10:03:11 +02:00
Andreas Dangel e712b89fa0 [java] UnusedPrivateFieldRule - improve rule doc 2022-09-30 10:00:23 +02:00
Andreas Dangel 45f3f6e5bb [scala] Bump scalameta from 4.2.0 to 4.6.0 2022-09-30 09:24:22 +02:00
Andreas Dangel 167dd635ed [scala] Bump scala-library from 2.12.10 to 2.12.17 2022-09-30 09:23:54 +02:00
Andreas Dangel 2f2b6a2476 [scala] Bump scala-library from 2.13.3 to 2.13.9
Fixes https://github.com/pmd/pmd/security/dependabot/28
Fixes https://github.com/advisories/GHSA-8qv5-68g4-248j
Fixes CVE-2022-36944
2022-09-30 09:23:24 +02:00
Andreas Dangel 306db99400 [java] UnusedPrivateField - ignore any annotations
Deprecate "ignoreAnnotations" property
2022-09-29 19:12:04 +02:00
Andreas Dangel a66cffa55d Merge branch 'master' into pr-4100 2022-09-29 18:31:42 +02:00
Andreas Dangel 9c215e9722 [doc] Update release notes 2022-09-29 16:41:59 +02:00
Andreas Dangel 8cddfc73ad Merge pull request #4137 from lfalcantar:java-3858-junit5-comment-default-access-modifier
[java] Fixes 3859: Exclude junit5 test methods from the commentDefaultAccessModifierRule #4137
2022-09-29 16:32:58 +02:00
Andreas Dangel 38955b5c8d Add @lfalcantar as a contributor 2022-09-29 16:28:43 +02:00
Andreas Dangel ec97933e99 Remove old comment 2022-09-29 16:28:09 +02:00
Andreas Dangel b916113c9e Merge pull request #4134 from adangel:issue-4090
[java] FinalFieldCouldBeStatic - ignore synchronized statements in no… #4134
2022-09-29 16:26:04 +02:00
Andreas Dangel 5a08ad736a Merge pull request #4128 from OlegAndreych:Fix_#4103
[java] Fix False-positive UnnecessaryFullyQualifiedName when nested and non-nest… #4103 #4128
2022-09-29 16:24:15 +02:00
Andreas Dangel 94d343e63b [doc] Update release notes (#4085, #4128) 2022-09-29 16:21:32 +02:00
Andreas Dangel 491e8bec6c Add @OlegAndreych as a contributor 2022-09-29 16:21:02 +02:00
Andreas Dangel def6449d01 Merge pull request #4124 from pzygielo:typos
[doc] Fix typos in Java rule docs #4124
2022-09-29 16:16:09 +02:00
Andreas Dangel cb85a01a88 [doc] Update release notes (#4124) 2022-09-29 16:13:41 +02:00
Andreas Dangel 00201ae9f7 Update @pzygielo as a contributor 2022-09-29 16:13:07 +02:00
Andreas Dangel 3750f6f652 Merge pull request #4119 from adangel:fix-java-version-script
[cli] Fix java version in run.sh script #4119
2022-09-29 16:10:56 +02:00
Andreas Dangel 8d7a6503a7 Merge pull request #4109 from adangel:doc-3rd-party-rulesets
[doc] Add page for 3rd party rulesets #4109
2022-09-29 16:08:58 +02:00
Andreas Dangel fe1222abfe [doc] Update release notes (#4109) 2022-09-29 16:08:08 +02:00
Andreas Dangel 560a9a0781 [doc] Update release notes 2022-09-29 16:05:43 +02:00
Andreas Dangel f72a049924 Add @osiegmar as a contributor 2022-09-29 16:03:11 +02:00
Andreas Dangel 792fe44d0b Fixups from review (#4128) 2022-09-29 15:54:50 +02:00
Andreas Dangel defb0cd47c [doc] Update release notes (#1718, #2348) 2022-09-29 15:42:05 +02:00
Andreas Dangel dbe2881d6d [doc] CommentDefaultAccessModifier - update rule description 2022-09-29 15:13:55 +02:00
Andreas Dangel c9dfbffb66 [doc] Update release notes (#3859, #4137) 2022-09-29 15:06:20 +02:00
Andreas Dangel 3ba63285ac [java] CommentDefaultAccessModifier - configure JUnit5 annotations to be ignored 2022-09-29 15:04:35 +02:00
Andreas Dangel d21a562e90 [java] ConstructorCallsOverridableMethod - fix message for call chains
First method in the chain was missing
2022-09-29 14:19:51 +02:00
Andreas Dangel 5840afe39a [java] ConstructorCallsOverridableMethod - improve message for call chains 2022-09-29 12:21:56 +02:00
Andreas Dangel d94a943911 [java] ConstructorCallsOverridableMethod - fix false negatives
- Identify method calls of generic methods
2022-09-29 11:15:02 +02:00
Luis Alcantar 58c9f361d3 [java] issue#3859: Exclude junit5 test methods from the commentDefaultAccessModifierRule
There was a conflict between the CommentDefaultAccessModifier and the JUnit5TestShouldBePackagePrivate rule. while the JUnit5TestShouldBePackagePrivate rule passed, the CommentDefaultAccessModifier complained about the lack of a comment on the method encapsulation generating a false alert.

example "@org.junit.jupiter.api.Test void MissingCommentMethod {}", missing " /* default */" but not required in junit5.

The changes will exclude methods with junit5 @Test or @ParameterizedTest annotation for the commentDefaultAccessModifierRule.
2022-09-28 12:02:16 -07:00
Andreas Dangel b59ceb6c60 [java] ConstructorCallsOverridableMethod - fix false negatives
- Use type of the method call result
- Do not consider super method calls,
  but this references
2022-09-27 20:55:25 +02:00
Andreas Dangel adec817908 Merge branch 'master' into issue-4099-constructorcallsoverridable 2022-09-27 19:49:14 +02:00
Andreas Dangel 1ea82f1ee6 Fix git connection for java-regression-tests 2022-09-27 19:38:25 +02:00
Andreas Dangel d30edd618e Change something in pmd-core to let the regression tester run 2022-09-26 20:45:49 +02:00
Andreas Dangel dd82e5e19f Add java-regression-tests for regression testing
Fixes #3431
2022-09-26 19:47:05 +02:00
Andreas Dangel a44c328732 [java] FinalFieldCouldBeStatic - ignore synchronized statements in non-static methods
Fixes #4090
2022-09-26 18:39:49 +02:00
Andreas Dangel 0dcff72455 Update gems
Fixes https://github.com/pmd/pmd/security/dependabot/26
Fixes https://github.com/advisories/GHSA-4qw4-jpp4-8gvp
2022-09-24 17:52:56 +02:00
Andreas Dangel b56e697b28 Bump org.yaml:snakeyaml from 1.31 to 1.32
Fixes https://github.com/pmd/pmd/security/dependabot/25
Fixes https://github.com/advisories/GHSA-9w3m-gqgf-c4p9
Fixes CVE-2022-38752
2022-09-24 17:50:55 +02:00
Andreas Dangel 90e38ecab1 Merge pull request #4131 from Suvashri:patch-1
[doc] TooFewBranchesForASwitchStatement - Use if-else instead of if-then #4131
2022-09-24 17:47:23 +02:00
Andreas Dangel d6b5f1cf52 Add @Suvashri as a contributor 2022-09-24 17:46:14 +02:00
Andreas Dangel f23f5c2f2b [doc] Update release notes (#4131) 2022-09-24 17:45:48 +02:00
Andreas Dangel 993c5f809a Update pmd-java/src/main/resources/category/java/performance.xml 2022-09-24 17:35:55 +02:00
Andreas Dangel ea2f4fb649 Merge pull request #4066 from matthargett:lua-types
[lua] Support Luau, a gradually typed language based on Lua #4066
2022-09-24 17:30:32 +02:00
Andreas Dangel 4d630031c4 Add missing test files 2022-09-24 17:29:00 +02:00
Andreas Dangel 746fcbf086 [lua] Fixups from #4066 2022-09-24 17:18:32 +02:00
Andreas Dangel dcd8ff0ac0 [lua] Fix parsing of short/long comments 2022-09-24 17:13:29 +02:00
Suvashri 9d7c37cef7 Update performance.xml 2022-09-21 15:28:51 +05:30
Alex 4966e99082 build: harden git-repo-sync.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-19 21:10:13 +02:00
Alex 600561e44c build: harden build.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-19 21:02:02 +02:00
mohan-chinnappan-n e91427bed0 pmd report: added exports and summary table 2022-09-18 20:04:43 -04:00
Oleg Andreych af30f4cef9 False-positive UnnecessaryFullyQualifiedName when nested and non-nested classes with the same name and in the same package are used together #4085
* Regression fix;
2022-09-18 15:29:50 +05:00
Oleg Andreych 7f7f8f7b6a False-positive UnnecessaryFullyQualifiedName when nested and non-nested classes with the same name and in the same package are used together #4085 2022-09-17 11:07:12 +05:00
Matt Hargett 05c30a1053 Update documentation and changelog 2022-09-13 22:52:14 -07:00
Matt Hargett f7a5f9cad9 fix incorrect comments 2022-09-13 22:17:43 -07:00
Matt Hargett 936cbafd36 remove unused param 2022-09-13 21:58:02 -07:00
Matt Hargett 6b1658116f Merge branch 'master' of github.com:pmd/pmd into lua-types 2022-09-12 17:11:24 -07:00
mohan-chinnappan-n a8a4f1c19e CLI xslt line doc line added 2022-09-12 19:13:39 -04:00
mohan-chinnappan-n 2872a76ad5 pmd-report-v2.xslt cleanup 2022-09-12 18:50:22 -04:00
mohan-chinnappan-n 7598d43bbf v2 pmd-report xslt added 2022-09-12 18:21:17 -04:00
Piotrek Żygieło a3ea6be9ca Fix it's -> its 2022-09-12 20:29:00 +02:00
Piotrek Żygieło f4a0dff0c9 Add missing 'to' and agree verb with subject 2022-09-12 20:27:27 +02:00
Piotrek Żygieło 57138dc1c7 Fix punctuation/use full stop in sentence 2022-09-12 20:27:13 +02:00
Piotrek Żygieło 0962a33e14 Fix typo 2022-09-12 20:27:12 +02:00
Andreas Dangel cb9a660d23 Merge pull request #4116 from mohan-chinnappan-n:master
[core] Fix missing --file arg in TreeExport CLI example #4116
2022-09-11 11:10:38 +02:00
Andreas Dangel 91d8930e91 [doc] Update release notes (#4116) 2022-09-11 11:09:46 +02:00
Andreas Dangel dba3a76312 Add @mohan-chinnappan-n as a contributor 2022-09-11 11:09:29 +02:00
Andreas Dangel ba262675af Bump org.yaml:snakeyaml from 1.30 to 1.31
Fixes https://github.com/advisories/GHSA-3mc7-4q67-w48m
Fixes https://github.com/pmd/pmd/security/dependabot/24
Fixes CVE-2022-25857
2022-09-10 17:14:59 +02:00
Andreas Dangel 940252bafc Bump checkstyle from 9.3 to 10.3.3 2022-09-10 16:55:03 +02:00
Andreas Dangel 1510010442 Bump maven-checkstyle-plugin from 3.1.2 to 3.2.0 2022-09-10 16:54:52 +02:00
Andreas Dangel 9a46adf8a9 Bump maven-pmd-plugin from 3.18.0 to 3.19.0 2022-09-10 16:54:24 +02:00
Andreas Dangel 48269572eb Use the same jversion convention in designer.bat
java 1.8.0: 80
java 9.0: 90
java 17.0: 170
2022-09-10 15:41:58 +02:00
Andreas Dangel 0b6a9ce0a7 Add manual test script 2022-09-10 10:46:04 +02:00
Andreas Dangel 01ea52f90c [cli] Fix java version detection in run.sh
Fixes #4118
2022-09-10 10:34:25 +02:00
Matt Hargett 7d9a84fdde Format to have more consistent style with itself. Most other files appear to have mixed formatting. 2022-09-09 16:51:33 -07:00
Matt Hargett b8b4e513ac Support multi-line 'normal' strings. Support skipping literal sequences. More minor adjustments to make the testing corpus tokenize without errors. 2022-09-09 16:42:18 -07:00
mohan-chinnappan-n 9ebabbe82d Merge pull request #3 from mohan-chinnappan-n/mohan-chinnappan-n-patch-1
Update TreeExportCli.java
2022-09-09 04:35:28 -04:00
mohan-chinnappan-n 11b7bda871 Update TreeExportCli.java
missing --file arg in "Example: ast-dump --format xml --language java --file MyFile.java" added
2022-09-09 04:21:56 -04:00
Matt Hargett 7747b75091 Cleanups and minor tweaks for issues found in testing across 500KLOC of open source Lua code. 2022-09-08 12:46:43 -07:00
Matt Hargett 7cf9c6571e add an if-expression twist 2022-09-07 19:37:13 -07:00
Matt Hargett 026015954a Move rules from lexer to parser. Fix some bugs found in manual testing. Add bugs found via manual testing to new lua test file. 2022-09-07 19:29:55 -07:00
Matt Hargett c59ee1d55d Merge branch 'master' of github.com:pmd/pmd into lua-types 2022-09-07 17:00:14 -07:00
Andreas Dangel 898454510d [doc] Update ADRs from PR review comments 2022-09-06 19:28:11 +02:00
Andreas Dangel 0f99ef0c3c [html] Bump jsoup from 1.14.3 to 1.15.3
Fixes https://github.com/pmd/pmd/security/dependabot/23
CVE-2022-36033
https://github.com/advisories/GHSA-gp7f-rwcx-9369
2022-09-06 18:33:26 +02:00
LynnBroe ba0f2a2bfd Update UnusedPrivateField.xml 2022-09-05 21:16:13 +08:00
Lynn bd0a2e3258 Merge branch 'pmd:master' into master 2022-09-05 15:28:54 +08:00
Thomas Prouvot 5d4457bc3f Merge branch 'pmd:master' into master 2022-09-02 11:24:51 +02:00
Andreas Dangel ca2ee05562 [doc] Add page for 3rd party rulesets 2022-09-01 10:49:48 +02:00
Andreas Dangel c374d3934f Bump pmd from 6.48.0 to 6.49.0 2022-08-31 19:52:02 +02:00
Andreas Dangel 76be7ba669 Prepare next development version [skip ci] 2022-08-31 19:20:51 +02:00
Andreas Dangel 90663d746b [maven-release-plugin] prepare for next development iteration 2022-08-31 19:19:27 +02:00
Andreas Dangel 4b4ebabc2d [maven-release-plugin] prepare release pmd_releases/6.49.0 2022-08-31 19:19:22 +02:00
Andreas Dangel 232949566a Prepare pmd release 6.49.0 2022-08-31 19:07:21 +02:00
Andreas Dangel fe65a6ba98 Bump pmd-designer from 6.37.0 to 6.49.0 2022-08-31 18:34:48 +02:00
Andreas Dangel bdde4b7f28 Merge pull request #3971 from adangel:filecollector-language
[core] Remember language when using FileCollector.addFile #3971
2022-08-30 19:22:59 +02:00
Andreas Dangel b232ea46d1 Merge branch 'master' into filecollector-language 2022-08-30 19:21:30 +02:00
Andreas Dangel 814ee91296 Merge pull request #4095 from pacvz:master
[core] CPD: Added begin and end token to XML reports #4095
2022-08-30 19:06:03 +02:00
Andreas Dangel 504d2ad5f9 [doc] Update release notes (#4095) 2022-08-30 19:04:08 +02:00
Andreas Dangel aafd95eb3c Add @pacvz as a contributor 2022-08-30 19:02:42 +02:00
Thomas Prouvot 986192b2c1 Add new Assert class updates 2022-08-30 09:11:31 +02:00
Andreas Dangel 54a26140dc Merge pull request #4097 from tprouvot:feature/addNewClassForAssertion
[apex] ApexUnitTestClassShouldHaveAssertsRule: Support new Assert class (Apex v56.0) #4097
2022-08-29 19:08:37 +02:00
Andreas Dangel 04b38c3c55 Update @tprouvot as a contributor 2022-08-29 19:07:55 +02:00
Andreas Dangel 38e7e69edf [doc] Update release notes (#4097, #4096) 2022-08-29 19:06:03 +02:00
Andreas Dangel 7c6277c8b8 [apex] Update tests (ApexUnitTestClassShouldHaveAsserts, ApexAssertionsShouldIncludeMessage) #4097 2022-08-29 19:05:40 +02:00
Andreas Dangel 563d7b6a55 Merge pull request #4104 from nvuillam:patch-1
[doc] Add MegaLinter in the list of integrations #4104
2022-08-29 18:35:27 +02:00
Andreas Dangel bb81bd7857 Add @nvuillam as a contributor 2022-08-29 18:34:52 +02:00
Andreas Dangel b83ca316e1 [doc] Update release notes (#4104) 2022-08-29 18:33:17 +02:00
Nicolas Vuillamy d6399b09d9 Add MegaLinter in the list of integrations 2022-08-28 15:00:55 +02:00
Thomas Prouvot 29c4e996fb Increase test coverage 2022-08-25 16:54:11 +02:00
Thomas Prouvot d73cdcc193 Ad new tests for Assert method class 2022-08-25 15:44:37 +02:00
Thomas Prouvot 065b4b8083 Remove param message not mandatory in this test 2022-08-25 15:44:18 +02:00
Thomas Prouvot ac94df9e17 Update add violation parameters to macth with new tests 2022-08-25 15:34:54 +02:00
Thomas Prouvot d6194be47b Add tests for new methods 2022-08-25 15:31:13 +02:00
Thomas Prouvot 46aa491c45 Merge branch 'feature/addNewClassForAssertion' of https://github.com/tprouvot/pmd into feature/addNewClassForAssertion 2022-08-25 15:14:18 +02:00
tprouvot d7cf959ad2 Merge branch 'pmd:master' into feature/addNewClassForAssertion 2022-08-25 12:27:18 +02:00
Thomas Prouvot c61108c752 Add new Assert methods to ApexAssertionsShouldIncludeMessageRule 2022-08-25 12:18:15 +02:00
Thomas Prouvot 2e9f25c8ba PR review comment 2022-08-25 12:17:51 +02:00
Thomas Prouvot 50641a5c97 Fix typo 2022-08-25 12:17:32 +02:00
tprouvotandAndreas Dangel d5098ca115 Update pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-08-25 12:15:30 +02:00
tprouvotandAndreas Dangel e0b9965c27 Update pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveAssertsRule.java
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-08-25 10:46:47 +02:00
Andreas Dangel 804e4d188a [ci] Allow building of branch "experimental-apex-parser"
It should build like a pull request
2022-08-24 19:41:08 +02:00
Andreas Dangel 5d5fbd5b21 Bump maven-pmd-plugin from 3.17.0 to 3.18.0 2022-08-24 19:15:56 +02:00
Andreas Dangel d41628c1c6 Merge pull request #4092 from aaronhurst-google:enum-qualified-names
[apex] Implement ApexQualifiableNode for ASTUserEnum #4092
2022-08-24 18:01:33 +02:00
Andreas Dangel 4847470db0 Update @aaronhurst-google as a contributor 2022-08-24 18:00:17 +02:00
Andreas Dangel 67bab16091 [doc] Update release notes (#4092) 2022-08-24 17:59:57 +02:00
Andreas Dangel 18c4bbfdac Merge pull request #4081 from eklimo:remove-leaks
[apex] Remove Jorje leaks outside ast package #4081
2022-08-24 17:58:04 +02:00
Andreas Dangel f71d68067c Add @eklimo as a contributor 2022-08-24 17:57:23 +02:00
Andreas Dangel d2bd69437a [doc] Update release notes (#4081) 2022-08-24 17:56:57 +02:00
Andreas Dangel f83a1a092c [doc] Add deprecation infos 2022-08-24 17:55:04 +02:00
Andreas Dangel b9eec549fa Merge branch 'master' into pr-4081 2022-08-24 17:43:09 +02:00
Andreas Dangel 9401cf82bb Merge pull request #4083 from abyss638:issue-4082-unnecessaryimport-nested-classes
[java] UnnecessaryImport false positive for on-demand imports of nested classes (fix for #4082) #4083
2022-08-24 17:28:58 +02:00
Andreas Dangel 075507cb01 Add @abyss638 as a contributor 2022-08-24 17:28:13 +02:00
Andreas Dangel 8fcbcb434e [doc] Update release notes (#4082, #4083) 2022-08-24 17:27:34 +02:00
Andreas Dangel e3145b0e36 Fix PMD - unused local variables 2022-08-24 16:38:04 +02:00
Andreas Dangel f58719f7a6 Fix NPE 2022-08-24 16:33:38 +02:00
Andreas Dangel 5f0cb7d757 Support subtyping 2022-08-24 16:18:09 +02:00
Andreas Dangel a4afb59667 Fix handling of varargs 2022-08-24 15:53:13 +02:00
Andreas Dangel 64675dc600 Fix handling of array types 2022-08-24 15:35:44 +02:00
Andreas Dangel 596f129600 Fix False positive with public method call on new instance 2022-08-24 15:04:43 +02:00
Andreas Dangel bc21be4072 Fix handling of reference types 2022-08-24 12:18:48 +02:00
Andreas Dangel 292ec89833 [java] ConstructorCallsOverridableMethod should consider method calls with var access
Fixes #4099
2022-08-24 11:23:56 +02:00
Lynn 738c19b398 Update UnusedPrivateFieldRule.java
revise SpyBean about unusedprivatefield
2022-08-24 14:41:50 +08:00
Thomas Prouvot 41802862cb fix contributors 2022-08-18 17:11:22 +02:00
Thomas Prouvot dc03e52be3 Update method name and number of parameters (PR Comment) 2022-08-18 16:34:46 +02:00
Thomas Prouvot a2058c454b move fully qualified variant under comment (PR Comment) 2022-08-18 16:34:14 +02:00
Thomas Prouvot ad21a24b74 Fix contributors 2022-08-18 14:48:25 +02:00
Thomas Prouvot 539838c906 Update previous negative test which is ok now and add new positive test. 2022-08-18 14:40:50 +02:00
Thomas Prouvot 2edcfe25cd Update @tprouvot as a contributor 2022-08-18 10:28:19 +02:00
Thomas Prouvot 2e1d913058 Update @tprouvot as a contributor 2022-08-18 10:27:06 +02:00
Thomas Prouvot 237b106676 Add new assert methods for api 56 2022-08-17 15:09:54 +02:00
zon 91fbcc804a Added begin and end token attributes to XML output of CPD 2022-08-17 12:40:39 +02:00
Matt Hargett ba77fa19e5 Merge branch 'master' of github.com:pmd/pmd into lua-types 2022-08-14 09:35:20 -07:00
Aaron Hurst fbeb071d08 Implement ApexQualifiableNode for ASTUserEnum.
Include enum in qualified name. Properly handle case where enum is root node.

Fixes null deref in ApexQualifiedName.toString() for built-in ASTMethods in enum types.
Reference: https://developer.salesforce.com/docs/atlas.en-us.apexref.meta/apexref/apex_methods_system_enum.htm

Add tests of qualified and unqualified enums.

Change-Id: I691795d40a66f3d3335ab72ad43de7055a6aee31
2022-08-12 19:10:54 +00:00
Edward Klimoshenko ea455fa356 Remove Jorje leaks outside ast package
Operators
- Create operator enums to wrap internal Jorje operators.
- Create getters returning new operator enums in operator-expression
  nodes. Deprecate old getters.
- Refactor metrics classes to use new operator enums.

Tests
- Remove references to internal Jorje nodes.
2022-08-11 11:06:20 +00:00
Clément Fournier 2977bd8764 test-schema: fix tests 2022-08-10 17:26:20 +02:00
Clément Fournier 8a41e13bdb test-schema: fix wrong warning message 2022-08-10 00:18:21 +02:00
Simon Abykov b63368fe8d Fixed checkstyle errors 2022-08-05 13:43:51 +01:00
Simon Abykov dedb263fe7 [java] UnnecessaryImport false positive for on-demand imports of nested classes
Fixes #4082
2022-08-05 11:34:01 +01:00
Andreas Dangel 533428db9b Bump pmd from 6.47.0 to 6.48.0 2022-07-30 12:23:19 +02:00
Andreas Dangel 77e3bab4a6 Prepare next development version [skip ci] 2022-07-30 11:38:19 +02:00
Andreas Dangel 995d00fde3 [maven-release-plugin] prepare for next development iteration 2022-07-30 11:35:57 +02:00
Andreas Dangel 6aa2b47f2e [maven-release-plugin] prepare release pmd_releases/6.48.0 2022-07-30 11:35:53 +02:00
Andreas Dangel 143545c390 Prepare pmd release 6.48.0 2022-07-30 11:23:41 +02:00
Andreas Dangel b6ccad2e38 Merge pull request #4074 from adangel:pmd6-cpd-debug-flag
[core] Add --debug flag for CPD #4074
2022-07-30 10:01:34 +02:00
Andreas Dangel 6128631acb [doc] Add SPONSORS.md 2022-07-30 09:59:57 +02:00
Andreas DangelandClément Fournier ca87fe51e3 Fixups from review
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-07-29 15:24:30 +02:00
Andreas DangelandClément Fournier a36032b2bf Fixups from review
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-07-29 12:33:43 +02:00
Andreas Dangel 815242a39a [core] Store languageVersion in DataSource
in order to support FileCollector.addFile with language

Fixes #3970
2022-07-29 12:21:11 +02:00
Andreas Dangel 2cfdc9c6aa Merge branch 'master' into filecollector-language 2022-07-29 11:15:37 +02:00
Andreas Dangel ee38e7d81a [core] Add "--debug" flag for CPD
Fixes #3796
2022-07-29 10:12:30 +02:00
Andreas Dangel bf5828d7d1 [doc] Fix jdoc link in release notes 2022-07-28 14:59:08 +02:00
Andreas Dangel cbbe0e0cb0 [doc] Add "ADR 2 - Policy on the use of Kotlin for development" 2022-07-28 14:29:02 +02:00
Andreas Dangel 68eaf06e1a [doc] Add proposal for architecture decision records 2022-07-28 11:55:51 +02:00
Clément Fournier d092e20ed2 Merge branch 'pr/4052'
Refs #4052
2022-07-27 12:15:36 +02:00
Clément Fournier 3e57ea2076 Merge branch 'master' into pr/4052 2022-07-27 12:15:15 +02:00
Matt Hargett 3d6fab0782 rename new snapshot artifact to better express intent 2022-07-26 13:29:19 -07:00
Matt Hargett cfb8374611 Capture more syntax scenarios in the regression test, update the snapshot. 2022-07-26 13:25:14 -07:00
Matt Hargett 8aaa1302cc Support all Luau type extension syntax available in all test corpus sources. Add a regression test for a few of the things that required tweaks. 2022-07-26 00:13:35 -07:00
Matt Hargett 65fef39a4c Initial Lua type grammar 2022-07-25 21:43:54 -07:00
Andreas Dangel 0550512a63 Merge pull request #4061 from matthargett:fortify-lua-grammar
[lua] Fix several related Lua parsing issues found when using CPD #4061
2022-07-25 20:01:04 +02:00
Andreas Dangel b000b077ca [doc] Update release notes (#4061) 2022-07-25 20:00:00 +02:00
Andreas Dangel c583031a18 Add @matthargett as a contributor 2022-07-25 19:59:52 +02:00
Andreas Dangel 73a7ed98ca Merge pull request #4056 from gwilymatgearset:add-support-for-soql-injection-detection-in-count-query
[apex] ApexSOQLInjection: Add support count query #4056
2022-07-25 19:44:53 +02:00
Andreas Dangel f121ad1526 [doc] Update release notes (#4056) 2022-07-25 19:43:59 +02:00
Andreas Dangel 618790613f [apex] Small fixups 2022-07-25 19:42:02 +02:00
Andreas Dangel fb9762877f Merge pull request #4053 from Monits:qol
[core] Allow building PMD under Java 18+ #4053
2022-07-25 19:04:22 +02:00
Andreas Dangel 49835cb990 [doc] Update release notes (#4053) 2022-07-25 19:03:45 +02:00
Matt Hargett b189d07a15 Fix another superflous ws 2022-07-24 13:41:37 -07:00
Matt Hargett 5dc75e720b Remove superfluous whitespace' 2022-07-24 13:31:24 -07:00
Matt Hargett 8fa558e754 Add explaining comment, cleanup inconsistent fragment formatting 2022-07-24 13:26:37 -07:00
Matt Hargett 54918a7097 Comments have to go to HIDDEN channel so that suppression comments will work. 2022-07-24 13:19:21 -07:00
Matt Hargett f7f449ca2b Luau benchmarks and conformance suite all analyze fine, update test suite comment. 2022-07-24 13:09:30 -07:00
Matt Hargett 08cc6a1c5c World of Warcraft Lua uses a few non-standard escape patterns, which are easy enough to add and shouldn't introduce any confusions with errors messages on other dialects. 2022-07-24 13:04:14 -07:00
Matt Hargett 50b06f37bc Fortify the Lua parser to fix parse error in several OSS Lua codebases when trying to use CPD. 2022-07-24 12:58:49 -07:00
Andreas Dangel 907c0722b3 Merge pull request #4058 from oowekyala:pmd6-focused-test-attr
[test-schema] Add focused attr to the test schema #4058
2022-07-23 19:15:20 +02:00
Andreas Dangel 2f3f0d6960 [java] Refactor RegexpAcceptanceTest 2022-07-22 21:06:30 +02:00
Andreas Dangel bc7bbed1b4 [test] Remove unused code from RuleTst 2022-07-22 21:06:21 +02:00
Andreas Dangel cb5acd6389 [java] Remove usages of reinitializeRule and useAuxClasspath in rule tests
(#3976 / #3302)
2022-07-22 21:03:35 +02:00
Andreas Dangel d9984ec92f [test] Document deprecated attribute useAuxClasspath in schema 2022-07-22 21:01:25 +02:00
Clément Fournier c1b8d6a5d8 Fix PMD warning 2022-07-22 17:30:54 +02:00
Clément Fournier ee5fa8ee94 Update docs 2022-07-22 15:05:07 +02:00
Clément Fournier db430e64c5 add deprecations 2022-07-22 15:03:20 +02:00
Clément Fournier 8065929879 Add impl to parse focused attr 2022-07-22 14:43:30 +02:00
Clément Fournier 34acac180c Add focused attr to the schema 2022-07-22 14:15:37 +02:00
Andreas Dangel 4308aafe92 Update gems
Fixes https://github.com/pmd/pmd/security/dependabot/22
TZInfo relative path traversal vulnerability allows loading of arbitrary files
CVE-2022-31163
https://github.com/advisories/GHSA-5cm2-9h8c-rvfx
2022-07-22 14:14:12 +02:00
Andreas Dangel f13b212736 [test] Fix TestSchemaParser.Reporter: ClassWithOnlyPrivateConstructorsShouldBeFinal 2022-07-21 23:27:55 +02:00
Andreas Dangel 6d8c811403 [test] Correctly report available property names 2022-07-21 21:55:07 +02:00
Andreas Dangel 12516ff035 Fix deprecated attribute usage "regressionTest" 2022-07-21 21:25:33 +02:00
Andreas Dangel a8efa19d61 Merge pull request #3976 from oowekyala:pmd6-extract-test-schema-module
[test] Extract xml schema module #3976
2022-07-21 21:16:12 +02:00
Andreas Dangel bed3b17917 [doc] Update release notes (#3758, #3976) 2022-07-21 20:28:28 +02:00
Andreas Dangel bc1dd85f3b [test] Rename ignored -> disabled 2022-07-21 20:07:41 +02:00
Andreas Dangel 6471faa253 Fix pom parent ref 2022-07-21 19:44:53 +02:00
Andreas Dangel d09f981ce5 Merge branch 'master' into pr-3976 2022-07-21 19:10:13 +02:00
Andreas Dangel 029b4b2053 Merge pull request #4021 from tiobe:report_total_number_of_tokens
[core] CPD: Add total number of tokens to XML reports #4021
2022-07-21 17:33:02 +02:00
Andreas Dangel 4568176f21 [doc] Update release notes (#4021) 2022-07-21 16:48:40 +02:00
Andreas Dangel 43a17337fc [doc] Add deprecation notice for CPDRenderer 2022-07-21 16:48:23 +02:00
Andreas Dangel 94c19d2251 [core] Refactor CPDReport to use a List 2022-07-21 16:34:05 +02:00
Andreas Dangel 33bfd00303 [core] Refactor how CPD Renderers are determined 2022-07-21 16:27:02 +02:00
Andreas Dangel ee8622e54f [core] Internalize methods in CPDConfiguration and CPDRendererAdapter 2022-07-21 15:45:42 +02:00
Andreas Dangel ce6feada37 Merge branch 'master' into pr-4021 2022-07-21 15:00:56 +02:00
Andreas Dangel c31278504c Fix test under Windows 2022-07-21 10:53:50 +02:00
Gwilym Kuiper 94b3723da0 Use correct queries rather than the same as the Database.query ones 2022-07-20 16:48:05 +01:00
Gwilym Kuiper b3aab7c07e Now detect Database.countQuery as well as Database.query 2022-07-20 16:41:23 +01:00
Gwilym Kuiper c211759d86 Add tests for Database.countQuery by copying the Database.query tests 2022-07-20 16:40:46 +01:00
Juan Martín Sotuyo Dodero 2c8524866c [core] Allow building PMD under Java 18+
- Tests would fail due to the internal usage of SecurityManager without this flag
2022-07-20 01:23:09 -03:00
Andreas Dangel 84c5887f88 [doc] Fix missing additional rulesets
Fixes #4051
2022-07-19 20:40:39 +02:00
Clément Fournier a42913fb10 Merge branch 'pr/4032' 2022-07-16 18:10:42 +02:00
Clément Fournier ada87388b2 Merge branch 'master' into pr/4032 2022-07-16 15:08:00 +02:00
Andreas Dangel 0f2cb5a116 [java] Verify that "when" can still be used as type name (#4038, #4039) 2022-07-14 11:38:45 +02:00
Clément Fournier 8f36f5d523 Bump dependency nice-xml-messages
For a patch to the thing causing the
stackOverflow.
2022-07-13 21:21:37 +02:00
Clément Fournier fe0643d59a Merge branch 'master' into pmd6-extract-test-schema-module 2022-07-13 21:18:49 +02:00
Clément Fournier aae6d02c10 Merge branch 'pr/4038' 2022-07-13 20:05:11 +02:00
Clément Fournier 3a2eb2bfe4 Merge branch 'master' into pr/4038 2022-07-13 20:04:13 +02:00
Clément Fournier 9bbee061a8 fix remaining problems 2022-07-10 14:45:46 +02:00
Andreas Dangel b197daf84e Apply fixes from review (#4038) 2022-07-10 14:29:03 +02:00
Clément Fournier 07121bcbb5 Fix ignore behavior 2022-07-10 14:12:36 +02:00
Clément Fournier 0c1bad6972 Merge remote-tracking branch 'upstream/master' into pmd6-extract-test-schema-module 2022-07-10 13:57:29 +02:00
Andreas Dangel c83987f942 Merge pull request #3994 from 341816041:handling_issue_3729
[java] TooManyMethods - improve getter/setter detection (#3729) #3994
2022-07-07 15:59:33 +02:00
Andreas Dangel 3394263ec7 Merge pull request #3992 from dalizi007:parenthesis_iss#3949
[java] FinalFieldCouldBeStatic - fix false negative with unnecessary parenthesis #3992
2022-07-07 15:58:09 +02:00
Andreas Dangel 78e4ca6c04 [doc] Update release notes (#4015) 2022-07-07 15:42:13 +02:00
Andreas Dangel 13b55a8b9b [java] Verify that "when" can indeed still be used as identifier 2022-07-07 15:41:44 +02:00
Andreas Dangel 32a76bd602 [java] Remove language version 17-preview 2022-07-07 15:24:49 +02:00
Andreas Dangel a5b68ddfcf [java] Add support for RecordPatterns
See JEP 405
2022-07-07 15:06:52 +02:00
Andreas Dangel eeeccde494 [java] Update implementation for "Pattern Matching for switch"
See JEP 427
This is a preview feature
2022-07-07 15:03:20 +02:00
Andreas Dangel 2b6774e750 Bump org.ow2.asm:asm from 9.2 to 9.3 2022-07-07 11:06:20 +02:00
Andreas Dangel eb53daa2c2 [java] Add new language versions 19 and 19-preview 2022-07-07 10:44:13 +02:00
Andreas Dangel 71b5855d76 [doc] Update release notes (#3729, #3994) 2022-07-07 10:09:48 +02:00
Andreas Dangel 53747dd9ee Add @341816041 as a contributor 2022-07-07 10:09:31 +02:00
Andreas Dangel 8f3c7ee71d [java] Improve TooManyMethods (#3994) 2022-07-07 10:07:35 +02:00
Andreas Dangel 5fa2a6b976 Merge branch 'master' into pr-3994 2022-07-07 09:49:43 +02:00
Andreas Dangel 0a68e204b9 [doc] Update release notes (#3992, #3949) 2022-07-07 09:47:51 +02:00
Andreas Dangel a168bc239c [java] Improve FinalFieldCouldBeStatic (#3992) 2022-07-07 09:35:15 +02:00
Andreas Dangel fbb542688e Merge branch 'master' into pr-3992 2022-07-07 09:03:50 +02:00
Andreas Dangel 19a6b38bbd Merge pull request #3988 from VoidxHoshi:master
[java] Modify WhileLoopWithLiteralBoolean to meet the missing case #3455 #3988
2022-07-01 14:02:25 +02:00
Clément Fournier 5a87894b44 Merge remote-tracking branch 'upstream/master' into pmd6-extract-test-schema-module 2022-07-01 13:02:35 +02:00
Andreas Dangel a191bcb2f8 Merge pull request #3984 from LiGaOg:master
[java] Fix AddEmptyString false-negative issue #3984
2022-07-01 12:29:21 +02:00
Andreas Dangel 7557abb739 Update pmd-java/src/main/resources/category/java/performance.xml 2022-07-01 12:25:13 +02:00
Andreas Dangel c82505353c [doc] Update release notes (#3455, #3988) 2022-07-01 12:23:25 +02:00
Andreas Dangel 6fb5b3b960 [java] Improve WhileLoopWithLiteralBoolean (#3988) 2022-07-01 12:20:23 +02:00
Andreas Dangel 0abfa1bd72 Merge branch 'master' into pr-3988 2022-07-01 11:16:27 +02:00
Andreas Dangel f15cd8febc [java] AddEmptyString - fix false positive with scoping 2022-07-01 11:10:02 +02:00
Andreas Dangel cfcfa32dfb [doc] Update release notes (#3984, #3625) 2022-07-01 10:55:01 +02:00
Andreas Dangel d333e09f3d [java] Improve AddEmptyString (#3984) 2022-07-01 10:52:27 +02:00
Maikel Steneker 4d7890112d Move sorting to CPDReport class 2022-07-01 10:34:26 +02:00
Maikel Steneker f4dd873fc2 Remove catch from test case 2022-07-01 10:34:17 +02:00
Andreas Dangel 41798069a1 Merge branch 'master' into pr-3984 2022-07-01 10:31:08 +02:00
Andreas Dangel 06e166adec Merge pull request #4017 from tiobe:feature_gherkin
Add Gherkin support to CPD #4017
2022-07-01 09:20:30 +02:00
Andreas Dangel ed6ac96e49 [doc] Update release notes (#4017) 2022-07-01 09:18:03 +02:00
Andreas Dangel 326c03d5a4 Add @ASBrouwers as a contributor 2022-07-01 09:14:34 +02:00
Andreas Dangel b14d51829d [gherkin] Move CPD classes into specific gherkin package 2022-07-01 09:06:06 +02:00
Andreas Dangel fb79f527e8 [core] Avoid closing stdout for CPD as well 2022-06-30 20:05:13 +02:00
Andreas Dangel 5d3ffca1fc Fix imports (checkstyle) 2022-06-30 19:43:40 +02:00
Andreas Dangel 157e623c68 [core] If report is written to stdout, stdout should not be closed
Fixes #4031
2022-06-30 19:24:47 +02:00
Andreas Dangel eb87e074a1 Merge pull request #4024 from oowekyala:pmd6-plain-text-lang
[core] Add plain text language #4024
2022-06-30 18:25:32 +02:00
Andreas Dangel 0fb18f4b29 Add @stokpop as a contributor 2022-06-30 15:09:13 +02:00
Andreas Dangel e2fbe21917 Update @jborgers as a contributor 2022-06-30 15:09:01 +02:00
Maikel StenekerandClément Fournier a15758fcf9 Hide CPDReport constructor
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-06-30 11:56:44 +02:00
Maikel Steneker d544efee83 Improve encapsulation of CPD report contents 2022-06-30 11:11:58 +02:00
Maikel Steneker 9fc8a56e31 Add total number of tokens to XML reports 2022-06-29 11:35:36 +02:00
Anne Brouwers c5f06cdf88 Add Gherkin page to docs 2022-06-28 17:20:19 +02:00
Anne Brouwers 5897eb70bc Implement PR feedback 2022-06-28 17:19:18 +02:00
Anne Brouwers bedb6057de Merge branch 'master' into feature_gherkin 2022-06-28 17:16:47 +02:00
Clément Fournier e66ec711a5 Merge branch 'pmd6-plain-text-lang' into pmd6-extract-test-schema-module 2022-06-25 14:57:30 +02:00
Clément Fournier aae9c0cf78 checkstyle 2022-06-25 14:57:09 +02:00
Clément Fournier 76d5a0be01 Fix tests using PlainTextLang 2022-06-25 14:49:03 +02:00
Clément Fournier b77fe07f76 Merge branch 'pmd6-plain-text-lang' into pmd6-extract-test-schema-module 2022-06-25 14:45:54 +02:00
Clément Fournier 44b9b0a10a add plain text language 2022-06-25 14:44:14 +02:00
Andreas Dangel e98d2006df Bump pmd from 6.46.0 to 6.47.0 2022-06-25 11:39:17 +02:00
Andreas Dangel 129674e0d5 Prepare next development version [skip ci] 2022-06-25 09:33:00 +02:00
Andreas Dangel a5006f6383 [maven-release-plugin] prepare for next development iteration 2022-06-25 09:30:43 +02:00
Andreas Dangel 07eb3d2d80 [maven-release-plugin] prepare release pmd_releases/6.47.0 2022-06-25 09:30:37 +02:00
Andreas Dangel cf90c2141f Prepare pmd release 6.47.0 2022-06-25 09:15:59 +02:00
Andreas Dangel ed6cd9ae39 [doc] Update release notes - escape @ to not mention people on github 2022-06-24 15:50:11 +02:00
Andreas Dangel 25eb9d885b Merge pull request #4005 from adangel:sonatype-lift-issues
[core] Fix current sonatype lift issues #4005
2022-06-24 15:36:36 +02:00
Andreas Dangel bde5a0c191 Merge pull request #4003 from jjlharrison:master
[java] UnusedPrivateField: Ignore fields annotated with @Id, @EmbeddedId, @Version, @Mock, @Spy, or @MockBean #4003
2022-06-24 15:22:13 +02:00
Andreas Dangel 18dd7f1abb Merge pull request #4018 from oowekyala:issue4008_immutable_field
[java] Fix #4008 - ImmutableField FN with field assigned only in initializer #4018
2022-06-23 16:30:51 +02:00
Andreas Dangel c5e4b71646 [java] ImmutableField - remove now unnecessary defaultSuppressionAnnotations 2022-06-23 16:23:45 +02:00
Andreas Dangel 5b210a7239 Add @FSchliephacke as a contributor 2022-06-23 16:15:14 +02:00
Andreas Dangel de3f377c62 Add @HaelC as a contributor 2022-06-23 16:14:23 +02:00
Andreas Dangel 1694fb714f Add @lgemeinhardt as a contributor 2022-06-23 16:14:02 +02:00
Andreas Dangel 520ca80cc5 [doc] Update release notes for PR #4018
Fixes #3823
Fixes #4004
Fixes #4008
Fixes #4011
Fixes #4020
2022-06-23 16:13:11 +02:00
Andreas Dangel c1b6f7cc27 [java] ImmutableField - remove now unneeded default suppression annotations 2022-06-23 16:01:12 +02:00
Andreas Dangel 7f4ed46a6a [java] ImmutableField - add test case for JPA Entity (#3823) 2022-06-23 15:55:25 +02:00
Andreas Dangel 770e416de1 [java] ImmutableField - add test case for GwtMockito and Spy (Mockito) (#4004) 2022-06-23 15:51:11 +02:00
Andreas Dangel b68b7b6a87 [java] ImmutableField - add test case for Selenium (#4020) 2022-06-23 15:49:03 +02:00
Andreas Dangel f16532f0e0 [java] ImmutableField - add test case for @Inject (#4011) 2022-06-23 15:47:23 +02:00
Clément Fournier 5c05c105b7 Fix tests 2022-06-18 19:16:16 +02:00
Clément Fournier 5d8b210e6d Simplify 2022-06-17 06:51:17 +02:00
Clément Fournier efd0c9ed13 Fix #4008 2022-06-17 06:40:17 +02:00
Anne Brouwers ac2dcd8c4d Add Gherkin support to CPD 2022-06-16 16:38:20 +02:00
Andreas Dangel d787604c52 Bump maven from 3.8.5 to 3.8.6 2022-06-14 18:53:27 +02:00
James Harrison cce5bec391 Merge branch 'master' into master 2022-06-14 16:40:28 +01:00
Andreas Dangel 2ce74f6d4f Merge pull request #4000 from adangel:fix-cli-file-list-3999
[core] Fix cli when only --file-list is used #4000
2022-06-13 19:05:04 +02:00
Andreas Dangel de01d20458 Merge pull request #4007 from adangel:pmd7-new-m-pmd-p
Use maven-pmd-plugin 3.18.0-pmd7-SNAPSHOT for pmd7 #4007
2022-06-13 18:48:34 +02:00
Andreas Dangel 12a3ba060e Merge pull request #4010 from tiobe:bump_kotlin
[core] Bump kotlin to version 1.7.0 #4010
2022-06-13 18:33:52 +02:00
Andreas Dangel d5e9cde2d1 [doc] Update release notes (#4009, #4010) 2022-06-13 18:32:42 +02:00
Andreas Dangel 176b5d3e17 Merge pull request #4000 from adangel:fix-cli-file-list-3999
[core] Fix cli when only --file-list is used #4000
2022-06-13 18:27:45 +02:00
Andreas Dangel 5bbb5b1763 Merge pull request #4006 from shiomiyan:patch-1
[doc] Fix eclipse plugin update site URL #4006
2022-06-13 18:25:43 +02:00
Andreas Dangel c1d3324abe Add @shiomiyan as a contributor 2022-06-13 18:24:55 +02:00
Andreas Dangel 0c647f5365 [doc] Update release notes (#4006) 2022-06-13 18:24:35 +02:00
Andreas Dangel 02a7d4e0dd Use maven-pmd-plugin 3.18.0-pmd7-SNAPSHOT for pmd7 2022-06-13 18:18:43 +02:00
Maikel Steneker f2d1c95102 Bump dokka maven plugin from 1.4.32 to 1.6.21 2022-06-13 11:44:32 +02:00
Maikel Steneker 179578dffb Bump kotlin from 1.4.32 to 1.7.0 2022-06-13 11:43:04 +02:00
shiomiyanandAndreas Dangel a9b8991700 Update docs/pages/pmd/userdocs/tools/tools.md
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-06-11 01:25:02 +09:00
shiomiyan 8fbedb3a0f fix documentation link 2022-06-10 13:08:09 +09:00
Clément Fournier c4809825fd Merge branch 'master' into fix-cli-file-list-3999 2022-06-09 17:22:16 -07:00
Andreas Dangel 9537629e58 Upgrade com.google.protobuf:protobuf-java from 3.7.1 to 3.16.1
Fixes CVE-2021-22569 A potential Denial of Service issue in protobuf-java
https://github.com/protocolbuffers/protobuf/security/advisories/GHSA-wrvw-hg22-4m67
2022-06-09 16:22:29 +02:00
Andreas Dangel a8a61f2c44 Upgrade io.github.classgraph:classgraph from 4.8.102 to 4.8.112
Fixes [sonatype-2021-1074] CWE-611: Improper Restriction of XML External Entity Reference ('XXE')
2022-06-09 16:19:28 +02:00
Andreas Dangel 4b2c3fa1a4 Exclude commons-io (CVE-2021-29425)
Refactor last test usages to use PMD's IOUtil instead.
2022-06-09 16:15:19 +02:00
Andreas Dangel 872111f2a1 chore: retry git push sync
During the release it can happen, that two pushes are executed fast one after another.
This could lead to gh action jobs overlapping while trying to push to sourceforge leading
to errors like "remote: error: cannot lock ref 'refs/heads/master': is at XXX but expected
YYY".
2022-06-09 14:59:07 +02:00
James Harrison b4916d6a4b UnusedPrivateField: Ignore fields annotated with @Id, @EmbeddedId, @Version, @Mock, @Spy, or @MockBean 2022-06-09 07:52:19 +01:00
Andreas Dangel b90c5f3ae3 chore: Regenerate credits.md 2022-06-08 18:58:18 +02:00
Andreas Dangel f5e3ab9ab6 Merge pull request #4002 from jjlharrison:master
[java] ImmutableField: Ignore @Value (Spring) and @Captor (Mockito) #4002
2022-06-08 18:56:26 +02:00
Andreas Dangel 6ecaa64beb Bump maven-pmd-plugin from 3.16.0 to 3.17.0 2022-06-07 19:41:37 +02:00
James Harrison e29a589970 [java] ImmutableField: Ignore @Value (Spring) and @Captor (Mockito) 2022-06-07 10:58:38 +01:00
Andreas Dangel 021c5a25e8 chore: Check for SNAPSHOT build tools and other SNAPSHOTs 2022-06-04 15:49:01 +02:00
Andreas Dangel e6669f13d5 Merge pull request #3985 from Scrsloota:master
[java] Fix false negative problem about Enum in AvoidFieldNameMatchingMethodName #3936
2022-06-04 15:15:58 +02:00
Andreas Dangel 62d27c07b4 [doc] Update release notes (#3936, #3985) 2022-06-04 15:14:35 +02:00
Andreas Dangel 066b510eef chore: Fix project.parent.relativePath in pom.xml
It must point to a file, pointing to a directory
is not valid.
2022-06-04 11:00:30 +02:00
Andreas Dangel 1e99280cab [core] Fix cli when only --file-list is used
Fixes #3999
2022-06-04 10:27:57 +02:00
Scrsloota 051951e852 change to avoid instanceof checks 2022-06-02 23:43:31 +08:00
Scrsloota a442f41d6f Merge branch 'pmd:master' into master 2022-06-02 18:41:30 +08:00
Andreas Dangel 973eaefd0a Merge pull request #3993 from dalizi007:buz_definition_#3937
[java] AvoidDuplicateLiterals - Add the method buz definition to test cases #3993
2022-06-02 11:36:31 +02:00
Andreas Dangel 74c9ebb15a Add @dalizi007 as a contributor 2022-06-02 11:35:42 +02:00
Andreas Dangel 25e59bc2ee [doc] Update release notes (#3937, #3993) 2022-06-02 11:35:19 +02:00
茅延安 7f5f0406ec Update design.xml 2022-06-01 09:51:23 +08:00
茅延安 3c1a246fe9 handle issue 3729 2022-05-29 22:43:32 +08:00
dalizi007 75f7836b3e Merge branch 'pmd:master' into buz_definition_#3937 2022-05-28 23:58:00 +08:00
dalizi007 6111951e6c [java] Add the method "buz" definition #3937 2022-05-28 23:55:47 +08:00
dalizi007 077005f7b4 Merge branch 'pmd:master' into parenthesis_iss#3949 2022-05-28 23:50:17 +08:00
dalizi007 a5b0a3239c [java] fix false negative with unnecessary parenthesis pmd#3949 2022-05-28 23:46:34 +08:00
HoshiNoMei d4b356a68e Fix the rule xml WhileLoopWithLiteralBoolean 2022-05-28 22:30:06 +08:00
Scrsloota 8723839a4d Merge branch 'pmd:master' into master 2022-05-28 21:06:22 +08:00
HoshiNoMei ca562fc133 Fix the rule xml WhileLoopWithLiteralBoolean 2022-05-28 20:35:19 +08:00
Andreas Dangel 459c23a8b6 Bump build-tools from 17-SNAPSHOT to 18 2022-05-28 11:56:10 +02:00
Andreas Dangel 44e7aec80f Bump pmd from 6.45.0 to 6.46.0 2022-05-28 11:42:52 +02:00
Andreas Dangel c3f6be479b Prepare next development version [skip ci] 2022-05-28 11:05:56 +02:00
Andreas Dangel 04c1271d88 [maven-release-plugin] prepare for next development iteration 2022-05-28 11:04:32 +02:00
Andreas Dangel a75acdeff8 [maven-release-plugin] prepare release pmd_releases/6.46.0 2022-05-28 11:04:27 +02:00
Andreas Dangel 6f86a711f5 Prepare pmd release 6.46.0 2022-05-28 10:50:43 +02:00
Andreas Dangel 09c1abbf8c Merge pull request #3980 from adangel:deprecate-ant-formatter
[core] Internalize some methods in Ant Formatter #3980
2022-05-28 09:09:49 +02:00
Andreas Dangel ede4c6d4fc Merge pull request #3979 from adangel:deprecate-cpd-system-props
[core] Internalize CPDCommandLineInterface #3979
2022-05-28 09:07:46 +02:00
Andreas Dangel 3779a54f8a Merge pull request #3978 from adangel:html-extensions
[html] Add additional file extensions htm, xhtml, xht, shtml #3978
2022-05-28 09:05:42 +02:00
Andreas Dangel 16df537813 Merge pull request #3958 from oowekyala:issue2352-ruleset-deprecations
[core] Deprecate some syntax for ruleset references #3958
2022-05-28 09:04:23 +02:00
Andreas Dangel 3b774eb513 Merge pull request #3716 from oowekyala:merge-empty-rules
[java] Merge rules that check for empty things #3716
2022-05-28 09:02:42 +02:00
Andreas Dangel 95ad4d3f0a [doc] Update release notes (#3096) 2022-05-28 09:01:58 +02:00
Andreas Dangel 650e66bb3d [doc] Update release notes (#2352, #3958) 2022-05-27 18:32:44 +02:00
Andreas Dangel 425015c3b6 Merge branch 'master' into pr/3958 2022-05-27 18:30:21 +02:00
Scrsloota 7261b7fd10 add test cases 2022-05-28 00:17:32 +08:00
Scrsloota 1a62ddffad fix AvoidFieldNameMatchingMethodName without enum 2022-05-28 00:17:11 +08:00
Andreas Dangel e41ac3d239 [java] EmptyControlStatementRule - fix messages 2022-05-27 17:59:29 +02:00
Andreas Dangel 02581bcc4a [java] EmptyControlStatementRule - fix messages 2022-05-27 17:36:01 +02:00
Andreas Dangel 6524ae9d33 [java] Rename ASTResource#getName to getStableName 2022-05-27 17:16:02 +02:00
Andreas Dangel 88a1ae80a6 [doc] Update release notes with new rules 2022-05-27 15:55:03 +02:00
Andreas Dangel 0224b6bd01 [java] Deprecate Empty* rules 2022-05-27 15:48:38 +02:00
Andreas Dangel 8b4d16b029 Update pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/EmptyControlStatement.xml 2022-05-27 15:24:06 +02:00
Andreas DangelandClément Fournier 3630c3732a Apply suggestions from code review
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-05-27 15:23:31 +02:00
Andreas Dangel ee0e4f8685 [java] Fix rule reference 2022-05-27 15:19:47 +02:00
Andreas Dangel 7ed7fc0e42 [java] EmptyControlStatement: Fix NPE for concise try-with-resources 2022-05-27 15:04:36 +02:00
Andreas Dangel 0ef01e0fb5 [java] EmptyControlStatement: Fix NPE for if without else 2022-05-27 14:54:38 +02:00
Andreas Dangel 91cd958a20 Merge branch 'master' into pr/3716 2022-05-27 14:13:19 +02:00
李家奥 dcc6977168 add test cases 2022-05-27 16:10:05 +08:00
李家奥 b741ce261c fix addEmptyString in performance.xml 2022-05-27 15:32:05 +08:00
Andreas Dangel 42b4f366bc [doc] Fix javadoc refs in release notes 2022-05-26 20:39:06 +02:00
Andreas Dangel 4bc13520f0 [core] Internalize some methods in Ant Formatter
- Fixes #3787
2022-05-26 20:34:47 +02:00
Andreas Dangel e530bff3f9 [core] Internalize CPDCommandLineInterface
Fixes #3835
2022-05-26 20:13:22 +02:00
Andreas Dangel 0eb745e187 [doc] Update release notes (#3978) 2022-05-26 18:48:26 +02:00
Andreas Dangel 3d898527ee [html] Add additional file extensions htm, xhtml, xht, shtml
xhtml and xht is application/xhtml+xml
shtml is text/html with server side includes
2022-05-26 18:45:30 +02:00
Andreas Dangel 51fa5e400f Merge pull request #3968 from adangel:replace-commons-io
[core] Replace commons-io #3968
2022-05-26 15:46:28 +02:00
Andreas Dangel 108b670268 Add @filipponova as a contributor 2022-05-26 15:27:14 +02:00
Andreas Dangel 67629e13d0 Merge pull request #3968 from adangel:replace-commons-io
[core] Replace commons-io #3968
2022-05-26 15:26:22 +02:00
Andreas Dangel 1cbb942852 Merge pull request #3966 from adangel:usearraysaslist-fixes
[java] UseArraysAsList fixes #3966
2022-05-26 15:11:16 +02:00
Andreas Dangel 4235ccb9eb Merge pull request #3967 from adangel:update-kotlin-reflect
Bump kotlin from 1.4.10 to 1.4.32 #3967
2022-05-26 15:08:06 +02:00
Andreas Dangel 8e66fc627b Merge branch 'master' into replace-commons-io 2022-05-26 15:01:30 +02:00
Andreas Dangel 5d923bee19 Merge pull request #3961 from flyhard:#3954
[java] Fix #3954 - NPE in UseCollectionIsEmptyRule with record #3961
2022-05-26 11:04:05 +02:00
Andreas Dangel 6f234bab8d Add @flyhard as a contributor 2022-05-26 11:03:34 +02:00
Andreas Dangel 95d6619a6b Add @Ramel0921 as a contributor 2022-05-26 11:03:20 +02:00
Andreas Dangel 11cda428f1 [doc] Update release notes (#3954, #3961) 2022-05-26 11:03:01 +02:00
Andreas Dangel 5428d280b3 Merge branch 'master' into pr/3961 2022-05-26 11:01:03 +02:00
Andreas Dangel 416306fa47 Merge pull request #3974 from tiobe:ignore_attributes
[cs] Add option to ignore C# attributes (annotations) #3974
2022-05-26 10:58:07 +02:00
Andreas Dangel d0873ff6fa [doc] Update release notes (#3974) 2022-05-26 10:57:08 +02:00
Andreas Dangel ba8762c9b8 Merge branch 'master' into pr/3974 2022-05-26 10:52:31 +02:00
Andreas Dangel e35ac06167 Merge pull request #3946 from oowekyala:java-unicode
[java] [js] [go] [python] Improve unicode support #3946
2022-05-26 10:51:48 +02:00
Andreas Dangel aae06c45ac [doc] Update release notes (#3946, #3423, #2605, #2604, #2752) 2022-05-26 10:36:55 +02:00
Andreas Dangel 7e4340afc4 Merge branch 'master' into pr/3946 2022-05-26 10:33:34 +02:00
Andreas Dangel 7ab71abb4a Merge branch 'master' into pr/3961 2022-05-26 10:31:04 +02:00
Andreas Dangel aef06d4b3a Add @vibhory2j as a contributor 2022-05-26 10:28:18 +02:00
Andreas DangelandClément Fournier 01c48e1ca7 [doc] Update release notes (#3960)
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-05-26 10:26:03 +02:00
Clément Fournier ebd009e16a Replace old schema with newer one
(This is backward compatible)
2022-05-21 13:21:38 +02:00
Clément Fournier bf0b451397 Cleanup new schema 2022-05-21 13:21:01 +02:00
Clément Fournier b9342f736f Cleanup schema, add ignore attribute 2022-05-20 20:29:51 +02:00
Clément Fournier 42dcc3c779 Update RuleTst 2022-05-20 20:18:05 +02:00
Andreas Dangel ab2484801f Merge pull request #3955 from adangel:pmd-html-improvements
[html] Improvements for handling text and comment nodes #3955
2022-05-20 14:25:50 +02:00
Andreas Dangel fd7cae278e [doc] Update release notes (#3955) 2022-05-20 14:24:42 +02:00
Andreas Dangel 5b2d2d5eb8 Merge pull request #3960 from oowekyala:issue1445-cli-globs
[core] Support globs in CLI #3960
2022-05-20 14:22:23 +02:00
Andreas Dangel 5736b38d2f Merge pull request #3964 from lukelukes:master
[java] Fix #3874 - ImmutableField: fix mockito/spring false positives #3964
2022-05-20 14:19:52 +02:00
Clément Fournier 519ad318b7 Cleanups 2022-05-20 13:44:33 +02:00
Clément Fournier 1801b691f6 Add tests 2022-05-20 13:30:52 +02:00
Clément FournierandAndreas Dangel 380d81ca8f Add todo comment
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2022-05-20 10:24:24 +02:00
Andreas Dangel 1a596693fd [html] Added test case to verify #text doesn't find text nodes anymore 2022-05-20 09:56:49 +02:00
Andreas Dangel 85095f19d3 [html] Added test case to verify #text doesn't find text nodes anymore 2022-05-20 09:54:48 +02:00
Andreas DangelandClément Fournier 7736980475 Apply suggestions from code review
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-05-20 09:51:45 +02:00
Maikel Steneker 91328436a0 Clarify documentation on --ignore-annotations CLI option 2022-05-20 09:35:53 +02:00
Andreas Dangel a2fa69f464 Merge branch 'master' into pr/3960 2022-05-20 09:31:59 +02:00
Andreas Dangel 8c55824dc4 Merge branch 'master' into pr/3964 2022-05-20 09:27:09 +02:00
Andreas Dangel d9fce6107e Add @lukelukes as a contributor 2022-05-20 09:26:11 +02:00
Andreas Dangel 8a99dee911 [java] Update test case (ImmutableField) 2022-05-20 09:08:05 +02:00
Andreas Dangel 2daa3381b4 [doc] Update release notes (#3874, #3964) 2022-05-20 09:06:29 +02:00
Andreas DangelandClément Fournier c53a64c688 Update pmd-core/src/main/java/net/sourceforge/pmd/util/IOUtil.java
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-05-20 08:51:52 +02:00
Clément Fournier 60139c8f4a Most of the work to extract module
Need a release of nice-xml-messages
Need an update to pmd-test
Need to add the 'ignored' attribute to schema
2022-05-17 23:34:17 +02:00
Clément Fournier fa41583254 Fix tests 2022-05-17 21:31:43 +02:00
Clément Fournier 9f98d5e264 Merge branch 'master' into issue2352-ruleset-deprecations 2022-05-17 21:17:34 +02:00
Maikel Steneker 7921e836b1 Add option to ignore C# attributes (annotations) 2022-05-16 16:45:08 +02:00
Andreas DangelandClément Fournier e8935523ed Update pmd-java/src/main/resources/category/java/performance.xml
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-05-13 20:07:18 +02:00
Andreas Dangel 1b5f7e8bae [core] Remember forced language per file
Fixes #3970
2022-05-13 19:57:08 +02:00
Andreas Dangel 8fc4e7e1c9 Merge branch 'master' into replace-commons-io 2022-05-13 18:40:30 +02:00
Andreas Dangel 9d23d79802 [ci] regression test - skip patching/building spring
The regression tester now does not anymore
execute a "git reset"... and the patched
files stay in place in the github actions cache.
2022-05-13 18:40:05 +02:00
Andreas Dangel a9219b7967 [core] Fix bug in IOUtil.fromReader 2022-05-13 17:13:16 +02:00
Andreas Dangel 8addd05369 Fix tests under Windows 2022-05-13 16:43:17 +02:00
Andreas Dangel 1c9096809d [doc] Update release notes (#3942) 2022-05-13 15:25:24 +02:00
Andreas Dangel cfacfbbff2 Fix tests under Windows 2022-05-13 15:18:03 +02:00
Andreas Dangel bef7eed0ec [doc] Replace IOUtils with IOUtil 2022-05-13 12:03:16 +02:00
Andreas Dangel a1922c5956 [dist] Replace IOUtils with IOUtil 2022-05-13 12:03:16 +02:00
Andreas Dangel a4ebb66769 Replace IOUtils with IOUtil
plsql, xml, apex, html, javascript, scala
2022-05-13 12:03:15 +02:00
Andreas Dangel abfc463ef9 Update build-tools to 18-SNAPSHOT 2022-05-13 12:03:15 +02:00
Andreas Dangel 2887fe3ae0 [core] Replace IOUtils with IOUtil 2022-05-13 12:03:15 +02:00
Andreas Dangel 753cb49e40 [all] Remove dependency to commons-io 2022-05-13 12:03:14 +02:00
Andreas Dangel 4944177cc4 [core] Add missing methods to IOUtil as replacement for IOUtils 2022-05-13 12:03:14 +02:00
Andreas Dangel a28c239921 Bump kotest from 4.3.1 to 4.4.3 2022-05-12 18:08:36 +02:00
Andreas Dangel 03a51a73a5 Bump kotlin from 1.4.10 to 1.4.32
Fixes https://nvd.nist.gov/vuln/detail/CVE-2020-29582
2022-05-12 17:48:04 +02:00
Andreas Dangel 8d5fda07be Merge branch 'master' into usearraysaslist-fixes 2022-05-12 17:36:08 +02:00
Andreas Dangel dc512e8a04 [ci] Update gems
- update pmdtester from 1.5.0 to 1.5.1
- update nokogiri from 1.13.5 to 1.13.6
- update activesupport from 6.0.4.8 to 6.0.5
2022-05-12 17:33:54 +02:00
Andreas Dangel f81752dc57 [java] UseArraysAsList - skip primitive arrays
Fixes #3379
2022-05-12 15:54:47 +02:00
Andreas Dangel 28b0d13da9 [java] UseArraysAsList - ignore non-trivial loops
Fixes #3965
2022-05-12 15:16:49 +02:00
Luke Lukes 402939f9cc [java] ImmutableField: fix mockito/spring false positives 2022-05-10 14:56:10 +03:00
Per Abich d0ed105b90 Slight refactoring of my changes to reduce complexity 2022-05-09 09:12:33 +02:00
Clément Fournier 8d7074dbaa Improve doc for parameters 2022-05-08 15:17:40 +02:00
Per Abich f85a635669 Fixed checkstyle violations 2022-05-08 13:02:15 +02:00
Per Abich 418fe220b9 Fixed #3954 missing reporting of issue on records. 2022-05-08 12:45:40 +02:00
Per Abich 5657559026 Fixed #3954 and wrote test confirming it. 2022-05-08 11:55:20 +02:00
Clément Fournier 90ef710c48 release notes 2022-05-07 19:33:29 +02:00
Clément Fournier e7229407d4 Fix tests 2022-05-07 19:29:00 +02:00
Clément Fournier 06d0d6b0fb More tests, release notes 2022-05-07 18:59:21 +02:00
Clément Fournier 686e878caf Fix #1445 - Allow CLI to take globs as parameters
This doesn't interpret globs or anything, only
makes the parameter parsing compatible with shell
expansion. Globs are therefore available provided
you use a shell with that feature
2022-05-07 18:42:45 +02:00
Clément Fournier f27ea900ab Fix test 2022-05-07 17:02:14 +02:00
Clément Fournier abf7d71e2e Remove doc for deprecated things 2022-05-07 14:56:37 +02:00
Clément Fournier b0fd5c4400 Update release notes 2022-05-07 14:36:16 +02:00
Clément Fournier 0542b333a6 Add tests and fix logic
Another change is that the error in case of unresolved ruleset
doesn't just dump the entire classpath, which is unreadable.
Instead the classpath is logged with a debug level at the start
of execution.
2022-05-07 14:30:48 +02:00
Clément Fournier db9a1d9067 Deprecate some syntax about ruleset references
Some undocumented ruleset reference forms are deprecated:
- java-basic (resolves to rulesets/java/basic.xml), refs #2352
- 641 (resolves to rulesets/releases/641.xml)

Also using `<rule ref="rset1.xml,rset2.xml">` is deprecated.
As before, only the first ruleset is considered, but now the
rest is not ignored silently.

Refs #2612
2022-05-07 13:55:53 +02:00
Andreas Dangel ec8e42ad2b Merge branch 'master' into pmd-html-improvements 2022-05-06 16:02:05 +02:00
Andreas Dangel 46727eb5d7 [html] Document XPath 2.0 only and text nodes handling 2022-05-06 15:52:59 +02:00
Andreas Dangel 3538c6d3bd [core] Improve support for #text and #comment node types 2022-05-06 15:52:12 +02:00
Andreas Dangel d3880443f7 [ci] Update gems
- update pmtester from 1.4.1 to 1.5.0
- update nokogiri from 1.13.4 to 1.13.5
2022-05-06 15:05:20 +02:00
Andreas Dangel 0973206dda [ci] Update project-list.xml
- use same exclusion in pmd6 and pmd7 for checkstyle
- use original repos with commit sha1 for fflib-apex-common and Schedul-o-matic-9000
2022-05-06 14:48:52 +02:00
Andreas Dangel eae87d26a7 Merge pull request #3950 from oowekyala:issue3948-js-parse-error
[js] Fix object property with method type #3950
2022-05-03 19:27:59 +02:00
Clément Fournier b5b07b48bf update release notes 2022-05-02 19:19:37 +02:00
Clément Fournier d39ff7df9b [js] Fix object property with method type
Fix #3948
2022-05-02 19:19:37 +02:00
Clément Fournier f80c73e44f Test dollar in ident in python 2022-05-01 18:56:45 +02:00
Clément Fournier 078345fbca Add phonetic extensions to other langs 2022-05-01 18:16:53 +02:00
Clément Fournier e6054e4b65 Add another test case for java 2022-05-01 18:09:04 +02:00
Clément Fournier 669f2fecbd Same for go
Fix #2752
2022-05-01 17:59:21 +02:00
Clément Fournier 71b9362828 [python] unicode support
Fix #2604
2022-05-01 17:51:38 +02:00
Clément Fournier b328bc5fdc Add more cjk and exotic scripts, also to JS
Fix #2605
2022-05-01 17:47:11 +02:00
Clément Fournier 98f44b7e3f Allow Phonetic Extensions block in java
Fix #3423
2022-05-01 17:31:52 +02:00
Andreas Dangel 86891b0c6d Bump pmd from 6.44.0 to 6.45.0 2022-04-30 10:27:59 +02:00
Andreas Dangel b5dfd05c00 Prepare next development version [skip ci] 2022-04-30 09:41:05 +02:00
Andreas Dangel ec64315ad7 [maven-release-plugin] prepare for next development iteration 2022-04-30 09:38:24 +02:00
Andreas Dangel 1d2b40b3c0 [maven-release-plugin] prepare release pmd_releases/6.45.0 2022-04-30 09:38:19 +02:00
Andreas Dangel 2212ff1fca Prepare pmd release 6.45.0 2022-04-30 09:25:31 +02:00
Andreas Dangel e4577c47ea [doc] Add user survey to release notes (#3814) 2022-04-30 09:18:09 +02:00
Andreas Dangel 915b7f8b61 Merge pull request #3939 from adangel:improved-rule-test-support
[test] Print Test Method Name for failed rule tests #3939
2022-04-29 12:36:44 +02:00
Andreas Dangel efcc583086 [test] Improve test method name, display test method 2022-04-29 12:22:44 +02:00
Andreas Dangel 094bb1310a Update gems 2022-04-29 12:06:23 +02:00
Andreas Dangel 4eb2471939 Update gems
Fixes Command injection in ruby-git
(https://github.com/pmd/pmd/security/dependabot/21)
2022-04-29 12:01:29 +02:00
Andreas Dangel e110a84473 Merge pull request #3943 from turrisxyz:setup-permissions
chore: Set permissions for GitHub actions #3943
2022-04-29 11:58:38 +02:00
Andreas Dangel 47beb1c3cd Add @naveensrinivasan as a contributor 2022-04-29 11:57:00 +02:00
Andreas Dangel 94057f688d [doc] Update release notes (#3943) 2022-04-29 11:56:36 +02:00
Andreas Dangel c224209d7f [test] Backport NodePrinters.kt from pmd7 2022-04-29 11:38:52 +02:00
naveen 57dfc7fb40 chore: Set permissions for GitHub actions
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
2022-04-29 01:00:46 +00:00
Andreas Dangel de13682753 [core] Support #text and #comment nodes 2022-04-28 15:43:26 +02:00
Andreas Dangel d407a92dfc Merge pull request #3885 from adangel:html-jsoup
[html] Add support for HTML using jsoup parser #3885
2022-04-28 15:07:19 +02:00
Andreas Dangel 3336b1ccd4 [doc] Update release notes 2022-04-28 15:05:26 +02:00
Andreas Dangel c9fa05d2c7 Merge pull request #3938 from VoidxHoshi:master
[java] Modify SimplifiedTernary to meet the missing case #3603 #3938
2022-04-28 15:03:28 +02:00
Andreas Dangel d94f85f443 Add @VoidxHoshi as a contributor 2022-04-28 15:01:16 +02:00
Andreas Dangel 0af3883607 [doc] Update release notes (#3603, #3938) 2022-04-28 15:00:55 +02:00
Andreas Dangel 1e5d69d722 Merge pull request #3935 from Scrsloota:master
[plsql] Fix parser exception in EXECUTE IMMEDIATE BULK COLLECT #3687 #3935
2022-04-28 14:55:49 +02:00
Andreas Dangel 69c7f4b2ad Merge pull request #3930 from adangel:improve-ArrayIsStoredDirectly
[java] Improve rule ArrayIsStoredDirectly #3930
2022-04-28 14:54:15 +02:00
Andreas Dangel 4d78148504 Merge pull request #3900 from adangel:issue-3867-usearraysaslist
[java] Fix UseArraysAsList with method calls #3900
2022-04-28 14:51:31 +02:00
Andreas Dangel da0478d244 Merge pull request #3862 from adangel:report-mutable
[core] Add transformation methods to Report #3862
2022-04-28 14:48:41 +02:00
Andreas DangelandClément Fournier 56cc599b91 Update pmd-core/src/main/java/net/sourceforge/pmd/Report.java
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-04-28 12:11:08 +02:00
Andreas Dangel f48ab0e509 [doc] Mark package n.s.p.lang.html experimental 2022-04-28 11:57:30 +02:00
Andreas Dangel 84b6cfe93f [doc] Update release notes (#3687, #3935) 2022-04-28 11:38:20 +02:00
Andreas Dangel 061d0d6724 Add @Scrsloota as a contributor 2022-04-28 11:35:52 +02:00
Andreas Dangel 8370d6253d [plsql] Fix usage of "IN" - it is a reserved word 2022-04-28 11:34:25 +02:00
Andreas Dangel 35b6cc79ca [plsql] Refactor execute immediate statement
- It is now more compliant to the specification
- Add new AST node DynamicReturnClause
2022-04-28 10:57:59 +02:00
Andreas Dangel 45e4ec9e98 [plsql] Migrate ExecuteImmediateBulkCollectTest to BaseTreeDumpTest 2022-04-28 09:58:59 +02:00
LaLucidandClément Fournier f29770f968 Use a more clear XPath form
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-04-27 05:47:07 +08:00
LaLucid e951d6df8f Use a more clear XPath form to replace the former 2022-04-27 04:07:02 +08:00
LaLucid 3841e7d0c9 Revert the original XPath 2022-04-25 06:50:56 +08:00
Andreas Dangel 6ec5fe1073 Fix pmd 2022-04-24 22:44:05 +02:00
Andreas Dangel 1f9c7c5765 [test] Print Test Method Name for failed rule tests
This helps to select just this failed test to
rerun it within the IDE.
Also replace parenthesis in the test case description.
2022-04-24 22:29:36 +02:00
LaLucid f1a2a77e64 modify the SimplifiedTernary test 2022-04-25 03:31:19 +08:00
LaLucid 56cc9fc163 make the description simple 2022-04-25 02:35:34 +08:00
LaLucidandClément Fournier 38d3c091d0 Update pmd-java/src/main/resources/category/java/design.xml
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-04-25 02:27:26 +08:00
LaLucidandClément Fournier 28a454d155 Update pmd-java/src/main/resources/category/java/design.xml
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-04-25 02:25:18 +08:00
HoshiNoMei 996f81ccce Modify the rule to meet the missing case 2022-04-24 23:36:46 +08:00
wsf 1a2682d5f8 fix ExecuteImmediateBulkCollect bug and add some test cases 2022-04-23 17:31:16 +08:00
Andreas Dangel e6254baaae Merge remote-tracking branch 'adangel/html-jsoup' into html-jsoup 2022-04-22 12:40:44 +02:00
Andreas Dangel 0e6ad2dc63 [html] Add documentation (#3885) 2022-04-22 12:34:59 +02:00
Andreas Dangel 83c07a540b [html] New rule UseAltAttributeForImages which uses rule chain 2022-04-22 12:01:55 +02:00
Andreas Dangel b3871a1476 [html] New rule UnnecessaryTypeAttributeRule 2022-04-22 11:39:38 +02:00
Andreas Dangel 3e8274fd0d [html] Rename AST nodes 2022-04-22 11:38:40 +02:00
Andreas Dangel 004a59ab04 [html] Add visitor, add tests for xpath and java rules 2022-04-22 10:49:13 +02:00
Andreas Dangel 62bedd301a Merge branch 'master' into html-jsoup 2022-04-22 08:55:55 +02:00
Andreas Dangel 24f4b2ecb6 [ci] Fix maven-pmd-plugin configuration 2022-04-22 08:20:46 +02:00
Andreas Dangel 23997a15d7 Fix pmd dogfood - ClassWithOnlyPrivateConstructorsShouldBeFinal 2022-04-21 21:06:31 +02:00
Andreas Dangel 764920f61f Fix unit test under Windows 2022-04-21 17:14:11 +02:00
Andreas Dangel 9b2a92bc52 Merge pull request #3921 from oowekyala:issue3068-mock-rules-for-cli-tests
[java] Make cli tests use dummy rules #3921
2022-04-21 16:55:29 +02:00
Andreas Dangel ab1cb6d0e9 Merge pull request #3910 from laoseth:master
[java] UnusedPrivateField - Allow the ignored fieldnames to be configurable #3910
2022-04-21 16:52:36 +02:00
Andreas Dangel 29175e0c90 [doc] Update release notes (#3910) 2022-04-21 16:51:58 +02:00
Andreas Dangel e1868543ad Merge branch 'master' into pr-3910 2022-04-21 16:49:49 +02:00
Andreas Dangel dc4894d0f5 Add @laoseth as a contributor 2022-04-21 16:45:30 +02:00
Andreas Dangel 455cd962eb Update docs/pages/release_notes.md 2022-04-21 16:43:29 +02:00
Andreas Dangel b0f349085d Merge pull request #3896 from oowekyala:fix-dump-cli
[core] Fix ast-dump CLI when reading from stdin #3896
2022-04-21 16:41:51 +02:00
Andreas Dangel 8e0eac97bc Fix unit test 2022-04-21 16:30:13 +02:00
Andreas Dangel cfc981fc8e [doc] Update release notes (#3896) 2022-04-21 16:22:18 +02:00
Andreas Dangel bb564be0b1 [core] AbstractParser.setFileName is InternalApi 2022-04-21 16:21:48 +02:00
Andreas Dangel aa50b6f28c Merge branch 'master' into pr-3896 2022-04-21 16:19:38 +02:00
Andreas Dangel 8b7aa436a0 Merge branch 'master' into report-mutable 2022-04-21 15:55:53 +02:00
Andreas Dangel d6b736f676 [core] Report - Mark new methods as @Experimental 2022-04-21 15:53:59 +02:00
Andreas DangelandClément Fournier a098ab17ac Apply suggestions from code review
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-04-21 15:41:37 +02:00
Andreas Dangel f27c6453ca [java] ArrayIsStoredDirectly - report assignment rather than formal param
Fixes #3929
2022-04-21 15:15:11 +02:00
Andreas Dangel 0d8373d290 [java] ArrayIsStoredDirectly - fix field access with this
Fixes #1185
2022-04-21 14:48:23 +02:00
Andreas Dangel 5566290821 [java] ArrayIsStoredDirectly - ignore method calls
Fixes #1474
2022-04-21 14:31:20 +02:00
Andreas Dangel 8d5c2e5683 [java] ArrayIsStoredDirectly - fix tree traversal
Fixes #3879
2022-04-21 14:12:47 +02:00
Andreas Dangel a6d8c1b646 Merge pull request #3928 from LiGaOg:master
[plsql] Fix plsql parsing error in parenthesis groups #3928
2022-04-21 11:32:41 +02:00
Andreas Dangel cb4b981fdd Add @LiGaOg as a contributor 2022-04-21 11:29:53 +02:00
Andreas Dangel ebbc017363 [doc] Update release notes (#3706, #3928) 2022-04-21 11:29:26 +02:00
Andreas Dangel f5be685068 [plsql] Convert ParenthesisGroupTest to be a tree dump test 2022-04-21 11:26:30 +02:00
李家奥 17ff1b7ffb fix one error in ParenthesisGroup0.pls 2022-04-21 14:47:08 +08:00
李家奥 2667b421c1 add junit test cases 2022-04-20 14:37:11 +08:00
Clément Fournier 9513c505fb checkstyle 2022-04-19 00:30:20 -06:00
Clément Fournier 8277fd2064 Update release notes, refs #3910 2022-04-19 00:30:20 -06:00
Clément Fournier 6f12ed1322 Stop ignoring name "IDENT" 2022-04-19 00:30:20 -06:00
Seth Wilcox aab240bc2d Allow the ignored fieldnames in the Unused Private Field check to be configurable. The current hardcoded defaults handle the fields needed for java serialization, but this isn't documented, and having this be configurable, as well as explicitly documented can be helpful. For example, our default new file template always creates a logger for every file, and I would prefer to have the logger there unused for future use, rather than having to pull it when not used 2022-04-19 00:30:20 -06:00
李家奥 5958b928dc [plsql] Fix parsing exception 2022-04-19 11:03:29 +08:00
Clément Fournier 91d019343c Move things around 2022-04-16 20:11:10 +02:00
Clément Fournier 24b7bfb47a Merge branch 'master' into pr/3885 2022-04-16 20:06:32 +02:00
Clément Fournier cdf4944865 Checkstyle 2022-04-15 20:05:04 +02:00
Clément Fournier afc43191dc update release notes 2022-04-15 19:55:35 +02:00
Clément Fournier 367c6cf54a Update JS module 2022-04-15 19:54:31 +02:00
Clément Fournier c778266294 Update java/CLITest 2022-04-15 19:41:39 +02:00
Clément Fournier 359225ca37 Update ExcludeLinesTest 2022-04-15 19:34:55 +02:00
Clément Fournier 715442b66b Update java/PMDTaskTest to use mocked rules 2022-04-15 19:31:56 +02:00
Clément Fournier be2618b66b Merge branch 'pr/3886'
Ref #3886
2022-04-15 14:46:30 +02:00
Clément Fournier 28168ac27e Merge branch 'master' into pr/3886 2022-04-15 14:46:22 +02:00
Andreas Dangel 45cb0a0a35 [ci] Fix pmd-regression-tester calls for PRs against pmd/7.0.x
In that case, we should run the regression tests against master
with the same ruleset as used for pmd/7.0.x in the previous
run.
2022-04-12 19:20:56 +02:00
Andreas Dangel 654c8bdb14 Merge pull request #3883 from jasonqiu98:master
[doc] Improve side bar by Adding Release Date #3883
2022-04-12 17:06:51 +02:00
Andreas Dangel 95a3eaf90f Add @jasonqiu98 as a contributor 2022-04-12 16:56:32 +02:00
Andreas Dangel aa4e76cb71 [doc] Update release notes (#2505, #3883) 2022-04-12 16:55:55 +02:00
Andreas Dangel d09a48ad5f Update regression-tester and other gems
pmd-tester 1.4.1
nokogiri 1.13.4

Fixes the following security alerts:
- Out-of-bounds Write in zlib affects Nokogiri
- XML Injection in Xerces Java affects Nokogiri
- Inefficient Regular Expression Complexity in Nokogiri
- Denial of Service (DoS) in Nokogiri on JRuby
2022-04-12 12:17:01 +02:00
Andreas Dangel d3211dbbf0 Merge pull request #3889 from adangel:noclassdeffound-uselessoverridingrule
[java] Catch LinkageError in UselessOverridingMethodRule #3889
2022-04-12 12:10:34 +02:00
Andreas Dangel 4f2e075521 Merge pull request #3887 from adangel:sarif-encoding
[core] Use always UTF-8 encoding for SARIF #3887
2022-04-12 11:50:24 +02:00
Andreas DangelandClément Fournier 6890cb13a4 Update pmd-core/src/test/java/net/sourceforge/pmd/FooRule.java
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2022-04-12 11:47:54 +02:00
Andreas Dangel 55e674cb0e [doc] Update release notes (#3792, #3862) 2022-04-12 09:29:46 +02:00
Andreas Dangel 0d72f8a37d Revert "[core] Add Report#empty"
This reverts commit bdcde56857.
2022-04-12 09:03:57 +02:00
Andreas Dangel bdcde56857 [core] Add Report#empty 2022-04-08 17:11:32 +02:00
Andreas Dangel 6dbc99a742 Merge branch 'master' into report-mutable 2022-04-08 16:38:21 +02:00
Andreas Dangel 12508a209e [core] Add Report#filterViolations and Report#union
- Fixes #3792
2022-04-08 16:38:03 +02:00
Andreas Dangel eab61f9f06 Revert "[core] Make Report mutable"
This reverts commit 8998d0e3a4.
2022-04-08 15:44:14 +02:00
Andreas Dangel ddb0ecfceb [java] Fix UseArraysAsList with method calls
- Fixes #3867
2022-04-08 15:30:25 +02:00
Clément Fournier 1ed96bb52b Move misplaced field 2022-04-07 22:07:13 +02:00
Clément Fournier 00da4fe48a Add names for line separators 2022-04-06 09:09:41 +02:00
Clément Fournier 9888ca4851 checkstyle 2022-04-05 00:01:19 +02:00
Clément Fournier 5485794da5 Cleanup some tests 2022-04-03 18:07:47 +02:00
Clément Fournier 13e2b3342c Make tree dump cli testable 2022-04-03 17:50:05 +02:00
Clément Fournier 41b03fec64 Make dummy parser more useful
It builds a tree now, which allows building
valid trees more easily.

The syntax is lispish: balanced parentheses
create new nodes.
2022-04-03 17:50:04 +02:00
Clément Fournier d30841b200 [core] Fix ast-dump CLI when reading from stdin
Bug was introduced in e64d48
2022-04-03 16:21:26 +02:00
Andreas Dangel 4d322b8fba [doc] Update release notes (#3889) 2022-04-01 19:35:21 +02:00
Andreas Dangel 674353c716 [java] Catch LinkageError in UselessOverridingMethodRule
Might occur when the auxclasspath is incomplete
2022-04-01 19:19:44 +02:00
Andreas Dangel cd18ba0144 [core] Use always UTF-8 encoding for SARIF
Fixes #3881
2022-04-01 12:45:44 +02:00
Andreas Dangel 05d5bead37 Merge pull request #3882 from oowekyala:issue3881
[core] Fix AssertionError about exhaustive switch #3882
2022-04-01 11:25:52 +02:00
Andreas Dangel bbcfc00dae [doc] Update release notes (#3882) 2022-04-01 11:03:34 +02:00
Andreas Dangel 7a43e8745a Merge pull request #3873 from pmd/dependabot/github_actions/master/actions/cache-3
Bump actions/cache from 2 to 3
2022-04-01 10:33:03 +02:00
Andreas Dangel 7080ca0487 [core] Renderers are started now by PmdAnalyzer
PMDTask doesn't need to start it itself.

- Fixes #3884
2022-03-31 18:14:40 +02:00
Andreas Dangel b413d86d08 [html] Add support for HTML using jsoup parser 2022-03-31 17:08:45 +02:00
jasonqiu98 6f3dd6c11d add release date on sidebar 2022-03-31 02:25:53 +02:00
Clément Fournier d662e9f8ef Fix AssertionError (exhaustive switch)
Ref #3881
2022-03-30 21:59:43 +02:00
dependabot[bot] 2a57871fdb Bump actions/cache from 2 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-28 03:01:58 +00:00
Andreas Dangel 4a12aebbf9 Bump pmd from 6.43.0 to 6.44.0 2022-03-27 17:48:08 +02:00
Andreas Dangel 820a17d6bd Prepare next development version [skip ci] 2022-03-27 17:03:24 +02:00
Andreas Dangel be3e941a08 [maven-release-plugin] prepare for next development iteration 2022-03-27 17:01:59 +02:00
Andreas Dangel 8998d0e3a4 [core] Make Report mutable
Refs #3792

This changes the getters to return mutable list. This allows
any downstream consumers of the Report to make modifications
to it before passing it manually to a renderer.
2022-03-18 18:14:35 +01:00
Clément Fournier b23b76d57c fix url 2022-01-16 14:57:36 +00:00
Clément Fournier 5c87f456f2 Cleanups, add tests 2022-01-04 23:22:21 +01:00
Clément Fournier 6115e543b2 Rename to EmptyControlStatement 2022-01-03 00:43:42 +01:00
Clément Fournier eb6a38d38d Add rule EmptyCodeBlock 2022-01-03 00:13:10 +01:00
Clément Fournier 61201eba12 Add rule codestyle.xml/UnnecessarySemicolon 2022-01-02 17:52:19 +01:00
684 changed files with 36810 additions and 5414 deletions

No files matched your search

+531 -8
View File
File diff suppressed because it is too large. Load diff
+28 -10
View File
@@ -32,17 +32,20 @@ function build() {
./mvnw clean install --show-version --errors --batch-mode --no-transfer-progress "${PMD_MAVEN_EXTRA_OPTS[@]}"
pmd_ci_log_group_end
# Danger is executed only on the linux runner
if [ "$(pmd_ci_utils_get_os)" = "linux" ]; then
pmd_ci_log_group_start "Executing danger"
regression_tester_setup_ci
regression_tester_executeDanger
pmd_ci_log_group_end
# Execute danger and dogfood only for pull requests in our own repository
if [[ "${PMD_CI_IS_FORK}" = "false" && -n "${PMD_CI_PULL_REQUEST_NUMBER}" ]]; then
# Danger is executed only on the linux runner
if [ "$(pmd_ci_utils_get_os)" = "linux" ]; then
pmd_ci_log_group_start "Executing danger"
regression_tester_setup_ci
regression_tester_executeDanger
pmd_ci_log_group_end
# also run dogfood for PRs (only on linux)
pmd_ci_log_group_start "Executing PMD dogfood test with ${PMD_CI_MAVEN_PROJECT_VERSION}"
pmd_ci_dogfood
pmd_ci_log_group_end
# also run dogfood for PRs (only on linux)
pmd_ci_log_group_start "Executing PMD dogfood test with ${PMD_CI_MAVEN_PROJECT_VERSION}"
pmd_ci_dogfood
pmd_ci_log_group_end
fi
fi
exit 0
@@ -68,6 +71,18 @@ function build() {
pmd_ci_maven_setup_settings
pmd_ci_log_group_end
if [ "${PMD_CI_BRANCH}" = "experimental-apex-parser" ]; then
pmd_ci_log_group_start "Build with mvnw"
./mvnw clean install --show-version --errors --batch-mode --no-transfer-progress "${PMD_MAVEN_EXTRA_OPTS[@]}"
pmd_ci_log_group_end
pmd_ci_log_group_start "Creating new baseline for regression tester"
regression_tester_setup_ci
regression_tester_uploadBaseline
pmd_ci_log_group_end
exit 0
fi
pmd_ci_log_group_start "Build and Deploy"
pmd_ci_build_run
pmd_ci_deploy_build_artifacts
@@ -244,12 +259,15 @@ ${rendered_release_notes}"
# Runs the dogfood ruleset with the currently built pmd against itself
#
function pmd_ci_dogfood() {
local mpmdVersion=()
./mvnw versions:set -DnewVersion="${PMD_CI_MAVEN_PROJECT_VERSION}-dogfood" -DgenerateBackupPoms=false
sed -i 's/<version>[0-9]\{1,\}\.[0-9]\{1,\}\.[0-9]\{1,\}.*<\/version>\( *<!-- pmd.dogfood.version -->\)/<version>'"${PMD_CI_MAVEN_PROJECT_VERSION}"'<\/version>\1/' pom.xml
if [ "${PMD_CI_MAVEN_PROJECT_VERSION}" = "7.0.0-SNAPSHOT" ]; then
sed -i 's/pmd-dogfood-config\.xml/pmd-dogfood-config7.xml/' pom.xml
mpmdVersion=(-Denforcer.skip=true -Dpmd.plugin.version=3.18.0-pmd7-SNAPSHOT)
fi
./mvnw verify --show-version --errors --batch-mode --no-transfer-progress "${PMD_MAVEN_EXTRA_OPTS[@]}" \
"${mpmdVersion[@]}" \
-DskipTests \
-Dmaven.javadoc.skip=true \
-Dmaven.source.skip=true \
+35 -15
View File
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<projectlist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="projectlist_1_1_0.xsd">
xsi:noNamespaceSchemaLocation="projectlist_1_1_0.xsd">
<description>Standard Projects</description>
<project>
@@ -12,6 +12,7 @@ xsi:noNamespaceSchemaLocation="projectlist_1_1_0.xsd">
<exclude-pattern>.*/target/test-classes/com/puppycrawl/tools/checkstyle/.*</exclude-pattern>
<exclude-pattern>.*/target/generated-sources/.*</exclude-pattern>
<exclude-pattern>.*/src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/javaparser/InputJavaParserNoFreezeOnDeeplyNestedLambdas.java</exclude-pattern>
<build-command><![CDATA[#!/usr/bin/env bash
if test -e classpath.txt; then
@@ -39,6 +40,11 @@ mvn dependency:build-classpath -DincludeScope=test -Dmdep.outputFile=classpath.t
<exclude-pattern>.*/build/generated-sources/.*</exclude-pattern>
<build-command><![CDATA[#!/usr/bin/env bash
## Skip gradle execution
if test -e classpath.txt; then
exit
fi
set -e
# Make sure to use java11. This is already installed by build.sh
@@ -128,10 +134,24 @@ index 6021fa574d..15d29ed699 100644
EOF
) | patch --strip=1
## Skip gradle execution
if test -e classpath.txt; then
exit
fi
# Patch 4: Add https://maven.repository.redhat.com/ga/ as repository in order to resolve
# dependency com.ibm.websphere/uow/6.0.2.17
# See https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020
(cat <<EOF
diff --git a/build.gradle b/build.gradle
index 6021fa57..8319ff76 100644
--- a/build.gradle
+++ b/build.gradle
@@ -291,6 +291,7 @@ configure(allprojects) { project ->
}
repositories {
mavenCentral()
+ maven { url "https://maven.repository.redhat.com/ga/" }
maven { url "https://repo.spring.io/libs-spring-framework-build" }
}
}
EOF
) | patch --strip=1
./gradlew --console=plain --build-cache --no-daemon --max-workers=4 build testClasses -x test -x javadoc -x api -x asciidoctor -x asciidoctorPdf
./gradlew --console=plain --build-cache --no-daemon --max-workers=4 createSquishClasspath -q > classpath.txt
@@ -150,23 +170,15 @@ fi
<project>
<name>Schedul-o-matic-9000</name>
<type>git</type>
<connection>https://github.com/pmd/Schedul-o-matic-9000</connection>
<!--
<connection>https://github.com/SalesforceLabs/Schedul-o-matic-9000</connection>
Note: using forked repo from pmd, as original repo doesn't have any useful tags/branches
-->
<tag>pmd-regression-test</tag>
<tag>6b1229ba43b38931fbbab5924bc9b9611d19a786</tag>
</project>
<project>
<name>fflib-apex-common</name>
<type>git</type>
<connection>https://github.com/pmd/fflib-apex-common</connection>
<!--
<connection>https://github.com/apex-enterprise-patterns/fflib-apex-common</connection>
Note: using forked repo from pmd, as original repo doesn't have any useful tags/branches
-->
<tag>pmd-regression-test</tag>
<tag>7e0891efb86d23de62811af56d87d0959082a322</tag>
</project>
<project>
@@ -176,4 +188,12 @@ fi
<tag>v2.3.0</tag>
<src-subpath>samples</src-subpath>
</project>
<project>
<name>java-regression-tests</name>
<type>git</type>
<connection>https://github.com/pmd/java-regression-tests</connection>
<tag>main</tag>
<auxclasspath-command>realpath java-regression-tests-*.jar</auxclasspath-command>
</project>
</projectlist>
+38 -1
View File
@@ -27,7 +27,7 @@ function git_repo_sync() {
pmd_ci_log_group_start "Git Sync"
git remote add pmd-sf "${PMD_SF_USER}@git.code.sf.net:/p/pmd/code"
if [ -n "${PMD_CI_BRANCH}" ]; then
git push pmd-sf "${PMD_CI_BRANCH}:${PMD_CI_BRANCH}"
retry 5 git push pmd-sf "${PMD_CI_BRANCH}:${PMD_CI_BRANCH}"
pmd_ci_log_success "Successfully pushed ${PMD_CI_BRANCH} to sourceforge"
elif [ -n "${PMD_CI_TAG}" ]; then
git push pmd-sf tag "${PMD_CI_TAG}"
@@ -39,6 +39,43 @@ function git_repo_sync() {
pmd_ci_log_group_end
}
#
# From: https://gist.github.com/sj26/88e1c6584397bb7c13bd11108a579746
#
# Retry a command up to a specific number of times until it exits successfully,
# with exponential back off.
#
# $ retry 5 echo Hello
# Hello
#
# $ retry 5 false
# Retry 1/5 exited 1, retrying in 1 seconds...
# Retry 2/5 exited 1, retrying in 2 seconds...
# Retry 3/5 exited 1, retrying in 4 seconds...
# Retry 4/5 exited 1, retrying in 8 seconds...
# Retry 5/5 exited 1, no more retries left.
#
function retry {
local retries=$1
shift
local count=0
until "$@"; do
exit=$?
wait=$((2 ** $count))
count=$(($count + 1))
if [ $count -lt $retries ]; then
echo "Retry $count/$retries exited $exit, retrying in $wait seconds..."
sleep $wait
else
echo "Retry $count/$retries exited $exit, no more retries left."
return $exit
fi
done
return 0
}
git_repo_sync
exit 0
@@ -19,7 +19,7 @@ Please provide the rule name and a link to the rule documentation:
**Code Sample demonstrating the issue:**
```
```java
```
@@ -19,7 +19,7 @@ Please provide the rule name and a link to the rule documentation:
**Code Sample demonstrating the issue:**
```
```java
```
+1 -1
View File
@@ -17,7 +17,7 @@ assignees: ''
**Code Sample:** This should include code, that should be flagged by the rule. If possible, the "correct" code
according to this new rule should also be demonstrated.
```
```java
```
+1 -1
View File
@@ -25,7 +25,7 @@ A clear and concise description of what the bug is.
**Code Sample demonstrating the issue:**
```
```java
```
+11 -2
View File
@@ -5,6 +5,7 @@ on:
branches:
- main
- master
- experimental-apex-parser
tags:
- '**'
pull_request:
@@ -13,9 +14,17 @@ on:
- cron: '0 4 1 * *'
workflow_dispatch:
permissions:
contents: read # to fetch code (actions/checkout)
jobs:
build:
runs-on: ${{ matrix.os }}
permissions:
# read to fetch code (actions/checkout)
# write to push code to gh-pages, create releases
# note: forked repositories will have maximum read access
contents: write
continue-on-error: false
strategy:
matrix:
@@ -25,7 +34,7 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 2
- uses: actions/cache@v2
- uses: actions/cache@v3
with:
path: |
~/.m2/repository
@@ -45,7 +54,7 @@ jobs:
run: |
echo "LANG=en_US.UTF-8" >> $GITHUB_ENV
echo "MAVEN_OPTS=-Dmaven.wagon.httpconnectionManager.ttlSeconds=180 -Dmaven.wagon.http.retryHandler.count=3 -DautoReleaseAfterClose=true -DstagingProgressTimeoutMinutes=30" >> $GITHUB_ENV
echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/17/scripts" >> $GITHUB_ENV
echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/20/scripts" >> $GITHUB_ENV
- name: Check Environment
shell: bash
run: |
+4 -1
View File
@@ -9,6 +9,9 @@ on:
- '**'
workflow_dispatch:
permissions:
contents: read # to fetch code (actions/checkout)
jobs:
build:
runs-on: ubuntu-latest
@@ -21,7 +24,7 @@ jobs:
shell: bash
run: |
echo "LANG=en_US.UTF-8" >> $GITHUB_ENV
echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/17/scripts" >> $GITHUB_ENV
echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/20/scripts" >> $GITHUB_ENV
- name: Sync
run: .ci/git-repo-sync.sh
shell: bash
+5 -2
View File
@@ -2,6 +2,9 @@ name: troubleshooting
on: workflow_dispatch
permissions:
contents: read
jobs:
build:
runs-on: ${{ matrix.os }}
@@ -13,7 +16,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v2
- uses: actions/cache@v3
with:
path: |
~/.m2/repository
@@ -33,7 +36,7 @@ jobs:
run: |
echo "LANG=en_US.UTF-8" >> $GITHUB_ENV
echo "MAVEN_OPTS=-Dmaven.wagon.httpconnectionManager.ttlSeconds=180 -Dmaven.wagon.http.retryHandler.count=3 -DstagingProgressTimeoutMinutes=30" >> $GITHUB_ENV
echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/17/scripts" >> $GITHUB_ENV
echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/20/scripts" >> $GITHUB_ENV
- name: Check Environment
shell: bash
run: |
+1
View File
@@ -21,3 +21,4 @@ node_modules
# rule docs are generated
docs/pages/pmd/rules
.history/*
+2 -2
View File
@@ -14,5 +14,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.5/apache-maven-3.8.5-bin.zip
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.0/apache-maven-3.9.0-bin.zip
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
+1 -1
View File
@@ -47,7 +47,7 @@ There are various channels, on which you can ask questions:
* Create a new discussion for your question at <https://github.com/pmd/pmd/discussions>.
* Ask your question on Gitter <https://gitter.im/pmd/pmd>.
* Ask your question in our [Gitter room](https://app.gitter.im/#/room/#pmd_pmd:gitter.im).
## Code Style
+1 -1
View File
@@ -42,7 +42,7 @@ def run_pmdtester
@base_branch = 'master'
@logger.info "\n\n--------------------------------------"
@logger.info "Run against #{@base_branch}"
@summary = PmdTester::Runner.new(get_args(@base_branch)).run
@summary = PmdTester::Runner.new(get_args(@base_branch, FALSE, 'target/diff1/patch_config.xml')).run
# move the generated report out of the way
FileUtils.mv 'target/reports/diff', 'target/diff2'
+34 -53
View File
@@ -1,106 +1,87 @@
GEM
remote: https://rubygems.org/
specs:
addressable (2.8.0)
public_suffix (>= 2.0.2, < 5.0)
addressable (2.8.1)
public_suffix (>= 2.0.2, < 6.0)
claide (1.1.0)
claide-plugins (0.9.2)
cork
nap
open4 (~> 1.3)
colored2 (3.1.2)
concurrent-ruby (1.1.10)
concurrent-ruby (1.2.0)
cork (0.3.0)
colored2 (~> 3.1)
danger (8.5.0)
danger (9.2.0)
claide (~> 1.0)
claide-plugins (>= 0.9.2)
colored2 (~> 3.1)
cork (~> 0.1)
faraday (>= 0.9.0, < 2.0)
faraday (>= 0.9.0, < 3.0)
faraday-http-cache (~> 2.0)
git (~> 1.7)
kramdown (~> 2.3)
kramdown-parser-gfm (~> 1.0)
no_proxy_fix
octokit (~> 4.7)
octokit (~> 5.0)
terminal-table (>= 1, < 4)
differ (0.1.2)
et-orbi (1.2.7)
tzinfo
faraday (1.10.0)
faraday-em_http (~> 1.0)
faraday-em_synchrony (~> 1.0)
faraday-excon (~> 1.1)
faraday-httpclient (~> 1.0)
faraday-multipart (~> 1.0)
faraday-net_http (~> 1.0)
faraday-net_http_persistent (~> 1.0)
faraday-patron (~> 1.0)
faraday-rack (~> 1.0)
faraday-retry (~> 1.0)
faraday (2.7.4)
faraday-net_http (>= 2.0, < 3.1)
ruby2_keywords (>= 0.0.4)
faraday-em_http (1.0.0)
faraday-em_synchrony (1.0.0)
faraday-excon (1.1.0)
faraday-http-cache (2.2.0)
faraday-http-cache (2.4.1)
faraday (>= 0.8)
faraday-httpclient (1.0.1)
faraday-multipart (1.0.3)
multipart-post (>= 1.2, < 3)
faraday-net_http (1.0.1)
faraday-net_http_persistent (1.2.0)
faraday-patron (1.0.0)
faraday-rack (1.0.0)
faraday-retry (1.0.3)
fugit (1.5.2)
et-orbi (~> 1.1, >= 1.1.8)
faraday-net_http (3.0.2)
fugit (1.8.1)
et-orbi (~> 1, >= 1.2.7)
raabro (~> 1.4)
git (1.10.2)
git (1.13.1)
addressable (~> 2.8)
rchardet (~> 1.8)
kramdown (2.3.2)
kramdown (2.4.0)
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
liquid (5.3.0)
liquid (5.4.0)
logger-colors (1.0.0)
mini_portile2 (2.8.0)
multipart-post (2.1.1)
mini_portile2 (2.8.1)
nap (1.1.0)
no_proxy_fix (0.1.2)
nokogiri (1.13.3)
nokogiri (1.14.1)
mini_portile2 (~> 2.8.0)
racc (~> 1.4)
octokit (4.22.0)
faraday (>= 0.9)
sawyer (~> 0.8.0, >= 0.5.3)
octokit (5.6.1)
faraday (>= 1, < 3)
sawyer (~> 0.9)
open4 (1.3.4)
pmdtester (1.4.0)
pmdtester (1.5.3)
differ (~> 0.1)
liquid (~> 5.2)
liquid (~> 5.4)
logger-colors (~> 1.0)
nokogiri (~> 1.13)
rufus-scheduler (~> 3.8)
slop (~> 4.6)
public_suffix (4.0.6)
slop (~> 4.9)
public_suffix (5.0.1)
raabro (1.4.0)
racc (1.6.0)
racc (1.6.2)
rchardet (1.8.0)
rexml (3.2.5)
rouge (3.28.0)
rouge (4.0.1)
ruby2_keywords (0.0.5)
rufus-scheduler (3.8.1)
rufus-scheduler (3.8.2)
fugit (~> 1.1, >= 1.1.6)
safe_yaml (1.0.5)
sawyer (0.8.2)
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (> 0.8, < 2.0)
slop (4.9.1)
faraday (>= 0.17.3, < 3)
slop (4.9.3)
terminal-table (3.0.2)
unicode-display_width (>= 1.1.1, < 3)
tzinfo (2.0.4)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.1.0)
unicode-display_width (2.4.2)
PLATFORMS
ruby
@@ -113,4 +94,4 @@ DEPENDENCIES
safe_yaml
BUNDLED WITH
2.1.4
2.4.5
+8 -7
View File
@@ -1,11 +1,11 @@
# PMD - source code analyzer
[![Join the chat at https://gitter.im/pmd/pmd](https://badges.gitter.im/pmd/pmd.svg)](https://gitter.im/pmd/pmd?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
[![Join the chat](https://img.shields.io/gitter/room/pmd/pmd)](https://app.gitter.im/#/room/#pmd_pmd:gitter.im?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
[![Build Status](https://github.com/pmd/pmd/workflows/build/badge.svg?branch=master)](https://github.com/pmd/pmd/actions)
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/net.sourceforge.pmd/pmd/badge.svg)](https://maven-badges.herokuapp.com/maven-central/net.sourceforge.pmd/pmd)
[![Reproducible Builds](https://img.shields.io/badge/Reproducible_Builds-ok-green?labelColor=blue)](https://github.com/jvm-repo-rebuild/reproducible-central#net.sourceforge.pmd:pmd)
[![Coverage Status](https://coveralls.io/repos/github/pmd/pmd/badge.svg)](https://coveralls.io/github/pmd/pmd)
[![Codacy Badge](https://api.codacy.com/project/badge/Grade/a674ee8642ed44c6ba7633626ee95967)](https://www.codacy.com/app/pmd/pmd?utm_source=github.com&amp;utm_medium=referral&amp;utm_content=pmd/pmd&amp;utm_campaign=Badge_Grade)
[![Codacy Badge](https://app.codacy.com/project/badge/Grade/ea550046a02344ec850553476c4aa2ca)](https://www.codacy.com/gh/pmd/pmd/dashboard?utm_source=github.com&amp;utm_medium=referral&amp;utm_content=pmd/pmd&amp;utm_campaign=Badge_Grade)
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-v2.0%20adopted-ff69b4.svg)](code_of_conduct.md)
[![Documentation (latest)](https://img.shields.io/badge/docs-latest-green)](https://pmd.github.io/latest/)
@@ -15,11 +15,12 @@ It uses JavaCC and Antlr to parse source files into abstract syntax trees (AST)
Rules can be written in Java or using a XPath query.
It supports Java, JavaScript, Salesforce.com Apex and Visualforce,
Modelica, PLSQL, Apache Velocity, XML, XSL, Scala.
Modelica, PLSQL, Apache Velocity, HTML, XML and XSL.
Scala is supported, but there are currently no Scala rules available.
Additionally it includes **CPD**, the copy-paste-detector. CPD finds duplicated code in
C/C++, C#, Dart, Fortran, Go, Groovy, Java, JavaScript, JSP, Kotlin, Lua, Matlab, Modelica,
Objective-C, Perl, PHP, PLSQL, Python, Ruby, Salesforce.com Apex, Scala, Swift, Visualforce and XML.
Additionally, it includes **CPD**, the copy-paste-detector. CPD finds duplicated code in
C/C++, C#, Dart, Fortran, Gherkin, Go, Groovy, HTML, Java, JavaScript, JSP, Kotlin, Lua, Matlab, Modelica,
Objective-C, Perl, PHP, PLSQL, Python, Ruby, Salesforce.com Apex and Visualforce, Scala, Swift, T-SQL and XML.
In the future we hope to add support for data/control flow analysis and automatic (quick) fixes where
it makes sense.
@@ -50,7 +51,7 @@ See [Tools / Integrations](https://pmd.github.io/latest/pmd_userdocs_tools.html)
or on [discussions](https://github.com/pmd/pmd/discussions).
* I got this error and I'm sure it's a bug -- file an [issue](https://github.com/pmd/pmd/issues).
* I have an idea/request/question -- create a new [discussion](https://github.com/pmd/pmd/discussions).
* I have a quick question -- ask on our [Gitter chat](https://gitter.im/pmd/pmd).
* I have a quick question -- ask in our [Gitter room](https://app.gitter.im/#/room/#pmd_pmd:gitter.im).
* Where's your documentation? -- <https://pmd.github.io/latest/>
## 🤝 Contributing
+10
View File
@@ -0,0 +1,10 @@
# PMD's sponsors
Many thanks to all our sponsors:
* [Matt Hargett](https://github.com/matthargett) (@matthargett)
If you also want to sponsor PMD, you have two options:
* [Sponsor @pmd on GitHub Sponsors](https://github.com/sponsors/pmd)
* [PMD - Open Collective](https://opencollective.com/pmd)
+9 -1
View File
@@ -72,6 +72,14 @@ export RELEASE_VERSION
export DEVELOPMENT_VERSION
export CURRENT_BRANCH
# check for SNAPSHOT version of pmd.build-tools.version
BUILD_TOOLS_VERSION=$(./mvnw org.apache.maven.plugins:maven-help-plugin:3.2.0:evaluate -Dexpression=pmd.build-tools.version -q -DforceStdout)
BUILD_TOOLS_VERSION_RELEASE=${BUILD_TOOLS_VERSION%-SNAPSHOT}
if [ "${BUILD_TOOLS_VERSION}" != "${BUILD_TOOLS_VERSION_RELEASE}" ]; then
echo "Error: version pmd.build-tools.version is ${BUILD_TOOLS_VERSION} - snapshot is not allowed"
exit 1
fi
RELEASE_RULESET="pmd-core/src/main/resources/rulesets/releases/${RELEASE_VERSION//\./}.xml"
echo "* Update date info in **docs/_config.yml**."
@@ -108,7 +116,7 @@ echo "* Days since last release: $(( ( $(date +%s) - $(git log --max-count=1 --f
)
TEMP_RELEASE_NOTES=$(cat docs/pages/release_notes.md)
TEMP_RELEASE_NOTES=${TEMP_RELEASE_NOTES/\{\% endtocmaker \%\}/$STATS$'\n'$'\n'\{\% endtocmaker \%\}$'\n'}
TEMP_RELEASE_NOTES=${TEMP_RELEASE_NOTES/\{\% endtocmaker \%\}/${STATS//\&/\\\&}$'\n'$'\n'\{\% endtocmaker \%\}$'\n'}
echo "${TEMP_RELEASE_NOTES}" > docs/pages/release_notes.md
echo
+1
View File
@@ -2,3 +2,4 @@ source 'https://rubygems.org'
gem 'jekyll'
gem 'github-pages'
gem "webrick"
+45 -66
View File
@@ -1,62 +1,42 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (6.0.4.7)
activesupport (7.0.4.2)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
addressable (2.8.0)
public_suffix (>= 2.0.2, < 5.0)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
addressable (2.8.1)
public_suffix (>= 2.0.2, < 6.0)
coffee-script (2.4.1)
coffee-script-source
execjs
coffee-script-source (1.11.1)
colorator (1.1.0)
commonmarker (0.23.4)
concurrent-ruby (1.1.9)
commonmarker (0.23.8)
concurrent-ruby (1.2.0)
dnsruby (1.61.9)
simpleidn (~> 0.1)
em-websocket (0.5.3)
eventmachine (>= 0.12.9)
http_parser.rb (~> 0)
ethon (0.15.0)
ethon (0.16.0)
ffi (>= 1.15.0)
eventmachine (1.2.7)
execjs (2.8.1)
faraday (1.10.0)
faraday-em_http (~> 1.0)
faraday-em_synchrony (~> 1.0)
faraday-excon (~> 1.1)
faraday-httpclient (~> 1.0)
faraday-multipart (~> 1.0)
faraday-net_http (~> 1.0)
faraday-net_http_persistent (~> 1.0)
faraday-patron (~> 1.0)
faraday-rack (~> 1.0)
faraday-retry (~> 1.0)
faraday (2.7.4)
faraday-net_http (>= 2.0, < 3.1)
ruby2_keywords (>= 0.0.4)
faraday-em_http (1.0.0)
faraday-em_synchrony (1.0.0)
faraday-excon (1.1.0)
faraday-httpclient (1.0.1)
faraday-multipart (1.0.3)
multipart-post (>= 1.2, < 3)
faraday-net_http (1.0.1)
faraday-net_http_persistent (1.2.0)
faraday-patron (1.0.0)
faraday-rack (1.0.0)
faraday-retry (1.0.3)
faraday-net_http (3.0.2)
ffi (1.15.5)
forwardable-extended (2.6.0)
gemoji (3.0.1)
github-pages (225)
github-pages (228)
github-pages-health-check (= 1.17.9)
jekyll (= 3.9.0)
jekyll (= 3.9.3)
jekyll-avatar (= 0.7.0)
jekyll-coffeescript (= 1.1.1)
jekyll-commonmark-ghpages (= 0.2.0)
jekyll-commonmark-ghpages (= 0.4.0)
jekyll-default-layout (= 0.1.4)
jekyll-feed (= 0.15.1)
jekyll-gist (= 1.5.0)
@@ -88,12 +68,12 @@ GEM
jekyll-theme-time-machine (= 0.2.0)
jekyll-titles-from-headings (= 0.5.3)
jemoji (= 0.12.0)
kramdown (= 2.3.1)
kramdown (= 2.3.2)
kramdown-parser-gfm (= 1.1.0)
liquid (= 4.0.3)
liquid (= 4.0.4)
mercenary (~> 0.3)
minima (= 2.5.1)
nokogiri (>= 1.12.5, < 2.0)
nokogiri (>= 1.13.6, < 2.0)
rouge (= 3.26.0)
terminal-table (~> 1.4)
github-pages-health-check (1.17.9)
@@ -102,17 +82,17 @@ GEM
octokit (~> 4.0)
public_suffix (>= 3.0, < 5.0)
typhoeus (~> 1.3)
html-pipeline (2.14.0)
html-pipeline (2.14.3)
activesupport (>= 2)
nokogiri (>= 1.4)
http_parser.rb (0.8.0)
i18n (0.9.5)
i18n (1.12.0)
concurrent-ruby (~> 1.0)
jekyll (3.9.0)
jekyll (3.9.3)
addressable (~> 2.4)
colorator (~> 1.0)
em-websocket (~> 0.5)
i18n (~> 0.7)
i18n (>= 0.7, < 2)
jekyll-sass-converter (~> 1.0)
jekyll-watch (~> 2.0)
kramdown (>= 1.17, < 3)
@@ -128,11 +108,11 @@ GEM
coffee-script-source (~> 1.11.1)
jekyll-commonmark (1.4.0)
commonmarker (~> 0.22)
jekyll-commonmark-ghpages (0.2.0)
commonmarker (~> 0.23.4)
jekyll-commonmark-ghpages (0.4.0)
commonmarker (~> 0.23.7)
jekyll (~> 3.9.0)
jekyll-commonmark (~> 1.4.0)
rouge (>= 2.0, < 4.0)
rouge (>= 2.0, < 5.0)
jekyll-default-layout (0.1.4)
jekyll (~> 3.0)
jekyll-feed (0.15.1)
@@ -216,33 +196,32 @@ GEM
gemoji (~> 3.0)
html-pipeline (~> 2.2)
jekyll (>= 3.0, < 5.0)
kramdown (2.3.1)
kramdown (2.3.2)
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
liquid (4.0.3)
listen (3.7.1)
liquid (4.0.4)
listen (3.8.0)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.3.6)
mini_portile2 (2.8.0)
mini_portile2 (2.8.1)
minima (2.5.1)
jekyll (>= 3.5, < 5.0)
jekyll-feed (~> 0.9)
jekyll-seo-tag (~> 2.1)
minitest (5.15.0)
multipart-post (2.1.1)
nokogiri (1.13.3)
minitest (5.17.0)
nokogiri (1.14.1)
mini_portile2 (~> 2.8.0)
racc (~> 1.4)
octokit (4.22.0)
faraday (>= 0.9)
sawyer (~> 0.8.0, >= 0.5.3)
octokit (4.25.1)
faraday (>= 1, < 3)
sawyer (~> 0.9)
pathutil (0.16.2)
forwardable-extended (~> 2.6)
public_suffix (4.0.6)
racc (1.6.0)
rb-fsevent (0.11.1)
public_suffix (4.0.7)
racc (1.6.2)
rb-fsevent (0.11.2)
rb-inotify (0.10.1)
ffi (~> 1.0)
rexml (3.2.5)
@@ -255,23 +234,22 @@ GEM
sass-listen (4.0.0)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
sawyer (0.8.2)
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (> 0.8, < 2.0)
faraday (>= 0.17.3, < 3)
simpleidn (0.2.1)
unf (~> 0.1.4)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
thread_safe (0.3.6)
typhoeus (1.4.0)
ethon (>= 0.9.0)
tzinfo (1.2.9)
thread_safe (~> 0.1)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unf (0.1.4)
unf_ext
unf_ext (0.0.8)
unf_ext (0.0.8.2)
unicode-display_width (1.8.0)
zeitwerk (2.5.4)
webrick (1.8.1)
PLATFORMS
ruby
@@ -279,6 +257,7 @@ PLATFORMS
DEPENDENCIES
github-pages
jekyll
webrick
BUNDLED WITH
2.1.4
2.4.5
+3 -3
View File
@@ -1,9 +1,9 @@
repository: pmd/pmd
pmd:
version: 6.44.0
previous_version: 6.43.0
date: 27-March-2022
version: 6.55.0
previous_version: 6.54.0
date: 25-February-2023
release_type: minor
# release types: major, minor, bugfix
+42
View File
@@ -58,6 +58,9 @@ entries:
- title: PMD Report formats
url: /pmd_userdocs_report_formats.html
output: web, pdf
- title: 3rd party rulesets
output: web, pdf
url: /pmd_userdocs_3rdpartyrulesets.html
- title: null
output: web, pdf
subfolders:
@@ -178,6 +181,18 @@ entries:
- title: Error Prone
output: web, pdf
url: /pmd_rules_ecmascript_errorprone.html
- title: null
output: web, pdf
subfolders:
- title: HTML Rules
output: web, pdf
subfolderitems:
- title: Index
output: web, pdf
url: /pmd_rules_html.html
- title: Best Practices
output: web, pdf
url: /pmd_rules_html_bestpractices.html
- title: null
output: web, pdf
subfolders:
@@ -292,6 +307,15 @@ entries:
- title: Security
output: web, pdf
url: /pmd_rules_vf_security.html
- title: null
output: web, pdf
subfolders:
- title: Scala Rules
output: web, pdf
subfolderitems:
- title: Index
output: web, pdf
url: /pmd_rules_scala.html
- title: null
output: web, pdf
subfolders:
@@ -310,6 +334,15 @@ entries:
- title: Error Prone
output: web, pdf
url: /pmd_rules_vm_errorprone.html
- title: null
output: web, pdf
subfolders:
- title: WSDL Rules
output: web, pdf
subfolderitems:
- title: Index
output: web, pdf
url: /pmd_rules_wsdl.html
- title: null
output: web, pdf
subfolders:
@@ -367,6 +400,12 @@ entries:
- title: XML and XML dialects
url: /pmd_languages_xml.html
output: web, pdf
- title: HTML
url: /pmd_languages_html.html
output: web, pdf
- title: Gherkin
url: /pmd_languages_gherkin.html
output: web, pdf
- title: Developer Documentation
output: web, pdf
folderitems:
@@ -451,6 +490,9 @@ entries:
- title: Old release notes
url: /pmd_release_notes_old.html
output: web, pdf
- title: Decisions
url: /pmd_projectdocs_decisions.html
output: web, pdf
- title: null
output: web, pdf
subfolders:
+1
View File
@@ -2,6 +2,7 @@
<ul id="mysidebar" class="nav">
<li class="sidebarTitle">{{sidebar[0].product}} {{sidebar[0].version | replace: '!PMD_VERSION!', site.pmd.version}}</li>
<div class="sidebarTitleDate">Release date: {{site.pmd.date}}</div>
{% for entry in sidebar %}
{% for folder in entry.folders %}
{% if folder.output contains "web" %}
+1 -1
View File
@@ -102,7 +102,7 @@ class JDocNamespaceDeclaration < Liquid::Tag
RESERVED_NSPACES = ['apex', 'core', 'cpp', 'cs', 'dart', 'dist', 'doc', 'fortran', 'go', 'groovy', 'java',
'javascript', 'jsp',
'kotlin', 'lua', 'matlab', 'objectivec', 'perl', 'php', 'plsql', 'python', 'ruby', 'scala', 'swift',
'test', 'ui',
'test', 'test-schema', 'ui',
'modelica', 'visualforce', 'vm', 'xml'].flat_map {|m| [m, "pmd-" + m]}
def self.make_base_namespaces
+6
View File
@@ -88,3 +88,9 @@ details[open] summary {
.xpath-fun-doc .code-examples dt {
font-weight: normal;
}
div.sidebarTitleDate {
margin-top:2.5px;
margin-bottom:5px;
margin-left:5px;
}
+2 -2
View File
@@ -97,7 +97,7 @@ li.sidebarTitle {
font-weight:normal;
font-size:130%;
color: #ED1951;
margin-bottom:10px;
margin-left: 5px;
margin-bottom:2.5px;
margin-left:5px;
}
+2 -2
View File
@@ -93,7 +93,7 @@ li.sidebarTitle {
font-weight:normal;
font-size:130%;
color: #ED1951;
margin-bottom:10px;
margin-left: 5px;
margin-bottom:2.5px;
margin-left:5px;
}
+2 -2
View File
@@ -7,7 +7,7 @@ summary: >
Welcome to the documentation site for PMD and CPD! <br/><br/>
last_updated: August 2017
last_updated: October 2022
author: Jeff Jensen <jjensen@apache.org>, Andreas Dangel <andreas.dangel@adangel.org>,
Clément Fournier <clement.fournier76@gmail.com>
---
@@ -29,7 +29,7 @@ author: Jeff Jensen <jjensen@apache.org>, Andreas Dangel <andreas.dangel@adangel
**PMD** is a static source code analyzer. It finds common programming flaws like
unused variables, empty catch blocks, unnecessary object creation, and
so forth. It's mainly concerned with **Java and Apex**, but **supports six other
so forth. It's mainly concerned with **Java and Apex**, but **supports 12 other
languages**.
PMD features many **built-in checks** (in PMD lingo, *rules*), which are documented
File diff suppressed because it is too large. Load diff
Loaded 30 of 684 files, more files were not shown because too many files have changed in this diff. Show more