yusheng-guo/kube-metrics-adapter
1
0
Fork 1
mirror of https://github.com/zalando-incubator/kube-metrics-adapter.git synced 2024-12-31 14:24:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Testing multiple metrics inserts with different Group/Resources/Namesapces

Browse Source 
Signed-off-by: Muhammad Muaaz Saleem <muhammad.muaaz.saleem@zalando.de>
This commit is contained in:
Muhammad Muaaz Saleem
2018-11-22 16:36:51 +01:00
parent 28b3b3b2b7
commit e3ee745777
2 changed files with 109 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/provider/metric_store.go
View File

@ -101,6 +101,7 @@ func (s *MetricStore) insertCustomMetric(value custom_metrics.MetricValue, label
value.DescribedObject.Name: metric,
},
}
return
}
namespace, ok := group[value.DescribedObject.Namespace]
@ -108,6 +109,7 @@ func (s *MetricStore) insertCustomMetric(value custom_metrics.MetricValue, label
group[value.DescribedObject.Namespace] = map[string]customMetricsStoredMetric{
value.DescribedObject.Name: metric,
}
return
}
namespace[value.DescribedObject.Name] = metric

109
pkg/provider/metrics_store_test.go
View File

@ -283,7 +283,7 @@ func TestMultipleMetricValues(t *testing.T) {
}
}{
{
test: "insert/list/get an Ingress metric",
test: "insert/list/get multiple Ingress metrics",
insert: []collector.CollectedMetric{
{
Type: v2beta1.MetricSourceType("Object"),
@ -352,7 +352,7 @@ func TestMultipleMetricValues(t *testing.T) {
},
},
{
test: "insert/list/get a namespaced resource metric",
test: "insert/list/get multiple namespaced resource metrics",
insert: []collector.CollectedMetric{
{
Type: v2beta1.MetricSourceType("Object"),
@ -563,6 +563,111 @@ func TestCustomMetricsStorageErrors(t *testing.T) {
})
}
var multiValueTests = []struct {
test string
insert []collector.CollectedMetric
list []provider.CustomMetricInfo
byName struct {
name types.NamespacedName
info provider.CustomMetricInfo
}
byLabel struct {
namespace string
selector labels.Selector
info provider.CustomMetricInfo
}
}{
{
test: "insert/list/get multiple metrics in different groups",
insert: []collector.CollectedMetric{
{
Type: v2beta1.MetricSourceType("Object"),
Custom: custom_metrics.MetricValue{
MetricName: "metric-per-unit",
Value: *resource.NewQuantity(0, ""),
DescribedObject: custom_metrics.ObjectReference{
Name: "metricObject",
Namespace: "default",
Kind: "Ingress",
APIVersion: "extensions/vbeta1",
},
},
},
{
Type: v2beta1.MetricSourceType("Object"),
Custom: custom_metrics.MetricValue{
MetricName: "metric-per-unit",
Value: *resource.NewQuantity(1, ""),
DescribedObject: custom_metrics.ObjectReference{
Name: "metricObject",
Namespace: "default",
Kind: "Pod",
APIVersion: "core/v1",
},
},
},
{
Type: v2beta1.MetricSourceType("Object"),
Custom: custom_metrics.MetricValue{
MetricName: "metric-per-unit",
Value: *resource.NewQuantity(1, ""),
DescribedObject: custom_metrics.ObjectReference{
Name: "metricObject",
Namespace: "new-namespace",
Kind: "Pod",
APIVersion: "core/v1",
},
},
},
},
list: []provider.CustomMetricInfo{
{
GroupResource: schema.GroupResource{},
Namespaced: true,
Metric: "metric-per-unit",
},
},
byName: struct {
name types.NamespacedName
info provider.CustomMetricInfo
}{
name: types.NamespacedName{Name: "metricObject", Namespace: "default"},
info: provider.CustomMetricInfo{
GroupResource: schema.GroupResource{},
Namespaced: true,
Metric: "metric-per-unit",
},
},
byLabel: struct {
namespace string
selector labels.Selector
info provider.CustomMetricInfo
}{
namespace: "default",
selector: labels.Everything(),
info: provider.CustomMetricInfo{
GroupResource: schema.GroupResource{},
Namespaced: true,
Metric: "metric-per-unit",
},
},
},
}
for _, tc := range multiValueTests {
t.Run(tc.test, func(t *testing.T) {
metricsStore := NewMetricStore(func() time.Time {
return time.Now().UTC().Add(15 * time.Minute)
})
// Insert a metric with value
for _, insert := range tc.insert {
metricsStore.Insert(insert)
}
})
}
}
func TestExternalMetricStorage(t *testing.T) {