4586 Commits

Author SHA1 Message Date
Sven Jacob
0bf2e1410e fixed bug
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4902 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 14:15:09 +00:00
Sven Jacob
48262206e5 removed unused imports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4901 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 14:12:57 +00:00
Tom Copeland
671f9bf052 *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4900 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 02:21:18 +00:00
Tom Copeland
47287851b5 Added Maven bundle creation to release process
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4899 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 02:19:30 +00:00
Tom Copeland
1be2b58e9e Doh! I had forgotten to upload the site
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4898 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 01:52:33 +00:00
Xavier Le Vourch
463bd02c30 bug fix: //ConditionalExpression//ConditionalExpression raised a java.lang.StringIndexOutOfBoundsException
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4897 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 19:19:13 +00:00
Tom Copeland
fd96acd61d rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4895 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 14:23:15 +00:00
Tom Copeland
ad6246cdd0 More suppression tests; thanks to Ryan Gustafson for the patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4894 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 04:07:02 +00:00
Tom Copeland
df56bd7746 Added note about ignore PMD annotations; thank to Jason Bennett for the research
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4893 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 04:04:36 +00:00
Allan Caplan
9e7deee88f I've refactored this class to not cache the results any more. This is a
tradeoff in testing I've found the CPU tradeoff is negligeable. With the
cache, large codebases consumed a lot of memory and slowed down greatly when approaching 3,000 classes.

Also fixes some false positives.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4892 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 01:02:12 +00:00
Tom Copeland
9f6ee02e66 Patch [ 1615410 ] Various fixes for build with maven 1.x; thanks to Lukas Theussl!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4891 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-18 14:10:10 +00:00
Xavier Le Vourch
aa787a7e26 Oops, 1.5 constructs integrated in previous commit...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4890 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-17 01:54:49 +00:00
Xavier Le Vourch
70ef1ccc2f bug fixes: multithreading issues reported by Ryan Gustafson in the forum
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4889 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-17 01:44:19 +00:00
Allan Caplan
958c6bf91a Fixing some false positives Xavier pointed out
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4888 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-16 01:35:13 +00:00
Xavier Le Vourch
b24c8fe053 DynamicXPathRule is now generated automatically by parsing XPath expression and is transparent to rule writers (based on code by Ryan Gustafson)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4887 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 02:29:37 +00:00
Allan Caplan
753bd13853 Mapping for inner classes had an issue.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4886 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 01:48:52 +00:00
Allan Caplan
713256dda1 Fixed bug 1571309 - CLI should recognize leading options
Modified CommandLineOptions to check if the first element starts with a -. If it does, the optional options are first, it therefore looks at the end for the optional args.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4885 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 01:10:50 +00:00
Allan Caplan
d0a8f7fedd Adding missing test resource
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4884 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 00:34:55 +00:00
Allan Caplan
6cf52f8267 Unit test for patch 1615546
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4883 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 00:28:49 +00:00
Allan Caplan
e2f2298ffa Applied patch 1615546 - Added option to command line to write directly to a file
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4882 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 00:17:27 +00:00
Allan Caplan
2ad29feced Updating test to reflect change in classloader
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4881 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 14:44:12 +00:00
Tom Copeland
d5f48b5146 Fixes from Ryan Gustafson
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4880 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 14:18:13 +00:00
Xavier Le Vourch
4269dede06 Applied patch 1615519 - controversial/DefaultPackage XPath rule is wrong
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4879 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 08:05:47 +00:00
Xavier Le Vourch
dea96e3059 Bug fix: creating InputStream in different thread lead to resource exhaustion on Linux...; unexepected exception in worker threads now shutdowns the ExecutorService right away
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4878 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 04:43:22 +00:00
Allan Caplan
1664005b21 Applied patch 1613674 - Support classpaths with spaces in pmd.bat
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4877 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 02:46:17 +00:00
Tom Copeland
7dc290d89e Renamed with Test suffix
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4876 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 02:13:30 +00:00
Allan Caplan
db33e92828 Fixed bug 1031966
Re-Implemented CloneMethodMustImplementCloneable as a typeresolution rule. This rule can now detect super classes/interfaces which are cloneable.

The JUnit test was a bit tricky - I've added the interface as an actual concrete interface inside the xml package, and reference it from the xml test definitions. The JUnit works, this sort of design may be needed for other type resolution rules


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4875 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 01:33:39 +00:00
Allan Caplan
ca180e0ac2 Adding JUnit tests for the type resolution facility.
This is just a start - more to come


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4874 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 01:29:38 +00:00
Allan Caplan
6fff435614 Adding JUnit tests for the type resolution facility.
This is just a start - more to come


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4873 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 01:22:19 +00:00
Xavier Le Vourch
fe18d61b70 -cpus command line option added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4872 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-13 22:04:26 +00:00
Brian Remedios
62d1e9ee73 a minor optimization to test commits in CVS
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4871 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-12 22:19:28 +00:00
Xavier Le Vourch
0f44bce4e5 Multithreaded processing on multi core or multi cpu systems.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4870 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-12 01:33:39 +00:00
Tom Copeland
3bb598ccd9 Fixed ReportTest broken by SuppressWarning change
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4869 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-11 22:52:21 +00:00
Wouter Zelle
3006a12892 MisplacedNullCheck now catches more cases (bug 1610730)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4868 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-11 22:27:58 +00:00
Wouter Zelle
6e7d39c4eb Fixed little bug
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4867 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-11 21:56:56 +00:00
Sven Jacob
233f5b9bac some refactoring
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4866 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-11 17:51:08 +00:00
Sven Jacob
82debb0fd5 added dataflowanomaly-analysis test
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4865 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-11 17:24:58 +00:00
Xavier Le Vourch
64b035b8c7 Bug fix: reusing the same Facade objects created problems with multithreading. It is also likely that the Eclipse plugin was affected as several analysis can be done in parallel
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4864 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-08 01:14:36 +00:00
Tom Copeland
14feb13963 Modified annotation suppression to use @SuppressWarning('PMD') to suppress all warnings and @SuppressWarning('PMD.UnusedLocalVariable') to suppress a particular rule's warnings.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4863 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-07 13:56:47 +00:00
Xavier Le Vourch
81a8aea958 New DynamicXPathRule class to speed up XPath based rules by providing a base type for the XPath expression.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4862 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-06 06:32:17 +00:00
Tom Copeland
2b2869b853 Fixed bug 1570824 - HTML reports generated on Windows no longer contain double backslashes. This caused problems when viewing those reports with Apache.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4861 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-05 14:38:24 +00:00
Tom Copeland
5f3dcf3dfc Oops, checked in wrong test value
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4860 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-04 23:07:46 +00:00
Xavier Le Vourch
7feb6f4417 undo previous commit
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4859 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-04 18:24:37 +00:00
Xavier Le Vourch
cc320fdaa3 xpath removed: rule has been rewritten in Java
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4858 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-04 18:15:10 +00:00
Tom Copeland
deb8bb0e6f Enhancements to UselessStringValueOf thanks to Thomas Leplus
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4857 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-04 14:01:23 +00:00
Tom Copeland
bb75de2bd0 *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4856 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-01 14:00:19 +00:00
Sven Jacob
24d9380ea9 show dialog box after cpd finished without results
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4855 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-01 11:13:48 +00:00
Brian Remedios
71c8d956d1 minor scope optimization
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4854 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-01 07:12:13 +00:00
Brian Remedios
c2b88baac1 rm dead interface (renamed to LineGetter a while back)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4853 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-01 07:10:50 +00:00
Xavier Le Vourch
8b527ccfe4 bug fix: detection of extra parenthesis was not correct, selfassigned returned true for more than cases such as '(i)++'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4852 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-01 07:10:26 +00:00