hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
4,540 Commits 16 Branches 123 Tags
Commit Graph

4540 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Xavier Le Vourch
21ba3d8e22 annotation before package could not be parsed 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4754 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-27 00:59:54 +00:00
Xavier Le Vourch
75664112cf PMD on PMD: UseCollectionIsEmpty 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4753 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 23:55:50 +00:00
Xavier Le Vourch
3e7b44fb80 Bug fixes in UseCollectionIsEmpty: detect > 0, size() in expression is not valid ( .size() % mod == 0), NPE on jdk 6 source code 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4752 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 23:20:16 +00:00
Xavier Le Vourch
2e3a00b084 PMD on PMD: UseCollectionIsEmpty 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4751 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 18:41:49 +00:00
Xavier Le Vourch
b022eaf244 PMD on PMD: import cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4750 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 18:28:36 +00:00
Xavier Le Vourch
abb5dcd8ce Fixed bug in UselessOverridingMethod: false + when adding synchronization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4749 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 18:15:30 +00:00
Allan Caplan
afb64b04a6 Fixed UseCollectionIsEmpty rule to only fire on Collection types. Made the code abstract since it's very similar to InefficientEmptyStringCheck. 
The code also only found lst.size() == 0, and not 0 == lst.size(), that's fixed too.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4748 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 17:28:59 +00:00
Xavier Le Vourch
6c5338fdaf Fixed array handling in UnusedFormalParameter 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4747 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 16:56:14 +00:00
Brian Remedios
ffc5bcb052 minor tweak 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4746 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 05:38:35 +00:00
Xavier Le Vourch
babfc20c39 Fixed array handling in AvoidReassigningParameters 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4745 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 05:29:52 +00:00
Allan Caplan
6215d97b9e Checkin of the Type Resolution Facility 
Re-implemented LooseCoupling as a new rule - new or changed type resolution rules should go in typeresolution to be separated.

I have not added this to 39.xml!

Sorry about the lack of comments, will go through and try and get important things commented.

There's a couple TODO's that if addressed should help performance.

Remember, to run compiled classes must be in the CLASSPATH!


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4744 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 02:35:38 +00:00
Xavier Le Vourch
15abbd44ae bug fix: incorrect detection of top level classes/interfaces (crashed on jdk 1.5 and 1.6 source code) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4743 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 23:21:30 +00:00
Xavier Le Vourch
9bad2be979 Fixed several rules (annotations related exceptions for on jdk 1.5 and jdk 1.6 source code) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4742 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 19:40:45 +00:00
Xavier Le Vourch
70a6550716 Fixed several rules (exceptions on jdk 1.5 and jdk 1.6 source code). 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4741 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 02:26:36 +00:00
Xavier Le Vourch
3afd463075 fixed 1.5 parsing bugs: hex floating points, annotations before enum constants 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4740 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 01:59:11 +00:00
Allan Caplan
d8d36f0796 Type Resolution Code. Posting for comments. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4739 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 01:45:49 +00:00
Tom Copeland
c2e36685a7 Removed unused script element, thanks to Jason Bennett for the good catch 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4738 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 00:52:31 +00:00
Xavier Le Vourch
de7a4f1f70 NPE in rule LocalVariableCouldBeFinal on jdk 1.5 source code (RegexParser.java) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4737 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-24 03:05:39 +00:00
Brian Remedios
833427e74f refactored common functionality 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4736 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 14:50:06 +00:00
Xavier Le Vourch
8cc36876c1 Fixed several rules (exceptions on jdk 1.5 source code). 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4735 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 07:05:21 +00:00
Xavier Le Vourch
5287ab72a2 Performance Refactoring, XPath rules re-written as Java: MoreThanOneLogger 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4734 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 05:42:36 +00:00
Xavier Le Vourch
b90fba9662 Performance Refactoring, XPath rules re-written as Java: AssignmentInOperand AvoidDollarSigns SuspiciousHashcodeMethodName UselessStringValueOf 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4733 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 00:17:58 +00:00
Xavier Le Vourch
e67a4521bc import cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4732 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 19:07:32 +00:00
Brian Remedios
b24b73850d + deprecation tag 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4731 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:54:46 +00:00
Brian Remedios
76fff7b62a updated 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4730 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:50:36 +00:00
Brian Remedios
e75bead8c5 minor optimization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4729 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:44:38 +00:00
Brian Remedios
873c282aac minor Javadoc fixup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4728 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:41:06 +00:00
Brian Remedios
38af9abcf0 updated Javadoc 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4727 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:30:49 +00:00
Brian Remedios
42c4e0e336 Java handlers are mere factories - made their broker a static function 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4726 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:29:16 +00:00
Xavier Le Vourch
47655a29c8 1.6 added as a valid option for targetjdk 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4725 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 01:51:24 +00:00
Xavier Le Vourch
f13070e2c5 1.6 added as a valid option for targetjdk 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4724 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 01:30:39 +00:00
Xavier Le Vourch
9218cfeac1 java 1.4 is needed to run pmd 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4723 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 00:44:57 +00:00
Xavier Le Vourch
065681cfc7 Fixed bug 1581123 - False +: UnnecessaryWrapperObjectCreation 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4722 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 23:13:09 +00:00
Xavier Le Vourch
d1f45bb555 SourceType made Comparable 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4721 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 22:50:18 +00:00
Xavier Le Vourch
91614290e7 pmd requires javac 1.4 or newer 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4720 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 22:44:37 +00:00
Xavier Le Vourch
fef103761e java 1.4 is needed to run pmd 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4719 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 22:40:30 +00:00
Tom Copeland
2aa188e17e The remainder of the fixes from Aaron, thanks much! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4718 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 19:56:36 +00:00
Tom Copeland
7c6cba0e76 Oops 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4717 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 19:51:22 +00:00
Tom Copeland
ddf3533bbf Fixed false negatives in UseArraysAsList, thanks to Fabio Insaccanebbia for the patch! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4716 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 19:38:12 +00:00
Tom Copeland
2fb2fcd14d Now a rule can access the SourceType via the RuleContext 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4715 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 15:38:09 +00:00
Xavier Le Vourch
5fb4c57b46 use of entrySet to iterate over Maps. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4714 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 06:03:04 +00:00
Brian Remedios
2e0477cdb1 renamed poorly-named interface 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4713 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:44:37 +00:00
Brian Remedios
b66c99dc6c minor performance tweak & import set cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4712 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:42:07 +00:00
Brian Remedios
fa760a735c minor optimization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4711 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:40:49 +00:00
Brian Remedios
d120170a5e minor cleanup (Vector -> ArrayList), etc 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4710 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:40:14 +00:00
Tom Copeland
dff3475e32 Fixed bug 1580859 - AvoidDecimalLiteralsInBigDecimalConstructor now catches more cases, thanks to Ryan Gustafson for the fix! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4709 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 01:57:47 +00:00
Tom Copeland
67e3695637 Fixed JDK 1.5 source parsing bug 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4708 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 21:10:09 +00:00
Tom Copeland
923173a3e9 Fixed bug 1579615 - OverrideBothEqualsAndHashcode no longer throws an Exception on equals methods that don't have Object as a parameter type. Thanks to Wouter Zelle for the report and the fix! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4707 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 20:45:24 +00:00
Tom Copeland
de197ba845 *** empty log message *** 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4706 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 18:14:40 +00:00
Tom Copeland
7b1671ca6d Improvements to equals from Sven Jacob 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4705 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 18:14:32 +00:00