hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
4,540 Commits 16 Branches 123 Tags
Commit Graph

4540 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Xavier Le Vourch
ec24b90757 results Text area made non editable 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4654 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 22:26:45 +00:00
Tom Copeland
e9ae40d1ba tweak 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4653 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 17:08:40 +00:00
Brian Remedios
ec157c53a2 new facilities in prep for property management framework 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4652 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:52:37 +00:00
Brian Remedios
26f2a5fdfe Comment cleanup for bug #1512374 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4651 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:36:10 +00:00
Brian Remedios
6433ace8b7 Comment cleanup for bug #1512374 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4650 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:26:23 +00:00
Brian Remedios
e31e3387e5 Comment cleanup for bug #1512374 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4649 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:15:01 +00:00
Tom Copeland
80c477cb32 Fixed typo, thx to A.M. Berg for the report 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4648 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 04:52:42 +00:00
Tom Copeland
29a652acdf Renamed file to avoid confusing the Ant unit test globber 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4647 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 04:42:11 +00:00
Allan Caplan
8b577f11d6 Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4646 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 01:25:19 +00:00
Allan Caplan
07a82e37ca Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4645 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 01:16:57 +00:00
Allan Caplan
736a3560ea Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4644 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 00:56:57 +00:00
Allan Caplan
dd9da8fc4e Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4643 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 00:38:37 +00:00
Allan Caplan
b32e7fbd6b Improving JUnit tests 
I went over the output, it looks correct. For many, having a test will help down the road to throw a flag if anything changes


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4642 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 23:49:38 +00:00
Tom Copeland
3525293786 Fix from Jason Bennett: Fixed bug 1371753 - UnnecessaryLocalBeforeReturn is now less aggressive in its reporting. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4641 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 22:02:21 +00:00
Allan Caplan
8609d6de90 assertion for code fragment appended PMD.EOL. This would be correct, except on Windows systems it appears that the Dom is not using the system's carriage return, rather it always uses \n's. 
This test runs A-OK on linux, was failing on Windows. Runs A-OK for me on both now.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4640 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 21:05:16 +00:00
Allan Caplan
7e2877ec84 Added some JUnit tests, fixed comment in rule 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4639 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 20:54:08 +00:00
Allan Caplan
0d2aec583c Added some JUnit tests 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4638 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 13:32:12 +00:00
Tom Copeland
2c76cab7c7 Added new NpathComplexity rule from Jason Bennett 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4637 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 13:30:22 +00:00
Tom Copeland
730234d7ae Added new NpathComplexity rule from Jason Bennett 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4636 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 13:30:21 +00:00
Allan Caplan
36803bc9f6 Doing a JUnit review - checking tests with low coverage for what they're missing 
ExcessivePublicCount Rule looks OK, just added some missing JUnit tests


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4635 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 02:04:34 +00:00
Xavier Le Vourch
d60c00c5ab useless ; in java code removed 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4634 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 02:01:41 +00:00
Allan Caplan
8189d97f05 Doing a JUnit review - checking tests with low coverage for what they're missing 
ArrayIsStoredDirectly is documented as finding constructors, as well as methods, but only methods were tested. Adding a constructor to the test revealed a failed JUnit test - fixed rule.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4633 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 01:37:33 +00:00
Allan Caplan
1aa75f9540 Doing a JUnit review - checking tests with low coverage for what they're missing 
ArrayIsStoredDirectly is documented as finding constructors, as well as methods, but only methods were tested. Adding a constructor to the test revealed a failed JUnit test - fixed rule.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4632 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 00:44:12 +00:00
Tom Copeland
394556e9a5 Fixed property initializing 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4631 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-12 19:57:12 +00:00
Allan Caplan
5503e6244b Removing DontMixJsfWithJspText test - it was empty, and there is no DontMixJsfWithJsp rule. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4630 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-12 18:16:17 +00:00
Tom Copeland
5c4ed3407d Fixed property initialization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4629 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-12 13:24:16 +00:00
Xavier Le Vourch
0e2eb81fa6 Applied patch 1574988 - false + in OverrideBothEqualsAndHashcode 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4628 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-12 03:31:20 +00:00
Xavier Le Vourch
cf20efc5a6 Applied patch 1573981 - false + in CloneMethodMustImplementCloneable 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4627 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-12 03:22:07 +00:00
Tom Copeland
d0d04a8118 Added Xavier Le Vourch; welcome aboard Xavier! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4626 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-12 00:26:42 +00:00
Allan Caplan
9bb86a7325 https://sourceforge.net/forum/message.php?msg_id=3956007 
CloseResource was looking for import java.sql.* - removed this check, since java.io checks might might have java.sql imports


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4625 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-11 14:54:16 +00:00
Brian Remedios
ce664ea5fe moved property retrieval to within constructor - bugfix 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4624 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-11 03:43:09 +00:00
Philippe Herlin
5240919b79 Fix other PMD warnings 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4623 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 22:31:02 +00:00
Philippe Herlin
9417d666ea Review Sebastian code... and fix most PMD warnings 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4622 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 22:19:59 +00:00
Philippe Herlin
0220fe980e Review Sebastian code... and fix most PMD warnings 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4621 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 21:43:20 +00:00
Brian Remedios
337140049f refactored 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4620 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 05:48:29 +00:00
Brian Remedios
23f2e78266 faster contains() test using Sets 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4619 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 05:36:05 +00:00
Brian Remedios
9fd45540f6 faster contains() test using Sets 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4618 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 05:26:13 +00:00
Brian Remedios
17a19c9bae refactored to use new asSet utility method 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4617 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 05:22:33 +00:00
Brian Remedios
fa22ffead5 refactored asSet f'n into new CollectionUtil class 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4616 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 05:17:46 +00:00
Brian Remedios
67471afb6d added missing violation description 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4615 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 05:09:06 +00:00
Brian Remedios
95857a8b62 optimization in preparation for new property mgmt code: retrieving report level just once at startup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4614 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 05:05:00 +00:00
Brian Remedios
2ed04a9118 Vector -> ArrayList & import cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4613 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 04:55:19 +00:00
Brian Remedios
2e2c8b97af refactored, new generalized importsPackage(packageName) function in superclass 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4612 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 04:51:43 +00:00
Brian Remedios
c7e7048c5b optimized & refactored 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4611 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 04:45:57 +00:00
Brian Remedios
ff044bf2a4 append optimizations 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4610 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 04:30:13 +00:00
Brian Remedios
5f6dd18214 refactored, new isQualifiedName(SimpleNode) method 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4609 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 04:12:21 +00:00
Tom Copeland
1fab9a1a41 Oops, checked in a debugging version by mistake 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4608 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 04:06:55 +00:00
Tom Copeland
85e1b75ad2 A patch from Xavier Le Vourch to fix a missed hit in ProperCloneImplementation 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4607 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 03:55:58 +00:00
Allan Caplan
65e1f026c1 1573591 - NonThreadSafeSingleton throws NullPointerException 
Using this keyword messed things up - modified to use Wouter's suggestion, works nice


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4606 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-10 00:07:26 +00:00
Allan Caplan
0e9d2882d5 1573795 - PreserveStackTrace throws ClassCastException 
Code didn't take into account throws with 0 args. Fixed.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4605 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-09 23:59:00 +00:00