4540 Commits

Author SHA1 Message Date
Tom Copeland
ad0bec0843 Some tweaks from Aaron Optimizer Digulla
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4704 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-19 15:28:27 +00:00
Brian Remedios
ce424d73a2 refactored type lookup functionality with a new TypeMap
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4703 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-18 13:26:10 +00:00
Allan Caplan
f0e67f2dbc Soliciting feedback. Please see: https://sourceforge.net/forum/message.php?msg_id=3968620
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4702 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-18 00:22:16 +00:00
Allan Caplan
82a7af9b27 Temporary check in - looking for feedback, some working code for symbol resolution
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4701 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 16:50:34 +00:00
Xavier Le Vourch
4461137169 Spelling
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4700 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 04:34:58 +00:00
Brian Remedios
f32e56c7c8 added property descriptors & references to them
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4699 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 02:37:43 +00:00
Brian Remedios
1ea1900e09 added property descriptors & references to them
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4698 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 02:28:09 +00:00
Brian Remedios
a2744c7eae added property descriptors & references to them
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4697 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 02:22:18 +00:00
Brian Remedios
99246f8819 added property descriptors & references to them
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4696 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 02:10:16 +00:00
Brian Remedios
9039d018c8 added property descriptors & references to them
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4695 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 02:04:43 +00:00
Brian Remedios
e54bf36d7a replaced getImage().equals with utility method hasImageEqualTo (cleaner & handles nulls)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4694 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 01:07:18 +00:00
Brian Remedios
3969dcbf7c minor performance tweaks
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4693 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 01:01:33 +00:00
Brian Remedios
e4a9e4128b replaced getImage().equals with utility method hasImageEqualTo (cleaner & handles nulls)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4692 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 00:48:10 +00:00
Brian Remedios
56a8619c4e revised method call
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4691 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 00:27:46 +00:00
Brian Remedios
ad68c535bb updated to use revised API
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4690 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 00:24:21 +00:00
Brian Remedios
834b9848d6 rm calls to deprecated methods in test suite
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4689 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 00:18:07 +00:00
Allan Caplan
9c0eef920c Fixed bugs 1060761 / 1433119 & RFE 1196954 - CloseResource now takes an optional parameter to identify closure methods
Using strings to identify the parameter, and not the property descriptor as the JUnit test did not pass using the property descriptor.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4688 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 00:13:16 +00:00
Brian Remedios
bb51e44aaf updated test suite to accommodate API change
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4687 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-17 00:00:18 +00:00
Brian Remedios
54124e6034 replaced new Integers with constants
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4686 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 23:39:13 +00:00
Allan Caplan
2395305df3 Fixing Integer.valueOf
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4685 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 23:35:27 +00:00
Allan Caplan
75c4980c4c Fixing Integer.valueOf
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4684 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 23:05:13 +00:00
Brian Remedios
9797a8857d revised API to use descriptors as property keys rather than strings
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4683 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 20:55:31 +00:00
Allan Caplan
0e8bf7c3ab Implemented RFE 1566313 - allow minimumpriority attribute to be set at command line
used same attribute as the ant task, minimumpriority, but used all lower case to keep in line with other command line params


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4682 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 19:10:42 +00:00
Allan Caplan
da63ae1c76 Applied patch 1565532 Java NCSS checks from Jason Bennett
Changes made:
- Changed classes to Ncss* to maintain consistency between them and the rule name
- Added JUnit tests. Ran against NCSS current release to validate code size
- Moved to codesize package


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4681 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 15:42:45 +00:00
Allan Caplan
2378d27100 Implemented patch 1577540 from Jason Bennet
Patch is for Feature Request ] 1434274 - UseCollectionIsEmpty
Thanks Jason!

Some small tweaks: Moved some null checks around for performance, added JUnit test.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4680 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 14:40:51 +00:00
Tom Copeland
d366791ce8 Trying to get under the SF quota
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4679 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 14:24:48 +00:00
Allan Caplan
d71a09c431 Testing for bug 1432595 :False +: MissingStaticMethodInNonInstantiatableClass
Not reproducable


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4678 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 13:35:18 +00:00
Tom Copeland
b3ae8d05cf More complexity measurement cleanups from Jason Bennett; thanks Jason!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4677 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 13:25:23 +00:00
Allan Caplan
3975d821c3 Adding tests for defect report: http://sourceforge.net/tracker/index.php?func=detail&aid=1531158&group_id=56262&atid=479921
Could not reproduce - issue may have been fixed


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4676 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 13:15:40 +00:00
Tom Copeland
cdc30a26d1 More tweaks from Peter
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4675 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 12:56:31 +00:00
Tom Copeland
e1871526ed Er, I mean, a better 'create rule XML' panel from _Peter Van de Voorde_
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4674 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 12:54:29 +00:00
Tom Copeland
0560184d06 A better 'create rule XML' panel from Sven Jacob
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4673 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 12:52:11 +00:00
Brian Remedios
ee22ca56c2 minor optimization
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4672 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 04:03:18 +00:00
Brian Remedios
3e8266b96a updated rule with property descriptors
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4671 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-16 02:11:24 +00:00
Tom Copeland
55a9139f46 Fixed ORO Maven reference name, thanks to Dave Brosius for the tip!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4670 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 18:40:23 +00:00
Brian Remedios
662189f644 minor updates
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4669 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 06:22:05 +00:00
Brian Remedios
810ae42392 Documentation for the property handling framework
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4668 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 05:56:16 +00:00
Brian Remedios
73262fea13 updated rule with property descriptors
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4667 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 05:31:22 +00:00
Tom Copeland
ab83afb522 Fixed bug 1566547 - Annotations with an empty MemberValueArrayInitializer are now parsed properly.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4666 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 05:20:41 +00:00
Brian Remedios
084fb9f924 property framework addition - revised rule superclasses to use it
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4665 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 05:18:17 +00:00
Brian Remedios
1c7b95bb55 new property management framework - not activated yet
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4664 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 05:05:58 +00:00
Brian Remedios
4be25d55e9 StringBuffer use optimization
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4663 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 01:38:02 +00:00
Allan Caplan
37bc14d37b Tweaking JUnit tests to be more complete
Adding this test to validate current working code doesn't break I've been
trying to locate the article referenced. The code stresses the NPath
rule, and according to its current style, runs 2 tests, one pass and one
fail.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4662 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 01:27:06 +00:00
Allan Caplan
fbbf3bc58d Tweaking JUnit tests to be more complete
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4661 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 00:47:24 +00:00
Allan Caplan
bb7e04f5d7 Tweaking JUnit tests to be more complete
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4660 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 00:31:11 +00:00
Xavier Le Vourch
a9c8f02a94 import cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4659 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 00:21:48 +00:00
Allan Caplan
d21442b15c Tweaking JUnit tests to be more complete
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4658 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-15 00:16:15 +00:00
Allan Caplan
302788631a Tweaking JUnit tests to be more complete
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4657 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-14 23:56:10 +00:00
Xavier Le Vourch
303f3f5bfc undo/redo added to text areas in designer.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4656 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-14 23:12:21 +00:00
Tom Copeland
32da061555 Added Alan's article
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4655 51baf565-9d33-0410-a72c-fc3788e3496d
2006-10-14 22:43:14 +00:00