4722 Commits

Author SHA1 Message Date
Xavier Le Vourch
45e310cfe4 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4990 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-28 00:29:59 +00:00
Xavier Le Vourch
0f22e2b21b Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4989 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 23:56:52 +00:00
Xavier Le Vourch
7786a8266b Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4988 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 23:17:08 +00:00
Xavier Le Vourch
d37b148b01 pmd task needs targetjdk 1.5 for 'pmdOnPmd'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4987 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 22:44:19 +00:00
Xavier Le Vourch
eeaef87936 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4986 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 22:26:16 +00:00
Xavier Le Vourch
dbe392343a Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4985 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 22:21:58 +00:00
Xavier Le Vourch
0dbf51a023 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4984 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 21:51:18 +00:00
Xavier Le Vourch
5e3e0492ce Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4983 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 21:26:11 +00:00
Xavier Le Vourch
2d2970a3c1 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4982 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 21:01:43 +00:00
Allan Caplan
1d1e289298 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4981 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 18:17:06 +00:00
Allan Caplan
ccdef61ec8 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4980 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 18:11:14 +00:00
Allan Caplan
7e76a69137 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4979 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 16:22:46 +00:00
Allan Caplan
8293ffc2aa Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4978 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 15:59:46 +00:00
Allan Caplan
42008b02f4 Checking in some Java 5 changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4977 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 15:46:28 +00:00
Xavier Le Vourch
e3437d47df bin and java/bin versions use similar variables
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4976 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 05:00:49 +00:00
Xavier Le Vourch
bf8fc96a0a all .bat files use similar setup. Should be easier to maintain/automate changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4975 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 04:21:06 +00:00
Xavier Le Vourch
cb0c334007 updates for weaving to work on Linux
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4974 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 02:25:57 +00:00
Xavier Le Vourch
516c081652 PMD now requires JDK 1.5 to be compiled. Java 1.4 support is provided using Retroweaver
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4973 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-27 01:14:44 +00:00
Brian Remedios
797aedf087 Cleanup rule description formatting & sorting bug crasher
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4972 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-24 22:46:17 +00:00
Allan Caplan
9a785ded03 RFE - 1627581 - Unused(*) rules should respect annotations
@SuppressWarnings("unused") will suppress the rules currently in unusedcode.xml ruleset

Including unit tests.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4971 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-24 02:44:17 +00:00
Wouter Zelle
0b79372cf5 clarified loop
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4970 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-22 21:13:05 +00:00
Wouter Zelle
e3c2b25ad5 commented out code that is related to the other commented out code
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4969 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-22 21:12:25 +00:00
Wouter Zelle
7d19e1dbd8 Added NOPMD and comments to indicate why
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4968 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-22 21:12:21 +00:00
Wouter Zelle
70b048e96e Don't catch Throwables
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4967 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-22 21:08:25 +00:00
Wouter Zelle
68e10b5157 New ant target to run PMD on the PMD sources with 20 rules that we could enforce at one point
Small change to copy all rulesets cleanly
Added proper target dependencies to pmd target, same as pmdOnPmd


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4966 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-22 20:48:53 +00:00
Ryan Gustafson
f690a1114f Add nested scenario with same variable name on inner and outer catches.
My regression testing pointed this out as a false negative with the rule
using XPath based queries.  The modified rule now catches this.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4965 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-21 07:56:52 +00:00
Ryan Gustafson
2a62df0b32 Performance improvement by replacing call to findChildNodesWithXPath()
with findChildrenOfType() and custom match logic.  My test scenario
went from 39s time spent by this Rule to less than 1s.
Minor reformatting too.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4964 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-21 07:07:45 +00:00
Radim Kubacki
dd355e8734 [ 1634131 ] Netbeans Plug-in and source level 1.6 - fixed, test added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4963 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-19 09:04:00 +00:00
Radim Kubacki
3221fa8445 compile warning
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4962 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-19 09:00:21 +00:00
Philippe Herlin
d0d88dd9c2 Fix 1583788 StackOverflowError in rule edit window
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4960 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 22:38:04 +00:00
Philippe Herlin
0445e005bc Release v3.2.0
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4959 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 21:05:30 +00:00
Philippe Herlin
33e3df41d8 Fix several problems on memento usage
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4958 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 21:03:56 +00:00
Philippe Herlin
8b52679b95 Improve rule dialog
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4957 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 21:03:17 +00:00
Philippe Herlin
a29e5e1b74 Fix several cast and NPE exceptions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4956 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 21:01:20 +00:00
Philippe Herlin
075015ade0 Add support for Java 6.0
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4955 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 21:00:23 +00:00
Philippe Herlin
33200450e8 Integrate PMD v3.9
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4954 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 20:59:45 +00:00
Wouter Zelle
e036922986 Fix for class arguments in the expressions that are checked for equality
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4953 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 17:50:36 +00:00
Xavier Le Vourch
33a6d45cd1 NoClassDefFoundError exception caught to prevent pmd from exiting on type resolver issues
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4952 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 01:23:55 +00:00
Allan Caplan
85b2f45b0b Fixing 1636420 - false + in StringToString
Code wasn't looking at the target method. There are no String[].toString's in PMD, running on other sources surfaced this


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4951 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-18 01:15:07 +00:00
Xavier Le Vourch
f5195c01a7 latin1 encoding option for javac: warnings on Linux otherwise
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4950 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-16 23:53:13 +00:00
Xavier Le Vourch
9fba2a117d code cleanup: PMD on PMD
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4949 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-16 01:08:58 +00:00
Sven Jacob
d35f00bdd5 violation overview was not updated in some cases... fixed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4948 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-14 21:03:49 +00:00
Tom Copeland
ad55a35501 Ryan has commit now; welcome aboardgrep -rn egen src/
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4947 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-14 19:55:24 +00:00
Allan Caplan
482a505f68 Fixed bug 1627830 - False+ UseLocaleWithCaseConversions
The XPath was looking for any ArgumentCount==0, it should only look at one spot


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4946 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-14 02:16:38 +00:00
Allan Caplan
97faa6fe61 Fixed bug 1631646 - UselessOperationOnImmutable doesn't throw on variable.method().variable.
This defect falls under the bigger umbrella of issues around getUsages. A more global fix was eluding me - Fixing directly


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4945 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-14 01:44:30 +00:00
Allan Caplan
f308f8c4cc 1634078 - False positive in StringToString
StringToString rule wasn't taking arrays into account.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4944 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-13 03:55:30 +00:00
Allan Caplan
28e81e38e1 Fixed bug 1531216 - ImmutableField
NameOccurence did not detect this.x++ or ++this.x as a self-assignment, even though x++ or ++x was.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4943 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-13 03:05:27 +00:00
Xavier Le Vourch
32f881bb60 more benchmark changes from Ryan Gustafson
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4942 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-13 01:37:25 +00:00
Wouter Zelle
b381f76941 Fixes for 1633683. BrokenNullCheck now also catches problems if there is an equality expression in the offending code. The rule now also matches array literals in the expressions, for slightly greater accuracy. Some comments + cleanups too.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4941 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-12 22:11:55 +00:00
Xavier Le Vourch
632d65cb17 refactoring: ByRule suffix dropped
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4940 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-12 19:33:00 +00:00