10741 Commits

Author SHA1 Message Date
Benoît Ganne
2ef2ac780e ipsec: fix AES CBC IV generation (CVE-2022-46397)
For AES-CBC, the IV must be unpredictable (see NIST SP800-38a Appendix
C). Chaining IVs like is done by ipsecmb and native backends for the
VNET_CRYPTO_OP_FLAG_INIT_IV is fully predictable.
Encrypt a counter as part of the message, making the (predictable)
counter-generated IV unpredictable.

Fixes: VPP-2037
Type: fix

Change-Id: If4f192d62bf97dda553e7573331c75efa11822ae
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2023-02-07 18:30:24 +01:00
Benoît Ganne
bb25fbf28c rdma: fix rdma-core install
We should not install symlinks to local build directory.

Type: fix

Change-Id: I81e624dd5775ec9c5dd8c58f578ee51c5acfef73
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 521a9f8eb9d35d2d8783175b89821c6a157237ca)
2021-11-30 21:09:30 +00:00
Dave Wallace
90e6edf15c build: Remove boost dependencies from VOM
- VOM was deprecated in VPP 21.06, but the boost library
  dependencies did not get cleaned up.

Type: make

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I0fb860a7a37676c1a1a0981c91f383882d9a820a
(cherry picked from commit bfcd23968246086b5b884f7df1e78adb1a059724)
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2021-11-30 16:01:41 -05:00
Fan Zhang
bb7418cf9b dpdk: fix missing symbol
Type: fix

This patch fixes the missing symbol of dpdk_plugin.so when
creating symmetric key. The solution is to add dependency
of libssl to dpdk cryptodev and disable cryptodev engine
when libssl is not presented.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I30aa6e3e3af1faefa82883bad613e1d82235a2ec
(cherry picked from commit 3f3da0d27dcf83808f2691205b891a42ac2b4679)
2021-07-07 08:58:27 +00:00
Andrew Yourtchenko
fc83f8cc67 misc: 21.06 Release Notes
Change-Id: Iedd1263a971e50aceb2d579982484dd8873814dc
Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
v21.06
2021-06-30 13:11:13 +00:00
Florin Coras
3001c0344e session: free ctrl event data on connect rpc
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I56c4682aef59ed0e69073f9001341c425e65bd48
(cherry picked from commit 595724a49072b30356e365ce78a3cc815980d342)
2021-06-29 21:26:59 +00:00
wanghanlin
f68dcb720c vcl: Don't use app_socket_api to notify VPP in parent when child exited
Type: fix

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: Icd2fc3cc2d0a0a6060abfb262044cf9e09ab4ba2
(cherry picked from commit b940fd4d5a16b62a5aa09b924140a135fd06c6bb)
2021-06-29 18:49:15 +00:00
Florin Coras
803ac6389d vcl: epoll fix postponed evt handling
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3d208f8ef4638e7557929f4b2bca4d640af85baa
(cherry picked from commit 87f7600dd67debf68d1236395cefdc5d6e7484fb)
2021-06-29 14:32:18 +00:00
Arthur de Kerhor
e19fef7c88 stats: fix race conditions in vpp-api stats client
Type: fix

Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ie5c197f6ec0d41d5e405b22662701d83ad94d29e
(cherry picked from commit c9ae8cfaccd75fbc2dc27bdebccdbd14fc0cb60c)
2021-06-25 08:35:55 -04:00
Florin Coras
c5111d4fa0 session: avoid reordering unlisten and connect msg
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ibe32f7965f8cf457c39845713b029c8a4647ee55
(cherry picked from commit c53eb72931bc8c75204141f3952ac7682f0ae697)
2021-06-22 23:31:20 +00:00
Dave Barach
0a4b9ad148 vlib: fix coverity warning
Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ib563e2c09d46cc26fb983ffde3d5fcb88166f6a5
(cherry picked from commit bfb9a66fab43e935772806e9d2f6b0ecf7146d67)
2021-06-21 18:45:11 +00:00
Florin Coras
1cb93827f9 vcl: fix worker cleanup
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I575068df56623f24c0290fa42b8d301548a089d4
(cherry picked from commit cba215dad3101c6b03483c5c40f806903de8460d)
2021-06-17 19:23:04 +00:00
jxm
d1fd73a93d tls: increase engine bits room in handle to support custom engine type
Type: improvement
Signed-off-by: jxm <jiangxiaoming@outlook.com>
Change-Id: I80a51e841f9727b68d1de713b6b6d51675ef53c5
(cherry picked from commit 975fde82b11307180b3df7dc9b5b1b496f207a08)
2021-06-17 17:41:39 +00:00
Florin Coras
a95292ffdb vcl: fix fifo sharing
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iec1fe8315a057214901250d5fb06d1c1e33dda46
(cherry picked from commit 8eb8d50ecfd7507aae340cb05a0fb07a790e4303)
2021-06-16 23:25:44 +00:00
Florin Coras
8b297dbceb session: fix listener ct transport retrieval on accept
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ied2608e7a28c59c908803ca676abbe93072fadb8
(cherry picked from commit ba02641cc7a27ff02aca65036ffc4bd003497f0b)
v21.06-rc2
2021-06-14 19:46:02 +00:00
Florin Coras
a34aad732b tcp: fix proto in port reuse check
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I338e61654a62ed6308ecd8bb15e1a8b13cd859b9
(cherry picked from commit 41a6fbada173b2733ca3b43bf620d6a9634c50da)
2021-06-14 15:54:10 +00:00
Dave Barach
6b6f413b5c vlib: fix dangling reference in node_by_name hash
When recycling a debug CLI process node, unix_cli_file_add() needs to
delete and recreate the related node_by_name hash table entry.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I635da4918509d5b22eae37627c2d9b3608380ca6
(cherry picked from commit 52c33d60bc63626d400067e38ab0af312fdb8594)
2021-06-13 17:43:18 +00:00
Damjan Marion
6510663c7a memif: fix crash with zero-copy slave
Type: fix
Change-Id: I456cc0b0a6f2dc32b14791baf9d4a7f67279e8df
Signed-off-by: Damjan Marion <damarion@cisco.com>
2021-06-11 17:38:03 +00:00
Florin Coras
3558a9a0ba session: half-open free only on main thread
TCP and (D)TLS clean up half-opens on main without a lock/barrier so
cleanup initiated from first worker, e.g., cut-throughs, can corrupt the
session pool.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2e5162831c0e201b22454f17fe55bfac44b85fa9
(cherry picked from commit 6bd54caf46aaa68dddbae6161688d428ce60550b)
2021-06-11 16:16:24 +00:00
Dave Barach
7dabce4024 docs: cleanup, remove stale material
Point https://fd.io/docs/vpp/master/links/index.html at docs.fd.io/vpp
instead of at one specific stale release

Remove https://fd.io/docs/vpp/master/featuresbyrelease/index.html

Remove https://fd.io/docs/vpp/master/events/index.html

Remove dead projects from
https://fd.io/docs/vpp/master/relatedprojects/index.html

Remove unsupported distros from
https://fd.io/docs/vpp/master/whatisvpp/supported.html

Reduce (doxygen) list of test framework doc files to actively
supported releases

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I179966fbbe09ac123e5f2647787a8dea93190b5c
(cherry picked from commit 3db2c670a157b8bf2daccf77a872c154f88f6d0a)
2021-06-11 14:00:42 +00:00
Florin Coras
50797cda3a vcl: touch fifo on epoll del only if session open
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I0971c18a183319d09486459b0da08d44ce38acef
(cherry picked from commit f1ddeeb15555e783a9cb0133d4f8eb9c40852ab5)
2021-06-10 17:53:50 +00:00
Benoît Ganne
d0f23a3164 fib: make sure dpo is valid even when path pool expands
The path pool can expand during in fib_path_attached_next_hop_get_adj()
when calling adj_nbr_add_or_lock(). If dpo points to a path->fp_dpo, its
reference becomes stale.
Use a temporary copy instead.

Type: fix

Change-Id: Ie966cb5f3f7b416425964dca12f1f586bfc2010c
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit e9d7b0982d7bd189097260b6581abff472da251a)
2021-06-09 15:16:10 +00:00
Benoît Ganne
655c377607 fib: make sure adj is valid during walk
The adj can be deleted during fib_walk_sync(), make sure it can happen
only after clearing the SYNC_WALK_ACTIVE flag.

Type: fix

Change-Id: I68be00e9602e2783d9dced71c51547c38b7e8a00
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 9f10edbb46dc1937ed99469a581723cb1ac1ff45)
2021-06-09 15:14:48 +00:00
Benoît Ganne
6ac910e0d6 ipsec: fix crypto ops in esp decrypt
When both chained and non-chained buffers are processed in the same
vector, make sure the non-chained buffers are processed as non-chained
crypto ops.

Type: fix

Change-Id: I19fc02c25a0d5e2e8a1342e2b88bbae3fe92862f
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit e631ece4aa32b33651ed458200ab551ffb8fbb47)
2021-06-09 12:18:52 +00:00
Dave Barach
f9d10e7dd5 vppinfra: pool_free_elts() now supports fixed-size pools
Test added to the unittest plugin / test_vlib.py

Type: improvement
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I73445e57918347c102ff6f5e8c9ddb9bd96f1407
(cherry picked from commit 4de5f9be88857197ddf17e3bff66318f78f4b6bb)
2021-06-08 15:24:29 +00:00
Florin Coras
e9b33fcbde vcl: avoid multiple reads on peek
Only try once and return what was found.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I50b1d26babf1b7431d36f6b7472a1fb01475bb35
(cherry picked from commit 233683180638d1c7f517b713722cbbeb3b4be86e)
2021-06-07 21:31:53 +00:00
Florin Coras
b635851ee2 vcl: avoid updating errno on ldp init check
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7f5887865aa29c9881b5063be1d7d42369a493c1
2021-06-07 21:31:36 +00:00
Simon Zhang
dd6fe0c539 tls: change picotls plugin crypto module to accommodate new version picotls
Type: fix

Change-Id: I58931e235535be7d596ca578790f389b64a4fbd2
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
(cherry picked from commit 778b3186fc911af2aabbbfbf56bc1df5e2373061)
2021-06-07 21:31:18 +00:00
Florin Coras
53af06a214 vcl: accept zero length writes
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I84985f59274e77219a38ea6ac865fc73ac635d72
(cherry picked from commit 0b0d28e9bf1ea078ce1a846d22e499d13eadd464)
2021-06-07 21:25:49 +00:00
Florin Coras
2fea186aee vcl: epoll error handling fixes and improvements
- return VPPCOM_EEXIST if attempting to re-add a session
- return VPPCOM_ENOENT if the session to be removed is not epolled
- generate EPOLLIN if adding it through a mod operation on a session
that has data and did not have the event previously set.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I728a06b8cf84af8d8c1dea7406e284de8886dffc
(cherry picked from commit 2645f68985df4955fd8a161224595dad9f4ab488)
2021-06-07 21:25:09 +00:00
pibr
1c20c2f774 dpdk: silence coverity warning on use of uninitialized value
Type: fix

Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
Change-Id: I76923ad5035498aae821db4fd42a127617476fbb
(cherry picked from commit d838e533f1f8f5335ceadb193fa9554f44d04fbf)
2021-06-07 16:02:02 +00:00
Tianyu Li
ce4716f4e2 build: fix build error after make wipe
ninja: error: '/home/vpp/src/vpp-api/vapi/fake.api.json',
needed by 'CMakeFiles/vpp-api/vapi/fake.api.vapi.h',
missing and no known rule to make it

Recent fake.api.json has been moved from test/ to src/,
update make wipe to reflect the movement.

Type: fix

Signed-off-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I1e8ef414a3f8a2fce11767e0778fe21e14d54e6f
(cherry picked from commit 0b652134752890fd987152005ed378a9520d2c68)
2021-06-07 14:56:58 +00:00
Ruslan Babayev
f1bd293ff2 nat: fix broken nat44-ed cli
snat_set_frame_queue_nelts has been replaced with
nat44_ed_set_frame_queue_nelts.

Type: fix
Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
Change-Id: I8d970be71376fdbb2bfd383d4d5824a8def93bb3
2021-06-07 14:10:26 +00:00
Dave Wallace
b3e5909e80 build: fix centos-8 cmake missing package dependency
Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I199fea4607cf38a127ed31b2ddf1dd993a2462ba
(cherry picked from commit e20d3c8c007bb7437ef7d1db47cfefb4235c0fe6)
2021-06-05 21:37:21 +00:00
Neale Ranns
e027d88521 tests: Fix 'test-wipe'
Type: fix

Error:
vagrant@ ~/vpp (make-test-wipe) $ make test-wipe
make[1]: Entering directory '/home/vagrant/vpp/test'
make[2]: Entering directory '/home/vagrant/vpp/test'
make[2]: *** ext: No such file or directory.  Stop.
make[2]: Leaving directory '/home/vagrant/vpp/test'
make[1]: *** [Makefile:239: wipe] Error 2
make[1]: Leaving directory '/home/vagrant/vpp/test'
make: *** [Makefile:440: test-wipe] Error 2

Signed-off-by: Neale Ranns <neale@graphiant.com>
Change-Id: I3615a962882d5d56c394aa628e9942fed07cde84
(cherry picked from commit 46cb4c40941e06d726c116975c321603766d24bd)
2021-06-04 13:33:06 +00:00
Juraj Linkeš
4b0882c9a9 dpdk: disable i40evf in favor of iavf patch
Fix an issue where multiple VPP instances with DPDK starting at the
same time would not initialize VFs properly. This is done by using the
iavf PMD (where the issue can't be reproduced) instead of the i40evf
PMD.

Type: fix
Ticket: VPP-1943
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Change-Id: I444bd24722f81faec836478851e7cc3c72143227
2021-06-03 19:11:59 +00:00
Florin Coras
76189089b5 svm: release mem order for fifo chunk list CAS
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ifad679f46abd6e9c18a3eaf7e55800a09f3791ab
(cherry picked from commit 324d161963025a595a79a10cf953b23250f825a1)
2021-06-03 19:11:27 +00:00
Florin Coras
5b6d2c1ae2 session: avoid ct connects loop
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I99af136ecab9be1f9e00de6d197b8f1c74ab4b20
(cherry picked from commit 821b5002bf5cd18e1ec7750ff1b6fb379b241869)
2021-06-03 19:11:06 +00:00
Florin Coras
d5f89e04ae session: lcl transport info on accept
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia46b0b8afed30f84b244c06f0457303f9e8832cd
(cherry picked from commit 67c90a32b7ad0c5a38c483ce849cc7a231e7ba54)
2021-06-03 19:10:35 +00:00
Florin Coras
afb0194b5a srtp: cleanup build and default to disabled
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I62fb56257445a05105e556d1ea6cc6280b5eeccc
(cherry picked from commit 427feb6fdd8aee373405dbd3a59f69440107b046)
2021-06-03 19:08:42 +00:00
Arthur de Kerhor
27777bd890 misc: bug fixes and improvements for stats Fuse fs
Added syslogs
Added support for symlinks
Relocated make commands in a local Makefile
Dumping stats on index instead of paths
Updated README
Added go.mod and go.sum with relevant dependencies for the module

Type: fix
Change-Id: I2c91317939b2f4d765771ab7038372ae27d3109d
Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>
(cherry picked from commit 9cfbd3b7869db3ca5131c6fd0c0f77b787fa4312)
2021-06-03 07:38:21 +00:00
Dave Barach
cd01b3a735 interface: fix vnet_sw_interface_update_unnumbered
Unless a software interface is actually unnumbered, do not set
ip[46]_main.lookup_main.if_address_pool_index_by_sw_if_index [sw_if_index]
to ~0

Fixes this scenario:

loop create
set int state loop0 up
create sub-interface loop0 1
set interface ip addr loop0.1 192.168.1.1/24
delete sub-interface loop0.1
set int ip addr loop0 192.168.1.1/24

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I46141d862fa57d70b93d7bb0c105403708165264
(cherry picked from commit 64d20e76b9108c9158b2b538cd2312d740f48103)
2021-06-01 14:46:57 +00:00
Florin Coras
ce48c87744 tls: fix handling of failed accepts
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I34b53dcaf4f049157b538ea40a39033d43e525a5
(cherry picked from commit b6fe52f3da79d4c4ea8095b9d36988b0825a9891)
2021-06-01 14:45:52 +00:00
Florin Coras
b39fac168b hsa: proxy listener support addition of fifo segments
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I59218f784140ef5ecb8468af6aebfe25fd7703a4
(cherry picked from commit b740fdc8ff7f58637524e999d5fe01b8b010810d)
2021-05-29 16:51:45 +00:00
Dave Wallace
f5d9237c56 svm: fix inadequate atomic load for chunk mgr
- Fixes intermittent LDP cut thru iperf3 test
  failure on AARCH64

Type: fix

Change-Id: Id21a078d642e03d974bacacd1f4d0faa42fb6652
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
(cherry picked from commit 5c520919e838bcb645ddd879641d54c620740989)
2021-05-28 16:08:32 +00:00
Florin Coras
88b2269a45 vppinfra: explicit blocking mode for sock connects
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3a33230de13fef613dc9523cf24a9968d200c2e5
(cherry picked from commit 57e0af924b8b48cf39b1020bf11f10e3c227f22c)
2021-05-26 18:48:32 +00:00
Andrew Yourtchenko
e82d59f381 misc: Initial changes for stable/2106 branch
Change-Id: Ia484268463cc504902402cde2243f0cfdb02d101
Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
v21.06-rc1
2021-05-26 13:05:36 +00:00
Neale Ranns
1372178e0e fib: During the mfib lookup set the unicast FIB index in the packet so that a uRPF check on a for-us packet is done in the correct VRF
Type: fix

Signed-off-by: Neale Ranns <neale@graphiant.com>
Change-Id: Iafa6efea0d96962aa9136dccefc148a961f74476
2021-05-26 10:22:02 +00:00
Ray Kinsella
457271d71c pg: revert exec file fixes
This reverts commit fd4fd0d1853ae7384e7a64c4cad17a3469720b95.

Type: fix
Change-Id: I6ef84f646372270ded486eacee81817067e49106
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
2021-05-26 08:23:09 +00:00
Klement Sekera
2de7e96e6f nat: add thread index assertions
Add extra assertions to debug build.

Type: improvement
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: Ib20130365e8f9dbb556fcbb4321dd184c7eff603
2021-05-26 07:38:01 +00:00