0182eb9d9 Test variant arguments to worklets
de28a4351 Add an entry to VariantUnion to help compiler copy structs
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !3030
Add a regression test for passing a variant as an argument to a worklet.
Variants are tricky objects, and the compiler might make some strange
assumptions during optimization.
One case that popped up in particular was when a variant contained two
objects with the same `sizeof` but the first object had padding. When the
variant contained the second object, the value under the padded part of
the first object was not set.
I've been seeing errors in a nightly build that compiles for CUDA Pascal
using GCC5. The issue is that one of the `ArrayHandleMultiplexer` tests
is failing to copy an implicit array correctly. I think the problem is
that in this test the first and second type of the `Variant` are the same
size, but the first type has some padding in the middle whereas the
second type does not. When using this second type, the values in the
same position of the padding of the first type don't seem to be
initialized properly in the kernel invocation.
My nonexhaustive experiment shows that things work OK as long as the
first type is large enough and has no fillers. Enforce this by adding an
internal entry to the union that is completely full.
c8702f132 Punch the dashboard in the neck.
d25710823 cleanup and better check for valid seeds.
fe35202de Merge branch 'master' of https://gitlab.kitware.com/vtk/vtk-m into sl_block_duplication
eb3c91494 Fixes to block duplication code.
d1e68ace9 Kick the dashboards....
778e2783a Kick the dashboards.....
186f06a82 Remove debug statements.
812b8f393 Fix serial compile error.
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3033
This new filtered designed for bi-variate analysis builds the continuous scatterplot of a 3D tetrahedralized mesh for two given scalar point fields. The continuous scatterplot is an extension of the discrete scatterplot for continuous bi-variate analysis.
While adding checks to the size of implicit arrays, it was discovered
that some of the Mask and ScatterPermutation arrays were constructed
with the wrong sizes during dispatch. In particular, these arrays were
supposed to be sized on the output, but were instead sized on the input.
They went unnoticed because they were using implicit arrays that worked
even if the array access went out of bounds.
The clip filter used to copy the input points and point fields as is,
regardless of if they were actually part of the output. With this change,
we track which input points are actually part of the output and copy
only those values.
Address: #112
e598fd635 Refer to field by name instead of index to fix crash in contour tree exmaple.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !3034
684652db9 Fix compile error in serial mode.
a5ad12a4f Merge branch 'master' of https://gitlab.kitware.com/vtk/vtk-m into sync_streamlines
dc547de80 Remove debugging information.
42f183e81 More code cleanup................
1dea2b2ee Code cleanup........
322012a59 Only log message in debug.
9d3c24ab9 Undo an inadvertent change.
ad49b1e25 propagate the sync/async comm flag down.
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Abhishek Yenpure <abhi.yenpure@kitware.com>
Merge-request: !2936
