Compare commits

..
Author SHA1 Message Date
Andreas Dangel 3c2721587d [maven-release-plugin] prepare release pmd-build/0.9 2015-03-23 20:25:49 +01:00
Andreas Dangel 34f1eaca11 Upgrade maven-pmd-plugin to 3.4 2015-03-23 20:19:11 +01:00
Andreas Dangel 2fdb51fcb6 dogfood, whitespaces 2015-03-23 20:16:03 +01:00
Andreas Dangel b7bf3fbb8c dogfood, whitespaces 2015-03-22 00:15:08 +01:00
Andreas Dangel 10ae0fb999 dogfood, whitespaces 2015-03-21 23:30:55 +01:00
Andreas Dangel 86d2387784 update gitignore 2015-03-21 23:11:45 +01:00
Andreas Dangel f300ce1ad6 maven-plugin-pmd-build: use target/generated-site directory as default 2015-03-21 22:50:22 +01:00
Andreas Dangel 9e7839b1f3 doc: Add github ribbon, add topBarIcon 2015-03-21 19:42:17 +01:00
Andreas Dangel 8b4d71a284 doc: Fix syntax error 2015-03-21 19:11:22 +01:00
Andreas Dangel 0c69ed6f8b PMD exit with status 4 if violations have been found. 2015-03-21 19:03:03 +01:00
Andreas Dangel 741a9470bd Update changelog 2015-03-21 18:17:02 +01:00
Andreas Dangel 07e641f20a Merge branch 'tiobe/fix-error-handling' of https://github.com/tiobe/pmd into tiobe-tiobe/fix-error-handling 2015-03-21 18:16:16 +01:00
Andreas Dangel f0dfca261d doc: Update best practices after basic doesn't contain empty/unnecessary
rules anymore (deprecation)
2015-03-21 18:09:04 +01:00
Andreas Dangel ea9789dac5 Use wildcard classpath instead of java.ext.dirs 2015-03-21 18:02:40 +01:00
Andreas Dangel fb1e1ba1aa doc: Improve PMD command line documentation 2015-03-21 17:55:50 +01:00
Andreas Dangel 9312e23a8f doc: add CPD GUI section 2015-03-21 16:38:25 +01:00
Andreas Dangel 415eed32c5 doc: Improve helptext of CPD command line 2015-03-21 16:38:21 +01:00
Andreas Dangel 3ad6663dfb doc: Improve CPD documentation 2015-03-21 16:38:17 +01:00
Andreas Dangel 28dfbeabf8 #1321 CPD format XML fails with NullPointer 2015-03-15 19:39:09 +01:00
Andreas Dangel 65398d9eed #1319 PMD stops with NoClassDefFoundError (typeresolution) 2015-03-15 18:49:45 +01:00
Andreas Dangel a153b974cc #1320 Enhance SimplifyBooleanReturns checks 2015-03-15 18:49:41 +01:00
Andreas Dangel dd6affeb6e Use new pmd-build plugin, adjust some rule documentation for markdown changes 2015-03-15 14:59:55 +01:00
Andreas Dangel d17786000f maven-plugin-pmd-build: generate markdown files for the rules
* simplify the configuration of the plugin
* use better default values
2015-03-15 14:58:57 +01:00
Andreas Dangel 9367879e69 #1277 Delete BooleanInversion as it makes no sense
Deprecate the rule for now - to be completely deleted later
2015-03-15 10:51:57 +01:00
Andreas Dangel d484469fdf doc: fix markdown sites 2015-03-14 22:26:36 +01:00
Andreas Dangel c5622d9c21 doc: Convert xdoc to markdown - usage pages 2015-03-14 22:26:35 +01:00
Andreas Dangel b182001920 doc: Convert xdoc to markdown - customizing pages 2015-03-14 22:26:30 +01:00
Andreas Dangel 0ac64e9d88 doc: Convert xdoc to markdown - index and all overview pages 2015-03-14 16:22:51 +01:00
Andreas Dangel 70070295b7 maven-plugin-pmd-build: Output also deprecated rules that are no references. 2015-03-14 14:40:00 +01:00
Andreas Dangel 03e35f5596 maven-plugin-pmd-build: add the deprecated rules to the rules index page 2015-03-14 13:47:19 +01:00
Andreas Dangel 233b948bd4 maven-plugin-pmd-build: Also display deprecated rules 2015-03-14 13:19:11 +01:00
Andreas Dangel 0ba3c0b8ed maven-plugin-pmd-build: output the rule priority 2015-03-14 11:54:11 +01:00
Andreas Dangel 08c89fb4f5 maven-plugin-pmd-build: whitespace for xsl 2015-03-14 11:47:56 +01:00
Andreas Dangel 9860ded4c8 maven-plugin-pmd-build: add project-info-reports version 2015-03-14 11:43:33 +01:00
Andreas Dangel b379d2e264 maven-plugin-pmd-build: pmd dogfood 2015-03-14 11:43:19 +01:00
Andreas Dangel bc44701af0 maven-plugin-pmd-build: whitespace, formatting 2015-03-14 11:30:43 +01:00
Andreas Dangel 22a5f95272 maven-plugin-pmd-build: update plugins, add plugin annotations 2015-03-14 11:26:02 +01:00
Andreas Dangel 6c79f12da1 maven-plugin-pmd-build: update plugins 2015-03-14 11:12:33 +01:00
Andreas Dangel a52d0dcc6f Make sure, a deprecated and renamed rule is not executed twice. 2015-03-09 22:14:37 +01:00
Andreas Dangel dff3bfb359 #1283 Rename UncommentedEmptyMethod to UncommentedEmptyMethodBody 2015-03-09 20:57:35 +01:00
Andreas Dangel 6c480f6dc7 Document deprecated rules in changelog 2015-03-09 19:56:53 +01:00
Andreas Dangel c74b43baf2 #1317 RuntimeException when parsing class with multiple lambdas
Removing Java8MultipleLambdasTest from java8 integration, as it can
be tested with java < 8 in pmd-java
2015-03-07 21:12:04 +01:00
Andreas Dangel 59b14bd009 Cleanup and add license headers 2015-03-07 20:09:47 +01:00
Andreas Dangel c3882ef6f4 Update changelog 2015-03-07 19:19:01 +01:00
Andreas Dangel c30b0be663 Merge branch 'bugfix/improves-jdk8-support' of https://github.com/bric3/pmd into bric3-bugfix/improves-jdk8-support 2015-03-07 19:13:56 +01:00
Andreas Dangel 74708fa69e RuleProperties: Further refactoring - making the delimiters configurable 2015-03-07 19:01:52 +01:00
Jan van Nunen e2cc67c591 Fixed exit status of PMD when error occurs
When an error occured the exit status of PMD was 0. The error occured
because the logic of 'NO_EXIT_AFTER_RUN' was incorrect/inverted. A
'System.exit()' was performed when 'NO_EXIT_AFTER_RUN' was set while it
should be skipped. I copied the fix from the CPDCommandLineInterface
class.

Furthermore I made sure all error messages are printed to System.err
instead of System.out, so they can easily extracted/found when PMD is
invoked by external tools.
2015-03-05 12:22:56 +01:00
Andreas Dangel 99f735cc3b RuleProperties: Whitespaces, reformat 2015-03-02 21:40:14 +01:00
Andreas Dangel 8ca4a57c13 RuleProperties: get rid of AbstractDelimitedProperty
Just using AbstractProperty now, it can do both.
2015-03-02 20:45:53 +01:00
Andreas Dangel df423b373c RuleProperties: Add more tests and fix some multi property issues.
Add missing BooleanMultiProperty.FACTORY
2015-03-02 20:15:04 +01:00
Brice Dutheil 18f393da3c Introduces java 8 integration test module
* Only for testing pmd-java
* Activated only if the jdk is 1.8
2015-03-01 22:11:51 +01:00
Brice Dutheil 28d1764428 Improves pmd jdk8 readiness
* Upgrade asm so that it understands default method and static methods in interfaces jdk8 class files
* see 9b91690f21 for ASM4 support
2015-03-01 22:09:33 +01:00
Brice Dutheil c50d84ff24 Replaces with spaces only (was mixed whitespaces) 2015-03-01 22:04:17 +01:00
Andreas Dangel fcad3925cd #1316 Multi Rule Properties with delimiter not possible 2015-02-28 14:12:53 +01:00
Andreas Dangel acb8b49aa8 #1302 False Positive: UnusedPrivateField when accessed by inner class 2015-02-21 11:53:38 +01:00
Andreas Dangel 33212c7da3 #1302 False Positive: UnusedPrivateField when accessed by inner class 2015-02-21 11:29:44 +01:00
Andreas Dangel bdf9c19a1d #1304 UseCollectionIsEmpty false positive comparing to 1 2015-02-21 11:26:12 +01:00
Shuyang Zhou cd8325dff3 #1303 OverrideBothEqualsAndHashcodeRule does not work on class implements resolvable interfaces 2015-02-21 11:16:13 +01:00
Andreas Dangel 9b8496ab16 #1305 variable declaration inside switch causes ClassCastException 2015-02-20 20:28:39 +01:00
Andreas Dangel 96b425be46 Disable Scala for jdk9 builds for now (see #1314 Enable Scala for JDK9) 2015-02-20 20:05:38 +01:00
Andreas Dangel 21d7ebb809 Fixes for java9 2015-02-20 19:19:16 +01:00
Andreas Dangel abb247a13a Update changelog 2015-02-20 18:51:36 +01:00
Robert Whitebit cd52e39b08 [JUnit] Check assertion message present in assertEquals with delta
A missing assertion message for assertEquals(double, double, double)
is detected in most cases now. If the assertEquals method has two
arguments, an assertion message is missing, if the assertEquals method
has three arguments, the first one has to be a string.

Pmd will only print an error if the first argument type has been
determined (getType() != null) and isn't a String. Therefore
assertEquals(getInt(), getInt(), getInt()) won't be detected as an
error. However, double d = 1.0; assertEquals(d, 1.0, 1.0); will be
detected.

The JUnitAssertionsShouldIncludeMessageRule.check method has been moved
to the inner class AssertionCall and has been expanded by an
isException hook. The assertEquals with three arguments check overrides
the isException method, returns true if the first argument can't be
determined or is a String and if so, no violation will be added. Also
the constructor arguments have been swapped for readability.

https://sourceforge.net/p/pmd/bugs/1313/
2015-02-20 00:36:11 +01:00
Andreas Dangel 1d0d7d995e Update changelog 2015-02-19 20:57:09 +01:00
Andreas Dangel ed6a876549 Merge branch 'missingAsserts' of https://github.com/robertwhitebit/pmd into robertwhitebit-missingAsserts 2015-02-19 20:56:29 +01:00
Andreas Dangel 5c9eae44c1 Update changelog 2015-02-19 20:52:19 +01:00
Andreas Dangel 6b7846a329 Merge branch 'unused-private-field-inner' of https://github.com/rsalvador/pmd into rsalvador-unused-private-field-inner 2015-02-19 20:51:40 +01:00
Andreas Dangel 299d167e1b Update changelog 2015-02-19 20:47:21 +01:00
Andreas Dangel 563fc4ed5a Merge branch 'no-class-def-found-error' of https://github.com/rsalvador/pmd into rsalvador-no-class-def-found-error 2015-02-19 20:40:15 +01:00
Andreas Dangel 0f0984af3c #1312 Rule reference must not override rule name of referenced rule
The RuleSetWriter used the wrong name, too
2015-02-19 18:29:03 +01:00
Robert Whitebit 41e921531a Add missing assertions in JUnitAssertionsShouldIncludeMessage test
Missing assertions were assertArrayEquals, assertNotSame, assertThat and
fail.
2015-02-18 23:02:43 +01:00
Andreas Dangel d5d6118f12 #1312 Rule reference must not override rule name of referenced rule
otherwise the rule reference is broken
2015-02-18 20:07:44 +01:00
Roman 070a7c992f Fix some false positives in UnusedPrivateField 2015-02-15 11:43:49 -08:00
Roman 1f6421ec88 Handle NoClassDefFoundError along ClassNotFoundException 2015-02-15 11:34:32 -08:00
Andreas Dangel c44d94416d verify #1310 PMD cannot parse int.class with real example 2015-02-10 22:32:09 +01:00
Andreas Dangel 5fbbe0ac94 verify #1310 PMD cannot parse int.class 2015-02-09 21:36:49 +01:00
Andreas Dangel 12d6d71242 Update changelog 2015-01-28 21:34:49 +01:00
Andreas Dangel 5572f9896c Merge branch 'master' into tiobe-tiobe/csv_linenumber_per_file 2015-01-28 20:33:51 +01:00
Andreas Dangel 4e23642f74 Rewrote java-design/FieldDeclarationsShouldBeAtStartOfClass as a java rule
Fixes #1308 PMD runs endlessly on some generated files
2015-01-28 20:22:24 +01:00
Andreas Dangel a51a58476c Another small performance improvement for rule FieldDeclarationsShouldBeAtStartOfClass
It is still the slowest rule from #1308 PMD runs endlessly on some generated files
2015-01-26 20:48:49 +01:00
Andreas Dangel 1159350e91 Merge branch 'tiobe/csv_linenumber_per_file' of https://github.com/tiobe/pmd into tiobe-tiobe/csv_linenumber_per_file 2015-01-24 18:34:21 +01:00
Andreas Dangel 172c20efa6 Small performance improvements for rule FieldDeclarationsShouldBeAtStartOfClass
It is the slowest rule from #1308 PMD runs endlessly on some generated files
2015-01-24 15:57:04 +01:00
Andreas Dangel 4be14adebb #1308 PMD runs endlessly on some generated files 2015-01-24 10:03:46 +01:00
Andreas Dangel 9522ab3cd4 #1306 False positive on duplicate when using static imports 2015-01-22 19:30:20 +01:00
Andreas Dangel 57beb7ed13 #914 False +ve from UnusedImports with wildcard static imports 2015-01-21 21:56:43 +01:00
Jan van Nunen b1769846e5 Created extra CSV output format 'csv_with_linecount_per_file' which outputs the correct line count per file.
Some of the tokenizers ignore comments and therefore the line count of a
duplication can differ per file. Take for example the following files:

FileA.java:

1: public class FileA {
2:  pulbic String Foo() {
3:    return "Foo";
4:   }
5:  }

FileB.java:

1: public class FileB {
2:   pulbic String Foo() {
3:     // This is a comment
4:     return "Foo";
5:   }
6: }

When comments are ignored and not tokenized, the duplication consist of
the following tokens:

'{', 'public', 'String', 'Foo', '(', ')', '{', 'return', 'Foo', ';',
'}', '}'

For 'FileA.java' the duplication is 5 lines long, it starts at line 1
and ends at line 5. For 'FileB.java' the duplication is 6 lines long, it
starts at line 1 and ends at line 6.

Note that this is just 1 example, because for most tokenizers comments
and white spaces are not significant. For example the following file
contains the same duplication all on 1 line:

FileC.java

1: public class FileC { public String Foo() { return "Foo"; } }

For us the correct line count per file is important, because we
highlight the duplications in an annotated source view and show the
percentage of duplicated code the file contains. The current output
formats only contain 1 line count per duplication and file set. For the
above example CPD would output the following:

Found a 4 line (12 tokens) duplication in the following files:
Starting at line 1 of FileA.java
Starting at line 1 of FileB.java

For FileB.java this is not correct and would lead to incorrect
percentage of duplicated code. (66% (4 of 6 lines) instead of the
correct 83% (5 of 6 lines)).

To fix the problem, I created an extra output format
'csv_with_linecount_per_file' which outputs the correct line count per
file. The format contains the following:

tokens,occurrences
<nr of tokens>,<nr of occurrences>(,<begin line>,<line count>,<file
name>)+

For the above example the output would be

tokens,occurrences
12,2,1,4,FileA.java,1,5,FileB.java
2015-01-21 13:55:49 +01:00
Andreas Dangel df81f1fbb5 Update changelog 2015-01-19 21:39:00 +01:00
Andreas Dangel e122ab2450 Fix unit tests after xerces is removed 2015-01-19 21:26:20 +01:00
Andreas Dangel 8d487384a3 Remove LineNumberAwareSaxHandler - as this would have needed xerces 2015-01-19 19:22:03 +01:00
Andreas Dangel a2a8d6c227 Remove xerces dependencies 2015-01-19 19:22:03 +01:00
Andreas Dangel 6ca24d1f8a Implement DOMLineNumbers to determine the line numbers after the parsing 2015-01-19 19:22:03 +01:00
Andreas Dangel 0da50b9e89 Fix XMLParser test to expect more accurate line numbers/columns 2015-01-19 19:22:03 +01:00
Andreas Dangel 5ae01d2d3e Up version to 5.3.0-SNAPSHOT 2015-01-18 12:19:52 +01:00
Andreas Dangel 3e7391ab64 Update changelog and credits 2015-01-18 12:15:01 +01:00
Andreas Dangel be6a422860 Merge branch 'tiobe/pmd-core-cpdcmdlineoptfix' of https://github.com/tiobe/pmd into tiobe-tiobe/pmd-core-cpdcmdlineoptfix 2015-01-18 12:13:09 +01:00
Andreas Dangel 2e8ff0487e Update changelog 2015-01-18 12:08:09 +01:00
Andreas Dangel 381a697a99 Merge branch 'tiobe/pmd-cpp-fixlexicalerrors' of https://github.com/tiobe/pmd into tiobe-tiobe/pmd-cpp-fixlexicalerrors 2015-01-18 12:06:29 +01:00
Andreas Dangel 6d89f5b30d Update changelog 2015-01-18 11:59:58 +01:00
Andreas Dangel 17e4d2fb9e Merge branch 'tiobe/pmd-cs-linenumberfix' of https://github.com/tiobe/pmd into tiobe-tiobe/pmd-cs-linenumberfix 2015-01-18 11:52:08 +01:00
Andreas Dangel d69624e823 Update changelog for scala pull request; update license infos 2015-01-18 11:45:26 +01:00
Andreas Dangel a4fbcef536 Merge branch 'tiobe/pmd-scala' of https://github.com/tiobe/pmd into tiobe-tiobe/pmd-scala 2015-01-18 11:22:03 +01:00
Andreas Dangel f5b36f3984 Update changelog for Objective-C pull request 2015-01-18 11:17:04 +01:00
Andreas Dangel cf442b463e Merge branch 'tiobe/pmd-objectivec' of https://github.com/tiobe/pmd into tiobe-tiobe/pmd-objectivec 2015-01-18 11:14:40 +01:00
Andreas Dangel e1886ac48e Update changelog for Matlab pull request 2015-01-18 11:09:41 +01:00
Andreas Dangel 68e4b3e4f1 Merge branch 'tiobe/pmd-matlab' of https://github.com/tiobe/pmd into tiobe-tiobe/pmd-matlab 2015-01-18 11:04:23 +01:00
Andreas Dangel 3ef82a6c3a Update changelog for python pull request 2015-01-18 11:00:10 +01:00
Andreas Dangel d5593f516f Merge branch 'tiobe/pmd-python' of https://github.com/tiobe/pmd into tiobe-tiobe/pmd-python 2015-01-18 10:47:24 +01:00
Andreas Dangel 6b69174e24 #1296 PMD UnusedPrivateMethod invalid detection of 'private void method(int,boolean,Integer...)' 2015-01-17 22:42:58 +01:00
Andreas Dangel 9d96d974de #1299 MethodReturnsInternalArray false positive 2015-01-17 11:32:55 +01:00
Andreas Dangel 24a435a42e RedundantFieldInitializer - consider binary literals and underscores (java7) 2015-01-17 11:08:46 +01:00
Andreas Dangel 89572efe0d #1298 Member variable int type with value 0xff000000 causes processing error 2015-01-16 21:34:05 +01:00
Jan van Nunen 5776c0e9c5 Made exceptions of the Scala tokenizer non-fatal when CPD is executed with the '--skipLexicalErrors' command line option. 2015-01-15 16:01:28 +01:00
Jan van Nunen 110184e542 Made exceptions of the Scala tokenizer non-fatal when CPD is executed with the '--skipLexicalErrors' command line option. 2015-01-15 15:32:19 +01:00
Jan van Nunen a376da0d9e Fixed '--files' command line option of CPD, so it also works for files and not only for directories.
The '--files' command line option of CPD lets you specify which
directories and files should be scanned for duplicated code.
Unfortunately it didn't work when you specified files instead of
directories, for example: '--files foo.c bar.c'. In this example CPD
executed successful, but the files 'foo.c' and 'bar.c' are completely
ignored.
2015-01-14 17:34:17 +01:00
Jan van Nunen 6c0b45519c Added pmd-python to default PMD distribution. 2015-01-13 14:25:42 +01:00
Jan van Nunen 5bbc99a6f8 Added pmd-objectivec to default PMD distribution. 2015-01-13 14:23:16 +01:00
Jan van Nunen 06f769ddd0 Added pmd-scala to default PMD distribution. 2015-01-13 14:19:08 +01:00
Jan van Nunen f58ee38cca Fixed build error by adding the configuration base-directory to the POM.xml 2015-01-13 14:11:06 +01:00
Jan van Nunen 23f03a78a9 Added pmd-matlab to default PMD distribution. 2015-01-13 14:07:43 +01:00
Jan van Nunen c92dc9706c Relaxed C++ tokenizer so a '\'(backslash) can be use to escape any character inside a string or character.
The following 2 code snippets could not be tokenized:

1:  if (*pbuf == '\0x05'), the problem is the '\0' in the character
literal '\0x05'.
2:  szPath = m_sdcacheDir + _T("\    oMedia");, the problem is the '\ '
in the string literal "\    oMedia".

I relaxed the lexical grammar so a '\' (backslash) can escape any
character inside a string or character literal. We can relax the grammar
because CPD only needs the tokens, so it is no problem to accept
'invalid' string / character literals. (according to the ANSI C
standard).  Failing too fast because the tokenizer is too strict is
annoying because then we can't check the files for duplicated code.

Both snippets were taken from existing projects and be successfully
compiled, so for some C / C++ compilers it is valid code.
2015-01-13 11:36:54 +01:00
Jan van Nunen d830974842 Fixed lexical error when a C++ file contains an empty character literal L''.
This commit fixes a lexical error when a C++ file contains an empty
character literal L''. The following code could not be tokenized:

std::wstring wsMessage( sMessage.length(), L'');

It triggers the following error:

net.sourceforge.pmd.lang.ast.TokenMgrError: Lexical error in file
'foo.cpp' at line 1, column 46.  Encountered: "\'" (39), after : "\'"
2015-01-13 11:36:54 +01:00
Jan van Nunen ceef6cd236 Fixed lexical eror when a preprocessor directive is followed by a single line comment that starts with "//*".
This commit fixes a lexical eror when a preprocessor directive is
followed by a single line comment that starts with "//*".

The following code could not be tokenized:

#define LSTFVLES_CPP  //*

It triggers the following error:

net.sourceforge.pmd.lang.ast.TokenMgrError: Lexical error in file
'foo.cpp' at line 2, column 0.  Encountered: <EOF> after : ""
2015-01-13 11:36:53 +01:00
Jan van Nunen 5c2df4c877 Fixed lexical error when a C++ file contains ASM with the '@' character.
This commit fixes a lexical error when a C++ file contains ASM with the
'@' character. The following code cannot be tokenized and triggers a
lexical error:

asm void eSPI_boot()
{
// setup stack pointer
lis r1, _stack_addr@h
ori r1, r1, _stack_addr@l
}

The error that occurs:

net.sourceforge.pmd.lang.ast.TokenMgrError: Lexical error in file
CODE_LOADED_FROM_STRING at line 4, column 22.  Encountered: "@" (64),
after : ""
2015-01-13 11:36:53 +01:00
Jan van Nunen 6d0be8b126 Fixed incorrect line numbers after mutiline comments and verbatim strings. 2015-01-12 10:53:34 +01:00
Jan van Nunen 952ace3128 Fixed build warning of Scala compiler. 2015-01-12 09:18:20 +01:00
Jan van Nunen bffea4bb3b Added support for Scala to CPD.
The Scala tokenizer was extracted from the Sonar Scala plugin.
(https://github.com/SonarCommunity/sonar-scala) I copied the code
because the Sonar Scala plugin has a lot of unwanted dependencies. I
tried to keep the changes to the Scala Sonar plugin as minimal as
possible.

To tokenize the source files the official Scala compiler is used.
2015-01-09 15:20:25 +01:00
Jan van Nunen 8dd3755db1 Added support for Objective-C to CPD. 2015-01-08 16:04:15 +01:00
Jan van Nunen 43750e3799 Added support for Python to CPD. 2015-01-07 12:07:24 +01:00
Jan van Nunen 16fabee7c3 Added support for Matlab to CPD. 2015-01-07 11:56:47 +01:00
Jan van Nunen 779ea00647 Created branch to add Matlab support 2015-01-07 11:00:49 +01:00
Andreas Dangel c1bc045c65 Update release process - use compression when uploading the site 2014-12-21 16:55:04 +01:00
Andreas Dangel 111fc31cd7 Update changelog for next version 2014-12-21 11:54:14 +01:00
Andreas Dangel 0e6a5db426 [maven-release-plugin] prepare for next development iteration 2014-12-21 11:46:02 +01:00
Andreas Dangel 6c316e9375 [maven-release-plugin] prepare release pmd_releases/5.2.3 2014-12-21 11:46:02 +01:00
Andreas Dangel 8831b710f1 Prepare pmd release 5.2.3 2014-12-21 11:39:41 +01:00
Andreas Dangel 990ed276f3 Update release process - don't use site-deploy anymore. 2014-12-21 11:26:41 +01:00
Andreas Dangel 0fce9a497b #1289 CommentRequired not ignored if javadoc {@inheritDoc} anon inner classes 2014-12-18 19:20:16 +01:00
Andreas Dangel 763b38e8de verify #1296 PMD UnusedPrivateMethod invalid detection of 'private void method(int,boolean,Integer...)' 2014-12-18 18:52:28 +01:00
Andreas Dangel 5530d7eb94 #1288 MethodNamingConventions for native should be deactivated 2014-12-17 21:52:42 +01:00
Andreas Dangel e48f18cce2 #1293 Disable VariableNamingConventions for native methods 2014-12-17 21:42:49 +01:00
Andreas Dangel 071040929e verify #1293 VariableNamingConventions False positive for native methods 2014-12-15 21:10:21 +01:00
Andreas Dangel 5daa4a9382 #1294 False positive UnusedPrivateMethod with public inner enum from another class 2014-12-14 18:01:07 +01:00
Andreas Dangel db51c7d217 Update changelog 2014-12-14 11:29:58 +01:00
alberto 3a2e1474d3 spaces 2014-12-12 20:50:20 +01:00
alberto 50df3e0e11 Allow byte[] data and byte data[] as no-varargs last argument 2014-12-12 20:39:46 +01:00
Andreas Dangel aea6c74a8f java/design/UseVargs - update changelog, extend test case 2014-12-12 19:26:36 +01:00
Andreas Dangel bdf454a967 Merge branch 'master' of https://github.com/albfernandez/pmd 2014-12-12 19:05:44 +01:00
Andreas Dangel 26b4f850b1 #1252 net.sourceforge.pmd.lang.ast.TokenMgrError: Lexical error in file xxx.cpp 2014-12-12 18:58:51 +01:00
Andreas Dangel 6b3b9d0ccc #1252 implement BOM detection differently for cpp 2014-12-12 17:45:38 +01:00
Alberto Fernández a07d8bdfce Update design.xml 2014-12-11 10:50:23 +01:00
Andreas Dangel 8fb2f0a09f Add a timeout for retrieving a ruleset from a URL
By default, timeout is 5 seconds
2014-12-10 22:00:05 +01:00
Andreas Dangel dd8c5f2d1a Implement possibility to specify a Single Rule from a Ruleset via http 2014-12-10 21:54:17 +01:00
alberto c5f28f4879 Allow byte[] as no-varargs final argument 2014-12-09 22:48:21 +01:00
Andreas Dangel a9e6d921dd Update changelog 2014-12-08 20:05:21 +01:00
Andreas Dangel b2f7a0b94c Merge branch 'master' of https://github.com/msiemczyk/pmd 2014-12-07 21:09:15 +01:00
msiemczyk 8d0f8080f4 #1290 RuleSetReferenceId does not process HTTP(S) correctly.
Fixed the bug and added one unit test.
2014-12-05 17:56:04 -05:00
Andreas Dangel 17e22c4cb3 Separate out the inner classes of XmlParser 2014-12-04 21:04:25 +01:00
Andreas Dangel 084c92efad Update changelog for next version 2014-12-03 21:24:39 +01:00
Andreas Dangel ac0181f017 [maven-release-plugin] prepare for next development iteration 2014-12-03 19:22:19 +01:00
Andreas Dangel c577dc8aac [maven-release-plugin] prepare release pmd_releases/5.2.2 2014-12-03 19:22:19 +01:00
Andreas Dangel 6ff80fbad1 Prepare pmd release 5.2.2 2014-12-03 19:11:52 +01:00
Andreas Dangel ce1e6b418c Fix dogfood ruleset 2014-11-30 21:23:04 +01:00
Andreas Dangel 0cab1ac78a Upgrade maven-pmd-plugin to 3.3 2014-11-30 20:29:32 +01:00
Andreas Dangel 944771c626 Fix javadoc for suppress marker 2014-11-30 20:24:22 +01:00
Andreas Dangel c8887de5ff #1090 cpp parser exception with inline asm 2014-11-28 21:32:32 +01:00
Andreas Dangel 7b58836ebb #1128 CompareObjectsWithEquals False Positive comparing boolean (primitive) values 2014-11-27 20:19:17 +01:00
Andreas Dangel 4d16e3a582 #1286 UnusedPrivateMethod returns false positives for varags and enums 2014-11-26 19:21:44 +01:00
Andreas Dangel 3fd0d7fe01 verify #1287 UnusedPrivateMethod returns false positives for Superclass 2014-11-26 19:12:33 +01:00
Andreas Dangel a9352d4d4c Update --encoding paramter description for CPD.
Thanks to Michael Osipov.
2014-11-25 21:49:58 +01:00
Andreas Dangel 3ce7442c2d Fix unit test 2014-11-24 22:18:13 +01:00
Andreas Dangel 20df4ca717 Don't rely on default encoding for unit tests 2014-11-24 21:06:16 +01:00
Andreas Dangel d0980bd30d Add back the old getRendererFromString method for compatibility 2014-11-24 20:30:17 +01:00
Andreas Dangel afc13b29a2 #1285 Prevent to modify the System environment 2014-11-24 20:18:44 +01:00
Andreas Dangel 8ab9f3ed5d #1280 False Positive in UnusedImports when import used in javadoc 2014-11-18 22:27:07 +01:00
Andreas Dangel 7d262036c6 Exclude LawOfDemeter rule from dogfood ruleset 2014-11-17 21:56:01 +01:00
Andreas Dangel e86341bf8e Checkstyle fixes 2014-11-17 21:55:57 +01:00
Andreas Dangel fbe6742666 Set beginColumn for the test nodes, so that no RuntimeException is thrown. 2014-11-16 12:00:29 +01:00
Andreas Dangel 5f35ded04b Fix PMD dogfood issues in pmd-java 2014-11-16 11:38:42 +01:00
Andreas Dangel 4345f04fb0 Fix PMD dogfood issues in pmd-plsql and pmd-xml 2014-11-16 11:11:56 +01:00
Andreas Dangel 3a4caa5c7c Fix PMD dogfood issues in pmd-cs, pmd-jsp, pmd-javascript, pmd-test 2014-11-16 00:15:47 +01:00
Andreas Dangel f7f89f2921 Fix PMD dogfood issues in pmd-core 2014-11-15 23:57:03 +01:00
Andreas Dangel 6b0ddaeb51 #1254 CPD run that worked in 5.1.2 fails in 5.1.3 with OOM
Removed default heapsize of 512m
reenabled multiple line strings in javascript
2014-11-15 21:44:37 +01:00
Andreas Dangel f5db63b374 Exclude generated sources from checkstyle 2014-11-15 19:53:34 +01:00
Andreas Dangel a2e6088faa Fix duplicated code in DBMSMetadata 2014-11-15 19:09:51 +01:00
Andreas Dangel e844ca290c Add cpd to the build 2014-11-15 19:08:39 +01:00
Andreas Dangel 0bca478e31 #1282 False Positive with implicit String.valuesOf() (Java) 2014-11-15 17:02:50 +01:00
Andreas Dangel 55a912e731 #1281 UnusedPrivateMethod incorrectly flagged for methods nested private classes 2014-11-15 16:51:51 +01:00
Andreas Dangel 70723b16bc verify #1280 False Positive in UnusedImports when import used in javadoc 2014-11-15 15:19:12 +01:00
Andreas Dangel a8d7b594ab #1276 False positive in UnusedPrivateMethod with inner enum 2014-11-15 12:55:15 +01:00
Andreas Dangel a5bc2a079f #1276, #1278, #1279, #1280 False positive in UnusedPrivateMethod
Make the auxclasspath option optional. Falls back to the old behavior,
which prevents many false positives.
But it introduces the false negative case #1226, if no auxclasspath is set.
2014-11-15 12:21:18 +01:00
Andreas Dangel 60fe895abf verify #1280 False Positive in UnusedImports when import used in javadoc 2014-11-13 20:10:14 +01:00
Andreas Dangel 4da773b7fc Add ruleset factory tests for all languages 2014-11-09 11:20:54 +01:00
Andreas Dangel 0daca93634 Fix links on index.html site 2014-11-05 21:18:34 +01:00
Andreas Dangel 461df4b86c Prepare changelog for next version 2014-11-03 20:45:16 +01:00
Andreas Dangel a97e9fc532 [maven-release-plugin] prepare for next development iteration 2014-11-03 19:59:01 +01:00
Andreas Dangel 22d22382f6 [maven-release-plugin] prepare release pmd_releases/5.2.1 2014-11-03 19:59:00 +01:00
Andreas Dangel 588330b4b9 pmd: Prepare pmd release 5.2.1 2014-11-03 19:45:50 +01:00
Andreas Dangel 61b11beda7 Another jdk9 fix for Swing's JTree TreeNode 2014-11-02 12:18:45 +01:00
Andreas Dangel 0450f9a9d7 #1258 Java 8 Lambda parse error on direct field access 2014-11-02 10:47:51 +01:00
Andreas Dangel 6b80078c03 #1253 Document default behaviour when CPD command line arguments "encoding" and "ignoreAnnotations" are not specified 2014-11-02 10:24:44 +01:00
Andreas Dangel 58bd3c0514 #1255 UseUtilityClass false positive with Exceptions 2014-11-02 10:13:12 +01:00
Andreas Dangel 1454d8d9c8 #1256 PositionLiteralsFirstInComparisons false positive with Characters 2014-11-02 09:55:04 +01:00
Andreas Dangel fdac23abfe #1259 CloseResource rule ignores conditionnals within finally blocks 2014-10-24 22:00:46 +02:00
Andreas Dangel 5fec443bad #1261 False positive "Avoid unused private methods" with Generics, another case 2014-10-24 20:18:19 +02:00
Andreas Dangel 0e68c00f41 #1275 False positive: UnusedModifier rule for static inner class in enum 2014-10-23 21:36:59 +02:00
Andreas Dangel 76af873708 #1274 ant integration broken with pmd-5.2.0
Separate PMDTask and PMDTaskImpl and set the context classloader
when executing PMD
For CPD, the validation of the language is deferred, until
the context class loader has been switched
2014-10-23 20:00:57 +02:00
Andreas Dangel d9ff018846 Checkstyle, whitespace, formatting 2014-10-21 22:38:19 +02:00
Andreas Dangel 67b1ad9c98 #1261 False positive "Avoid unused private methods" with Generics 2014-10-20 19:17:54 +02:00
Andreas Dangel 238f54ad70 Update rhino dependency to 1.7R4 2014-10-18 21:52:08 +02:00
Andreas Dangel d76454ec81 Update maven plugins 2014-10-18 21:38:57 +02:00
Andreas Dangel 71476b2b5a Fix website base url for sf-release 2014-10-18 21:28:36 +02:00
Andreas Dangel ef007904d2 Update maven-release-plugin 2014-10-18 21:28:26 +02:00
Andreas Dangel 2e7ddc9312 Update dependencies. The new dependencies don't seem to use any
internal jdk api anymore. At least, "jdeps -jdkinternals" doesn't flag
anything.
2014-10-18 21:22:21 +02:00
Andreas Dangel f213e7c38e Add project reports for top level site 2014-10-18 21:02:39 +02:00
Andreas Dangel 30c1a3f831 Fix duplicated maven-clover2-plugin configuration 2014-10-18 21:01:02 +02:00
Andreas Dangel 53048546ba Checkstyle/whitespace fixes 2014-10-18 13:31:14 +02:00
Andreas Dangel cc24717980 #1262 False positive for MissingBreakInSwitch 2014-10-18 13:15:47 +02:00
Andreas Dangel 8f866a8906 #1272 varargs in methods are causing IndexOutOfBoundException when trying to process files 2014-10-18 13:02:41 +02:00
Andreas Dangel 5f9bd17ee6 #1252 net.sourceforge.pmd.lang.ast.TokenMgrError: Lexical error in file xxx.cpp 2014-10-18 12:33:40 +02:00
Andreas Dangel 66ea6b0f9b #550 False +: MissingBreakInSwitch 2014-10-18 11:49:17 +02:00
Andreas Dangel 85afbcfe7c #1263 PMD reports CheckResultSet violation in completely unrelated source files. 2014-10-18 11:44:23 +02:00
Andreas Dangel 0b6f6322e6 #1273 CheckResultSet false positive in try-with-resources nested in if 2014-10-18 11:36:56 +02:00
Andreas Dangel 4660855609 delete Java grammer from pmd-core - it's now in pmd-java 2014-10-18 10:56:53 +02:00
Andreas Dangel 0351d02b20 Update changelog for next version 2014-10-17 22:37:05 +02:00
Andreas Dangel 6e9d825678 Update release process 2014-10-17 22:35:09 +02:00
Andreas Dangel 4a7be51c70 [maven-release-plugin] prepare for next development iteration 2014-10-17 20:15:46 +02:00
Andreas Dangel 118d1c5d30 [maven-release-plugin] prepare release pmd_releases/5.2.0 2014-10-17 20:15:45 +02:00
Andreas Dangel cdcbc8c7aa Enable autoVersionSubmodules for releasing 2014-10-17 20:08:42 +02:00
Andreas Dangel 7ee2faa359 Prepare pmd release 5.2.0 2014-10-17 20:01:40 +02:00
Andreas Dangel f3c238527b Fix link to changelog on index.html 2014-10-13 20:36:39 +02:00
Andreas Dangel b654d3c9cc Merge branch 'modularization' 2014-10-13 19:25:23 +02:00
Andreas Dangel c7d3d2969f Move Go Language into own sub-module, update changelog 2014-10-12 20:05:17 +02:00
Andreas Dangel e8fadec7de Merge branch 'cpd-language-go' of https://github.com/oinume/pmd into oinume-cpd-language-go 2014-10-12 19:57:41 +02:00
Andreas Dangel c714a7da87 Implement clean for generated xdocs 2014-10-12 19:50:25 +02:00
Andreas Dangel 64f9b04811 Update release docu, rename releases ruleset 514->520 2014-10-12 19:33:58 +02:00
Andreas Dangel 2584d7fbbd Update documentation 2014-10-12 19:10:47 +02:00
Andreas Dangel 9ade75a621 Refactor CPDGui to detect available languages dynamically 2014-10-12 10:43:53 +02:00
Andreas Dangel 694258d7df Cleanup dependencies 2014-10-12 09:39:43 +02:00
Andreas Dangel f839ff43d5 Cleanup dependencies 2014-10-11 13:26:10 +02:00
Andreas Dangel 464b0bcef8 Rework CPD's LanguageFactory to use ServiceLoader, too 2014-10-11 12:16:28 +02:00
Andreas Dangel 72719bd0c3 Move C# into own sub-module 2014-10-11 11:23:07 +02:00
Andreas Dangel 2e13d1dd5e Update changelog 2014-10-11 11:01:53 +02:00
Andreas Dangel 7deb1ac596 Bump version to 5.2.0-SNAPSHOT 2014-10-08 22:57:04 +02:00
Andreas Dangel f748539c45 Rename pmd -> pmd-core and pmd-aggregate -> pmd 2014-10-08 22:52:25 +02:00
Andreas Dangel 38dd43a16b PMD, Checkstyle and Clover configurations 2014-10-08 22:31:29 +02:00
Andreas Dangel 475745e98e Configure the site for every module 2014-10-08 21:49:23 +02:00
Andreas Dangel bc9469e385 Add all language modules to distribution package 2014-10-08 21:00:06 +02:00
Andreas Dangel 18ea8600ec Fix problem that some rules where not executed - max language version was
determined wrongly
2014-10-06 23:04:11 +02:00
Andreas Dangel 19fb5426f7 Move forgotten files to java 2014-10-06 22:52:13 +02:00
Andreas Dangel 17b573ef81 Fix ant tests - PMDTaskTest is moved partly to java,
javascript and xml
2014-10-06 22:46:01 +02:00
Andreas Dangel a36239bbc1 Fix remaining RuleSetFactoryTests and RuleSetReferenceIdTests 2014-10-06 22:08:34 +02:00
Andreas Dangel b8c79ffd47 Fix a couple of RuleSetFactoryTests 2014-10-06 20:44:09 +02:00
Andreas Dangel f120134b6d Fix CLI Tests, move coverage test to java 2014-10-06 20:14:43 +02:00
Andreas Dangel d038fed36e Fix RendererTests - XMLRendererTest same as all others now. 2014-10-06 20:00:31 +02:00
Andreas Dangel 8ce1607b23 Fix more tests like StatisticalRuleTest, SourceCodeTest
MatchAlgorithmTest moved to java
2014-10-06 19:19:52 +02:00
Andreas Dangel 09eb9ef2cc Fix DesignerTest - and lazily initialize the Designer class 2014-10-05 21:28:57 +02:00
Andreas Dangel 563a41afd7 More fixes - some tests simply moved to java module 2014-10-05 18:46:34 +02:00
Andreas Dangel 5c548570f6 Introduce two dummy languages for testing, fix more compile errors in tests 2014-10-04 21:16:33 +02:00
Andreas Dangel e41b56a8e5 Move tests for typeresolution and symboltable to java sub-module 2014-10-04 20:44:01 +02:00
Andreas Dangel 8165bc2bf5 Fix test compilation errors - LanguageVersion*Tests in each sub-module now 2014-10-04 20:40:05 +02:00
Andreas Dangel 36327e266e Move cpd code for ecmascript into javascript sub-module 2014-10-04 20:11:55 +02:00
Andreas Dangel 64728dd9c4 Move ruby into own sub-module 2014-10-04 20:09:46 +02:00
Andreas Dangel 600587e5b0 Move fortran into own sub-module 2014-10-04 20:05:38 +02:00
Andreas Dangel a3b4b0bff8 Move php into own sub-module 2014-10-04 20:00:55 +02:00
Andreas Dangel c352217131 Move cpd tokenizer tests to the various sub-modules 2014-10-04 19:16:01 +02:00
Andreas Dangel 36dd58a4ab Move xml and xsl into own sub-module pmd-xml 2014-10-04 19:06:41 +02:00
Andreas Dangel d2a7bc85f1 Move jsp into own sub-module 2014-10-04 18:56:33 +02:00
Andreas Dangel cdf293f9fc Move cpp into own sub-module 2014-10-04 18:48:35 +02:00
Andreas Dangel 802af053cf Move plsql into own sub-module 2014-10-04 18:40:22 +02:00
Andreas Dangel a8ef0ec863 Move velocity into own sub-module 2014-10-04 18:32:40 +02:00
Andreas Dangel 2e7310a2cd Move javascript into own sub-module 2014-10-04 18:23:23 +02:00
Andreas Dangel c859a05718 Extract test framework into own sub-module 2014-10-04 17:37:09 +02:00
Andreas Dangel ad88b4784d Move java into own sub-module pmd-java 2014-10-04 17:36:41 +02:00
Andreas Dangel fa950a8296 Merge remote-tracking branch 'chrisdutz/master' into modularization 2014-10-04 16:59:56 +02:00
Andreas Dangel 4546adac8f Move and remove more java language dependencies in tests
All the symboltable tests seem to be java specific
ParserTst is java specific, too
2014-10-04 16:34:40 +02:00
Andreas Dangel 01c59395b8 Remove more java language dependencies in test classes 2014-10-03 23:31:31 +02:00
Andreas Dangel 0c6e5c5e9a Remove more java language dependencies
SymbolTableViewer is unfinished and not used, so deleted now.
GetCommentOnFunction and TypeOfFunction are registered
with java's language handler.
2014-10-03 22:03:10 +02:00
Andreas Dangel e4faed2f47 Update gitignore 2014-10-03 21:20:08 +02:00
Andreas Dangel c214c1b5ba Move documentation up to parent module 2014-10-03 21:00:28 +02:00
Andreas Dangel c1c6f71981 Configure correct multi-module build
and move common parts up to the parent pom
2014-10-02 19:09:58 +02:00
Andreas Dangel 291245a081 Add sources to the src package
bin-package now only contains the binaries
src-package now only contains the sources
2014-10-01 20:09:58 +02:00
Andreas Dangel 6f7b1f55e4 Create a basic dist module, which creates the binaries for pmd 2014-10-01 19:46:31 +02:00
Andreas Dangel e8cb1bde54 Move test packages net.sourceforge.pmd.ast and .dfa to lang.java. 2014-09-30 21:54:40 +02:00
Andreas Dangel 64b43e1235 Remove references to java 2014-09-30 20:07:31 +02:00
Andreas Dangel d3e97d3c07 Move ImportWrapper in a general package as it's just a utility class 2014-09-30 20:05:26 +02:00
Andreas Dangel 612364a06d Create a first sub-module for java
* almost empty, just compiling the java grammar
* no code moved yet
2014-09-30 19:51:42 +02:00
oinuma-kazuhiro 8ca3805218 Fix indent tab 2014-09-30 15:44:52 +09:00
oinuma-kazuhiro 076d4a09b1 Add Go support to CPD 2014-09-30 15:42:17 +09:00
Christofer Dutz 079c72f7d6 Refactored the LanguageRegistry to use a Java 6 ServiceLoader instead of a custom-built property-file-based solution. 2014-09-29 22:38:46 +02:00
Christofer Dutz b781fd3eb5 Renamed LanguageVersionModule back to LanguageVersion and LanguageModule back to Language. 2014-09-29 21:28:33 +02:00
Andreas Dangel bb9039426b Merge branch 'marob-master' 2014-09-29 21:02:44 +02:00
Andreas Dangel 27b2466bf1 Add missing documentation + changelog 2014-09-29 20:55:51 +02:00
marob 59706b9075 Import jstl functions in tests 2014-09-24 18:11:14 +02:00
marob d7466ec50b Add the fn:escapeXml case 2014-09-24 17:00:50 +02:00
marob adbe4e4e9c merge from upstream 2014-09-24 16:03:42 +02:00
Christofer Dutz 5789144b93 Renamed LanguageVersionModule back to LanguageVersion and LanguageModule back to Language. 2014-09-22 22:05:17 +02:00
Christofer Dutz 0c43a7aae5 Refactored PMD to allow modular extension of languages. 2014-09-22 22:01:17 +02:00
Andreas Dangel dea0fe616e Prepare next version 2014-08-31 13:21:01 +02:00
Andreas Dangel 45c1a8ca71 [maven-release-plugin] prepare for next development iteration 2014-08-31 11:56:31 +02:00
Andreas Dangel 6063aafa80 [maven-release-plugin] prepare release pmd_releases/5.1.3 2014-08-31 11:56:31 +02:00
Andreas Dangel 730d1d75c2 release plugin back to 2.3.2 due to https://jira.codehaus.org/browse/MRELEASE-875 2014-08-31 11:52:16 +02:00
Andreas Dangel fae645106f Prepare pmd release 5.1.3 2014-08-31 11:14:35 +02:00
Andreas Dangel cd38be487e JDK9 code changes - interface javax.swing.tree.TreeNode changed slightly 2014-08-31 10:49:37 +02:00
Andreas Dangel b440eaf323 verify #1249 Regression: UnusedPrivateMethod from 5.0.5 to 5.1.2 2014-08-30 21:11:01 +02:00
Andreas Dangel c1f0d3c43b #1250 Method attribute missing for some violations 2014-08-30 20:57:19 +02:00
Andreas Dangel 94da2876c0 Documentation: Extra closing-brace in suppress-warnings example
See: https://sourceforge.net/p/pmd/discussion/188192/thread/9ecda507/
2014-08-30 19:03:05 +02:00
Andreas Dangel 5efaafc4f6 verify #1251 UnusedPrivateMethod false positives for boxing & unboxing arguments 2014-08-30 18:59:34 +02:00
Andreas Dangel b41e6ff682 #1246 False positive from MissingBreakInSwitch 2014-08-24 11:42:00 +02:00
Andreas Dangel eaa58d7f5f #1247 Not able to recognize JDK 8 Static Method References 2014-08-22 22:59:18 +02:00
Andreas Dangel 8a9c44148a #1245 False Positive for Law of Demeter 2014-08-22 22:38:25 +02:00
Andreas Dangel 3e182c9b03 Verify #1246 False positive from MissingBreakInSwitch 2014-08-22 22:17:10 +02:00
Andreas Dangel 67cdaf9edd Fix unit test 2014-08-18 20:47:58 +02:00
Andreas Dangel 2ffec3d953 Update changelog 2014-08-18 20:40:28 +02:00
Andreas Dangel 15571a15db Refactor cyclomatic complexity tests to be standard rule tests 2014-08-17 19:10:12 +02:00
Andreas Dangel fddf301589 Use PMDTestRunner for almost all rule tests 2014-08-16 20:54:37 +02:00
Andreas Dangel 7790c83fb1 #1241 False+ AvoidProtectedMethodInFinalClassNotExtending 2014-08-15 12:37:02 +02:00
Andreas Dangel 623ac14c51 #1243 Useless Parentheses False Positive 2014-08-15 12:27:08 +02:00
Andreas Dangel 8fcc45daf0 #1244 FieldDeclarationsShouldBeAtStartOfClass and anonymous classes 2014-08-15 12:09:32 +02:00
Andreas Dangel 2d6560c0f8 #1239 StackOverflowError in AbstractTokenizer.parseString running CPD on >1MB JS file 2014-08-14 22:50:34 +02:00
Andreas Dangel 643f85a5a2 #1235 scope dependencies in POM file 2014-08-14 21:58:31 +02:00
Andreas Dangel 9e3a672636 Verified #1156 False failure with "Avoid unused private methods" 2014-08-14 21:43:01 +02:00
Andreas Dangel c310c93c02 #1187 double variable with AvoidDecimalLiteralsInBigDecimalConstructor 2014-08-14 20:24:07 +02:00
Andreas Dangel 6c0eed7109 Fix NPE in ConstructorCallsOverridable and XPath error in AvoidLiteralsInIfCondition 2014-08-13 21:31:09 +02:00
Andreas Dangel 1025c09bf5 #1231 No Error Message on Missing Rule 2014-08-13 20:01:37 +02:00
marob 635fc40e6f Add NoUnsanitizedJSPExpression rule 2014-08-13 10:50:12 +02:00
Andreas Dangel 8a34f2c8d1 #1231 No Error Message on Missing Rule - add error message if excluded rule cannot be found 2014-08-12 20:02:34 +02:00
Andreas Dangel f6415ccc80 #1232 Make ShortClassName configurable 2014-08-11 20:04:01 +02:00
Andreas Dangel f5783eec6d #1234 Unused private methods still giving false positives in 5.1.3 snapshot 2014-08-10 18:59:46 +02:00
Andreas Dangel 9b73613ff4 Verify #1199 PMD CheckResultSet gives false positive in a do/while loop 2014-08-09 20:10:01 +02:00
Andreas Dangel c1f141f694 Upgrade maven plugins 2014-08-09 19:52:46 +02:00
Andreas Dangel d6b6e6a4a0 #1230 UseCollectionIsEmpty gets false positives 2014-08-09 18:05:40 +02:00
Andreas Dangel cb76795cb9 Improve test framework:
* PMDTestRunner reports all tests, that have been executed. This will
  explode the reported number of tests that are run
* It allows to selectively run single test cases (e.g. via eclipse)
* Used for now in DesignRulesTest
* Updated junit to 4.11
2014-08-09 16:04:03 +02:00
Andreas Dangel 9e35243b16 #1228 actually use the class loader for the symbol facade
and fix type resolution in the current package
2014-08-08 22:08:24 +02:00
Andreas Dangel 7a7ba2b23e #1228 UnusedPrivateMethod returns false positives - more cases 2014-08-08 21:13:02 +02:00
Andreas Dangel 1540440632 #1228 UnusedPrivateMethod returns false positives (7) - support allocation expressions 2014-08-08 19:37:23 +02:00
Andreas Dangel 6ee75a9e6d #1228 UnusedPrivateMethod returns false positives (6)
With auto-boxing for primitive types
2014-08-07 21:21:05 +02:00
Andreas Dangel 5428885ae4 #1233 UnusedPrivateMethod: False positive : method called on returned object. 2014-08-05 19:47:58 +02:00
Andreas Dangel 47a24d5625 Update maven-pmd-plugin 2014-08-03 17:36:36 +02:00
Andreas Dangel e28c7de3e5 #1228 UnusedPrivateMethod returns false positives (5a+b)
This adds the auxiliar classpath to the TypeSet type resolver that
is used by the symbol facade.
2014-08-01 19:35:30 +02:00
Andreas Dangel e6ce96cc10 #1228 UnusedPrivateMethod returns false positives (4) 2014-07-31 21:19:55 +02:00
Andreas Dangel 4cef35c7f6 #1228 UnusedPrivateMethod returns false positives 2014-07-28 19:53:59 +02:00
Andreas Dangel c730c15d13 Verify #1228 UnusedPrivateMethod returns false positives 2014-07-26 10:34:47 +02:00
Andreas Dangel 6d7d0bffd3 Checkstyle, Javadoc, Whitespace 2014-07-26 10:33:48 +02:00
Andreas Dangel ce1dca1c2c Update pmd plugin version to 3.1 2014-07-25 18:50:41 +02:00
Andreas Dangel a7f8c102ba Checkstyle, Javadoc, Whitespace 2014-07-25 18:41:23 +02:00
Andreas Dangel d5eafec027 Checkstyle, Javadoc, whitespace 2014-07-24 17:52:43 +02:00
Andreas Dangel fe325afb7b Update changelog 2014-07-20 12:24:43 +02:00
Andreas Dangel 805d4d0f92 [maven-release-plugin] prepare for next development iteration 2014-07-20 10:41:26 +02:00
Andreas Dangel cfc3617a4f [maven-release-plugin] prepare release pmd_releases/5.1.2 2014-07-20 10:41:25 +02:00
Andreas Dangel f6534c20ad pmd: Prepare pmd release 5.1.2 2014-07-20 10:11:40 +02:00
Andreas Dangel de1a8049ff Update release process documentation 2014-07-20 10:08:47 +02:00
Andreas Dangel 0e7ed771a6 Fix documentation about "Violation Suppress XPath"
Thanks to Scott Santucci.
2014-07-20 09:56:15 +02:00
Andreas Dangel da9c987ccd Verify #1225 UselessParentheses rule executed on empty ruleset 2014-07-20 09:40:20 +02:00
Andreas Dangel a0f3cb1027 #1226 False Positive: UnusedPrivateMethod overloading with varargs 2014-07-20 09:21:22 +02:00
Andreas Dangel 52ed5e3b8d #1198 ConfusingTernary does not ignore else if blocks even when property is set 2014-07-19 18:41:38 +02:00
Andreas Dangel 30dc6dfc6b #1200 setRuleSets method javadoc mistype commands instead commas 2014-07-19 18:04:03 +02:00
Andreas Dangel af0cbddc39 #1201 Error "Can't find resource null" when ruleset contains spaces after comma 2014-07-19 17:59:48 +02:00
Andreas Dangel ef236facb8 #1202 StackOverflowError in RuleSetReferenceId 2014-07-19 17:38:18 +02:00
Andreas Dangel 383a08847b #1227 GuardLogStatementJavaUtil doesn't catch log(Level.FINE, "msg" + " msg") calls 2014-07-18 20:29:48 +02:00
Andreas Dangel be46a71078 #1203 Make GuardLogStatementJavaUtil configurable 2014-07-18 19:57:12 +02:00
Andreas Dangel b476588f08 #1205 More parse errors with lambda expressions 2014-07-18 18:57:25 +02:00
Andreas Dangel ec088bdc9b #1205 Parse error on lambda with if 2014-07-17 20:53:31 +02:00
Andreas Dangel f4d767d844 #1208 yahtml's outputDir property does not work 2014-07-16 20:24:22 +02:00
Andreas Dangel 63851dfe55 #1209 XPath 2.0 following-sibling incorrectly includes context node 2014-07-15 20:54:20 +02:00
Andreas Dangel 783175eb01 #1224 GuardDebugLogging broken in 5.1.1 - missing additive statement check in log statement 2014-07-15 19:40:36 +02:00
Andreas Dangel ee2645f6fc #1213 AvoidLiteralsInIfCondition -- switch for integer comparison with 0 2014-07-14 22:15:27 +02:00
Andreas Dangel 629eb02970 #1211 PMD is failing with NPE for rule UseIndexOfChar while analyzing Jdk 8 Lambda expression
Actually fixed with 8f89d5a05f
2014-07-13 22:45:05 +02:00
Andreas Dangel b9dc8557aa Merge branch 'AlanHohn-master' 2014-07-12 19:23:52 +02:00
Andreas Dangel 6cf811b3b5 Make CyclomaticComplexityRule a subclass of StdCyclomaticComplexityRule
to remove the now duplicated code.
2014-07-12 19:18:46 +02:00
Andreas Dangel 029359607a Remove manual isSuppressed implementation 2014-07-12 19:07:06 +02:00
Andreas Dangel 6cfdeefdf4 Update changelog 2014-07-12 18:28:35 +02:00
Andreas Dangel d2d8a80958 Merge branch 'master' of https://github.com/AlanHohn/pmd into AlanHohn-master 2014-07-12 18:09:28 +02:00
Andreas Dangel 325b0cf06d #1214 UseCollectionIsEmpty misses some usage 2014-07-12 17:53:15 +02:00
Andreas Dangel ccd77a9e78 #1215 AvoidInstantiatingObjectsInLoops matches the right side of a list iteration loop 2014-07-12 14:53:59 +02:00
Andreas Dangel 38575faffa #1216 AtLeastOneConstructor ignores classes with *any* methods 2014-07-12 11:57:27 +02:00
Andreas Dangel b2f3b6cd53 Update changelog 2014-07-12 10:28:46 +02:00
Andreas Dangel 2f1c7a36de #1217 SystemPrintln always says "System.out.print is used"
Improved test framework to be able to assert the messages
produced by a rule.
2014-07-12 10:28:35 +02:00
Andreas Dangel 4b94dff6cf whitespace 2014-07-12 09:51:31 +02:00
Andreas Dangel 60ac836e21 #1218 TooFewBranchesForASwitchStatement misprioritized 2014-07-12 09:51:22 +02:00
Andreas Dangel dd63fdbfbd #1219 PrimarySuffix/@Image does not work in some cases in xpath 2.0 2014-07-11 23:17:08 +02:00
Andreas Dangel 33cd507fad Fix #1221 OneDeclarationPerLine really checks for one declaration each statement 2014-07-10 20:55:05 +02:00
Andreas Dangel 8f89d5a05f UseIndexOfChar: fix null pointer with lambda expressions 2014-07-09 21:16:25 +02:00
Andreas Dangel e08d585db0 Fix #1223 UnusedPrivateMethod: Java 8 method reference causing false positives 2014-07-09 20:40:01 +02:00
Andreas Dangel 671ba3367a #1206 Update Changelog 2014-07-08 21:00:58 +02:00
Andreas Dangel 6cad92ba4a #1206 Add test 2014-07-08 21:00:44 +02:00
Scott Santucci e20ab1629f #1206 Make SummaryHTMLRenderer respect show suppressions settings 2014-07-08 21:00:25 +02:00
Alan Hohn 7c0ff5f873 Standard and modified cyclomatic complexity 2014-06-18 21:42:46 -05:00
Andreas Dangel 8c042e394d Add tests for slf4j logger in MoreThanOneLogger.
This adds slf4j-api as a test dependency.
2014-06-14 10:00:31 -04:00
Mark Adamcin a0f04106fe Add SLF4j Logger type to MoreThanOneLogger rule 2014-06-12 15:34:06 -07:00
Andreas Dangel 40802ef517 Update changelog 2014-05-02 10:28:40 +02:00
muminc ba69f8bc82 update to use asm 5.0.2 2014-05-02 01:45:14 +01:00
Andreas Dangel 60bb47df8b Fix #1181 unused import false positive if used as parameter in javadoc only. 2014-04-30 09:41:39 +02:00
Andreas Dangel 62a8070657 Fix #1192 Ecmascript fails to parse this operator " ^= " 2014-04-29 09:14:04 +02:00
Andreas Dangel 057f996e6f Prepare changelog for next version 2014-04-27 11:45:57 +02:00
Andreas Dangel f9063393d3 [maven-release-plugin] prepare for next development iteration 2014-04-27 08:23:21 +02:00
Andreas Dangel 242ea1065b [maven-release-plugin] prepare release pmd_releases/5.1.1 2014-04-27 08:23:21 +02:00
Andreas Dangel 9273d334ac Prepare pmd release 5.1.1 2014-04-27 08:01:36 +02:00
Andreas Dangel d52db39846 Merge branch 'pmd/5.1.x' 2014-04-27 07:45:13 +02:00
Andreas Dangel 6f61b41e20 Fix #1191 Ecmascript fails to parse "void(0)" 2014-04-26 19:13:15 +02:00
Andreas Dangel d03f5a339c Adding TodoComment checkstyle rule. 2014-04-26 18:11:51 +02:00
Andreas Dangel 3b47b5d408 Checkstyle fixes. 2014-04-26 18:07:43 +02:00
Andreas Dangel 324f5707d2 Fix changelog layout 2014-04-26 17:53:13 +02:00
Andreas Dangel b2b02a69a4 Checkstyle fixes 2014-04-26 17:46:49 +02:00
Andreas Dangel dcb7668c57 Update changelog 2014-04-26 11:51:20 +02:00
Andreas Dangel 22647630b7 Merge branch 'commentrequired-enums' of https://github.com/igniti-gmbh/pmd into igniti-gmbh-master 2014-04-26 11:48:36 +02:00
Andreas Dangel 85d8660c6d Merge branch 'master' of https://github.com/igniti-gmbh/pmd into igniti-gmbh-master 2014-04-26 11:47:16 +02:00
Andreas Dangel f0346a9aee Verify #1189 GuardLogStatementRule and GuardDebugLoggingRule broken for log4j2 2014-04-23 16:54:39 +02:00
Andreas Dangel 0796dad74e Fix #1188 False positive in UnusedPrivateField 2014-04-23 16:29:57 +02:00
Alexander Stillich 785f01b0fa Added support for enums in CommentRequiredRule and extended corresponsing test 2014-04-16 14:33:11 +02:00
Alexander Stillich dbddeb01f1 Fixed NPE in ConsecutiveAppendsShouldReuseRule.getVariableAppended() which was triggered with the dogfood ruleset 2014-04-16 13:29:32 +02:00
Andreas Dangel 8694a26caf Fix #1167 Error while processing PLSQL file with BOM 2014-04-13 10:48:20 -04:00
Andreas Dangel 6eb8f84769 Fix #1165 SimplifyConditional false positive 2014-04-13 09:44:17 -04:00
Andreas Dangel 4bcef67b42 Fix #1185 UnusedModifier throws NPE when parsing enum with a nested static interface 2014-04-13 09:43:58 -04:00
Andreas Dangel 0f72ff41d9 Deleted all the folders that have been moved out into own repositories.
pmd-eclipse-plugin -> https://github.com/pmd/pmd-eclipse-plugin
pmd-jdeveloper* -> https://github.com/pmd/pmd-jdeveloper
website -> https://github.com/pmd/pmd.sourceforge.net
pmd-emacs -> https://github.com/pmd/pmd-emacs
everything else -> https://github.com/pmd/pmd-misc
2014-04-12 19:50:56 -04:00
Andreas Dangel 24c9bb9de9 Add test for AbstractCommentRule 2014-04-12 10:00:18 -04:00
Andreas Dangel 1fcc5ceeae Merge branch 'comment-fixes' of https://github.com/igniti-gmbh/pmd into igniti-gmbh-comment-fixes 2014-04-12 09:40:12 -04:00
Stuart Turton db000f3ad0 DBURI - add more feedback for problems returning DataSources from DBURIs 2014-04-11 20:37:12 -04:00
Stuart Turton 5ad79006ab PLSQL - Add InlinePragma class to support PRAGMA INLINE( method , ('YESY'|'NO') ) statement 2014-04-11 20:37:05 -04:00
Stuart Turton a12bc08c3b PLSQL - remove commented out Java Rule for PLSQ code size.xml Rules file 2014-04-11 20:36:57 -04:00
Andreas Dangel 423ac78d91 Enable PLSQL XPath Rule TooManyMethods 2014-04-11 20:34:42 -04:00
Stuart Turton 9a61116259 Incorporate PLDoc changes:-
Adding [EDITIONABLE|NONEDITIONABLE] keyword broke LOOKAHEAD Increase
QuickFix for Inline PRAGMA compiler instruction (support clause without adding new AST Type)
2014-04-11 20:24:11 -04:00
Andreas Dangel 2b11c5e1f2 Fix #1166 PLSQL XPath Rules Fail for XPath 1.0 2014-04-11 20:19:56 -04:00
Stuart Turton 06057f17ee PLSQL- Add minimal XPathHandler to PLSQLHandler in order to avoid NPE in XPath rules for XPath 1.0. 2014-04-11 20:06:49 -04:00
Andreas Dangel 1e3dbdb357 Add unit test for bug #1166 PLSQL XPath Rules Fail for XPath 1.0 2014-04-11 20:06:14 -04:00
Alexander Stillich e42bc43287 Fix comments between other comments being wrongly assigned:
/** Comment 1 */
	public void method1() {}

	/** Comment 2 */

	/** Comment 3 */
	public void method2() {}

Would assign Comment 2 to method2, should assign Comment 3.

Also added support for enums in AbstractCommentRule.orderedCommentsAndDeclarations().
2014-04-10 15:54:37 +02:00
Andreas Dangel 1aa11e5ee7 Fix unit test DesignerTest so that it runs in headless mode, too. 2014-04-07 21:02:11 -04:00
Andreas Dangel e8e7420027 Document that PMD requires java 1.6 2014-04-07 20:05:01 -04:00
Andreas Dangel 4dd18721c1 pmd: fix #1168 Designer errors when trying to copy xml to clipboard 2014-04-04 18:32:09 -04:00
Andreas Dangel 552acfd0c1 pmd: fix #1180 False Positive for ConsecutiveAppendsShouldReuse on different variable names 2014-04-03 20:20:28 -04:00
Andreas Dangel bc4f7cc1c2 pmd: fix #1177 Incorrect StringBuffer warning when that class is not used 2014-04-03 19:33:01 -04:00
Andreas Dangel 36fc87c3c8 pmd/cpd: add skipLexicalErrors and skipDuplicateFiles to CPD's ant task 2014-04-02 21:29:57 -04:00
Andreas Dangel 12adae6034 pmd: fix #1178 LexicalError while parsing Java code aborts CPD run 2014-04-02 20:22:34 -04:00
Andreas Dangel 88ee9c47d8 pmd: fix #1176 ShortVariable false positive with for-each loops 2014-03-30 16:58:26 -04:00
Andreas Dangel e54b6dd22f pmd: fix #1173 Java 8 support: method references 2014-03-30 09:32:10 -04:00
Andreas Dangel e0ece8f82a pmd: fix #1170 false positive with switch in loop 2014-03-29 19:49:38 -04:00
Andreas Dangel 7a806df932 pmd: verify #1173 Java 8 support: method references 2014-03-29 19:34:15 -04:00
Andreas Dangel 87989b524a pmd: fix #1175 false positive for StringBuilder.append called 2 consecutive times 2014-03-29 19:18:46 -04:00
Andreas Dangel 6e1927ee2a pmd: fix #1171 Specifying minimum priority from command line gives NPE 2014-03-29 16:51:21 -04:00
Andreas Dangel f0049c5946 pmd: format source, no changes 2014-03-29 16:44:57 -04:00
Andreas Dangel 21750b9bc4 pmd: update release process documentation
pmd.website.baseurl is set correctly if the profile "pmd-release" is used
  during releasing
2014-02-12 20:46:58 +01:00
Andreas Dangel 4aee867fc2 [maven-release-plugin] prepare for next development iteration 2014-02-11 21:32:12 +01:00
Andreas Dangel 79a9af14f2 [maven-release-plugin] prepare release pmd_releases/5.1.0 2014-02-11 21:30:13 +01:00
Andreas Dangel c7bba5bf26 pmd: Update changelog for next development version 2014-02-11 20:26:15 +01:00
Andreas Dangel b970324b97 pmd: Prepare pmd release 5.1.0 2014-02-11 20:26:15 +01:00
Andreas Dangel d36190ea7c pmd: Prepare next development version 5.2.0-SNAPSHOT 2014-02-11 20:26:15 +01:00
Andreas Dangel 83552fb843 pmd: Fix rulesets not meeting pmd conventions 2014-02-11 20:26:08 +01:00
Andreas Dangel f4343f6b19 pmd: update documentation about new supported languages. 2014-02-09 09:37:19 +01:00
Andreas Dangel c011fc6dd1 pmd: fix #1054 XML Rules ever report a line -1 and not the line/column where the error occurs 2014-02-08 22:46:55 +01:00
Andreas Dangel 93a46d17e7 pmd: fix #1045 //NOPMD not working (or not implemented) with ECMAscript 2014-02-02 22:37:15 +01:00
Andreas Dangel ec0471cebe pmd: fix #1164 Violations are not suppressed with @java.lang.SuppressWarnings("all") 2014-02-02 13:21:30 +01:00
Andreas Dangel 8aa83291c0 pmd: update changelog 2014-02-02 12:12:10 +01:00
Andreas Dangel 08041af650 pmd: fix #1124 PMD.run() multithreading issue 2014-02-02 12:09:55 +01:00
Andreas Dangel 8482948518 pmd: fix #1120 equalsnull false positive 2014-02-02 11:51:59 +01:00
Andreas Dangel a0a7f58dec pmd: verify #1122 parse error at class.super 2014-02-02 11:18:42 +01:00
Andreas Dangel 29a139797c pmd: verify #1143 ShortClassName fires with a 5-letter class name 2014-02-02 11:14:31 +01:00
Andreas Dangel 8607d02120 pmd: fix #1146 UseArrayListInsteadOfVector false positive when using own Vector class 2014-02-02 11:11:07 +01:00
Andreas Dangel 8e8cec667e pmd: fix #1125 Missing Static Method In Non Instantiatable Class 2014-02-02 10:54:03 +01:00
Andreas Dangel 5b52ba642c pmd: fix #1126 False positive with FieldDeclarationsShouldBeAtStartOfClass for static enums 2014-02-02 10:33:31 +01:00
Andreas Dangel bbb36686b9 pmd: fix #1147 EmptyMethodInAbstractClassShouldBeAbstract false positives 2014-02-01 19:47:43 +01:00
Andreas Dangel c0efb45c10 pmd: verify #1149 getBeginLine and getEndLine not working (ECMAScript) 2014-02-01 19:31:27 +01:00
Andreas Dangel ab158fe19f pmd: fix #1150 "EmptyExpression" for valid statements! 2014-02-01 19:15:06 +01:00
Andreas Dangel 86d9c1060c pmd: fix #1154 Call super onPause when there is no super 2014-02-01 18:56:30 +01:00
Andreas Dangel cc27363c97 pmd: verify #1156 False failure with "Avoid unused private methods" 2014-02-01 18:42:22 +01:00
Andreas Dangel aad969665f pmd: fix #1159 false positive UnusedFormalParameter readObject(ObjectInputStream) if not used 2014-02-01 18:36:07 +01:00
Andreas Dangel dff3d181f9 pmd-eclipse: update release notes 2014-02-01 13:02:04 +01:00
Andreas Dangel 8cac431226 Merge branch 'project-ruleset-workspace-path' of github.com:robinst/pmd 2014-02-01 12:53:38 +01:00
Andreas Dangel 4e30abe315 Merge branch 'preference-keyword' of github.com:robinst/pmd 2014-02-01 12:52:32 +01:00
Andreas Dangel 964f6933e1 pmd: update changelog 2014-02-01 12:50:03 +01:00
Andreas Dangel d9064e6956 Merge branch 'cpd_concurrency' of github.com:golpira/pmd into golpira-cpd_concurrency 2014-02-01 12:46:47 +01:00
Andreas Dangel 1a48102d9a pmd: register plsql dates ruleset 2014-02-01 12:44:16 +01:00
Andreas Dangel dc945f78b2 Merge branch 'master' of github.com:sturton/pmd into sturton-master 2014-02-01 11:37:45 +01:00
Andreas Dangel 570d6cedc6 pmd: enable some ignored tests and remove System.out in tests... 2014-02-01 11:34:12 +01:00
Andreas Dangel 2624b6b3ea pmd: add test code that cannot be parsed, but is valid java 8 code. 2014-02-01 10:09:01 +01:00
Andreas Dangel ee708b42ea pmd: add intersectionTypes flag to ASTCastExpression 2014-01-31 22:33:04 +01:00
Andreas Dangel 6355c1f6f4 pmd: adjust variable declarator id for missing type node in case
of lambda expressions.
2014-01-31 19:38:05 +01:00
Andreas Dangel 6dc3701cc8 pmd: add java 8 syntax for type annotations 2014-01-30 23:13:12 +01:00
Andreas Dangel 9fbaf13bd9 pmd: fix unit tests after changing default java version to 1.8. 2014-01-30 20:44:41 +01:00
Andreas Dangel 64ab7b78e7 pmd: Improve java 8 parser 2014-01-30 20:36:40 +01:00
Robin Stocker 4de96d5dd2 pmd-eclipse: Support workspace-relative path in ruleSetFile property
When using multiple projects that want to share the rule set definitions
in a single file, it's currently only possible to reference the shared
file using an absolute path. The downside of the absolute path is that
it is different for each developer, so the resulting .pmd file can not
be committed in the repository.

To fix this, this change also tries to resolve the path against the
workspace root, so e.g. "/foo/.ruleset" can be used to refer to the
.ruleset file in the foo project.

Such a path can be ambiguous to an absolute file system path, but in
practice it should not be a problem. An alternative solution would be to
support variables (as known from Eclipse run configurations) such as
"${project_loc:foo}" in the path.
2014-01-29 13:35:47 +01:00
Robin Stocker 5f9598815f pmd-eclipse: Add "PMD" keyword to all preference pages
Otherwise the subpages are not shown when searching for "PMD" in the
preferences.
2014-01-29 12:31:29 +01:00
Andreas Dangel bef23a8d2d pmd: use java 8 as default version of java. 2014-01-28 22:28:00 +01:00
Andreas Dangel bfa925a44f pmd: feature #1161 Confusing Ternary should skip else if statements (or have a property to do so) 2014-01-27 20:35:46 +01:00
Andreas Dangel b3af64fa52 pmd: update changelog for java 1.8 support. 2014-01-26 20:17:23 +01:00
Andreas Dangel 65864b6189 pmd: fix java 8 grammar with LambdaExpression to not be confused with Expression 2014-01-26 20:10:16 +01:00
Andreas Dangel 350d0c3cfc pmd: improve java parse exceptions - tell, where the parse exception occurred. 2014-01-26 19:47:17 +01:00
Andreas Dangel 9ba87965ca pmd: Integrate LambdaExpressions in java symboltable.
Lambda parameters are not added to the local scope's symbol table.
2014-01-26 12:29:05 +01:00
Andreas Dangel e57eb66c55 pmd: add Java language version 1.8 and enable checks in grammar/parser. 2014-01-26 12:00:12 +01:00
Andreas Dangel a49391f3f5 pmd: Adjust grammar to not break other parsing corner cases with java 8 enhancements. 2014-01-26 11:52:15 +01:00
Andreas Dangel 88d766ee8b pmd: Extend java grammar to support Java 8 language features. 2014-01-25 19:47:49 +01:00
Andreas Dangel 9b91690f21 pmd: make pmd jdk8 ready
* Upgrade asm so that it understands jdk8 class files
2014-01-23 22:46:02 +01:00
David Golpira 8c0a4f6e4f Changed TokenEntry to use ThreadLocal.
Two static fields are now stored in ThreadLocal.  This allows
multiple instances of CPD to run concurrently without stepping
on each other (eg: multi-module Maven projects.)
2014-01-23 01:08:24 -05:00
Stuart Turton 5f02803d78 CPD: add getter for all identified or added Sources 2014-01-10 22:05:12 +00:00
Stuart Turton f7b61616ea CPD: Rename List<String> getSources() to getSourcePaths() 2014-01-10 21:58:14 +00:00
Stuart Turton 28449e7f71 XPATH - make DocumentNavigator more robust 2014-01-09 00:03:33 +00:00
Stuart Turton 61c25b793e CPD- add getter for list of Source paths 2014-01-08 23:59:31 +00:00
Stuart Turton faa035b1c1 PMD-PLSQL - derive different faux-filename suffices for package/type specifications and bodies
-  Add rules for date
2014-01-08 23:47:05 +00:00
Andreas Dangel 4d9b7b0f8b pmd: checkstyle fixes 2014-01-05 15:17:20 +01:00
Andreas Dangel 36224a5ef7 pmd: checkstyle fixes 2014-01-05 14:48:16 +01:00
Andreas Dangel bc47a7109e pmd: checkstyle fixes 2014-01-03 14:51:51 +01:00
Andreas Dangel 9bf3895a48 pmd: update changelog and integrate it into the site
* The changelog uses now markdown for formatting
2014-01-03 11:55:46 +01:00
Andreas Dangel 7ec06b3adb pmd: review Velocity pull request
* Introduced AbstractVmNode (formerly SimpleNode)
* Added VmNode interface
* Added PMD's license header to the rule implementations, etc.
* Added rulesets.properties file for velocity rules
* Added externalInfoUrl to the rules
* Added Apache License info
2014-01-02 18:46:39 +01:00
Andreas Dangel 4fe4b40279 Merge branch 'master' of github.com:andrey81inmd/pmd into velocity
Conflicts:
	pmd/src/main/ant/alljavacc.xml
	pmd/src/main/java/net/sourceforge/pmd/lang/LanguageVersion.java
2014-01-02 10:10:17 +01:00
Andreas Dangel cce09d0f64 Merge branch 'm2e-error' of github.com:robinst/pmd 2014-01-02 10:06:36 +01:00
Andreas Dangel 388b1f5e65 pmd: code cleanups - no functional change
* checkstyle and pmd dogfood
2014-01-01 11:12:32 +01:00
Andreas Dangel 687eadbb10 pmd: update maven-pmd-plugin to 3.0.1 2013-12-31 16:06:07 +01:00
Andreas Dangel 75addab584 pmd: add howto about adding new languages to PMD. Thanks to Andrey Utis. 2013-12-31 16:06:07 +01:00
Andreas Dangel 0dd9ffb390 pmd: add markdown as additional documentation language 2013-12-31 16:05:12 +01:00
Andreas Dangel 6fd188a2ab pmd: Reviewed plsql pull request
* reworked symboltable implementation of plsql to use the refactored
general interfaces
2013-12-31 16:01:58 +01:00
Andreas Dangel d8ec3bfd39 Merge branch 'master' into plsql 2013-12-31 15:58:08 +01:00
Andreas Dangel 6a09146169 Merge branch 'symboltable' 2013-12-31 15:50:32 +01:00
Andreas Dangel 7d455c0064 pmd: update changelog with symboltable API changes 2013-12-25 10:20:31 +01:00
Andreas Dangel 5ed9bd8a0a pmd: move ScopedNode into the symboltable package 2013-12-25 10:19:50 +01:00
Andreas Dangel 93a5d77184 pmd: update changelog and add test for bug #1155 2013-12-23 13:17:34 +01:00
Henning Schmiedehausen c1cb3bfb5e Fix NPE with empty rulesets.
This is the fix for bug #1155 (https://sourceforge.net/p/pmd/bugs/1155/)

The whole code is in dire need of revisiting its behaviour when a
value is null or empty. Same goes for e.g. createRules whether it
should return null values (then the caller will have to deal with it)
or empty Rulesets.

Catching and discarding the rule not found exception looks pretty
suspicious.
2013-12-23 13:10:48 +01:00
Andreas Dangel e2b5b3753e pmd: add changelog and test for #1144 2013-12-23 13:09:33 +01:00
Andreas Dangel d4719914fa pmd: Refactor designer to not be Java specific anymore 2013-12-22 18:44:33 +01:00
Andreas Dangel 036cd3c143 pmd: Refactor rule implementation to use new generic symboltable 2013-12-22 18:44:33 +01:00
Andreas Dangel eee76b0248 pmd: Refactor java's symboltable implementation to use the new generic base classes 2013-12-22 18:44:32 +01:00
Andreas Dangel 1354f6f1fa pmd: Add basic/abstract implementations for Scope and NameDeclaration 2013-12-22 18:44:32 +01:00
Andreas Dangel a10c7dc78e pmd: Introduce generic Scope, NameDeclaration and NameOccurrence 2013-12-22 18:44:32 +01:00
Andreas Dangel 7f3a949935 pmd: Correct usage of generic ParseException 2013-12-22 18:44:32 +01:00
Andreas Dangel dee9df77c6 pmd: Refactor DFA and Designer, so that DFA is not Java specific 2013-12-22 18:44:32 +01:00
Robin Stocker 8412e5eb62 pmd-eclipse: Relax versionRange in pluginExecutionFilter for m2e 2013-11-30 15:17:07 +01:00
Pelisse Romain aea2504b2b Merge pull request #29 from hgschmie/master
Bring back the old CPDConfiguration constructor
2013-11-26 14:21:05 -08:00
Henning Schmiedehausen 8ad4a6a375 Bring back the old CPDConfiguration constructor; removing it will break
at least the maven pmd plugin which uses it.
2013-11-26 10:19:22 -08:00
Robin Stocker eb31689e26 pmd-eclipse: Fix "maven-dependency-plugin ... is not supported by m2e"
After importing the projects into Eclipse, m2e had the following error:

maven-dependency-plugin (goals "copy-dependencies", "unpack") is not
supported by m2e.

The error can be suppressed by adding a pluginExecutionFilter for m2e.
This does not affect the command-line build.
2013-11-18 17:00:13 +01:00
Andreas Dangel 9c9ab97523 pmd: improve doc example "how to write a rule" 2013-11-11 20:41:19 +01:00
Andreas Dangel 5c461b738d pmd: Verify UncommentedEmptyConstructor and move the tests to use the common test infrastructure. 2013-11-11 20:08:48 +01:00
Andreas Dangel 54f77b9ad4 pmd-eclipse: update release procedure 2013-10-31 12:47:01 +01:00
Andreas Dangel d6b6afab23 Prepare next pmd-eclipse-plugin development version 4.0.3-SNAPSHOT 2013-10-31 12:31:52 +01:00
Stuart Turton e9d7dddfbd plsql - make RELEASE an unreserved keywo 2013-10-22 00:15:48 +01:00
Andrey Utis 7ee2493593 Adding noinlinestyles rule 2013-10-17 13:38:00 -04:00
Andrey Utis 3a96e8ada3 Adding NoInlineJavaScript rule 2013-10-17 13:13:07 -04:00
Andrey Utis f5d9785625 Adding UnusedMacroParameterRule 2013-10-16 09:12:45 -04:00
Andrey Utis 3af86ec2aa Added EmptyForeachStmt rule 2013-10-11 16:40:25 -04:00
Andrey Utis f8e02bbd9f Adding EmptyIfStmt rule 2013-10-11 15:38:32 -04:00
Andrey Utis 3df53c4e1b Adding ExcessiveTemplateLengthRule and AvoidReassigningParameters rules 2013-10-09 15:38:08 -04:00
Andrey Utis 8e9bf2f321 Adding CollapsibleIfStatements rule for Velocity 2013-10-08 16:39:12 -04:00
Andrey Utis 2f21e2db42 creating Nested IF statement rule for VM 2013-10-07 21:20:21 -04:00
Andrey Utis b394464dcb Add VM visitor classes 2013-10-04 17:18:43 -04:00
Andrey Utis 916cdca56f fixing a couple more parsing issues 2013-10-01 21:56:49 -04:00
Andrey Utis d2bb244256 more cleanup - making dump work for vm 2013-10-01 21:23:36 -04:00
Andrey Utis 76beb2c48a removing dependency on velocity and cleanup 2013-10-01 20:59:52 -04:00
Andrey Utis d6df33915a fixing #foreach and cleanup 2013-09-30 22:23:59 -04:00
Andrey Utis 24b19cfd55 adding directives 2013-09-28 22:19:31 -04:00
Andrey Utis cbba43c6a3 initial attempt to add velocity language 2013-09-24 22:42:26 -04:00
Stuart Turton be4b6ecc5c Incorporate PLDoc 1.5.6 changes - Make NULLIF and RENAME unreserved keywords 2013-08-29 21:24:16 +01:00
Stuart Turton c8d41ce3b3 PLSQL Correct AccessibleByClause for second and successive accessors 2013-07-22 19:08:17 +01:00
Stuart Turton 67a4ed5b2e Merge branch 'master' of https://github.com/sturton/pmd
Conflicts:
	pmd/src/main/java/net/sourceforge/pmd/cpd/CPDCommandLineInterface.java
2013-07-21 18:05:43 +01:00
Stuart Turton ddacf7ec44 PLSQL- bring parser up to PLDoc 1.5.4 (11g EDITIONABLE/NONEDITIONABLE, 12c ACCESSIBLE BY clause )
Remove unused imports and variables
2013-07-21 00:58:03 +01:00
Stuart Turton a739794218 Merge commit '989672f8fb65b310f815d19667dd2e3dbdc92550'
Conflicts:
	pmd/src/main/java/net/sourceforge/pmd/RuleSet.java
	pmd/src/main/java/net/sourceforge/pmd/cpd/CPDCommandLineInterface.java
	pmd/src/main/java/net/sourceforge/pmd/cpd/CPDConfiguration.java
	pmd/src/test/java/net/sourceforge/pmd/LanguageVersionTest.java
2013-06-24 23:52:32 +01:00
Stuart Turton 3aa04a8860 PLSQL: Allow DEFINE SQL*Plus keyword to be used as a PL/SQL keyword 2013-06-17 19:31:14 +01:00
Stuart Turton 4781cdbcb5 Support ANSI DATE literals (DATE 'YYYY-MM-DD')
Allow TRIGGER REFERENCING clause to have ZERO subclauses.
2013-05-01 22:32:33 +01:00
Stuart Turton 391cf253ed PMD-PLSQL - correct AST for Named Global Block (Block Label(s) were checked for in LOOKAHEAD but not included in subsequent processing) 2013-03-24 21:05:25 +00:00
Stuart Turton 5b3b8df945 PMD-PLSQL - add plsql LanguageVersion tests 2013-03-24 21:03:44 +00:00
Stuart Turton cb5fea59ae Merge branch 'master' of git://github.com/pmd/pmd
Conflicts:
	pmd/src/main/java/net/sourceforge/pmd/cli/PMDParameters.java
2013-03-24 21:02:51 +00:00
Stuart Turton 782135b18a PMD-DB Add support for passing connection parameters via DBURI parameters and DBType properties with this priority (highest to lowest):-
explicit properties or explicit user and password
DBURI parameters
DBType properties

Update comments
2013-03-23 22:35:10 +00:00
Stuart Turton 584743234c PMD- DBURI changes - add getDataSourceName() to avoid calling getNiceFileName(….) with ignored parameters 2013-03-23 00:41:18 +00:00
Stuart Turton 5e1f79148f PMD-PLSQL: map TYPE and PACKAGE DBA_OBJECTS.OBJECT_TYPE values to DBMS_METADATA.GET_DDL TYPE_SPEC and PACKAGE_SPEC parameter values respectively - unchanged these values return both the specification and body objects. 2013-03-23 00:39:06 +00:00
Stuart Turton ace4fa4b46 PMD-PLSQL: comment out TooManyMethods because it throws a NULL pointer exception when used (works in PLSQLDesigner) 2013-03-23 00:35:48 +00:00
Stuart Turton 4034dbbe39 PMD - add helper method getURIDataSources to simplify use of DBURIs from maven-pmd-plugin 2013-03-21 19:45:45 +00:00
Stuart Turton 0d8b89aeeb CPD - refactor to simplify use of DBURIs from maven-pmd-plugin 2013-03-21 19:44:15 +00:00
Stuart Turton c58ad5603c PMD-DB - correct test defaults 2013-03-19 02:01:22 +00:00
Stuart Turton 42193382a1 Add some DBType property files used in tests 2013-03-19 01:25:09 +00:00
Stuart Turton a8cb39b313 Add BSD licensing boilerplate 2013-03-15 22:44:17 +00:00
Stuart Turton dfaca12bd3 PMD- add command line support for (database) URI source code location 2013-03-15 21:49:26 +00:00
Stuart Turton 9d302ed969 Merge branch 'master' of git://github.com/pmd/pmd
Conflicts:
	pmd/src/main/java/net/sourceforge/pmd/cpd/GUI.java
	pmd/src/main/java/net/sourceforge/pmd/cpd/LanguageFactory.java

Also:
Add ability to read source code via JDBC
net/sourceforge/pmd/util/database
CPD has been modified
2013-03-10 21:55:44 +00:00
Stuart Turton da68c9c6d3 Use Apache Commons IOUtils 2013-01-06 19:21:39 +00:00
Stuart Turton 9278e565aa Merge branch 'master' of git://github.com/pmd/pmd
Conflicts:
	pmd/src/test/java/net/sourceforge/pmd/ast/ParserCornersTest.java
2013-01-06 19:19:53 +00:00
Stuart Turton cfd4a980bd Set Image for BooleanLiteral and NullLiteral 2013-01-06 18:19:16 +00:00
Stuart Turton 718e918777 PLSQL: Alter Naming and Scope class changes to reflect adangel's refactoring 2013-01-06 16:18:13 +00:00
Stuart Turton b27d17f064 Support FORCE keyword in CREATE OR REPLACE TYPE (from PLDoc bug-fix) 2013-01-06 16:13:03 +00:00
Stuart Turton 78d5532b6f Merge branch 'master' of https://github.com/sturton/pmd into HEAD
Conflicts:
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/symboltable/NameOccurrence.java
2012-12-29 15:47:31 +00:00
Stuart Turton 509cc2a9ab Pre-Origin Pull commit to store CanonicalImage and dumpNodes changes to remove PLSQL Scope case-sensitivity 2012-12-29 15:43:21 +00:00
Stuart Turton 1c2fbb4c00 Merge branch 'adangel-master'
Conflicts:
	pmd/src/test/java/net/sourceforge/pmd/lang/plsql/dfa/StatementAndBraceFinderTest.java
2012-12-20 01:30:15 +00:00
Stuart Turton ec057aff19 PLSQL: sdd tests for code size rules; correct NcssObjectCountTule to ignore ProgramUnits not at the SchemaLevel 2012-12-20 01:18:59 +00:00
Stuart Turton 78a8735615 PLSQL: add tests for CASE statement 2012-12-16 17:53:39 +00:00
Stuart Turton 72dc749ef4 Ensure that tests can display standard output and error- use latest version of surefire plugin 2012-12-16 17:52:02 +00:00
Andreas Dangel f1ead3be52 pmd: make the java compiler happy by moving the string concatenation into a resource file 2012-12-14 15:40:25 +01:00
Andreas Dangel f88bcf144a pmd: plsql - added unit test for NPathComplexity and a initial PLSQL parser test 2012-12-13 18:22:43 +01:00
Andreas Dangel 2d5e59ba73 pmd: minor cleanups 2012-12-13 17:20:05 +01:00
Andreas Dangel cf1a1a2db9 pmd: adding license header to new files 2012-12-13 15:35:09 +01:00
Andreas Dangel 4fb3a50df2 pmd: refactored PLSQL integration
* Using now javacc during build time to regenerate most of the AST nodes
   and the parser
 * all AST nodes inherit now from the new class AbstractPLSQLNode. This
   class replaces the former SimpleNode. This class implements
   the interface PLSQLNode which inherits from PMD's Node.
 * Deleted all AST nodes that didn't have any modification after
   generating them.
 * PLSQL integration is now more like the Java integration
2012-12-13 15:24:18 +01:00
Andreas Dangel fa45557845 Merge remote-tracking branch 'pmd/master' into plsql 2012-12-12 19:23:37 +01:00
Stuart Turton 7a571b741e Amend StatementAndBraceFinder to add SWITCH_START for Searched CASE statement ; garden commented out code
Add more instrumentation into Linker
2012-12-11 23:39:24 +00:00
Stuart Turton 5d5b9e6a18 Correct control flow stack generation for ELSIF clause 2012-12-09 20:10:41 +00:00
Stuart Turton 873d9f6f83 PLSQL:codesize.xmlConvert Java examples to equivalent PLSQL examples; rewrite TooManyMethods Rule for PLSQL 2012-12-05 00:01:44 +00:00
Stuart Turton 4013461794 Avoid null pointer exception in PLSQLParser.canonicalName() 2012-12-04 23:58:15 +00:00
Stuart Turton 20bd584634 Add generic Oracle Object Length Rule - based on the OracleObject interface
Add PLSQL codesize ruleset file and example PLSQL  XPATH Rule (TomKytesDespair.xml)
2012-12-03 01:05:50 +00:00
Stuart Turton 17c9eadc61 Create OracleObject to flag AST that are (or for functions and procedures may be) schema-level items
Add  more statistical Rules (cribbed from Java Rules)
2012-12-03 00:05:02 +00:00
Stuart Turton 526b5610f0 Add unit tests for PLSQLParser and PLSQLStatementAndBraceFinder 2012-12-02 23:13:44 +00:00
Stuart Turton 374c734a98 Correct PLSQLDataNode to describe TypeMethod as a method
Remove System.err.println() from DFAPLSQLPanel
2012-12-02 21:53:55 +00:00
Stuart Turton d41ade9d10 Expose PLSQLParser.canonicalName() as helper method getCanonicalName() in SimpleNode
Correct logging message for StatementExpression equivalent inStatementAndBraceFinder
Correct off-by-one error when displaying code text )lines is zero-based so that it was displaying the next line- possibly what was intended)
Remove unused import from PLSQLDesigner (Interface ExecutableCode used instead)
2012-12-02 21:44:07 +00:00
Stuart Turton f5f4660b0a null pointer in Skip2NextTokenOccurrence 2012-11-30 19:14:14 +00:00
Stuart Turton 47ad0bbd7c PLSQL AST - Change StringBuffers to StringBuilders, parse Synonyms, Directories, Database Links, and the USING and RETURNING INTO clauses of embedded SQL.
Add a DDLCommand production, and add LOOKAHEAD to cope with otherwise unparsed  CREATE[ OR REPLACE] and  ALTER  statements.
2012-11-30 00:00:06 +00:00
Stuart Turton ef23c93398 Minor refactoring of NodeType and class which reference it StackObject, SequenceChecker, Linker etc.
The aspiration in  NodeType was to convert it to an enumeration: this refactoring moves AbstractDataFlowNode.stringFromType to make the class a bit more enum like and to make it publicly available for use in debugging other languages.
2012-11-29 23:47:10 +00:00
Stuart Turton 4a49e67caa Remove unused fields from TooManyFieldsRule 2012-11-29 23:05:51 +00:00
Stuart Turton 4f50ec7bc7 PLSQL - Correct DataFlow Stack generation for ELSIF clause 2012-11-29 23:01:51 +00:00
Stuart Turton 21a1afb2df Use StringBuilder instead of StringBuffer; add LOOKAHEAD for all input; parse and ignore DDL commands/system changes not already parsed; add static parser method to return a canonical Oracle name from arbitrary input 2012-11-28 00:26:46 +00:00
Stuart Turton 28f5d5d1ed Overwrite PLSQLParser and TokenManager after incorrect merge/rebase 2012-11-24 23:02:07 +00:00
Stuart Turton aab003ea51 Add support for SYNONYM, DIRECTORY and DATABASE LINK 2012-11-24 22:41:09 +00:00
Stuart Turton 969b29c1c8 Correct comment 2012-11-24 20:18:04 +00:00
Stuart Turton d21fdaf31d Remove end of line characters from Special Token SINGLE_LINE_TOKEN in order to allow the Skip* productions to search for the EOL Special Token without missing. 2012-11-24 20:13:40 +00:00
Stuart Turton 86f37b529c PLSQL: Attempt to set Class equivalent (Oracle Object level) for AbstractPLSQLRule; override getViolationParameters to return actual calculated measure for ExcessiveLength and AbstractNcssCountRule PLSQL Rules. 2012-11-21 00:11:07 +00:00
Stuart Turton 0f6ace560b PLSQL: Non-commented Source Statement and Too Many Methods (Package Specification and Object Type Specification 2012-11-20 22:47:20 +00:00
Stuart Turton 2ab85d1c35 Merge commit 'b0c2721c22dd03fd4c4fb1579b75f3005afd229b' 2012-11-20 19:43:06 +00:00
Stuart Turton ab0c209e53 Make Cyclomatic Complexity and NPath Complexity function with schema-level functions and procedures, object type bodies and triggers 2012-11-20 19:41:13 +00:00
Stuart Turton bfe1932037 PLSQL AST grammar with draft BSD lichence 2012-11-20 19:38:21 +00:00
Stuart Turton 93f5e8b2b4 Add more logging to PLSQL rules; Add visit() method for ExecutableCode interface 2012-11-16 20:56:22 +00:00
Stuart Turton 77fa5b6d1d Merge commit '3545b58820289b9dff7d404fb24f400323dd8f1f' 2012-11-16 20:51:31 +00:00
Stuart Turton 85f865e5e7 Add some code size rules (taken directly) from the Java rules: object length, Cyclomatic Complexity and NPath Complexity 2012-11-16 20:50:27 +00:00
Stuart Turton d157f8f869 The generated PLSQLParser code sets the last token _AFTER_ closing the scope, so getLastToken
cannot be used to identify the last Token: use getToken(0) instead.
         <code>
	      jjtreeCloseNodeScope(jjtn000);
	      jjtn000.jjtSetLastToken(getToken(0));
         </code>
2012-11-16 20:37:30 +00:00
Stuart Turton 3fb8fc1642 MethodDeclaration - ensure that TypeMethod is processed when building Dataflows.
MethodDeclaration covers both ProgramUnit and TypeMethod - previous  processing seemed to ignore TypeMethod when building data flows in Type Bodies.
2012-11-12 00:32:47 +00:00
Stuart Turton 878596e15f Support DFA analysis of simple and compound PL/SQL Triggers 2012-11-11 23:08:52 +00:00
Stuart Turton 03af9d4760 Correct comment spelling 2012-11-11 23:07:12 +00:00
Stuart Turton 1491532ea2 Allow PLSQLDesigner to process multiple types - create minimal interface ExecutableCode and refactor the relevant AST classes, graph rule, panel and PLSQDesigner to manipulate ExecutableCode objects. 2012-11-11 23:06:00 +00:00
Stuart Turton 66deb16cb1 Correct treatment of Labelled Statements 2012-11-07 00:02:44 +00:00
Stuart Turton 84853e2099 PL/SQL CASE statements with added BREAKS 2012-11-04 23:38:05 +00:00
Stuart Turton f47e6b9813 IF, IF,ELSE, IF,ELSIF, IF,ELSIF,ELSE, WHILE, amd LOOP statements now return 2012-11-04 18:54:52 +00:00
Stuart Turton 06e0af2cfe Add logging message and add comment about SquenceChecker infinite loop control index 2012-11-03 17:02:49 +00:00
Stuart Turton 037eaf9d2b Remove generated java classes from src/main/java ; change StringBuffer to StringBuilder in Structure.java 2012-11-03 16:59:57 +00:00
Stuart Turton 8dbd3798f9 Merge branch 'master' of git://github.com/pmd/pmd
Conflicts:
	pmd/src/main/java/net/sourceforge/pmd/lang/ast/CharStream.java
	pmd/src/main/java/net/sourceforge/pmd/lang/ast/JavaCharStream.java
	pmd/src/main/java/net/sourceforge/pmd/lang/ast/SimpleCharStream.java
	pmd/src/main/java/net/sourceforge/pmd/lang/ast/TokenMgrError.java
	pmd/src/main/java/net/sourceforge/pmd/lang/cpp/ast/Token.java
	pmd/src/main/java/net/sourceforge/pmd/lang/java/ast/JJTJavaParserState.java
	pmd/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaParser.java
	pmd/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaParserTreeConstants.java
	pmd/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaParserVisitor.java
	pmd/src/main/java/net/sourceforge/pmd/lang/java/ast/ParseException.java
	pmd/src/main/java/net/sourceforge/pmd/lang/java/ast/Token.java
	pmd/src/main/java/net/sourceforge/pmd/lang/jsp/ast/JJTJspParserState.java
	pmd/src/main/java/net/sourceforge/pmd/lang/jsp/ast/JspParserTreeConstants.java
	pmd/src/main/java/net/sourceforge/pmd/lang/jsp/ast/JspParserVisitor.java
	pmd/src/main/java/net/sourceforge/pmd/lang/jsp/ast/ParseException.java
	pmd/src/main/java/net/sourceforge/pmd/lang/jsp/ast/Token.java
2012-11-02 23:55:26 +00:00
Stuart Turton f0eafc912b Instrument code to identify infinite loop she procession PLSQL IF/THEN/ELSE
Amend AST to make this easier
2012-11-02 01:11:02 +00:00
Stuart Turton 6de746a359 Bring PLSQL AST file up to current code level 2012-10-21 23:09:01 +01:00
Stuart Turton cfa1b0c574 Cope with Object Type Bodies (TypeMethods) when generating scope; commit outstanding PLSQL changes after recovery from filename case problems 2012-10-21 22:39:32 +01:00
Stuart Turton 342b0848d1 Commit outstanding changes after merge 2012-10-21 22:25:02 +01:00
Stuart Turton 6dd19418d8 Merge branch 'master' of https://github.com/sturton/pmd 2012-10-21 22:21:44 +01:00
Stuart Turton f8b1ee358e Correct the filename case of AST production classes within git again 2012-10-21 22:21:02 +01:00
Stuart Turton 6d4905335c Merge commit '3d2ff17d8345c442bd94236892e1750112cd48f0' 2012-10-21 22:13:22 +01:00
Stuart Turton 4677cf8634 Correct case of filenames in github project 2012-10-21 21:02:46 +01:00
Stuart Turton 65edfe5e2f Push outstanding PLSQL changes 2012-10-20 22:52:52 +01:00
Stuart Turton ca5a24edd5 ASTTypeMethod added for TYPE BODY methods scope tracking; DFA works for PACKAGE BODIES 2012-10-17 22:33:32 +01:00
Stuart Turton d4a211087f Remeove terminating semi-colon from Conditional Compilation statement; add terminating semi-colon to global Block(); correct pasring for WRAPPED objects; assign ConditionalOrExpression() to avoid null pointer exception 2012-10-17 19:05:11 +01:00
Stuart Turton fb74093d2a Merge commit 'd126d9b0b89229de905dcaf3926b1321127fde9f' 2012-10-10 23:37:00 +01:00
Stuart Turton 8c4fefe4a8 Amended PLSQL AST 2012-10-10 20:00:47 +01:00
Stuart Turton daf1f4c632 PLSQL AST now supports CONTINUE as an 11G CONTINUE statement and as a variable name; EXIT may be a variable name; LabelledStatement is now cleaned up 2012-10-10 19:59:02 +01:00
Stuart Turton a9507e0ccd PLSQL AST now copes with 11G CONTINUE statements; PMD rule works for simple PLSQL; DFA is not working; PMD symbol handling is very buggy 2012-10-10 19:33:16 +01:00
Stuart Turton 99c71ddcbd PLSQL AST now copes with 11G CONTINUE statements; PMD rule works for simple PLSQL; DFA is not working; PMD symbol handling is very buggy 2012-10-10 19:28:30 +01:00
Stuart Turton 3b8d09cdd7 PLSQL AST now copes with 11G CONTINUE statements; PMD rule works for simple PLSQL; DFA is not working; PMD symbol handling is very buggy 2012-10-10 19:25:51 +01:00
Stuart Turton bf5bb5e2bb PLSQLDesigner - remove System.err 2012-10-02 23:14:07 +01:00
Stuart Turton c482f7a81a PLSQL AST JJTree - return Types from productions are accurate rather than all being declared as SimpleNode - NODE_EXTENDS,TRACK_TOKENS and NODE_SCOPE_HOOK are specified so that beginLine,beginColumn,endLine,endColumn fields are set 2012-10-02 23:02:55 +01:00
Stuart Turton 10e1e8cdb3 get XPath window working 2012-10-02 19:07:39 +01:00
Stuart Turton 3c3f811dff PldocAST.jjt - setImage() for IDs and Names 2012-10-01 23:24:00 +01:00
Stuart Turton fe3f159255 Hack PLSQLParser.java to avoid Arguments null pointer exception 2012-10-01 19:40:47 +01:00
Stuart Turton 501a4754f7 DumpFacade added 2012-09-30 23:48:57 +01:00
Stuart Turton 4580690ca9 PLSQLDesigner - removed System.err tracking 2012-09-30 23:35:32 +01:00
Stuart Turton 56df618d60 DumpFacade implemented- AST panel populates 2012-09-30 23:08:51 +01:00
Stuart Turton f513a0cad0 Merge branch 'master' of https://github.com/sturton/pmd
Conflicts:
	pmd/etc/grammar/PldocAST.jjt
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/PLSQLHandler.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/PLSQLParser.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/ASTArguments.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/ASTName.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/ASTPrimaryPrefix.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/ASTPrimarySuffix.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/Node.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/PLSQLParser.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/PLSQLParserVisitor.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/PLSQLParserVisitorAdapter.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/ast/SimpleNode.java
	pmd/src/main/java/net/sourceforge/pmd/lang/plsql/rule/PLSQLRuleChainVisitor.java
2012-09-30 17:45:37 +01:00
Stuart Turton 66f31a2c9a PLSQL AST rewritten to be more PMD-like; Scope compiles; PLSQLDesigner work in progress 2012-09-30 15:36:53 +01:00
Stuart Turton d7037af36f JJTree production names changed to be consistent with Java AST 2012-09-24 20:55:29 +01:00
Stuart Turton ba84d1d9fa Visitor JJTree language file 2012-09-24 20:47:00 +01:00
Stuart Turton 6f84da00a2 Convert parser classes from the initial (CPD) version to separate AST* classes in order allow the Visitor pattern (as used in
PMD).

These classes work with CPD, but also form an initial basis for PLSQL integration with PMD.

Also viewer_properties has been copied under src/main/resources so that it is automatically included in the packaged JAR file.
2012-08-26 15:29:02 +01:00
Stuart Turton ec4d9f9af2 PLSQL AST - modify PldocAST.jjt to allow Visitor pattern and return a terminal object (ASTinput) 2012-08-25 23:34:49 +01:00
Stuart Turton f7cdadc3a9 Revert "PLSQL AST - modify PldocAST.jjt to allow Visitor pattern and return a terminal object (ASTinput)"
This reverts commit 2e4e6b2231.
2012-08-25 23:26:45 +01:00
Stuart Turton 2e4e6b2231 PLSQL AST - modify PldocAST.jjt to allow Visitor pattern and return a terminal object (ASTinput) 2012-08-25 23:03:10 +01:00
Stuart Turton 0019f52074 Add PLSQL AST grammar for integrating PL/SQL parser for use in CPD.
This is the minimal conversion of the PLDoc parser (pldoc.sourceforge.net). This version is not suitable for incorporation into the main PMD suite, simply because PldocAST.jjt  does not specify the Visitor pattern, which seems to be required for PMD integration.
2012-08-25 22:43:07 +01:00
Stuart Turton 7ac8edb6a1 Add tests for PLSQLTokenizer 2012-08-08 20:17:32 +01:00
Stuart Turton 1d2d04b3eb Incorporate PLDoc 1.3.3 changes - support "AT LOCAL" and "AT TIME ZONE (DBTIMEZONE|SESSIONTIMEZONE|literal|expression)" time zone clauses 2012-08-05 23:03:09 +01:00
Stuart Turton 1cdbc0ca0a PMD-3546925 - Add PLSQL Language for PMD and CPD (extracted from PLDoc 1.3.2) 2012-07-23 21:11:10 +01:00
3618 changed files with 118696 additions and 194980 deletions

No files matched your search

+12
View File
@@ -0,0 +1,12 @@
target/
bin/
.project
.classpath
.checkstyle
.pmd
.ruleset
.settings/
*.iml
.idea
*.patch
*/src/site/site.xml
+405
View File
File diff suppressed because it is too large. Load diff
+12
View File
@@ -0,0 +1,12 @@
PMD
This product is licensed under a BSD-style license;
for more info see http://pmd.sourceforge.net/license.html or LICENSE
Part of this product (mostly the package net.sourceforge.pmd.lang.vm)
is licensed under the Apache License, Version 2.0;
for more info see http://www.apache.org/licenses/LICENSE-2.0 or LICENSE
Part of this product (part of pmd-scala)
is licensed under the GNU Lesser General Public License, Version 3 or later
for more info see http://www.gnu.org/licenses/lgpl.txt or LICENSE
@@ -1,41 +0,0 @@
package net.sourceforge.pmd.util.viewer;
import net.sourceforge.pmd.util.viewer.gui.MainFrame;
/**
* viewer's starter
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class Viewer {
/**
* starts the viewer
*
* @param args arguments
*/
public static void main(String[] args) {
new MainFrame();
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:41 tomcopeland
* Initial revision
*
* Revision 1.2 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,147 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui;
import net.sourceforge.pmd.ast.Node;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.util.viewer.gui.menu.ASTNodePopupMenu;
import net.sourceforge.pmd.util.viewer.model.ASTModel;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import net.sourceforge.pmd.util.viewer.model.ViewerModelEvent;
import net.sourceforge.pmd.util.viewer.model.ViewerModelListener;
import net.sourceforge.pmd.util.viewer.util.NLS;
import javax.swing.*;
import javax.swing.event.TreeSelectionEvent;
import javax.swing.event.TreeSelectionListener;
import javax.swing.tree.TreeNode;
import javax.swing.tree.TreePath;
import java.awt.BorderLayout;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
import java.util.LinkedList;
/**
* tree panel GUI
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class ASTPanel
extends JPanel
implements ViewerModelListener, TreeSelectionListener {
private ViewerModel model;
private JTree tree;
/**
* constructs the panel
*
* @param model model to attach the panel to
*/
public ASTPanel(ViewerModel model) {
this.model = model;
init();
}
private void init() {
model.addViewerModelListener(this);
setBorder(BorderFactory.createTitledBorder(BorderFactory.createEtchedBorder(), NLS.nls("AST.PANEL.TITLE")));
setLayout(new BorderLayout());
tree = new JTree((TreeNode) null);
tree.addTreeSelectionListener(this);
tree.addMouseListener(new MouseAdapter() {
public void mouseReleased(MouseEvent e) {
if (e.isPopupTrigger()) {
TreePath path =
tree.getClosestPathForLocation(e.getX(), e.getY());
tree.setSelectionPath(path);
JPopupMenu menu =
new ASTNodePopupMenu(model, (SimpleNode) path.getLastPathComponent());
menu.show(tree, e.getX(), e.getY());
}
}
});
add(new JScrollPane(tree), BorderLayout.CENTER);
}
/**
* @see ViewerModelListener#viewerModelChanged(ViewerModelEvent)
*/
public void viewerModelChanged(ViewerModelEvent e) {
switch (e.getReason()) {
case ViewerModelEvent.CODE_RECOMPILED:
tree.setModel(new ASTModel(model.getRootNode()));
break;
case ViewerModelEvent.NODE_SELECTED:
if (e.getSource() != this) {
LinkedList list = new LinkedList();
for (
Node node = (Node) e.getParameter(); node != null;
node = node.jjtGetParent())
list.addFirst(node);
TreePath path = new TreePath(list.toArray());
tree.setSelectionPath(path);
tree.scrollPathToVisible(path);
}
break;
}
}
/**
* @see javax.swing.event.TreeSelectionListener#valueChanged(javax.swing.event.TreeSelectionEvent)
*/
public void valueChanged(TreeSelectionEvent e) {
model.selectNode((SimpleNode) e.getNewLeadSelectionPath().getLastPathComponent(), this);
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.5 2005/02/16 15:46:05 mikkey
* javadoc fixes
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.3 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
* Revision 1.2 2003/09/23 07:52:16 bgr
* menus added
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,35 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui;
/**
* contains action command constants
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public interface ActionCommands {
String COMPILE_ACTION = "Compile";
String EVALUATE_ACTION = "Evaluate";
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.3 2004/12/22 20:52:12 tomcopeland
* Fixing some stuff PMD found
*
* Revision 1.2 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,105 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import net.sourceforge.pmd.util.viewer.model.ViewerModelEvent;
import net.sourceforge.pmd.util.viewer.model.ViewerModelListener;
import javax.swing.*;
import javax.swing.event.ListSelectionEvent;
import javax.swing.event.ListSelectionListener;
import java.awt.BorderLayout;
import java.util.Vector;
/**
* A panel showing XPath expression evaluation results
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class EvaluationResultsPanel
extends JPanel
implements ViewerModelListener {
private ViewerModel model;
private JList list;
/**
* constructs the panel
*
* @param model model to refer to
*/
public EvaluationResultsPanel(ViewerModel model) {
super(new BorderLayout());
this.model = model;
init();
}
private void init() {
model.addViewerModelListener(this);
list = new JList();
list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
list.addListSelectionListener(new ListSelectionListener() {
public void valueChanged(ListSelectionEvent e) {
if (list.getSelectedValue() != null) {
model.selectNode((SimpleNode) list.getSelectedValue(), EvaluationResultsPanel.this);
}
}
});
add(new JScrollPane(list), BorderLayout.CENTER);
}
/**
* @see ViewerModelListener#viewerModelChanged(ViewerModelEvent)
*/
public void viewerModelChanged(ViewerModelEvent e) {
switch (e.getReason()) {
case ViewerModelEvent.PATH_EXPRESSION_EVALUATED:
if (e.getSource() != this) {
list.setListData(new Vector(model.getLastEvaluationResults()));
}
break;
case ViewerModelEvent.CODE_RECOMPILED:
list.setListData(new Vector(0));
break;
}
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.5 2005/02/16 15:46:34 mikkey
* javadoc fixes
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
*/
@@ -1,172 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui;
import net.sourceforge.pmd.ast.ParseException;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import net.sourceforge.pmd.util.viewer.model.ViewerModelEvent;
import net.sourceforge.pmd.util.viewer.model.ViewerModelListener;
import net.sourceforge.pmd.util.viewer.util.NLS;
import javax.swing.*;
import java.awt.BorderLayout;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
/**
* viewer's main frame
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class MainFrame
extends JFrame
implements ActionListener, ActionCommands, ViewerModelListener {
private ViewerModel model;
private SourceCodePanel sourcePanel;
private ASTPanel astPanel;
private XPathPanel xPathPanel;
private JButton compileBtn;
private JButton evalBtn;
private JLabel statusLbl;
/**
* constructs and shows the frame
*/
public MainFrame() {
super(NLS.nls("MAIN.FRAME.TITLE"));
init();
}
private void init() {
model = new ViewerModel();
model.addViewerModelListener(this);
sourcePanel = new SourceCodePanel(model);
astPanel = new ASTPanel(model);
xPathPanel = new XPathPanel(model);
getContentPane().setLayout(new BorderLayout());
JSplitPane editingPane =
new JSplitPane(JSplitPane.HORIZONTAL_SPLIT, sourcePanel, astPanel);
editingPane.setResizeWeight(0.5d);
JPanel interactionsPane = new JPanel(new BorderLayout());
interactionsPane.add(xPathPanel, BorderLayout.SOUTH);
interactionsPane.add(editingPane, BorderLayout.CENTER);
getContentPane().add(interactionsPane, BorderLayout.CENTER);
compileBtn = new JButton(NLS.nls("MAIN.FRAME.COMPILE_BUTTON.TITLE"));
compileBtn.setActionCommand(COMPILE_ACTION);
compileBtn.addActionListener(this);
evalBtn = new JButton(NLS.nls("MAIN.FRAME.EVALUATE_BUTTON.TITLE"));
evalBtn.setActionCommand(EVALUATE_ACTION);
evalBtn.addActionListener(this);
evalBtn.setEnabled(false);
statusLbl = new JLabel();
statusLbl.setHorizontalAlignment(SwingConstants.RIGHT);
JPanel btnPane = new JPanel(new FlowLayout(FlowLayout.LEFT));
btnPane.add(compileBtn);
btnPane.add(evalBtn);
btnPane.add(statusLbl);
getContentPane().add(btnPane, BorderLayout.SOUTH);
setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
pack();
setSize(800, 600);
setVisible(true);
}
/**
* @see java.awt.event.ActionListener#actionPerformed(java.awt.event.ActionEvent)
*/
public void actionPerformed(ActionEvent e) {
String command = e.getActionCommand();
long t0, t1;
if (command.equals(COMPILE_ACTION)) {
try {
t0 = System.currentTimeMillis();
model.commitSource(sourcePanel.getSourceCode());
t1 = System.currentTimeMillis();
setStatus(NLS.nls("MAIN.FRAME.COMPILATION.TOOK")+ " "+(t1-t0)+" ms");
} catch (ParseException exc) {
setStatus(NLS.nls("MAIN.FRAME.COMPILATION.PROBLEM")+ " "+exc.toString());
new ParseExceptionHandler(this, exc);
}
} else if (command.equals(EVALUATE_ACTION)) {
try {
t0 = System.currentTimeMillis();
model.evaluateXPathExpression(xPathPanel.getXPathExpression(), this);
t1 = System.currentTimeMillis();
setStatus(NLS.nls("MAIN.FRAME.EVALUATION.TOOK")+ " "+(t1-t0)+" ms");
} catch (Exception exc) {
setStatus(NLS.nls("MAIN.FRAME.EVALUATION.PROBLEM")+ " "+exc.toString());
new ParseExceptionHandler(this, exc);
}
}
}
/**
* Sets the status bar message
* @param string the new status, the empty string will be set if the value is <code>null</code>
*/
private void setStatus(String string) {
if (string == null)
string = "";
statusLbl.setText(string);
}
/**
* @see ViewerModelListener#viewerModelChanged(ViewerModelEvent)
*/
public void viewerModelChanged(ViewerModelEvent e) {
evalBtn.setEnabled(model.hasCompiledTree());
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.6 2005/02/16 15:47:01 mikkey
* javadoc fixes
*
* Revision 1.5 2004/12/13 14:46:11 tomcopeland
* Applied, thanks Miguel!
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.2 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,112 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui;
import net.sourceforge.pmd.util.viewer.util.NLS;
import javax.swing.*;
import java.awt.BorderLayout;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
/**
* handles parsing exceptions
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class ParseExceptionHandler
extends JDialog
implements ActionListener {
private Exception exc;
private JTextArea errorArea;
private JButton okBtn;
/**
* creates the dialog
*
* @param parent dialog's parent
* @param exc exception to be handled
*/
public ParseExceptionHandler(JFrame parent, Exception exc) {
super(parent, NLS.nls("COMPILE_ERROR.DIALOG.TITLE"), true);
this.exc = exc;
init();
}
private void init() {
errorArea = new JTextArea();
errorArea.setEditable(false);
errorArea.setText(exc.getMessage() + "\n");
getContentPane().setLayout(new BorderLayout());
JPanel messagePanel = new JPanel(new BorderLayout());
messagePanel.setBorder(BorderFactory.createCompoundBorder(BorderFactory.createRaisedBevelBorder(),
BorderFactory.createTitledBorder(BorderFactory.createEtchedBorder(),
NLS.nls("COMPILE_ERROR.PANEL.TITLE"))));
messagePanel.add(new JScrollPane(errorArea), BorderLayout.CENTER);
getContentPane().add(messagePanel, BorderLayout.CENTER);
JPanel btnPane = new JPanel(new FlowLayout(FlowLayout.RIGHT));
okBtn = new JButton(NLS.nls("COMPILE_ERROR.OK_BUTTON.CAPTION"));
okBtn.addActionListener(this);
btnPane.add(okBtn);
getRootPane().setDefaultButton(okBtn);
getContentPane().add(btnPane, BorderLayout.SOUTH);
pack();
setLocationRelativeTo(getParent());
setVisible(true);
}
/**
* @see java.awt.event.ActionListener#actionPerformed(java.awt.event.ActionEvent)
*/
public void actionPerformed(ActionEvent e) {
if (e.getSource() == okBtn) {
dispose();
}
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.2 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,119 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import net.sourceforge.pmd.util.viewer.model.ViewerModelEvent;
import net.sourceforge.pmd.util.viewer.model.ViewerModelListener;
import net.sourceforge.pmd.util.viewer.util.NLS;
import javax.swing.*;
import javax.swing.text.BadLocationException;
import javax.swing.text.DefaultHighlighter;
import java.awt.BorderLayout;
import java.awt.Color;
/**
* source code panel
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class SourceCodePanel
extends JPanel
implements ViewerModelListener {
private ViewerModel model;
private JTextArea sourceCodeArea;
public SourceCodePanel(ViewerModel model) {
this.model = model;
init();
}
private void init() {
model.addViewerModelListener(this);
setBorder(BorderFactory.createTitledBorder(BorderFactory.createEtchedBorder(), NLS.nls("SOURCE.PANEL.TITLE")));
setLayout(new BorderLayout());
sourceCodeArea = new JTextArea();
add(new JScrollPane(sourceCodeArea), BorderLayout.CENTER);
}
/**
* retrieves the string representation of the source code
*
* @return source code's string representation
*/
public String getSourceCode() {
return sourceCodeArea.getText();
}
/**
* @see ViewerModelListener#viewerModelChanged(ViewerModelEvent)
*/
public void viewerModelChanged(ViewerModelEvent e) {
if (e.getReason() == ViewerModelEvent.NODE_SELECTED) {
final SimpleNode node = (SimpleNode) e.getParameter();
SwingUtilities.invokeLater(new Runnable() {
public void run() {
try {
sourceCodeArea.getHighlighter().removeAllHighlights();
if (node == null) {
return;
}
int startOffset =
(sourceCodeArea.getLineStartOffset(node.getBeginLine() - 1) +
node.getBeginColumn()) - 1;
int end =
(sourceCodeArea.getLineStartOffset(node.getEndLine() - 1) +
node.getEndColumn());
sourceCodeArea.getHighlighter().addHighlight(startOffset, end,
new DefaultHighlighter.DefaultHighlightPainter(new Color(79, 237, 111)));
sourceCodeArea.moveCaretPosition(startOffset);
} catch (BadLocationException exc) {
throw new IllegalStateException(exc.getMessage());
}
}
});
}
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.5 2005/02/16 15:47:27 mikkey
* javadoc fixes
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,115 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import net.sourceforge.pmd.util.viewer.model.ViewerModelEvent;
import net.sourceforge.pmd.util.viewer.model.ViewerModelListener;
import net.sourceforge.pmd.util.viewer.util.NLS;
import javax.swing.*;
import java.awt.Dimension;
/**
* Panel for the XPath entry and editing
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class XPathPanel
extends JTabbedPane
implements ViewerModelListener {
private ViewerModel model;
private JTextArea xPathArea;
/**
* Constructs the panel
*
* @param model model to refer to
*/
public XPathPanel(ViewerModel model) {
super(JTabbedPane.BOTTOM);
this.model = model;
init();
}
private void init() {
model.addViewerModelListener(this);
xPathArea = new JTextArea();
setBorder(BorderFactory.createTitledBorder(BorderFactory.createEtchedBorder(), NLS.nls("XPATH.PANEL.TITLE")));
add(new JScrollPane(xPathArea), NLS.nls("XPATH.PANEL.EXPRESSION"));
add(new EvaluationResultsPanel(model), NLS.nls("XPATH.PANEL.RESULTS"));
setPreferredSize(new Dimension(-1, 200));
}
/**
* retrieves the XPath expression typed into the text area
*
* @return XPath expression
*/
public String getXPathExpression() {
return xPathArea.getText();
}
/**
* @see ViewerModelListener#viewerModelChanged(ViewerModelEvent)
*/
public void viewerModelChanged(ViewerModelEvent e) {
switch (e.getReason()) {
case ViewerModelEvent.PATH_EXPRESSION_APPENDED:
if (e.getSource() != this) {
xPathArea.append((String) e.getParameter());
}
setSelectedIndex(0);
break;
case ViewerModelEvent.CODE_RECOMPILED:
setSelectedIndex(0);
break;
}
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.5 2005/02/16 15:47:48 mikkey
* javadoc fixes
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.3 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
* Revision 1.2 2003/09/23 07:52:16 bgr
* menus added
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,63 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui.menu;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import javax.swing.*;
/**
* context sensetive menu for the AST Panel
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class ASTNodePopupMenu
extends JPopupMenu {
private ViewerModel model;
private SimpleNode node;
public ASTNodePopupMenu(ViewerModel model, SimpleNode node) {
this.model = model;
this.node = node;
init();
}
private void init() {
add(new SimpleNodeSubMenu(model, node));
addSeparator();
add(new AttributesSubMenu(model, node));
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:43 tomcopeland
* Initial revision
*
* Revision 1.5 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.4 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.3 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.2 2003/09/23 20:34:33 tomcopeland
* Fixed some stuff PMD found
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/23 07:52:16 bgr
* menus added
*
*/
@@ -1,73 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui.menu;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.jaxen.Attribute;
import net.sourceforge.pmd.jaxen.AttributeAxisIterator;
import net.sourceforge.pmd.util.viewer.model.AttributeToolkit;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import net.sourceforge.pmd.util.viewer.util.NLS;
import javax.swing.*;
import java.text.MessageFormat;
/**
* contains menu items for the predicate creation
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class AttributesSubMenu
extends JMenu {
private ViewerModel model;
private SimpleNode node;
public AttributesSubMenu(ViewerModel model, SimpleNode node) {
super(MessageFormat.format(NLS.nls("AST.MENU.ATTRIBUTES"), new Object[]{node.toString()}));
this.model = model;
this.node = node;
init();
}
private void init() {
AttributeAxisIterator i = new AttributeAxisIterator(node);
while (i.hasNext()) {
Attribute attribute = (Attribute) i.next();
add(new XPathFragmentAddingItem(attribute.getName() + " = " + attribute.getValue(), model,
AttributeToolkit.constructPredicate(attribute)));
}
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:43 tomcopeland
* Initial revision
*
* Revision 1.5 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.4 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.3 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.2 2003/09/23 20:34:34 tomcopeland
* Fixed some stuff PMD found
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/23 07:52:16 bgr
* menus added
*
*/
@@ -1,76 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui.menu;
import net.sourceforge.pmd.ast.Node;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import net.sourceforge.pmd.util.viewer.util.NLS;
import javax.swing.*;
import java.text.MessageFormat;
/**
* submenu for the simple node itself
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class SimpleNodeSubMenu
extends JMenu {
private ViewerModel model;
private SimpleNode node;
/**
* constructs the submenu
*
* @param model model to which the actions will be forwarded
* @param node menu's owner
*/
public SimpleNodeSubMenu(ViewerModel model, SimpleNode node) {
super(MessageFormat.format(NLS.nls("AST.MENU.NODE.TITLE"), new Object[]{node.toString()}));
this.model = model;
this.node = node;
init();
}
private void init() {
StringBuffer buf = new StringBuffer(200);
for (Node temp = node; temp != null; temp = temp.jjtGetParent()) {
buf.insert(0, "/" + temp.toString());
}
add(new XPathFragmentAddingItem(NLS.nls("AST.MENU.NODE.ADD_ABSOLUTE_PATH"), model, buf.toString()));
add(new XPathFragmentAddingItem(NLS.nls("AST.MENU.NODE.ADD_ALLDESCENDANTS"), model,
"//" + node.toString()));
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:43 tomcopeland
* Initial revision
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/23 07:52:16 bgr
* menus added
*
*/
@@ -1,70 +0,0 @@
package net.sourceforge.pmd.util.viewer.gui.menu;
import net.sourceforge.pmd.util.viewer.model.ViewerModel;
import javax.swing.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
/**
* adds the given path fragment to the XPath expression upon action
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class XPathFragmentAddingItem
extends JMenuItem
implements ActionListener {
private ViewerModel model;
private String fragment;
/**
* constructs the item
*
* @param caption menu item's caption
* @param model model to refer to
* @param fragment XPath expression fragment to be added upon action
*/
public XPathFragmentAddingItem(String caption, ViewerModel model, String fragment) {
super(caption);
this.model = model;
this.fragment = fragment;
addActionListener(this);
}
/**
* @see java.awt.event.ActionListener#actionPerformed(java.awt.event.ActionEvent)
*/
public void actionPerformed(ActionEvent e) {
model.appendToXPathExpression(fragment, this);
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.4 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.3 2004/04/15 18:21:58 tomcopeland
* Cleaned up imports with new version of IDEA; fixed some deprecated Ant junx
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/23 07:52:16 bgr
* menus added
*
*/
@@ -1,125 +0,0 @@
package net.sourceforge.pmd.util.viewer.model;
import net.sourceforge.pmd.ast.SimpleNode;
import javax.swing.event.TreeModelEvent;
import javax.swing.event.TreeModelListener;
import javax.swing.tree.TreeModel;
import javax.swing.tree.TreePath;
import java.util.Vector;
/**
* Model for the AST Panel Tree component
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class ASTModel
implements TreeModel {
private SimpleNode root;
private Vector listeners = new Vector(1);
/**
* creates the tree model
*
* @param root tree's root
*/
public ASTModel(SimpleNode root) {
this.root = root;
}
/**
* @see javax.swing.tree.TreeModel#getChild(java.lang.Object, int)
*/
public Object getChild(Object parent, int index) {
return ((SimpleNode) parent).jjtGetChild(index);
}
/**
* @see javax.swing.tree.TreeModel#getChildCount(java.lang.Object)
*/
public int getChildCount(Object parent) {
return ((SimpleNode) parent).jjtGetNumChildren();
}
/**
* @see javax.swing.tree.TreeModel#getIndexOfChild(java.lang.Object,
* java.lang.Object)
*/
public int getIndexOfChild(Object parent, Object child) {
SimpleNode node = ((SimpleNode) parent);
for (int i = 0; i < node.jjtGetNumChildren(); i++)
if (node.jjtGetChild(i).equals(child)) {
return i;
}
return -1;
}
/**
* @see javax.swing.tree.TreeModel#isLeaf(java.lang.Object)
*/
public boolean isLeaf(Object node) {
return ((SimpleNode) node).jjtGetNumChildren() == 0;
}
/**
* @see javax.swing.tree.TreeModel#getRoot()
*/
public Object getRoot() {
return root;
}
/**
* @see javax.swing.tree.TreeModel#valueForPathChanged(javax.swing.tree.TreePath,
* java.lang.Object)
*/
public void valueForPathChanged(TreePath path, Object newValue) {
throw new UnsupportedOperationException();
}
/**
* @see javax.swing.tree.TreeModel#addTreeModelListener(javax.swing.event.TreeModelListener)
*/
public void addTreeModelListener(TreeModelListener l) {
listeners.add(l);
}
/**
* @see javax.swing.tree.TreeModel#removeTreeModelListener(javax.swing.event.TreeModelListener)
*/
public void removeTreeModelListener(TreeModelListener l) {
listeners.remove(l);
}
protected void fireTreeModelEvent(TreeModelEvent e) {
for (int i = 0; i < listeners.size(); i++) {
((TreeModelListener) listeners.elementAt(i)).treeNodesChanged(e);
}
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.3 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
*/
@@ -1,53 +0,0 @@
package net.sourceforge.pmd.util.viewer.model;
import net.sourceforge.pmd.jaxen.Attribute;
/**
* A toolkit for vaious attribute translations
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class AttributeToolkit {
/**
* formats a value for it's usage in XPath expressions
*
* @param attribute atribute which value should be formatted
* @return formmated value
*/
public static String formatValueForXPath(Attribute attribute) {
return "'" + attribute.getValue() + "'";
}
/**
* constructs a predicate from the given attribute
*
* @param attribute attribute to be formatted as predicate
* @return predicate
*/
public static String constructPredicate(Attribute attribute) {
return "[@" + attribute.getName() + "=" +
formatValueForXPath(attribute) + "]";
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.2 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/23 07:52:16 bgr
* menus added
*
*/
@@ -1,142 +0,0 @@
package net.sourceforge.pmd.util.viewer.model;
import net.sourceforge.pmd.ast.SimpleNode;
import javax.swing.tree.TreeNode;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Enumeration;
import java.util.List;
/**
* provides the adapter for the tree model
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class SimpleNodeTreeNodeAdapter
implements TreeNode {
private SimpleNode node;
private List children;
private SimpleNodeTreeNodeAdapter parent;
/**
* constructs the node
*
* @param node underlying AST's node
*/
public SimpleNodeTreeNodeAdapter(SimpleNodeTreeNodeAdapter parent, SimpleNode node) {
this.parent = parent;
this.node = node;
}
/**
* retrieves the underlying node
*
* @return AST node
*/
public SimpleNode getSimpleNode() {
return node;
}
/**
* @see javax.swing.tree.TreeNode#getChildAt(int)
*/
public TreeNode getChildAt(int childIndex) {
checkChildren();
return (TreeNode) children.get(childIndex);
}
/**
* @see javax.swing.tree.TreeNode#getChildCount()
*/
public int getChildCount() {
checkChildren();
return children.size();
}
/**
* @see javax.swing.tree.TreeNode#getParent()
*/
public TreeNode getParent() {
return parent;
}
/**
* @see javax.swing.tree.TreeNode#getIndex(javax.swing.tree.TreeNode)
*/
public int getIndex(TreeNode node) {
checkChildren();
return children.indexOf(node);
}
/**
* @see javax.swing.tree.TreeNode#getAllowsChildren()
*/
public boolean getAllowsChildren() {
return true;
}
/**
* @see javax.swing.tree.TreeNode#isLeaf()
*/
public boolean isLeaf() {
checkChildren();
return children.size() == 0;
}
/**
* @see javax.swing.tree.TreeNode#children()
*/
public Enumeration children() {
return Collections.enumeration(children);
}
/**
* checks the children and creates them if neccessary
*/
private void checkChildren() {
if (children == null) {
children = new ArrayList(node.jjtGetNumChildren());
for (int i = 0; i < node.jjtGetNumChildren(); i++) {
children.add(new SimpleNodeTreeNodeAdapter(this, (SimpleNode) node.jjtGetChild(i)));
}
}
}
/**
* @see java.lang.Object#toString()
*/
public String toString() {
return node.toString();
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:41 tomcopeland
* Initial revision
*
* Revision 1.3 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,180 +0,0 @@
package net.sourceforge.pmd.util.viewer.model;
import net.sourceforge.pmd.TargetJDK1_4;
import net.sourceforge.pmd.ast.ASTCompilationUnit;
import net.sourceforge.pmd.ast.ParseException;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.jaxen.DocumentNavigator;
import org.jaxen.BaseXPath;
import org.jaxen.JaxenException;
import org.jaxen.XPath;
import java.io.StringReader;
import java.util.List;
import java.util.Vector;
/**
* The model for the viewer gui
* <p/>
* <p/>
* This is the model part of MVC
* </p>
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class ViewerModel {
private Vector listeners;
private SimpleNode rootNode;
private List evaluationResults;
/**
* constructs the model
*/
public ViewerModel() {
listeners = new Vector(5);
}
/**
* Retrieves AST's root node
*
* @return AST's root node
*/
public SimpleNode getRootNode() {
return rootNode;
}
/**
* commits source code to the model.
* <p/>
* <p/>
* all existing source will be replaced
* </p>
*
* @param source source to be commited
*/
public void commitSource(String source) {
ASTCompilationUnit compilationUnit = new TargetJDK1_4().createParser(new StringReader(source)).CompilationUnit();
rootNode = compilationUnit;
fireViewerModelEvent(new ViewerModelEvent(this, ViewerModelEvent.CODE_RECOMPILED));
}
/**
* determines wheteher the model has a compiled tree at it's disposal
*
* @return true if there is an AST, false otherwise
*/
public boolean hasCompiledTree() {
return rootNode != null;
}
/**
* evaluates the given XPath expression against the current tree
*
* @param xPath XPath expression to be evaluated
* @param evaluator object which requests the evaluation
*/
public void evaluateXPathExpression(String xPath, Object evaluator)
throws ParseException, JaxenException {
XPath xpath = new BaseXPath(xPath, new DocumentNavigator());
evaluationResults = xpath.selectNodes(rootNode);
fireViewerModelEvent(new ViewerModelEvent(evaluator, ViewerModelEvent.PATH_EXPRESSION_EVALUATED));
}
/**
* retrieves the results of last evaluation
*
* @return a list containing the nodes selected by the last XPath expression
* evaluation
*/
public List getLastEvaluationResults() {
return evaluationResults;
}
/**
* selects the given node in the AST
*
* @param node node to be selected
* @param selector object which requests the selection
*/
public void selectNode(SimpleNode node, Object selector) {
fireViewerModelEvent(new ViewerModelEvent(selector, ViewerModelEvent.NODE_SELECTED, node));
}
/**
* appends the given fragment to the XPath expression
*
* @param pathFragment fragment to be added
* @param appender object that is trying to append the fragment
*/
public void appendToXPathExpression(String pathFragment, Object appender) {
fireViewerModelEvent(new ViewerModelEvent(appender, ViewerModelEvent.PATH_EXPRESSION_APPENDED, pathFragment));
}
/**
* adds a listener to the model
*
* @param l listener to be added
*/
public void addViewerModelListener(ViewerModelListener l) {
listeners.add(l);
}
/**
* removes the lisetener from the model
*
* @param l listener to be removed
*/
public void removeViewerModelListener(ViewerModelListener l) {
listeners.remove(l);
}
/**
* notifes all listener of a change in the model
*
* @param e change's reason
*/
protected void fireViewerModelEvent(ViewerModelEvent e) {
for (int i = 0; i < listeners.size(); i++) {
((ViewerModelListener) listeners.elementAt(i)).viewerModelChanged(e);
}
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.5 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.4 2004/04/12 17:35:09 tomcopeland
* Cleaned up imports
*
* Revision 1.3 2004/04/12 17:23:29 tomcopeland
* Moving all explicit JavaParser creations over to a factory-ish sort of thing. This makes the version of the parser explicit rather than assumed.
*
* Revision 1.2 2003/09/23 20:51:06 tomcopeland
* Cleaned up imports
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.3 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
* Revision 1.2 2003/09/23 07:52:16 bgr
* menus added
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,112 +0,0 @@
package net.sourceforge.pmd.util.viewer.model;
/**
* The event which will be sent every time the model changes
* <p/>
* <p/>
* Note: the instances will be immutable
* </p>
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class ViewerModelEvent {
/**
* reason in the case of code recompilation
*/
public static final int CODE_RECOMPILED = 1;
/**
* reason in the case of node selection
*/
public static final int NODE_SELECTED = 2;
/**
* reason in the case of path extension
*/
public static final int PATH_EXPRESSION_APPENDED = 3;
/**
* reason in the case of path expression evaluation
*/
public static final int PATH_EXPRESSION_EVALUATED = 4;
private Object source;
private int reason;
private Object parameter;
/**
* Creates an event
*
* @param source event's source
* @param reason event's reason
*/
public ViewerModelEvent(Object source, int reason) {
this(source, reason, null);
}
/**
* Creates an event
*
* @param source event's source
* @param reason event's reason
* @param parameter parameter object
*/
public ViewerModelEvent(Object source, int reason, Object parameter) {
this.source = source;
this.reason = reason;
this.parameter = parameter;
}
/**
* retrieves the reason for event's occurance
*
* @return event's reason
*/
public int getReason() {
return reason;
}
/**
* retrieves the object which caused the event
*
* @return object that casused the event
*/
public Object getSource() {
return source;
}
/**
* retrieves event's parameter
*
* @return event's parameter
*/
public Object getParameter() {
return parameter;
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.2 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.3 2003/09/24 00:40:35 bgr
* evaluation results browsing added
*
* Revision 1.2 2003/09/23 07:52:16 bgr
* menus added
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,39 +0,0 @@
package net.sourceforge.pmd.util.viewer.model;
/**
* identiefie a listener of the ViewerModel
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public interface ViewerModelListener {
/**
* DOCUMENT ME!
*
* @param e DOCUMENT ME!
*/
void viewerModelChanged(ViewerModelEvent e);
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.3 2004/12/22 20:52:12 tomcopeland
* Fixing some stuff PMD found
*
* Revision 1.2 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
@@ -1,34 +0,0 @@
##########################################################################
# english string translations for the viewer
#
##########################################################################
# Main Frame
MAIN.FRAME.TITLE = AST Viewer
MAIN.FRAME.COMPILE_BUTTON.TITLE = Compile
MAIN.FRAME.EVALUATE_BUTTON.TITLE = Evaluate XPath Expression
MAIN.FRAME.COMPILATION.TOOK = Compilation took
MAIN.FRAME.COMPILATION.PROBLEM = Compilation problem:
MAIN.FRAME.EVALUATION.TOOK = Evaluation took
MAIN.FRAME.EVALUATION.PROBLEM = Evaluation problem:
# Source Panel
SOURCE.PANEL.TITLE = Source code
# Tree Panel
AST.PANEL.TITLE = Abstract Syntax Tree
AST.MENU.ATTRIBUTES = Add predicate from {0}'a attributes
AST.MENU.NODE.TITLE = Add {0} to the XPath expression
AST.MENU.NODE.ADD_ABSOLUTE_PATH = Add with absolute path
AST.MENU.NODE.ADD_ALLDESCENDANTS = Add all descentands of this type
# XPath Panel
XPATH.PANEL.TITLE = XPath
XPATH.PANEL.EXPRESSION = Expression
XPATH.PANEL.RESULTS = Results
# Compile Error dialog
COMPILE_ERROR.DIALOG.TITLE = Compilation error
COMPILE_ERROR.PANEL.TITLE = Error message
COMPILE_ERROR.OK_BUTTON.CAPTION = Ok
@@ -1,49 +0,0 @@
package net.sourceforge.pmd.util.viewer.util;
import java.util.ResourceBundle;
/**
* helps with internationalization
*
* @author Boris Gruschko ( boris at gruschko.org )
* @version $Id$
*/
public class NLS {
private final static ResourceBundle bundle;
static {
bundle =
ResourceBundle.getBundle("net.sourceforge.pmd.util.viewer.resources.viewer_strings");
}
/**
* translates the given key to the message
*
* @param key key to be translated
* @return translated string
*/
public static String nls(String key) {
return bundle.getString(key);
}
}
/*
* $Log$
* Revision 1.1 2005/08/15 19:51:42 tomcopeland
* Initial revision
*
* Revision 1.2 2004/09/27 19:42:52 tomcopeland
* A ridiculously large checkin, but it's all just code reformatting. Nothing to see here...
*
* Revision 1.1 2003/09/23 20:32:42 tomcopeland
* Added Boris Gruschko's new AST/XPath viewer
*
* Revision 1.1 2003/09/24 01:33:03 bgr
* moved to a new package
*
* Revision 1.1 2003/09/22 05:21:54 bgr
* initial commit
*
*/
+33 -16
View File
@@ -6,13 +6,13 @@
<groupId>org.sonatype.oss</groupId>
<artifactId>oss-parent</artifactId>
<version>7</version>
<relativePath/>
<relativePath />
</parent>
<groupId>net.sourceforge.pmd</groupId>
<artifactId>pmd-build</artifactId>
<name>PMD Build Plugin</name>
<version>0.9-SNAPSHOT</version>
<version>0.9</version>
<packaging>maven-plugin</packaging>
<description>
<![CDATA[
@@ -42,7 +42,7 @@ only if you modify the java code.
<connection>scm:git:git://github.com/pmd/pmd.git</connection>
<developerConnection>scm:git:ssh://git@github.com/pmd/pmd.git</developerConnection>
<url>https://github.com/pmd/pmd</url>
<tag>HEAD</tag>
<tag>pmd-build/0.9</tag>
</scm>
<developers>
@@ -73,7 +73,7 @@ only if you modify the java code.
<target>1.6</target>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
@@ -84,6 +84,12 @@ only if you modify the java code.
<localCheckout>true</localCheckout>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
<version>3.4</version>
</plugin>
</plugins>
</build>
@@ -92,6 +98,12 @@ only if you modify the java code.
</properties>
<dependencies>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.1</version>
</dependency>
<dependency>
<groupId>org.apache.ant</groupId>
<artifactId>ant</artifactId>
@@ -120,6 +132,13 @@ only if you modify the java code.
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>3.3</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
@@ -127,13 +146,6 @@ only if you modify the java code.
<scope>test</scope>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
@@ -144,17 +156,21 @@ only if you modify the java code.
<reporting>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-project-info-reports-plugin</artifactId>
<version>2.8</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
<version>2.6</version>
<version>3.4</version>
<configuration>
<linkXref>true</linkXref>
<sourceEncoding>utf-8</sourceEncoding>
<minimumTokens>100</minimumTokens>
<targetJdk>1.6</targetJdk>
<rulesets>
<ruleset>http://pmd.svn.sourceforge.net/svnroot/pmd/trunk/pmd/rulesets/internal/dogfood.xml</ruleset>
<ruleset>${basedir}/../pmd-core/src/main/resources/rulesets/internal/dogfood.xml</ruleset>
</rulesets>
</configuration>
</plugin>
@@ -162,9 +178,10 @@ only if you modify the java code.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.8</version>
<version>2.13</version>
<configuration>
<configLocation>etc/checkstyle-config.xml</configLocation>
<configLocation>${basedir}/../pmd-core/etc/checkstyle-config.xml</configLocation>
<suppressionsFile>${basedir}/../pmd-core/etc/checkstyle-suppressions.xml</suppressionsFile>
</configuration>
</plugin>
</plugins>
File diff suppressed because it is too large. Load diff
@@ -3,23 +3,22 @@
*/
package net.sourceforge.pmd.build;
/**
* @author Romain PELISSE, belaran@gmail.com
*
*/
public class PmdBuildException extends Exception {
/**
* Default serial ID
*/
private static final long serialVersionUID = 1L;
/**
* Default serial ID
*/
private static final long serialVersionUID = 1L;
public PmdBuildException(String message){
super(message);
}
public PmdBuildException(String message) {
super(message);
}
public PmdBuildException(Throwable e) {
super(e);
}
public PmdBuildException(Throwable e) {
super(e);
}
}
@@ -1,55 +1,60 @@
/**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.build;
import java.net.URL;
public interface PmdBuildTools {
/**
* @return the rulesDirectory
*/
public abstract String getRulesDirectory();
String getRulesDirectory();
/**
* @param rulesDirectory the rulesDirectory to set
* @param rulesDirectory
* the rulesDirectory to set
*/
public abstract void setRulesDirectory(String rulesDirectory);
void setRulesDirectory(String rulesDirectory);
/**
*
* @throws PmdBuildException
*/
public abstract void convertRulesets() throws PmdBuildException;
void convertRulesets() throws PmdBuildException;
public abstract void preSiteGeneration() throws PmdBuildException;
void preSiteGeneration() throws PmdBuildException;
/**
* @return the targetDirectory
*/
public abstract String getTargetDirectory();
String getTargetDirectory();
/**
* @param targetDirectory the targetDirectory to set
* @param targetDirectory
* the targetDirectory to set
*/
public abstract void setTargetDirectory(String targetDirectory);
void setTargetDirectory(String targetDirectory);
/**
*
* @param siteXml
*/
public abstract void setSiteXml(String siteXml);
void setSiteXml(String siteXml);
/**
*
* @param siteXmlTaget
*/
public abstract void setSiteXmlTarget(String siteXmlTarget);
void setSiteXmlTarget(String siteXmlTarget);
/**
* Configures the classpath to use to analyze the properties of rules.
*
* @param runtimeClasspath
* @see RuntimeRulePropertiesAnalyzer
*/
public void setRuntimeClasspath(URL[] runtimeClasspath);
void setRuntimeClasspath(URL[] runtimeClasspath);
}
File diff suppressed because it is too large. Load diff
@@ -19,8 +19,6 @@ import org.w3c.dom.NodeList;
public class RuntimeRulePropertiesAnalyzer {
private static final String XPATH_RULE_CLASSNAME = "net.sourceforge.pmd.lang.rule.XPathRule";
private ClassLoader cl;
private Class<?> propertySource;
private Class<?> propertyDesc;
private Method nameMethod;
private Method descMethod;
private Method defaultValueMethod;
@@ -28,86 +26,90 @@ public class RuntimeRulePropertiesAnalyzer {
private Field propertiesValues;
public RuntimeRulePropertiesAnalyzer(URL[] runtimeClasspath) {
init(runtimeClasspath);
init(runtimeClasspath);
}
private void init(URL[] runtimeClasspath) {
try {
cl = new URLClassLoader(runtimeClasspath);
propertySource = cl.loadClass("net.sourceforge.pmd.AbstractPropertySource");
propertyDesc = cl.loadClass("net.sourceforge.pmd.PropertyDescriptor");
nameMethod = propertyDesc.getDeclaredMethod("name");
descMethod = propertyDesc.getDeclaredMethod("description");
defaultValueMethod = propertyDesc.getDeclaredMethod("defaultValue");
propertiesField = propertySource.getDeclaredField("propertyDescriptors");
propertiesValues = propertySource.getDeclaredField("propertyValuesByDescriptor");
propertiesField.setAccessible(true);
propertiesValues.setAccessible(true);
} catch (Exception e) {
throw new RuntimeException(e);
}
try {
cl = new URLClassLoader(runtimeClasspath);
Class<?> propertySource = cl.loadClass("net.sourceforge.pmd.AbstractPropertySource");
Class<?> propertyDesc = cl.loadClass("net.sourceforge.pmd.PropertyDescriptor");
nameMethod = propertyDesc.getDeclaredMethod("name");
descMethod = propertyDesc.getDeclaredMethod("description");
defaultValueMethod = propertyDesc.getDeclaredMethod("defaultValue");
propertiesField = propertySource.getDeclaredField("propertyDescriptors");
propertiesValues = propertySource.getDeclaredField("propertyValuesByDescriptor");
propertiesField.setAccessible(true);
propertiesValues.setAccessible(true);
} catch (Exception e) {
throw new RuntimeException(e);
}
}
/**
* Analyzes the class of the given rule definition to find the properties
* this rule supports.
* The properties are directly added to the rule node.
* @param document the document, used to create new property nodes
* @param rule the rule to analyze
* this rule supports. The properties are directly added to the rule node.
*
* @param document
* the document, used to create new property nodes
* @param rule
* the rule to analyze
*/
public void analyze(Document document, Node rule) {
Node classAttribute = rule.getAttributes().getNamedItem("class");
if (classAttribute == null) {
// some rule definitions, like <rule ref="..."/> have no class attribute
return;
}
String classAtt = classAttribute.getTextContent();
if (XPATH_RULE_CLASSNAME.equals(classAtt)) {
// xpath rules are ignored - they have there properties defined already in the rule definition xml
return;
}
Node classAttribute = rule.getAttributes().getNamedItem("class");
if (classAttribute == null) {
// some rule definitions, like <rule ref="..."/> have no class
// attribute
return;
}
String classAtt = classAttribute.getTextContent();
if (XPATH_RULE_CLASSNAME.equals(classAtt)) {
// xpath rules are ignored - they have their properties defined
// already in the rule definition xml
return;
}
try {
Class<?> clazz = cl.loadClass(classAtt);
Object ruleInstance = clazz.newInstance();
@SuppressWarnings("rawtypes")
List properties = (List)propertiesField.get(ruleInstance);
@SuppressWarnings("rawtypes")
Map values = (Map)propertiesValues.get(ruleInstance);
Element propsElem = null;
NodeList ruleChilds = rule.getChildNodes();
for (int j = 0; j < ruleChilds.getLength(); j++) {
Node item = ruleChilds.item(j);
if (item.getNodeType() == Node.ELEMENT_NODE && "properties".equals(item.getNodeName())) {
propsElem = (Element)item;
break;
}
}
if (propsElem == null) {
propsElem = document.createElement("properties");
rule.appendChild(propsElem);
}
try {
Class<?> clazz = cl.loadClass(classAtt);
Object ruleInstance = clazz.newInstance();
@SuppressWarnings("rawtypes")
List properties = (List) propertiesField.get(ruleInstance);
@SuppressWarnings("rawtypes")
Map values = (Map) propertiesValues.get(ruleInstance);
Element propsElem = null;
NodeList ruleChilds = rule.getChildNodes();
for (int j = 0; j < ruleChilds.getLength(); j++) {
Node item = ruleChilds.item(j);
if (item.getNodeType() == Node.ELEMENT_NODE && "properties".equals(item.getNodeName())) {
propsElem = (Element) item;
break;
}
}
if (propsElem == null) {
propsElem = document.createElement("properties");
rule.appendChild(propsElem);
}
for (Object o : properties) {
Object value = values.get(o);
if (value == null) {
value = defaultValueMethod.invoke(o);
}
for (Object o : properties) {
Object value = values.get(o);
if (value == null) {
value = defaultValueMethod.invoke(o);
}
Element propElem = document.createElement("property");
propElem.setAttribute("name", (String)nameMethod.invoke(o));
propElem.setAttribute("description", (String)descMethod.invoke(o));
if (value != null) {
String valueString = String.valueOf(value);
if (value.getClass().isArray()) {
valueString = Arrays.toString((Object[])value);
}
propElem.setAttribute("value", valueString);
}
propsElem.appendChild(propElem);
}
} catch (Exception e) {
throw new RuntimeException(e);
}
Element propElem = document.createElement("property");
propElem.setAttribute("name", (String) nameMethod.invoke(o));
propElem.setAttribute("description", (String) descMethod.invoke(o));
if (value != null) {
String valueString = String.valueOf(value);
if (value.getClass().isArray()) {
valueString = Arrays.toString((Object[]) value);
}
propElem.setAttribute("value", valueString);
}
propsElem.appendChild(propElem);
}
} catch (Exception e) {
throw new RuntimeException(e);
}
}
}
@@ -14,8 +14,8 @@ import java.io.FilenameFilter;
public class DirectoryFileFilter implements FilenameFilter {
public boolean accept(File dir, String name) {
return ( dir.exists() && dir.isDirectory() ) ? true : false;
}
public boolean accept(File dir, String name) {
return dir.exists() && dir.isDirectory() ? true : false;
}
}
Loaded 30 of 3618 files, more files were not shown because too many files have changed in this diff. Show more